Re: [Wikitech-l] Subclassing HTMLForm Question

2013-03-04 Thread Arthur Richards
I think Kaldari's approach actually makes sense and does not conflict with the available output formats of HTMLForm. The HTMLForm output formats are intended holistic for the whole form, rather than requiring a specific format for each form element. It would be ideal if all elements were output in

Re: [Wikitech-l] Subclassing HTMLForm Question

2013-03-04 Thread Tyler Romeo
On Mon, Mar 4, 2013 at 1:46 PM, Arthur Richards aricha...@wikimedia.orgwrote: I think Kaldari's approach actually makes sense and does not conflict with the available output formats of HTMLForm. The HTMLForm output formats are intended holistic for the whole form, rather than requiring a

Re: [Wikitech-l] Subclassing HTMLForm Question

2013-03-02 Thread Tyler Romeo
I'm fine either way with this change. I was just hesitant because I wasn't sure whether HTMLForm was designed in a matter where front-end developers were expecting all divs. *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com |

Re: [Wikitech-l] Subclassing HTMLForm Question

2013-03-01 Thread Ryan Kaldari
Tyler left out a critical piece of information: This new subclass is for constructing a matrix of checkbox options in a form. You feed it a list of row labels and a list of column labels and it constructs a table of checkbox options: Category 1 Category 2 Category 3

[Wikitech-l] Subclassing HTMLForm Question

2013-02-21 Thread Tyler Romeo
Hey, So there's a change (https://gerrit.wikimedia.org/r/48995) that's adding a new subclass to HTMLForm, so I had a quick question for whoever has more experience with HTMLForm than I do. The new subclass will always output a table for the getInputHTML(), even if the parent form is set to

Re: [Wikitech-l] Subclassing HTMLForm Question

2013-02-21 Thread Jeroen De Dauw
Hey, The new subclass will always output a table for the getInputHTML(), even if the parent form is set to div/raw output. That very much sounds like a violation of the Liskov substitution pattern. In other words, it sounds like code using an instance of HTMLForm might run into problems when