Re: [Wikitech-l] jquery.accessKeyLabel broke mobile

2014-04-29 Thread Jon Robson
Krinkle fixed the immediate problem I opened https://bugzilla.wikimedia.org/show_bug.cgi?id=64564 to further optimise the mediawiki.util library On Sun, Apr 27, 2014 at 11:23 AM, Krinkle krinklem...@gmail.com wrote: The module was split out of mediawiki.util, nothing new, no need for any

[Wikitech-l] jquery.accessKeyLabel broke mobile

2014-04-27 Thread Jon Robson
Looks like jquery.accessKeyLabel now seems to be a required ResourceLoader module. The patch that introduced it is https://gerrit.wikimedia.org/r/#/c/125426/and this has exploded the mobile site with 49 or 50 tests failing since the merge. I'm not quite sure whether this module is useful on

Re: [Wikitech-l] jquery.accessKeyLabel broke mobile

2014-04-27 Thread Krinkle
The module was split out of mediawiki.util, nothing new, no need for any special treatment here. It should've been given the same target definition as mediawiki.util. — Krinkle On 27 Apr 2014, at 19:37, Jon Robson jdlrob...@gmail.com wrote: Looks like jquery.accessKeyLabel now seems to be a