Re: [Wikitech-l] phan (new static analysis tool) is now voting on MediaWiki core

2016-12-13 Thread Erik Bernhardson
Getting Phan voting is a great first step, but we need everyone's help to improve the strictness of analysis we apply. For this initial rollout Phan is only voting on critical errors. These are typically PHP fatal errors like referencing a class that doesn't exist (missing use statement?) and calli

Re: [Wikitech-l] phan (new static analysis tool) is now voting on MediaWiki core

2016-12-12 Thread Legoktm
Hi, On 12/12/2016 10:03 PM, Sam Wilson wrote: > Is it possible now to add Phan to extensions' CI as well? That's the next step :). Filed for it. -- Legoktm ___ Wikitech-l mailing list Wikitech-l@lists.wikime

Re: [Wikitech-l] phan (new static analysis tool) is now voting on MediaWiki core

2016-12-12 Thread Stas Malyshev
Hi! > There's documentation on mediawiki.org[3] about how it is currently > configured, and how to set it up locally. You'll need PHP 7 with the ast > extension to actually run phan. If that's not possible for your system, > you can rely on jenkins to run it for you. I wonder how hard would it be

Re: [Wikitech-l] phan (new static analysis tool) is now voting on MediaWiki core

2016-12-12 Thread Sam Wilson
This is brilliant! :-) Is it possible now to add Phan to extensions' CI as well? On 13 December 2016 at 10:41, Legoktm wrote: > Hi! > > Thanks to some awesome work by Erik Bernhardson, phan[1], a new static > analysis tool, is now voting[2] on MediaWiki core patches. > > It's significantly mor

[Wikitech-l] phan (new static analysis tool) is now voting on MediaWiki core

2016-12-12 Thread Legoktm
Hi! Thanks to some awesome work by Erik Bernhardson, phan[1], a new static analysis tool, is now voting[2] on MediaWiki core patches. It's significantly more advanced than any of our other current tools, and should help identify some types of errors. It uses PHP 7's AST to process code, but is ca