Re: [Wikitech-l] ForkableMaintenance: thoughts and help with tests/code coverage

2018-08-14 Thread Brion Vibber
On Tue, Aug 14, 2018 at 8:34 AM Brion Vibber wrote: > On Tue, Aug 14, 2018, 3:39 AM Aleksey Bekh-Ivanov < > aleksey.bekh-iva...@wikimedia.de> wrote: > >> Hi Brion. >> >> I might be a bit late, but I just wonder why did you decide to go with >> forking instead of Pthreads PHP extension? >> > >

Re: [Wikitech-l] ForkableMaintenance: thoughts and help with tests/code coverage

2018-08-14 Thread Brion Vibber
On Tue, Aug 14, 2018, 3:39 AM Aleksey Bekh-Ivanov < aleksey.bekh-iva...@wikimedia.de> wrote: > Hi Brion. > > I might be a bit late, but I just wonder why did you decide to go with > forking instead of Pthreads PHP extension? > ForkController and OrderedStreamingForkController were already

Re: [Wikitech-l] ForkableMaintenance: thoughts and help with tests/code coverage

2018-08-14 Thread Aleksey Bekh-Ivanov
Hi Brion. I might be a bit late, but I just wonder why did you decide to go with forking instead of Pthreads PHP extension? AFAIK, Mediawiki should support not only *nix platforms, but Windows as well, and `pcntl_fork()` does not work on Windows. PS: Couldn't find related ticket. Can you post a

Re: [Wikitech-l] ForkableMaintenance: thoughts and help with tests/code coverage

2018-08-12 Thread Brion Vibber
Thanks, looks like I misinterpreted the report output. :) I think I can add a test case for ParallelMaintenance which should make the warning go away. -- brion On Sun, Aug 12, 2018, 1:51 PM Kunal Mehta wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hi, > > On 08/11/2018 06:48

Re: [Wikitech-l] ForkableMaintenance: thoughts and help with tests/code coverage

2018-08-12 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 08/11/2018 06:48 PM, Brion Vibber wrote: > Second, probably related to that I'm seeing a failure in the code > coverage calculations -- it's seeing some increased coverage on the > parent process at least but seems to think it's returning a

Re: [Wikitech-l] ForkableMaintenance: thoughts and help with tests/code coverage

2018-08-12 Thread Brion Vibber
(I've made both changes on the PR.) -- brion On Sun, Aug 12, 2018 at 7:54 AM Brion Vibber wrote: > > On Sun, Aug 12, 2018, 2:49 AM Aryeh Gregor wrote: > >> >> For what it's worth, when I saw ForkableMaintenance I thought of >> forking an open-source project, not Unix fork(). Something like

Re: [Wikitech-l] ForkableMaintenance: thoughts and help with tests/code coverage

2018-08-12 Thread Brion Vibber
On Sun, Aug 12, 2018, 2:49 AM Aryeh Gregor wrote: > > For what it's worth, when I saw ForkableMaintenance I thought of > forking an open-source project, not Unix fork(). Something like > ParallelMaintenance or ParallelizableMaintenance would better suggest > the desired meaning for me. > I

Re: [Wikitech-l] ForkableMaintenance: thoughts and help with tests/code coverage

2018-08-12 Thread Aryeh Gregor
On Sun, Aug 12, 2018 at 4:48 AM, Brion Vibber wrote: > While working on some maintenance scripts for TimedMediaHandler I've been > trying to make it easier to do scripts that use multiple parallel processes > to run through a large input set faster. > > My proposal is a ForkableMaintenance class,

[Wikitech-l] ForkableMaintenance: thoughts and help with tests/code coverage

2018-08-11 Thread Brion Vibber
Hey all! While working on some maintenance scripts for TimedMediaHandler I've been trying to make it easier to do scripts that use multiple parallel processes to run through a large input set faster. My proposal is a ForkableMaintenance class, with an underlying QueueingForkController which is a