Re: [Wikitech-l] Recently proposed patchsets by new contributors awaiting code review
On 12 October 2016 at 23:21, Andre Klapperwrote: > == pywikibot/core: == > > since 2016-09-25 (2nd time listed here): > Checks the type of isbn and modifies accordingly > https://gerrit.wikimedia.org/r/#/c/312726/ Might be better to send that one to the pywiki mailing lists. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Recently proposed patchsets by new contributors awaiting code review - organization?
On Sun, 2016-10-02 at 10:30 +, Marcin Cieslak wrote: > A just checked this one: > > > > > http://korma.wmflabs.org/browser/scr-backlog.html > > how does one recognize or define "Organization" affected by the > backlog? (it's the first time I see this) The organizations are defined in the underlying database. Currently those are * Hallo Welt! * Independent * Wikia, Inc. * Wikimedia Deutschland * Wikimedia Foundation * WikiWorks Some more technical information is available at https://www.mediawiki.org/wiki/Community_metrics#korma.wmflabs.org Cheers, andre -- Andre Klapper | Wikimedia Bugwrangler http://blogs.gnome.org/aklapper/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Recently proposed patchsets by new contributors awaiting code review - organization?
A just checked this one: > http://korma.wmflabs.org/browser/scr-backlog.html how does one recognize or define "Organization" affected by the backlog? (it's the first time I see this) Saper ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Recently proposed patchsets by new contributors awaiting code review
On Thu, 2016-09-22 at 18:27 +, Jon Robson wrote: > Thanks for these e-mails. Glad to hear that! :) > Would you be also open to flagging some of our oldest patches as part of > this mail (I think you are right to keep the number of patches low - a long > list can be overwhelming)? > > I just ran a Gerrit query and found these old patches that had no merge > conflicts. I'd love to get us to a point where at least core's patchsets > are weeks old rather than months. It seems these e-mails could be a good > mechanism for reaching the right people. I do share the sentiment; still "old patches" are a very different beast. The current email focuses on fresh contributors still "available" (even if it was a one-time drive-by contribution), in combination with ideas like https://phabricator.wikimedia.org/T73357 (Gerrit Welcome Bot). So I'd be open but I currently don't think it's the best use of (my) time, also as I am not sure how to easily gather that list & which criteria to apply. Plus it should likely be a separate email. We currently list "Oldest open Gerrit changesets without code review" on http://korma.wmflabs.org/browser/scr-backlog.html [1]. But that page does not exclude "Cannot merge / needs rebase" items. List of open MediaWiki Core patches without any code review: https://gerrit.wikimedia.org/r/#/q/status:open+project:%5Emediawiki/core+AND+label:Code-Review%3D0,n,z Cheers, andre [1] (that korma.wmflabs.org page is to be replaced by https://wikimedia.biterg.io/app/kibana#/dashboard/Gerrit-Backlog at some point in the future. All still very beta.) -- Andre Klapper | Wikimedia Bugwrangler http://blogs.gnome.org/aklapper/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Recently proposed patchsets by new contributors awaiting code review
Andre, Thanks for these e-mails. It really helps having an overview of where we can help. I really appreciate them. Would you be also open to flagging some of our oldest patches as part of this mail (I think you are right to keep the number of patches low - a long list can be overwhelming)? I just ran a Gerrit query and found these old patches that had no merge conflicts. I'd love to get us to a point where at least core's patchsets are weeks old rather than months. It seems these e-mails could be a good mechanism for reaching the right people. Some old patches: Added custom label for links in category pages https://gerrit.wikimedia.org/r/#/c/104905/ Add category name in ID property for extension row in Special:Version page https://gerrit.wikimedia.org/r/#/c/275836/2 On Thu, 22 Sep 2016 at 06:49 Andre Klapperwrote: > Your help is welcome to provide feedback and guidance: > > == in "mediawiki/tools/mwdumper": == > > since 2016-09-08: > Major refactoring > https://gerrit.wikimedia.org/r/#/c/309314/ > > Thanks in advance for your reviews. > > > Of last weeks' 5 listed patches, 4 got merged & 1 got reviewed. Thanks > to Amire80, Daniel, FlorianSW, Jdlrobson, MatmaRex, Smalyshev, Tjones! > > andre > -- > Andre Klapper | Wikimedia Bugwrangler > http://blogs.gnome.org/aklapper/ > > ___ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l