Re: [Wikitech-l] mediawiki.api.edit
I think the least inconvenient solution would be to leave your dependency on 'mediawiki.api.edit' in extension.json unchanged, and conditionally register that module as an "alias" for mediawiki.api if it doesn't exist, using the ResourceLoaderRegisterModules hook. You could even be super lazy and register it unconditionally in extension.json, it seems that the module from core will take precedence if it exists, but ResourceLoader will apparently log a warning for this. -- Bartosz Dziewoński ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] mediawiki.api.edit
> I'd assume https://www.mediawiki.org/wiki/Deprecation_policy#Removal > applies: "Code MUST emit hard deprecation notices for at least one major > MediaWiki version before being removed." Formally, this policy only applies to PHP code. The Scope section says: "This proposed policy applies to the PHP API of the MediaWiki core (mediawiki/core.git) codebase. It explicitly does not apply to the api.php API, client-side JavaScript, HTML output, or database schemas." I don't know if we even have a policy for the removal of JS modules. It would certainly be a good idea to have one, so we don't randomly break custom JS code... -- Daniel Kinzler Principal Software Engineer, Core Platform Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] mediawiki.api.edit
On Wed, 2019-09-25 at 05:44 +0200, Jeroen De Dauw wrote: > Yesterday I released a new feature in the Maps extension that uses the > mediawiki.api.edit resource loader module. > > I developed this against MediaWiki 1.31 (the latest LTS and minimum version > of MediaWiki required by Maps). Today I found out that things are broken on > MediaWiki 1.33.0. Apparently the mediawiki.api.edit resource loader module > got removed. https://phabricator.wikimedia.org/rMWecc812f06e7dff587b3f31dc18189adbf4616351 > What is the deprecation policy for such modules? I'd assume https://www.mediawiki.org/wiki/Deprecation_policy#Removal applies: "Code MUST emit hard deprecation notices for at least one major MediaWiki version before being removed." https://phabricator.wikimedia.org/T196802#5435748 for specific info. Cheers, andre -- Andre Klapper (he/him) | Bugwrangler / Developer Advocate https://blogs.gnome.org/aklapper/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
