[RFC] io.h friends

2003-01-09 Thread Dimitrie O. Paun
Folks, Just as I thought 'fine, I'll add the #ifdef, and get it over with', this thing comes back to haunt me. For the record, I've delete the previous thread, _and_ the io.h patch from my tree, thinking the issue was put to rest. As you can probably guess, I have the io.h problems in wxWindows,

Re: [RFC] io.h friends

2003-01-09 Thread Dan Kegel
Dimitrie O. Paun wrote: #if !defined(__UNIX__) || defined(USE_MSVCRT) #include io.h #endif But this is not all! For example, wxWindows includes stuff like this: #include sys/unistd.h #include sys/stat.h Since they are available in mingw, and cygwin, and in UNIX, but if I want to use msvcrt they

Re: [RFC] io.h friends

2003-01-09 Thread Alexandre Julliard
Dimitrie O. Paun [EMAIL PROTECTED] writes: So, let's say I do: #ifndef __UNIX__ #include io.h #endif Well, this will not work if I want to compile with msvcrt, because __UNIX__ will be defined anyway. So what do I have to test for? I think it would work. What you have to do is something

Re: [RFC] io.h friends

2003-01-09 Thread Dimitrie O. Paun
On January 9, 2003 12:12 pm, Alexandre Julliard wrote: I think it would work. What you have to do is something like: #ifndef __UNIX__ #include io.h #else #include unistd.h #endif This so fast! :) Remember, __UNIX__ is always defined when compiling in Wine, so we can never include io.h.

Re: [RFC] io.h friends

2003-01-09 Thread Alexandre Julliard
Dimitrie O. Paun [EMAIL PROTECTED] writes: Remember, __UNIX__ is always defined when compiling in Wine, so we can never include io.h. Which begs the question: why do we have it in msvcrt in the first place? :) Because not all apps are cygwin apps, and pure Windows apps are of course not going

Re: [RFC] io.h friends

2003-01-09 Thread Dimitrie O. Paun
On January 9, 2003 12:54 pm, Alexandre Julliard wrote: You can do that just fine with my solution, all we need is a trivial unistd.h in the msvcrt headers. Plus this way you also have a chance to build the app under normal Unix, where you will never have io.h. OK, cool. What about this patch?

Re: [RFC] io.h friends

2003-01-09 Thread Francois Gouget
On Thu, 9 Jan 2003, Dimitrie O. Paun wrote: [...] Remember, __UNIX__ is always defined when compiling in Wine, so we can never include io.h. Which begs the question: why do we have it in msvcrt in the first place? :) Because it's part of the Visual C++ headers for the msvcrt library. Visual

Re: [RFC] io.h friends

2003-01-09 Thread Alexandre Julliard
Dimitrie O. Paun [EMAIL PROTECTED] writes: On my system (RH 8.0), /usr/include/sys/unistd.h simply does #include unistd.h so it works perfectly with this addition. But is this standard? Should we just add a similar file to include/msvcrt/sys and be done with it? Yes, that's probably

Re: [RFC] io.h friends

2003-01-09 Thread Dimitrie O. Paun
On January 9, 2003 02:26 pm, Francois Gouget wrote: Which begs the question: why do we have it in msvcrt in the first place? :) Because it's part of the Visual C++ headers for the msvcrt library. I was just _kidding_ :) Notice the smiley ... -- Dimi.