Re: Fixing include quotes (was: Re: conformance test for ShellExecute)

2003-01-02 Thread Alexandre Julliard
Patrik Stridvall [EMAIL PROTECTED] writes: I think it is better than Alexandre runs winapi_cleanup --include-quotes himself if he thinks it does the correct things. If not please inform me what the problem is. In my tree, the patch is over 800k. I'm not sure there's much point in

Re: Fixing include quotes (was: Re: conformance test for ShellExecute)

2003-01-02 Thread Dan Kegel
Dimitrie O. Paun wrote: Bottom line, since the change is free (the work is done by a script), and there is little chance of conflicts with other patches (it touches only the include statements), I think it's worth doing now. There is one downside: it may make old patches harder to apply, and it

Re: Fixing include quotes (was: Re: conformance test for ShellExecute)

2003-01-02 Thread Dimitrie O. Paun
On January 2, 2003 02:07 pm, Dan Kegel wrote: There is one downside: it may make old patches harder to apply, and it may make it harder to sync with other trees (e.g. rewind). In general yes, but I don't think it's a big problem in this particular case where _only_ #include statements are

Re: Fixing SUBLANG_NEUTRAL (was: Re: Fixing include quotes (was: Re: conformance test for ShellExecute))

2003-01-02 Thread Dimitrie O. Paun
On January 2, 2003 04:05 pm, Shachar Shemesh wrote: While we are on the subject of api_check and such, how about changing SUBLANG_NEUTRAL in all non-neutral languages to SUBLANG_DEFAULT, as it should be? Are you volunteering? :) If it's supposed to be this way, a patch would be most

RE: Fixing include quotes (was: Re: conformance test for ShellExecute)

2003-01-01 Thread Patrik Stridvall
On December 31, 2002 06:41 am, Patrik Stridvall wrote: I think it is better than Alexandre runs winapi_cleanup --include-quotes himself if he thinks it does the correct things. Well, that's cool, but your original message gave the impression that this is still a work in progress

RE: Fixing include quotes (was: Re: conformance test for ShellExecute)

2002-12-31 Thread Patrik Stridvall
On December 30, 2002 03:41 pm, Patrik Stridvall wrote: I'm already on it by improving winapi_cleanup. Very well, I've put you up for it instead. But make sure you don't over do it :) Well, for the future I have planned grouping and automatic addition of #ifdef HAVE_ and that sort of

Re: Fixing include quotes (was: Re: conformance test for ShellExecute)

2002-12-31 Thread Dimitrie O. Paun
On December 31, 2002 06:41 am, Patrik Stridvall wrote: I think it is better than Alexandre runs winapi_cleanup --include-quotes himself if he thinks it does the correct things. Well, that's cool, but your original message gave the impression that this is still a work in progress not

Fixing include quotes (was: Re: conformance test for ShellExecute)

2002-12-30 Thread Dan Kegel
Dimitrie O. Paun wrote: On December 29, 2002 07:45 pm, Dan Kegel wrote: +#include wine/test.h Please use instead of even in Wine. The old code uses for historical reasons that are no longer an issue. It needs to be changed (and we're waiting for some Perl wizard to help out g), but the new

Re: Fixing include quotes (was: Re: conformance test for ShellExecute)

2002-12-30 Thread Dimitrie O. Paun
On December 30, 2002 12:43 pm, Dan Kegel wrote: OK, maybe that's another janitorial project I can take on. Is it only the test programs and winelib programs that should be converted from to , or is there more? Everything. That is, all files that include things from include/* should use

Re: Fixing include quotes (was: Re: conformance test for ShellExecute)

2002-12-30 Thread Dimitrie O. Paun
On December 30, 2002 12:43 pm, Dan Kegel wrote: OK, maybe that's another janitorial project I can take on. You asked for it! :) http://www.dssd.ca/wine/Wine-Janitorial.html#include-quotes -- Dimi.

RE: Fixing include quotes (was: Re: conformance test for ShellExecute)

2002-12-30 Thread Patrik Stridvall
On December 30, 2002 12:43 pm, Dan Kegel wrote: OK, maybe that's another janitorial project I can take on. You asked for it! :) http://www.dssd.ca/wine/Wine-Janitorial.html#include-quotes I'm already on it by improving winapi_cleanup. I'm not 100% sure it is correct though and I havn't

RE: Fixing include quotes (was: Re: conformance test for ShellExecute)

2002-12-30 Thread Jeff Smith
--include-qoutes needs to be --include-quotes ^^ ^^ This is incorrect in both the message and the patch. -- Jeff S From: Patrik Stridvall [EMAIL PROTECTED] I'm already on it by improving winapi_cleanup. I'm not 100% sure it is correct though and I

RE: Fixing include quotes (was: Re: conformance test for ShellExecute)

2002-12-30 Thread Patrik Stridvall
--include-qoutes needs to be --include-quotes ^^ ^^ This is incorrect in both the message and the patch. Ah. Thanks. :-) Somehow I can never learn that to spell the quo* words correctly. I always seem to believe it is spelled qou*. Despite working with

Re: Fixing include quotes (was: Re: conformance test for ShellExecute)

2002-12-30 Thread Dimitrie O. Paun
On December 30, 2002 03:41 pm, Patrik Stridvall wrote: I'm already on it by improving winapi_cleanup. Very well, I've put you up for it instead. But make sure you don't over do it :) It seems to me the algo is simple (if the include can not be accessed relative to the dir in which the .c file