In general yes, but not in the context of Wine. Of course it's more
satisfying to make the function behave better, and it's OK to do it as
long as it doesn't break anything, but we can't have anybody depend on
that; because if we someday find an app that depends on the garbage
results we will
Alexandre Julliard [EMAIL PROTECTED] writes:
This is silly. It's just a gratuitous incompatibility that will break
code for no good reason.
The point is: It does not break existing code. Existing code which
uses NULL as string parameter for _ultoa just does crash.
Do you seriously think that
[EMAIL PROTECTED] writes:
The native RtlLargeIntegerToChar function does produce garbage or
STATUS_BUFFER_OVERFLOW for base 2, 8 and 16 when the value is
larger than 0x. Here I decided also against bug for bug
compatibility.
IMHO doing something senseful instead of crashing or
Alexandre Julliard [EMAIL PROTECTED] writes:
[EMAIL PROTECTED] writes:
+ * _ultoa (NTDLL.@)
+ *
+ * Converts an unsigned long integer to a string.
+ *
+ * Assigns a '\0' terminated string to str and returns str.
+ * Does not check if radix is in the range of 2 to 36 (as
[EMAIL PROTECTED] writes:
The extension makes sense. I can think of several good usages of this
extension.
Applications using the extended functionality will not run under native
windows.
Therefore I documented the extension as Difference.
Summary: Using the extend and embrace strategy
Alexandre Julliard wrote:
snip
If the ReactOS guys want to add incompatible extensions that's their
choice; but it's a mistake IMO, and it's definitely not something we
are going to do in Wine.
The only incompatible extension we have discussed adding was for SVG
graphics support. This idea
[EMAIL PROTECTED] writes:
+ * _ultoa (NTDLL.@)
+ *
+ * Converts an unsigned long integer to a string.
+ *
+ * Assigns a '\0' terminated string to str and returns str.
+ * Does not check if radix is in the range of 2 to 36 (as native DLL).
+ *
+ * Difference:
+ * - Does not crash
