Re: [PATCH] check length in path canonicalize

2006-12-03 Thread Dmitry Timoshkov
Marcus Meissner [EMAIL PROTECTED] wrote: -MultiByteToWideChar(CP_ACP,0,lpszPath,-1,szPath,MAX_PATH); +INT ret; + +ret = MultiByteToWideChar(CP_ACP,0,lpszPath,-1,NULL,0); +if (ret MAX_PATH) { + FIXME(Too long path!\n); + return FALSE; +} +ret =

[PATCH] overflow checking for MultiByteToWideChar/WideCharToMultiByte

2006-12-03 Thread Marcus Meissner
Hi, This is more a FYI patch and GCC 4.0+ specific. This enhancement detects if the size of a known buffer is different than the specified size. Thie tests/sock.c adjustement is necessary due to stdlib.h inclusion. Ciao, Marcus --- dlls/kernel32/locale.c |2 ++ dlls/ws2_32/tests/sock.c

winedump: Cast-qual warnings fix (2 of 2)

2006-12-03 Thread Andrew Talbot
Sorry, I made a mess of titling this patch, twice. Please find and use the version whose subject line and changelog entry refer to winedump, not winedbg. Thanks, -- Andy.

Re: One more go at fixing GetCursorPos()

2006-12-03 Thread Stefan Dösinger
Hi, I will run both apps on windows(xp sp2) and compare the output. Just wanted to add that Windows brings up the same results. pgpCqj0Pb0IZQ.pgp Description: PGP signature

Re: d3d [2]: Optional callback infrastructure for implicit texture surface destruction.

2006-12-03 Thread Markus Amsler
H. Verbeet wrote: I think the callback should be non-optional. I think you're right. I wanted to avoid code duplication for default callbacks in ddraw, d3d8, d3d9, wined3d. But the non-optional way would avoid duplication in wined3d, and it's more elegant = non-optional wins with 1:2. I

Re: d3d [2]: Optional callback infrastructure for implicit texture surface destruction.

2006-12-03 Thread Markus Amsler
Stefan Dösinger wrote: Am Sonntag 03 Dezember 2006 21:52 schrieb Markus Amsler: /* IWineD3DTexture */ +IWineD3DTextureImpl_Destroy, Wouldn't it maybe be better to make the destroy method part of IWineD3DBase? They need different callback types as arguments, so I think it's not

Firefox-1.5.x on Wine slow on javascript-heavy pages

2006-12-03 Thread Dan Kegel
I've been using Firefox-1.5.x again on wine (using the winehq packages for Ubuntu) on my dual 650MHz system as my main browser again for the last few months. It's working quite well... except that javascript-heavy pages/apps like gmail are a tad sluggish at accepting keyboard input. For some

Re: Firefox-1.5.x on Wine slow on javascript-heavy pages

2006-12-03 Thread Aaron Slunt
On my family computer, which runs windows xp, js is incredibly slow on firefox with pages such as gmail. as well. 550mhz P3. I wouldn't think it's necessarily a wine issue moreso than a hardware issue, or the fact that javascript can be cpu intensive. On 12/3/06, Dan Kegel [EMAIL PROTECTED]

Re: riched20: fixes and additional conformance tests for EM_EXSETSEL

2006-12-03 Thread Matt Finnicum
Hey, I'm sorry for not noticing this bug earlier - I have a bad habit of only browsing bugs listed under wine-richedit. I actually sent in a patch that fixes this bug before, but it wasn't accepted because I hadn't marked a test that it causes to fail as todo_wine. Does the attached patch solve