Re: Work legalities

2007-03-09 Thread Shachar Shemesh
Jeremy White wrote: If you are employed to do programming (even at a university), or have made an agreement with your employer, school or anyone else saying it owns software you write, then you and we need a signed document from them disclaiming any rights they may have to the software.

Re: Work legalities

2007-03-09 Thread Nathan Williams
I asked today and was told there shouldn't be a problem and my boss is going to check it over for me with the powers that be. In the meantime I think I'll just start coding and not submit anything until I eventually get it in writing. On 3/9/07, Shachar Shemesh [EMAIL PROTECTED] wrote: Jeremy

Re: wined3d: Update cursor position on ShowCursor

2007-03-09 Thread H. Verbeet
I'm not sure why, but it looks like this was commited as part of http://source.winehq.org/git/wine.git/?a=commitdiff;h=7126b63645747fe035aaa1167f0dcda8cb38be01 On 08/03/07, Erich Hoover [EMAIL PROTECTED] wrote: Request for comments, as per http://www.winehq.com/site/sending_patches. For

Re: Alexandre Julliard : advapi32: Fixed registry test that failed because of a buffer overflow.

2007-03-09 Thread Alexandre Julliard
James Hawkins [EMAIL PROTECTED] writes: The test passes in Windows, so isn't this hiding a bug in our implementation of RegSetValueW? No, it's because the Windows build stores the variables differently in memory. The test was buggy. -- Alexandre Julliard [EMAIL PROTECTED]

Re: wined3d: Update cursor position on ShowCursor

2007-03-09 Thread Alexandre Julliard
H. Verbeet [EMAIL PROTECTED] writes: I'm not sure why, but it looks like this was commited as part of http://source.winehq.org/git/wine.git/?a=commitdiff;h=7126b63645747fe035aaa1167f0dcda8cb38be01 Yes, I screwed up the commit, but the patch is in. Sorry about the confusion. -- Alexandre

Re: [2/2] wined3d: IWineD3DDeviceImpl_UpdateSurface: return D3DERR_INVALIDCALL if source and dest format do not match

2007-03-09 Thread H. Verbeet
On 09/03/07, Fabian Bieler [EMAIL PROTECTED] wrote: +if (destFormat != srcFormat) { +WARN(source %p and dest %p must match, returning WINED3DERR_INVALIDCALL\n, pSourceSurface, pDestinationSurface); +return WINED3DERR_INVALIDCALL; +} You should probably print the actual

Re: quartz: Check allocation failure and clear memory in DSound Renderer

2007-03-09 Thread Robert Shearman
Chris Robinson wrote: return CLASS_E_NOAGGREGATION; pDSoundRender = CoTaskMemAlloc(sizeof(DSoundRenderImpl)); +if (!pDSoundRender) +return E_OUTOFMEMORY; +ZeroMemory(pDSoundRender, sizeof(DSoundRenderImpl)); pDSoundRender-lpVtbl = DSoundRender_Vtbl;

Re: quartz: Check allocation failure and clear memory in DSound Renderer

2007-03-09 Thread Chris Robinson
On Friday 09 March 2007 03:26:31 am you wrote: The check for allocation failure is good, but clearing the memory that is going to be initialised anyway is inefficient and unnecessary. Not all of it is initialized, which is what led me to create the patch (if the object is created then released

Re: quartz: Check allocation failure and clear memory in DSound Renderer

2007-03-09 Thread Detlef Riekenberg
On Fr, 2007-03-09 at 03:02 -0800, Chris Robinson wrote: +ZeroMemory(pDSoundRender, sizeof(DSoundRenderImpl)); Since you clear the whole struct, ... pDSoundRender-lpVtbl = DSoundRender_Vtbl; pDSoundRender-IBasicAudio_vtbl = IBasicAudio_Vtbl; @@ -325,9 +328,15 @@ HRESULT

Re: Tackling gdiplus?

2007-03-09 Thread Ivan de Jesus Deras Tabora
So what would be the overall of the project? I'm interested in participating in this Google SoC, so this project sound interesting to me for this SoC 2007. Regards, Ivan On 3/9/07, Dan Kegel [EMAIL PROTECTED] wrote: An increasing number of apps need gdiplus.dll. Seems like it's time for Wine

Re: Writing a winelib plugin

2007-03-09 Thread Shachar Shemesh
Dan Kegel wrote: What application did you have in mind? I honestly don't know, yet. I'm meeting a prospective client on Sunday that is currently doing some browser plugin via ActiveX, and wants to support Linux and Mac OSX, as well as Firefox. They were thinking about using Wine for some of the

Re: Tackling gdiplus?

2007-03-09 Thread Huw Davies
On Thu, Mar 08, 2007 at 10:50:30PM -0800, Dan Kegel wrote: An increasing number of apps need gdiplus.dll. Seems like it's time for Wine to include it. Yes, absolutely. Since Mono has implemented much of gdiplus already ( http://www.mono-project.com/Libgdiplus ), we ought to be able to just

Is there someone working on dxdiag?

2007-03-09 Thread Mirek
Hi, I would like to start some applications like Carmageddon TDR 2000 in HW mode, Neverwinter Nights 2 or just GetGPUAndSystemInfo.exe from Nvidia SDK demos and maybe 3DMark with HW info, but there are problems with detecting video card, I assume the main problem is in dxdiag library. So I

Re: user32: avoid NULL pointer access in DefWindowProcA WM_NCCREATE

2007-03-09 Thread Felix Nawothnig
Jan Zerebecki wrote: cs is never NULL at that point. Where should it be checked for NULL, then? Or what does it prevent to be NULL? cs == lParam. And this code is inside if (lParam != NULL).

Re: quartz: Check allocation failure and clear memory in DSound Renderer

2007-03-09 Thread Felix Nawothnig
Detlef Riekenberg wrote: @@ -325,9 +328,15 @@ HRESULT DSoundRender_create(IUnknown * pUnkOuter, LPVOID * ppv) pDSoundRender-pClock = NULL; pDSoundRender-init = FALSE; pDSoundRender-started = FALSE; ... there is no need to clear it again. However, note that NULL is not always all

Re: Is there someone working on dxdiag?

2007-03-09 Thread Bryan Haskins
have you tried plopping in a native dxdiag app. to see if it does enough for the application to think the environment is alright? It would be pretty cool to have a native Wine dxdiag though... Having a standardized set of tests would be very helpful, not to mention for the log output function,

Re: quartz: Check allocation failure and clear memory inDSound Renderer

2007-03-09 Thread Dmitry Timoshkov
Felix Nawothnig [EMAIL PROTECTED] wrote: However, note that NULL is not always all binary zero in memory. :) I don't believe it's true since NULL is defined as (void *)0. -- Dmitry.

Re: Is there someone working on dxdiag?

2007-03-09 Thread Mirek
WW, it is working, with native dxdiagn.dll I can start Neverwinter Nights 2 without any problems, coool :) Mirek Bryan Haskins napsal(a): have you tried plopping in a native dxdiag app. to see if it does enough for the application to think the environment is alright? It would be pretty

Re: quartz: Check allocation failure and clear memory inDSound Renderer

2007-03-09 Thread Felix Nawothnig
Dmitry Timoshkov wrote: However, note that NULL is not always all binary zero in memory. :) I don't believe it's true since NULL is defined as (void *)0. Actually it may aswell be just 0 in C. Just in C++ it's defined to be (void *)0. But even with just 0 an assignment/compare/whatever will

Re: Tackling gdiplus?

2007-03-09 Thread Ivan de Jesus Deras Tabora
On 3/9/07, Huw Davies [EMAIL PROTECTED] wrote: On Thu, Mar 08, 2007 at 10:50:30PM -0800, Dan Kegel wrote: An increasing number of apps need gdiplus.dll. Seems like it's time for Wine to include it. Yes, absolutely. Since Mono has implemented much of gdiplus already (

Re: quartz: Check allocation failure and clear memoryinDSound Renderer

2007-03-09 Thread Dmitry Timoshkov
Felix Nawothnig [EMAIL PROTECTED] wrote: Dmitry Timoshkov wrote: However, note that NULL is not always all binary zero in memory. :) I don't believe it's true since NULL is defined as (void *)0. Actually it may aswell be just 0 in C. Just in C++ it's defined to be (void *)0. But even with

Re: Tackling gdiplus?

2007-03-09 Thread Dmitry Timoshkov
Ivan de Jesus Deras Tabora [EMAIL PROTECTED] wrote: Since Mono has implemented much of gdiplus already ( http://www.mono-project.com/Libgdiplus ), we ought to be able to just slurp that into Wine and get quite a ways. Except that's based on top of Cairo, whereas ours should be based on

Re: Is there someone working on dxdiag?

2007-03-09 Thread Stefan Dösinger
Am Freitag 09 März 2007 15:50 schrieb Mirek: Hi, I would like to start some applications like Carmageddon TDR 2000 in HW mode, Neverwinter Nights 2 or just GetGPUAndSystemInfo.exe from Nvidia SDK demos and maybe 3DMark with HW info, but there are problems with detecting video card, I assume

Re: quartz: Check allocation failure and clear memoryinDSound Renderer

2007-03-09 Thread Alexandre Julliard
Dmitry Timoshkov [EMAIL PROTECTED] writes: Have you read it at all? NULL is guaranteed to be 0 in all contexts. If some C++ compiler decides to generate not 0 data while converting/casting a NULL pointer, it should be declared broken. The point is that (void*)0 isn't guaranteed to be

Re: [2/2] wined3d: IWineD3DDeviceImpl_UpdateSurface: return D3DERR_INVALIDCALL if source and dest format do not match

2007-03-09 Thread Fabian Bieler
Please ignore this patch.

Re: quartz: Check allocation failure and clear memory in DSound Renderer

2007-03-09 Thread Francois Gouget
On Fri, 9 Mar 2007, Felix Nawothnig wrote: Detlef Riekenberg wrote: @@ -325,9 +328,15 @@ HRESULT DSoundRender_create(IUnknown * pUnkOuter, LPVOID * ppv) pDSoundRender-pClock = NULL; pDSoundRender-init = FALSE; pDSoundRender-started = FALSE; ... there is no need to

Re: New opengl thread context selection patches for testing

2007-03-09 Thread Mirek
Stefan Dösinger napsal(a): Am Dienstag 06 März 2007 20:48 schrieb Mirek: Stefan Dösinger napsal(a): Am Sonntag 04 März 2007 23:04 schrieb Mirek: Ok, i tried it with current CVS. + Oblivion is still broken (same as with previous patchset) Which offscreen rendering method did you use?

Re: Work legalities

2007-03-09 Thread James Vasile
Shachar Shemesh wrote: Jeremy White wrote: If you are employed to do programming (even at a university), or have made an agreement with your employer, school or anyone else saying it owns software you write, then you and we need a signed document from them disclaiming any rights they may

How does wine determine to draw non-client area according to managed mode setting?

2007-03-09 Thread Sunil Baek
Hello, When wine runs on managed mode, it delegate drawing non-client area(caption, frame-border) to window manager. I found NC_DrawCaption function is not invoked on managed mode. On non-managed mode, that function is invoked. I tried to find routine which determine to draw non-client area

Re: New opengl thread context selection patches for testing

2007-03-09 Thread Mirek
Without patch 10 I can run Rainbow Six Vegas, even the game, but it is realy slow and graphic is very ugly. Mirek Slugen Mirek napsal(a): Ok, i tried it with current CVS. + There are many improvments in some games like Tomb Raider Legends, GTA San Andreas, HalfLife Episode One and 3DMark

Re: Don't compare file handles to NULL

2007-03-09 Thread Michael Stefaniuc
Francois Gouget wrote: On Wed, 7 Mar 2007, Michael Stefaniuc wrote: [...] You mean something like http://people.redhat.com/mstefani/wine/smatch/scripts/file_handles.pl ? Cool, thanks. [...] Most are false positives (non NULL check before CloseHandle()). These are not false

Re: Don't compare file handles to NULL

2007-03-09 Thread Michael Stefaniuc
Michael Stefaniuc wrote: Francois Gouget wrote: On Wed, 7 Mar 2007, Michael Stefaniuc wrote: [...] Sending patches... Send a patch too for the additional occurence that the improved script has found. Duh ... I mean I have sent a patch already for the additional bug found by the improved

Question about OpenGL/D3D

2007-03-09 Thread Mike Schaadt
Has anyone tested using standard window objects in a window that also had an opengl/d3d context? I believe Terragen 2 is attempting to do this. If this hasn't been tested, than it might be the cause of all of the static that appears non opengl area, making the program nearly unusable. No

Re: [Bug 7503] Eve Online pasword box on login screen doesn't work

2007-03-09 Thread Lei Zhang
On 2/20/07, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Lei Zhang [EMAIL PROTECTED] wrote: Can we change wineprefixcreate to copy the truetype fonts (if any) from /usr/X11R6/lib/X11/fonts/TTF or /usr/share/X11/fonts/TTF or [insert distro specific X11/fonts/TTF directory] to

Re: Writing a winelib plugin

2007-03-09 Thread Kevin Krammer
On Friday 09 March 2007 14:21 +0100, Shachar Shemesh wrote: Dan Kegel wrote: What application did you have in mind? I honestly don't know, yet. I'm meeting a prospective client on Sunday that is currently doing some browser plugin via ActiveX, and wants to support Linux and Mac OSX, as well

Re: Don't compare file handles to NULL

2007-03-09 Thread Alexandre Julliard
Michael Stefaniuc [EMAIL PROTECTED] writes: Ok, as there are no false positives i have improved the script a little; documented it on my Smatch page and added it to my daily Smatch run. If you know more functions that return a file_handle i can search for those too. At the moment i'm looking

Re: Question about OpenGL/D3D

2007-03-09 Thread Stefan Dösinger
Am Freitag 09 März 2007 19:47 schrieb Mike Schaadt: Has anyone tested using standard window objects in a window that also had an opengl/d3d context? This is known not to work. It was a regression due to the window management rewrite. The problem is that since the window management rewrite all

Re: Tackling gdiplus?

2007-03-09 Thread Dan Kegel
Huw wrote: Since Mono has implemented much of gdiplus already ( http://www.mono-project.com/Libgdiplus ), we ought to be able to just slurp that into Wine and get quite a ways. Except that's based on top of Cairo, whereas ours should be based on gdi32. But cairo has a win32 backend. So I

Patches in bugzilla

2007-03-09 Thread Vijay Kiran Kamuju
Hi, There are some patches that are attached in the bugzilla. They havent sent to wine-patches mailing list. Can I mail them to the mailing list on their behalf? I have asked them to submit to the mailing list. The patches are submitted about 2 months back. Thanks, VJ

Re: comctl32: treeview: Message sequencing tests

2007-03-09 Thread Marcelo Duarte
Chris Peterson escreveu: This is another patch for my CS130 assignment. It adds message sequencing tests. Other changes include: I updated one of my previous tests which was not testing the implied message; I changed a SendMessageW to SendMessageA call in DoFocusTest to fix a problem on

Re: comctl32: treeview: Message sequencing tests

2007-03-09 Thread James Hawkins
On 3/9/07, Marcelo Duarte [EMAIL PROTECTED] wrote: Chris Peterson escreveu: This is another patch for my CS130 assignment. It adds message sequencing tests. Other changes include: I updated one of my previous tests which was not testing the implied message; I changed a SendMessageW to

Re: Don't compare file handles to NULL

2007-03-09 Thread Michael Stefaniuc
Alexandre Julliard wrote: Michael Stefaniuc [EMAIL PROTECTED] writes: Ok, as there are no false positives i have improved the script a little; documented it on my Smatch page and added it to my daily Smatch run. If you know more functions that return a file_handle i can search for those

Re: Don't compare file handles to NULL

2007-03-09 Thread Francois Gouget
On Fri, 9 Mar 2007, Michael Stefaniuc wrote: [...] Ok, as there are no false positives i have improved the script a little; documented it on my Smatch page and added it to my daily Smatch run. Thanks a lot for the Smatch script. It has proven pretty useful already. -- Francois Gouget [EMAIL

Re: user32: avoid NULL pointer access in DefWindowProcA WM_NCCREATE

2007-03-09 Thread Jan Zerebecki
On Fri, Mar 09, 2007 at 03:53:17PM +0100, Felix Nawothnig wrote: Jan Zerebecki wrote: cs is never NULL at that point. Where should it be checked for NULL, then? Or what does it prevent to be NULL? cs == lParam. And this code is inside if (lParam != NULL). Sorry, I missed that, because it

Re: Question about OpenGL/D3D

2007-03-09 Thread Bryan Haskins
Ah so that was the infamous problem with things like the WC3 Map editor, and such? Thinking about that not it makes sense. On 3/9/07, Stefan Dösinger [EMAIL PROTECTED] wrote: Am Freitag 09 März 2007 19:47 schrieb Mike Schaadt: Has anyone tested using standard window objects in a window that

Re: Shader instruction table whitespace cleanup

2007-03-09 Thread Ivan Gyurdiev
Kevin Wallerbos wrote: This formatting patch cleans up the spacing in the pixel/vertexshader instruction table, making it somewhat nicer on the eyes. The lines have become a bit longer than practical on standard resolutions, but that shouldn't be a problem as most lines were already too long. A

Re: WineD3D: Blit the offscreen texture into the drawable if needed

2007-03-09 Thread Ivan Gyurdiev
This time cube texture support is added. Hopefully the coords are right, I had no test app for them. If not it should be easy to spot the very characteristic flipping of the image. I'm confused - you replaced a patch which had no support for cube maps, with one that has untested support

Quick, how do you install native dcom? Or the visual C++ runtimes? Or...

2007-03-09 Thread Dan Kegel
OK, I've been doing bug triage on and off for years, but just recently I've gotten to the point where I'm tired of going to the NativeDCOM wiki page to remember how to try an app with native dcom just to see if the bug in question is a COM bug. So I wrote a trivial script to automate installing

Re: Add Xcursor support

2007-03-09 Thread Adam Petaccia
This patch makes the Guild Wars show up in all its glory.