Re: WineD3D patch test needed

2007-04-22 Thread Vit Hrachovy
Hi Stefan, I've tested the patch using Oblivion and it seems there are no stability or rendering issues. Regards Vit Stefan Dösinger wrote: Hi, I have a patch which fixes the performance problems introduced with c0782603d09807c6ca506948bb4a814a73430184 . I am sure that the patch is correct,

Re: devenum: Constify a variable

2007-04-22 Thread Robert Shearman
Andrew Talbot wrote: Robert Shearman wrote: Andrew Talbot wrote: */ static HRESULT WINAPI DEVENUM_IClassFactory_CreateInstance( LPCLASSFACTORY iface, -LPUNKNOWN pUnkOuter, +const IUnknown *pUnkOuter, REFIID riid, LPVOID *ppvObj) I'm not sure what th

Re: comments for a fix for wine/dlls/wineoss.drv/mixer.c for Solaris

2007-04-22 Thread Dmitry Timoshkov
<[EMAIL PROTECTED]> wrote: +#ifndef __sun__ IOCTL_TO_STR(SOUND_MIXER_PHONEIN); IOCTL_TO_STR(SOUND_MIXER_PHONEOUT); +#endif IOCTL_TO_STR(SOUND_MIXER_VIDEO); IOCTL_TO_STR(SOUND_MIXER_RADIO); +#ifndef __sun__ IOCTL_TO_STR(SOUND_MIXER_MONITOR); +#endif There is no need in intro

Re: [1/2] Extend the testing framework to include IDL files and RPC clients (take 2)

2007-04-22 Thread Dan Hipschman
On Sun, Apr 22, 2007 at 05:13:23PM +0100, Robert Shearman wrote: > Dan Hipschman wrote: > >On Fri, Apr 20, 2007 at 11:41:16AM +0200, Alexandre Julliard wrote: > > > >>That's very ugly; you shouldn't need any of that stuff, especially not > >>a separate makefile. You should put everything in the s

comments for a fix for wine/dlls/wineoss.drv/mixer.c for Solaris

2007-04-22 Thread sol11x86
On a current git tree, I noticed some variables falling out as undefined for Solaris Express/Build 61 and OpenSound System 4.0 v1002. I patched it the following way, but because I haven't played with sound before, wanted to get some comments on whether or not there is a better fix (or a better #

Re: schannel: Move schannel tests from secur32 to the recent schannel

2007-04-22 Thread Yuval Fledel
On 22/04/07, Robert Shearman wrote: Yuval Fledel wrote: > Move schannel tests from secur32 to the recent schannel. Adding a > tests directory on the way. I don't see the point in this. The actual functionality is implemented in secur32, so it makes sense for the tests to also be there. Not for

Re: wine 0.9.30-35 Something strange happened with the fonts ? ** Problem Solved **

2007-04-22 Thread Nick Law
The problem : When using notepad the following fonts are invisible when you type anything into notepad. Courier MS San Serif Small Fonts System They appear in the pull down fonts menu, but if you select one of these fonts and start typing in the notepad, no characters are displayed. (As if th

Re: msi [3/3]: Enumerate the structured storage streams from the package into the _Streams table

2007-04-22 Thread James Hawkins
On 4/22/07, Robert Shearman <[EMAIL PROTECTED]> wrote: James Hawkins wrote: > +static const WCHAR Create[] = { > +'C','R','E','A','T','E',' ','T','A','B','L','E',' ', > +'`','_','S','t','r','e','a','m','s','`',' ','(',' ', > +'`','N','a','m','e','`',' ','C','H','A','R'

Re: RegDeleteTree [3rd]

2007-04-22 Thread Paul Vriens
Stefan Leichter wrote: Am Saturday 21 April 2007 20:13 schrieb Paul Vriens: Hi Stefan the results: registry.c:576:test_query_value_ex: type set to: 0x0022fe78 registry.c:1163: Test failed: Expected ERROR_SUCCESS, got 6 registry: 293 tests executed (0 marked as todo, 1 failure), 0 skipped. Tha

Re: [PATCH] Make wine build with the Intel CC

2007-04-22 Thread Steven Edwards
On 4/21/07, Jonathan Schleifer <[EMAIL PROTECTED]> wrote: I'm sure someone on the list has icc. I had it installed before but its been a while. I never could get anything other than console apps to work, which I assumed could be do to a calling convention mismatch like Eric spoke about. I'd be

Re: devenum: Constify a variable

2007-04-22 Thread Andrew Talbot
Robert Shearman wrote: > Andrew Talbot wrote: >> */ >> static HRESULT WINAPI DEVENUM_IClassFactory_CreateInstance( >> LPCLASSFACTORY iface, >> -LPUNKNOWN pUnkOuter, >> +const IUnknown *pUnkOuter, >> REFIID riid, >> LPVOID *ppvObj) >> > > I'm not sure what the point of

Re: [PATCH] Make wine build with the Intel CC

2007-04-22 Thread Jonathan Schleifer
Eric Pouech <[EMAIL PROTECTED]> wrote: > last time I checked ICC, it didn't support calling conventions > (cdecl, stdcall...). If we don't have those, it won't be possible to > support native binaries, and only use ICC for winelib applications > (even on x86). Unless ICC has these features, it's t

Re: [PATCH] Make wine build with the Intel CC

2007-04-22 Thread Jonathan Schleifer
Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > Wine could build fine without c++, not sure why everything has to > link against the c++ library as it will probably only be needed in > winegcc. Also these compiling flags seem kind of agressive. As I said, just quoted from my .profile, nothing spec

Re: [PATCH] Make wine build with the Intel CC [Resent]

2007-04-22 Thread Jonathan Schleifer
For some strange reason, this mail didn't appear on the list. Therefore I resent it. (Maybe it's missing because it included an attached GPG signature?) Eric Pouech <[EMAIL PROTECTED]> wrote: > last time I checked ICC, it didn't support calling conventions > (cdecl, stdcall...). If we don't have

Re: [PATCH] Make wine build with the Intel CC

2007-04-22 Thread Jonathan Schleifer
Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > Ok, Please when responding add wine-devel to CC so others can follow > discussion. Forgot that, just hit reply. Did that now. > It's working well for gcc Which means nothing since gcc often has a very strange, non-standard behaviour. > so I would

Re: [PATCH] Make wine build with the Intel CC [Resent]

2007-04-22 Thread Jonathan Schleifer
For some strange reason, this mail didn't appear on the list. Therefore I resent it. (Maybe it's missing because it included an attached GPG signature?) Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > Ok, Please when responding add wine-devel to CC so others can follow > discussion. Forgot that,

Re: Improving SysEx handling in winealsa.drv

2007-04-22 Thread Michał W.
Please find attached the unified diff. Stefan Dösinger napisał(a): Am Samstag 21 April 2007 18:44 schrieb Michał W.: Please consider incorporating the patch I submit, which improves handling of MIDI System Exclusive messages in alsa driver. It should be applied to dlls/winealsa.drv/midi.c fi

Re: [PATCH] Make wine build with the Intel CC [Resent]

2007-04-22 Thread Jonathan Schleifer
For some strange reason, this mail didn't appear on the list. Therefore I resent it. (Maybe it's missing because it included an attached GPG signature?) Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > Wine could build fine without c++, not sure why everything has to > link against the c++ library

Re: msi [3/3]: Enumerate the structured storage streams from the package into the _Streams table

2007-04-22 Thread Robert Shearman
James Hawkins wrote: +static const WCHAR Create[] = { +'C','R','E','A','T','E',' ','T','A','B','L','E',' ', +'`','_','S','t','r','e','a','m','s','`',' ','(',' ', +'`','N','a','m','e','`',' ','C','H','A','R','(','5','6',')',' ', +'N','O','T',' ','N','U','L','L',

Re: devenum: Constify a variable

2007-04-22 Thread Robert Shearman
Andrew Talbot wrote: */ static HRESULT WINAPI DEVENUM_IClassFactory_CreateInstance( LPCLASSFACTORY iface, -LPUNKNOWN pUnkOuter, +const IUnknown *pUnkOuter, REFIID riid, LPVOID *ppvObj) I'm not sure what the point of this is. -- Rob Shearman

Re: schannel: Move schannel tests from secur32 to the recent schannel

2007-04-22 Thread Robert Shearman
Yuval Fledel wrote: Move schannel tests from secur32 to the recent schannel. Adding a tests directory on the way. I don't see the point in this. The actual functionality is implemented in secur32, so it makes sense for the tests to also be there. -- Rob Shearman

Re: [1/2] Extend the testing framework to include IDL files and RPC clients (take 2)

2007-04-22 Thread Robert Shearman
Dan Hipschman wrote: On Fri, Apr 20, 2007 at 11:41:16AM +0200, Alexandre Julliard wrote: That's very ugly; you shouldn't need any of that stuff, especially not a separate makefile. You should put everything in the same exe, and differentiate server and client through command line arguments, t

Re: [PATCH] Make wine build with the Intel CC [Resent]

2007-04-22 Thread Jonathan Schleifer
It seems my replies never got through because I wasn't subscribed to the list, but instead using gmane. I subscribed now and resent all my replies. Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > Ok, Please when responding add wine-devel to CC so others can follow > discussion. Forgot that, jus

Re: [PATCH] Make wine build with the Intel CC [Resent]

2007-04-22 Thread Jonathan Schleifer
It seems my replies never got though because I wasn't subscribed to the list, but instead using gmane. I subscribed now and resent all my replies. Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > Wine could build fine without c++, not sure why everything has to > link against the c++ library as it

Re: [PATCH] Make wine build with the Intel CC [Resent]

2007-04-22 Thread Jonathan Schleifer
It seems my replies never got through because I wasn't subscribed to the list, but instead using gmane. I subscribed now and resent all my replies. Eric Pouech <[EMAIL PROTECTED]> wrote: > last time I checked ICC, it didn't support calling conventions > (cdecl, stdcall...). If we don't have thos

Re: WINECFG: use directory harddiskvolume1 for mapping drive C

2007-04-22 Thread EA Durbin
I know it can be worked around by hand, I was just wondering what the status of fixing it was as the post was in march of 2006 at which time Alexandre stated it was being worked on. From: Hans Leidekker <[EMAIL PROTECTED]> To: wine-devel@winehq.org Subject: Re: WINECFG: use directory harddis

Re: WineD3D patch test needed

2007-04-22 Thread Stefan Dösinger
Am Sonntag 22 April 2007 09:32 schrieb Mirek: > I can't find any regression in D3D apps. Cool, thanks for testing :-) pgpRYP0NDheid.pgp Description: PGP signature

re: WINECFG: use directory harddiskvolume1 for mapping drive C

2007-04-22 Thread Dan Kegel
To state the obvious, another workaround is: cd ~/.wine mv drive_c harddiskvolume1 cd dosdevices ln -sf ../harddiskvolume1 c: BTW this is http://bugs.winehq.org/show_bug.cgi?id=5351 - Dan

Re: WINECFG: use directory harddiskvolume1 for mapping drive C

2007-04-22 Thread Hans Leidekker
On Sunday 22 April 2007 05:57:56 EA Durbin wrote: > What's the status of this patch? Like Alexandre said, it needs to be solved differently, but note that you can work around this issue if you run the installer with /x and then start the embedded installer by hand. -Hans

Re: WineD3D patch test needed

2007-04-22 Thread Mirek
I can't find any regression in D3D apps. Mirek Stefan Dösinger napsal(a): Hi, I have a patch which fixes the performance problems introduced with c0782603d09807c6ca506948bb4a814a73430184 . I am sure that the patch is correct, but I have the bad feeling that it brings up a few other bugs, so I