Re: Resubmit user32: TrackPopupMenu(Ex) fixes

2009-03-06 Thread Reece Dunn
2009/3/6 Rein Klazes w...@online.nl: Hi, Several rounds of commits have gone by without this patch. I thought it was rather noncontroversial, there must be something that I am overlooking. Can I get a hint please? (cleaned up some white space errors, otherwise patch is unchanged. ) Fix

Re: [sane.ds 3/4] Add support for ICAP_SUPPORTEDSIZES, enabling rational sizing for scans.

2009-03-06 Thread Alexandre Julliard
Jeremy White jwh...@codeweavers.com writes: +rc = GetLocaleInfoA(LOCALE_USER_DEFAULT, LOCALE_IPAPERSIZE, paper, sizeof(paper)); +if (rc 0) +switch (atoi(paper)) You should use LOCALE_RETURN_NUMBER. -- Alexandre Julliard julli...@winehq.org

Re: [sane.ds 4/4] Move the README to the right place and update it; remove the TWAIN file as it is just an obsolete fragment of the readily available TWAIN specification file.

2009-03-06 Thread Alexandre Julliard
Jeremy White jwh...@codeweavers.com writes: diff --git a/dlls/sane.ds/README b/dlls/sane.ds/README new file mode 100644 index 000..ce030a7 --- /dev/null +++ b/dlls/sane.ds/README @@ -0,0 +1,64 @@ +Status/TODO as of March 5, 2009. +Jeremy White, jwh...@codeweavers.com. + + +What

Re: [sane.ds 2/4] Fix a subtle bug that prevented the float scrollbar from incrementing by one.

2009-03-06 Thread Francois Gouget
On Thu, 5 Mar 2009, Jeremy White wrote: [...] +/* Note that conversion of float - SANE_Fixed is lossy; + * and when you truncate it into an integer, you can get + * unfortunate results. This calculation attempts + * to

Re: [4/6] wined3d: Simplify IWineD3DVertexBufferImpl_PreLoad() a bit.

2009-03-06 Thread Alexandre Julliard
Henri Verbeet hverb...@codeweavers.com writes: From c0f791e008fba3b7576d7e444801a7d45c72ff6a Mon Sep 17 00:00:00 2001 From: Henri Verbeet hverb...@codeweavers.com Date: Fri, 6 Mar 2009 08:43:49 +0100 Subject: wined3d: Simplify IWineD3DVertexBufferImpl_PreLoad() a bit. It doesn't work here:

Re: [2/6] dbghelp: Don't define 32-bit module handling functions in Win64.

2009-03-06 Thread Alexandre Julliard
Mike Ruprecht cma...@gmail.com writes: diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c index fcdea2e..4b6c3d6 100644 --- a/dlls/dbghelp/module.c +++ b/dlls/dbghelp/module.c @@ -438,6 +438,7 @@ enum module_type module_get_type_by_name(const WCHAR* name) return DMT_PE; }

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (6)

2009-03-06 Thread Paul Vriens
Andreas Rosenberg wrote: Hi, Error during compilation: userenv_main.c:181: warning: passing argument 1 of ‘GetUserNameW’ from incompatible pointer type Shouldn't that line be: res = GetUserNameW( userName,

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (6)

2009-03-06 Thread Paul Vriens
Paul Vriens wrote: Paul Vriens wrote: Andreas Rosenberg wrote: Hi, Error during compilation: userenv_main.c:181: warning: passing argument 1 of ‘GetUserNameW’ from incompatible pointer type Shouldn't that line

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (2nd try)

2009-03-06 Thread Andreas Rosenberg
Vitaliy Margolen wrote: The error codes returned by a function are not part of the Windows API But they are. MS just made their obligation to document all of their craft that much easer and that much more undefined. According to this logic Error! is the only message you need for anything

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (6)

2009-03-06 Thread Paul Vriens
Paul Vriens wrote: Andreas Rosenberg wrote: Hi, Error during compilation: userenv_main.c:181: warning: passing argument 1 of ‘GetUserNameW’ from incompatible pointer type Shouldn't that line be: res =

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (7)

2009-03-06 Thread Paul Vriens
Andreas Rosenberg wrote: It's quite common for these functions to check for the needed buffersize when buffer=NULL and size=0 is passed. I did a quick check on W2K3 and this is what is returned: sizePath = 0;

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (6)

2009-03-06 Thread Andreas Rosenberg
On Friday 06 March 2009 14:12:11 you wrote: Paul Vriens wrote: Andreas Rosenberg wrote: Hi, Error during compilation: userenv_main.c:181: warning: passing argument 1 of ‘GetUserNameW’ from incompatible

Re: Resubmit user32: TrackPopupMenu(Ex) fixes

2009-03-06 Thread Rein Klazes
Reece Dunn schreef: = Implementation Comments: +/* FIXME: this check is performed several times, here and in the called + functions. That could be optimized */ +if( !hMenu || !MENU_GetMenu( hMenu )) { +SetLastError( ERROR_INVALID_MENU_HANDLE) ; +return FALSE; +

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (6)

2009-03-06 Thread Paul Vriens
Andreas Rosenberg wrote: On Friday 06 March 2009 14:12:11 you wrote: Paul Vriens wrote: Andreas Rosenberg wrote: Hi, Error during compilation: userenv_main.c:181: warning: passing argument 1 of ‘GetUserNameW’ from

Re: Resubmit user32: TrackPopupMenu(Ex) fixes

2009-03-06 Thread Reece Dunn
2009/3/6 Rein Klazes w...@online.nl: Reece Dunn schreef: = Implementation Comments: +    /* FIXME: this check is performed several times, here and in the called +       functions. That could be optimized */ +    if( !hMenu || !MENU_GetMenu( hMenu )) { +        SetLastError(

Re: [1/12] dinput: begin joystick separation into a generic module

2009-03-06 Thread Vitaliy Margolen
Aric Stewart wrote: --- Patch set looks good with exception of - few more things can be moved out of joystick_linuxinput.c. But that can be separate patch(es). Vitaliy

Status of TWAIN and SANE

2009-03-06 Thread Jeremy White
Alexandre is right; text files that bit rot are a rotten way to report status. Better is to write verbose emails that make people click delete quickly grin. I've been working on improving Wine's scanner support for the past few weeks, and it's come a long way. If anyone has a scanner, and wants

AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread Klaus Layer
Hi all, since several months a user Rozanne is changing AppDB entries without contacting the maintainers. Most of the changes so far were minor changes. But today I was informed that Rozanne just deleted an entry which was maintained by me. According to the email I received, there were

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread Austin English
On Fri, Mar 6, 2009 at 2:36 PM, Klaus Layer klaus.la...@gmx.de wrote: Hi all, since several months a user Rozanne is changing AppDB entries without contacting the maintainers. Most of the changes so far were minor changes. But today I was informed that Rozanne just deleted an entry which was

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread Klaus Layer
Am Freitag, 6. März 2009 21:42:18 schrieben Sie: Well, Rozanne _is_ an AppDB administrator, hence the permission to delete those entries. That said, yes, notice should be given. -- -Austin He/she never gave any notice. I just noticed that several weeks ago another program has being

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread Zachary Goldberg
2009/3/6 Klaus Layer klaus.la...@gmx.de: Am Freitag, 6. März 2009 21:42:18 schrieben Sie: Well, Rozanne _is_ an AppDB administrator, hence the permission to delete those entries. That said, yes, notice should be given. -- -Austin He/she never gave any notice. I just noticed that

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread Rosanne DiMesio
2009/3/6 Klaus Layer klaus.la...@gmx.de: Am Freitag, 6. März 2009 21:42:18 schrieben Sie: Well, Rozanne _is_ an AppDB administrator, hence the permission to delete those entries. That said, yes, notice should be given. -- -Austin He/she never gave any notice. I just

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread David Gerard
2009/3/6 Rosanne DiMesio dime...@earthlink.net: I have not been deleting entries per se; I have on occasion merged duplicate entries using Move child objects. However, I was unaware until now that not everything in the merged entry was being transferred when I did this. I apologize for

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread James Mckenzie
Austin English austinengl...@gmail.com wrote on March 6: Sent: Mar 6, 2009 1:42 PM To: Klaus Layer klaus.la...@gmx.de, Rosanne DiMesio dime...@earthlink.net Cc: Wine Develop wine-devel@winehq.org Subject: Re: AppDB entries are being delete without contacting maintainer by Rozanne On Fri, Mar

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread Austin English
On Fri, Mar 6, 2009 at 3:44 PM, James Mckenzie jjmckenzi...@earthlink.net wrote: Austin English austinengl...@gmail.com wrote on March 6: Sent: Mar 6, 2009 1:42 PM To: Klaus Layer klaus.la...@gmx.de, Rosanne DiMesio dime...@earthlink.net Cc: Wine Develop wine-devel@winehq.org Subject: Re: AppDB

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread David Gerard
2009/3/6 Austin English austinengl...@gmail.com: Codeweavers has their own AppDB type system: http://www.codeweavers.com/compatibility/ That's no reason not to mention them, if the point is to help the reader. - d.

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread James Mckenzie
Austin English austinengl...@gmail.com wrote on March 6th: Sent: Mar 6, 2009 4:47 PM To: James Mckenzie jjmckenzi...@earthlink.net Cc: Wine Develop wine-devel@winehq.org Subject: Re: AppDB entries are being delete without contacting maintainer by Rozanne On Fri, Mar 6, 2009 at 3:44 PM, James

Re: storing the registry key class name to make PDFXChange-Viewer happy

2009-03-06 Thread Patrick
Dear Dan, Juan, Austin et al I still hope that one of you guys could take care of including this in the mainline wine - i sent a patch to wine-patches which still applies fine to the latest git tree. Any help for including the bugfix is much appreciatet. The code is totally copyright free.

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread Ben Klein
2009/3/7 James Mckenzie jjmckenzi...@earthlink.net: Also, please be aware that entries referring to ReactOS, PlayonLinux and Crossover are also being removed.  The latter is actually biting the hand that feeds us.  CodeWeavers, the producers of Crossover, host WineHQ.  What might be a

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread James McKenzie
Ben Klein wrote: 2009/3/7 James Mckenzie jjmckenzi...@earthlink.net: Also, please be aware that entries referring to ReactOS, PlayonLinux and Crossover are also being removed. The latter is actually biting the hand that feeds us. CodeWeavers, the producers of Crossover, host WineHQ.

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread Ben Klein
2009/3/7 James McKenzie jjmckenzi...@earthlink.net: Ben Klein wrote: 2009/3/7 James Mckenzie jjmckenzi...@earthlink.net: Also, please be aware that entries referring to ReactOS, PlayonLinux and Crossover are also being removed.  The latter is actually biting the hand that feeds us.  

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread Sparr
On Fri, Mar 6, 2009 at 11:39 PM, Ben Klein shackl...@gmail.com wrote: Rating: Garbage What works: Installer What doesn't work: Starting the game What wasn't tested: N/A Additional comments: This works in Crossover Games, but not in Wine ^^ I don't have a problem with this. (If it mentioned

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread Ben Klein
2009/3/7 Sparr spa...@gmail.com: On Fri, Mar 6, 2009 at 11:39 PM, Ben Klein shackl...@gmail.com wrote: Rating: Garbage What works: Installer What doesn't work: Starting the game What wasn't tested: N/A Additional comments: This works in Crossover Games, but not in Wine ^^ I don't have a

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread Austin English
On Fri, Mar 6, 2009 at 10:43 PM, Sparr spa...@gmail.com wrote: On Fri, Mar 6, 2009 at 11:39 PM, Ben Klein shackl...@gmail.com wrote: Rating: Garbage What works: Installer What doesn't work: Starting the game What wasn't tested: N/A Additional comments: This works in Crossover Games, but not

Re: AppDB entries are being delete without contacting maintainer by Rozanne

2009-03-06 Thread Austin English
On Fri, Mar 6, 2009 at 11:05 PM, Ben Klein shackl...@gmail.com wrote: 2009/3/7 Sparr spa...@gmail.com: On Fri, Mar 6, 2009 at 11:39 PM, Ben Klein shackl...@gmail.com wrote: Rating: Garbage What works: Installer What doesn't work: Starting the game What wasn't tested: N/A Additional