Re: Article on wine development strategy

2009-04-22 Thread Scott Ritchie
Vincent Povirk wrote: Your model makes bugs that show up in only a few applications very rare. I've added some to your existing model with duct tape. I arbitrarily decided that about 40% of apps would have 1 or 2 unique bugs, in addition to the current ones. You can better model this by just

Remote named pipes and stuff.

2009-04-22 Thread Kai Blin
Hi folks, I'm at SambaXP again, and so of course the cifs Kernel driver folks talked to me about the named pipe implementation. It seems like they are still trying to figure out how this could be implemented in the cleanest way. However, Jeff Layton asked me about a use case, and I have to

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader

2009-04-22 Thread Henri Verbeet
2009/4/21 Tobias Jakobi liquid.a...@gmx.net: +struct ps_np2fixup_t { +unsigned char idx[MAX_FRAGMENT_SAMPLERS]; /* indices to the real constant */ +GLfloat*const_cache; /* constant cache for fast reloading (without readback) */ +WORDswz; /* bitfield used

[PATCH] comctl32/toolbar.c: fix trace info for TOOLBAR_InternalInsertButtonsT

2009-04-22 Thread Giuseppe Bilotta
TOOLBAR_DumpTBButton should be invoked over the button currently being inserted, and not always over the first button. --- dlls/comctl32/toolbar.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/comctl32/toolbar.c b/dlls/comctl32/toolbar.c index cf54df7..851a5cc

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader

2009-04-22 Thread Stefan Dösinger
Am Dienstag, 21. April 2009 23:37:51 schrieb Tobias Jakobi: +    unsigned char   idx[MAX_FRAGMENT_SAMPLERS]; /* indices to the real constant */ I don't remember how you plan to use the ps_np2fixup_t structure in the ARB backend, but an unsigned char might turn out to be too limited if you end

re: Remote named pipes and stuff.

2009-04-22 Thread Dan Kegel
Kai asked: Is there a use case for remote named pipes? http://support.microsoft.com/kb/q238949/ shows that SQL Server supports named pipes as an access method. Some apps or sites might assume that works, and not be able to use TCP/IP for this. Google finds at least three examples of people

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader

2009-04-22 Thread Tobias Jakobi
- I'm sure I mentioned this before, but please don't add code without using it. I'll merge it with one of the other patches then. - Why is this in struct ps_compiled_shader? This really looks like something that should be internal to the backend. No, that's definitely not the case. The

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader

2009-04-22 Thread Tobias Jakobi
However the FX only supports these 256 constants and every other NV card above the FX doesn't need the fixup since ARB_texture_non_power_of_two is supported in hardware. This was my thought when limiting the index array to uchars. I know that you mentioned we could use the fixup code also for

Re: Remote named pipes and stuff.

2009-04-22 Thread Juan Lang
Hi Kai, However, Jeff Layton asked me about a use case, and I have to admit I can't think of one off the top of my head. So, what application do we have that fails to work due to the lack of remote named pipes? I actually think the clearest use of remote named pipes is actually local named

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader

2009-04-22 Thread Henri Verbeet
2009/4/22 Tobias Jakobi liquid.a...@gmx.net: - Why is this in struct ps_compiled_shader? This really looks like something that should be internal to the backend. No, that's definitely not the case. The struct's data is used both in GLSL and ARB mode (I'll submit the ARB patches later) - so it

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader

2009-04-22 Thread Tobias Jakobi
Henri Verbeet wrote: 2009/4/22 Tobias Jakobi liquid.a...@gmx.net: - Why is this in struct ps_compiled_shader? This really looks like something that should be internal to the backend. No, that's definitely not the case. The struct's data is used both in GLSL and ARB mode (I'll submit the ARB

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader

2009-04-22 Thread Henri Verbeet
2009/4/22 Tobias Jakobi liquid.a...@gmx.net: Henri Verbeet wrote: Sure, but it's still internal bookkeeping of the backends. Everything the backend needs from the outside world is the np2_fixup field from struct ps_compile_args. For ARB mode this is essential since something like the

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader

2009-04-22 Thread Tobias Jakobi
Henri Verbeet wrote: A handle table would probably make the most sense. A pointer would work for ARB, but for GLSL that's just extra indirection that isn't really needed. Sry, I have to correct myself. It won't work that way. Setting up the data of the np2 fixup data struct is done in

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader

2009-04-22 Thread Tobias Jakobi
Henri Verbeet wrote: Tex fixup parameter for tex1 would have idx 0, the one for tex3 would have idx 1. These would then be packed as PsamplerNP2Fixup0.xy and PsamplerNP2Fixup0.zw. OK, forget that as well. Like I replied to Stefan about the uchar thing: The code is only active for FX cards

Re: [1/2] comctl32/listview: Additional tests for LVM_GETSUBITEMRECT

2009-04-22 Thread Paul Vriens
Nikolay Sivov wrote: Changelog: - Additional tests for LVM_GETSUBITEMRECT From 2f2cb8e54b81ff6be7229b7931945a3bb76f4bde Mon Sep 17 00:00:00 2001 From: Nikolay Sivov bungleh...@gmail.com Date: Wed, 22 Apr 2009 13:05:56 -0400 Subject: Additional tests for LVM_GETSUBITEMRECT ---

Re: [1/2] comctl32/listview: Additional tests for LVM_GETSUBITEMRECT

2009-04-22 Thread Nikolay Sivov
Paul Vriens wrote: Nikolay Sivov wrote: Changelog: - Additional tests for LVM_GETSUBITEMRECT From 2f2cb8e54b81ff6be7229b7931945a3bb76f4bde Mon Sep 17 00:00:00 2001 From: Nikolay Sivov bungleh...@gmail.com Date: Wed, 22 Apr 2009 13:05:56 -0400 Subject: Additional tests for

Re: [1/2] comctl32/listview: Additional tests for LVM_GETSUBITEMRECT

2009-04-22 Thread Paul Vriens
Nikolay Sivov wrote: Paul Vriens wrote: Nikolay Sivov wrote: Changelog: - Additional tests for LVM_GETSUBITEMRECT From 2f2cb8e54b81ff6be7229b7931945a3bb76f4bde Mon Sep 17 00:00:00 2001 From: Nikolay Sivov bungleh...@gmail.com Date: Wed, 22 Apr 2009 13:05:56 -0400 Subject: Additional

Re: [1/2] comctl32/listview: Additional tests for LVM_GETSUBITEMRECT

2009-04-22 Thread Nikolay Sivov
Paul Vriens wrote: Nikolay Sivov wrote: Paul Vriens wrote: Nikolay Sivov wrote: Changelog: - Additional tests for LVM_GETSUBITEMRECT From 2f2cb8e54b81ff6be7229b7931945a3bb76f4bde Mon Sep 17 00:00:00 2001 From: Nikolay Sivov bungleh...@gmail.com Date: Wed, 22 Apr 2009 13:05:56 -0400

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader

2009-04-22 Thread Stefan Dösinger
Am Mittwoch, 22. April 2009 17:37:55 schrieb Tobias Jakobi: However the FX only supports these 256 constants and every other NV card above the FX doesn't need the fixup since ARB_texture_non_power_of_two is supported in hardware. This was my thought when limiting the index array to uchars. I

Re: [4/4] (Try2) msi/tests: Fix package test when run on a different drive than C:\.

2009-04-22 Thread James Hawkins
On Wed, Apr 22, 2009 at 12:05 PM, Nicolas Le Cam niko.le...@gmail.com wrote: Try2: Use helper function added in second patch, as suggested by James. This one finally fixes current relative path test to expect correct value. This version isn't using a helper function. Please thoroughly go

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader

2009-04-22 Thread Stefan Dösinger
Am Mittwoch, 22. April 2009 18:39:40 schrieb Henri Verbeet: For ARB mode this is essential since something like the prog_link struct from GLSL doesn't exist there. It's not terribly hard to introduce something like that. That could mean adding a handle table to the ARB backend, or

Re: [4/4] (Try2) msi/tests: Fix package test when run on a different drive than C:\.

2009-04-22 Thread Nicolas Le Cam
2009/4/22 James Hawkins trui...@gmail.com: On Wed, Apr 22, 2009 at 12:05 PM, Nicolas Le Cam niko.le...@gmail.com wrote: Try2: Use helper function added in second patch, as suggested by James. This one finally fixes current relative path test to expect correct value. This version isn't

Re: [4/4] (Try2) msi/tests: Fix package test when run on a different drive than C:\.

2009-04-22 Thread James Hawkins
On Wed, Apr 22, 2009 at 12:44 PM, Nicolas Le Cam niko.le...@gmail.com wrote: 2009/4/22 James Hawkins trui...@gmail.com: On Wed, Apr 22, 2009 at 12:05 PM, Nicolas Le Cam niko.le...@gmail.com wrote: Try2: Use helper function added in second patch, as suggested by James. This one finally fixes

[PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-22 Thread Giuseppe Bilotta
Trying to add a separator with an invalid pointer in iString to a toolbar works in Windows, showing that the field is ignored. --- dlls/comctl32/tests/toolbar.c | 51 + 1 files changed, 51 insertions(+), 0 deletions(-) diff --git

[PATCH 2/2] comctl32/toolbar: skip iString field for separators

2009-04-22 Thread Giuseppe Bilotta
Some programs (e.g. Graphmatica 2.0f) forget to initialize the iString field for separators in toolbars. Windows copes with this smoothly, ignoring the field altogether. Do the same in Wine. --- dlls/comctl32/toolbar.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

[1/7] [wined3d] add ps_np2fixup_t ptr to shader_arb_priv (review)

2009-04-22 Thread Tobias Jakobi
For review: This patchset implements np2 texcoord fixup in ARB mode. Constants used to store texture dimensions are already packed, using the same data structures like the GLSL packing code. The code is finished and works quite well. It has been tested with Max Payne 2, HL2 and FEAR. All

[2/7] [wined3d] shader_generate_arb_declarations: add NP2 fixup code (review)

2009-04-22 Thread Tobias Jakobi
-- Neu: GMX FreeDSL Komplettanschluss mit DSL 6.000 Flatrate + Telefonanschluss für nur 17,95 Euro/mtl.!* http://dslspecial.gmx.de/freedsl-surfflat/?ac=OM.AD.PD003K11308T4569a 0002--wined3d-shader_generate_arb_declarations-add-NP2.patch Description: Binary data

[4/7] [wined3d] implement shader_arb_load_np2fixup_constants (review)

2009-04-22 Thread Tobias Jakobi
-- Neu: GMX FreeDSL Komplettanschluss mit DSL 6.000 Flatrate + Telefonanschluss für nur 17,95 Euro/mtl.!* http://dslspecial.gmx.de/freedsl-surfflat/?ac=OM.AD.PD003K11308T4569a 0004--wined3d-implement-shader_arb_load_np2fixup_constan.patch Description: Binary data

[6/7] [wined3d] force constant reload for NP2 fixup in shader_arb_select (review)

2009-04-22 Thread Tobias Jakobi
-- Neu: GMX FreeDSL Komplettanschluss mit DSL 6.000 Flatrate + Telefonanschluss für nur 17,95 Euro/mtl.!* http://dslspecial.gmx.de/freedsl-surfflat/?ac=OM.AD.PD003K11308T4569a 0006--wined3d-force-constant-reload-for-NP2-fixup-in-sha.patch Description: Binary data

[3/7] [wined3d] shader_hw_sample: add NP2 fixup code (review)

2009-04-22 Thread Tobias Jakobi
-- Pt! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01 0003--wined3d-shader_hw_sample-add-NP2-fixup-code.patch Description: Binary data

[7/7] [wined3d] correct now faulty comment (review)

2009-04-22 Thread Tobias Jakobi
-- Pt! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01 0007--wined3d-correct-now-faulty-comment.patch Description: Binary data

[5/7] [wined3d] remove comment about np2fixup not implemented for ARB mode (review)

2009-04-22 Thread Tobias Jakobi
-- Pt! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01 0005--wined3d-remove-comment-about-np2fixup-not-implemen.patch Description: Binary data