Re: Request for Patchreview

2009-06-16 Thread Dmitry Timoshkov
André Hentschel n...@dawncrow.de wrote: Fair enough. We tend to mimic Windows behavior. I hadn't checked this myself. Note that it still should be Install*.exe rather than Instal*.exe, at least in English. --Juan My tests worked with Instal*.exe files on english Windows, too. I bet it is

Re: Request for Patchreview

2009-06-16 Thread Ben Klein
2009/6/16 Dmitry Timoshkov dmi...@codeweavers.com: André Hentschel n...@dawncrow.de wrote: Fair enough.  We tend to mimic Windows behavior.  I hadn't checked this myself.  Note that it still should be Install*.exe rather than Instal*.exe, at least in English. --Juan My tests worked with

Re: [1/4] [wined3d] move creation of NP2 fixup uniforms into separate loop

2009-06-16 Thread Henri Verbeet
2009/6/15 Tobias Jakobi liquid.a...@gmx.net: Why do you need this to be in a separate loop? Also, could you please fix your mailer to set a proper Content-Type, instead of application/octet-stream?

Re: [1/4] [wined3d] move creation of NP2 fixup uniforms into separate loop

2009-06-16 Thread Tobias Jakobi
Hi Henri, I do this for patch 3/4, otherwise the code gets kinda ugly. A good point probably is that the code is indeed rarely used, since it was written specifically for the FX generation. So it makes sense to skip it early - put it into a seperate loop and conceal it with an if-statement. Like

Re: wininet: Always create a URL cache entry.

2009-06-16 Thread Jacek Caban
Hi Hans, Hans Leidekker wrote: Fixes file downloads in ie7. -Hans diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 8f9f404..2721427 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -3807,8 +3807,7 @@ BOOL WINAPI HTTP_HttpSendRequestW(LPWININETHTTPREQW lpwhr, LPCWSTR

Re: [1/4] [wined3d] move creation of NP2 fixup uniforms into separate loop

2009-06-16 Thread Stefan Dösinger
Am Dienstag, 16. Juni 2009 10:34:52 schrieb Tobias Jakobi: Hi Henri, I do this for patch 3/4, otherwise the code gets kinda ugly. Like Stefan stated on the FDO bugtracker: which can be disabled fairly effectively at runtime if not needed (referring to the np2fixup code) Actually that

Re: wininet: Always create a URL cache entry.

2009-06-16 Thread Hans Leidekker
On Tuesday 16 June 2009 11:15:49 am Jacek Caban wrote: diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 8f9f404..2721427 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -3807,8 +3807,7 @@ BOOL WINAPI HTTP_HttpSendRequestW(LPWININETHTTPREQW lpwhr, LPCWSTR

Re: [1/4] [wined3d] move creation of NP2 fixup uniforms into separate loop

2009-06-16 Thread Henri Verbeet
2009/6/16 Tobias Jakobi liquid.a...@gmx.net: However the main point is patch 3/4, where a seperate loop makes the code a lot neater - which I think is a good thing to have :) It should probably be part of that patch then, although it's not clear to me why having those two lines in there would

Re: [1/4] [wined3d] move creation of NP2 fixup uniforms into separate loop

2009-06-16 Thread Henri Verbeet
2009/6/16 Stefan Dösinger stefandoesin...@gmx.at: at the moment - but one if condition more or less doesn't hurt, if it keeps the code cleaner. I'm not convinced it does.

Fate of PulseAudio in WINE

2009-06-16 Thread Arthur Taylor
Recent activity in http://bugs.winehq.org/show_bug.cgi?id=10495 has caused some issues. This is also a response to http://www.winehq.org/pipermail/wine-devel/2009-April/074666.html First the background. WinePulse has been an attempt to write a winmm backend for pulseaudio for wine. Currently the

RFC: dmime: Implement the DirectMusicTool8 class factory.

2009-06-16 Thread Francois Gouget
--- So all the code in dlls/dmime/tool.c was unused because nothing was calling DMUSIC_CreateDirectMusicTool8Impl(). Apparently the intent was to call it from a class factory so I looked around and came up with the following patch that implements a class factory for DirectMusicTool8. However I

Re: [1/4] [wined3d] move creation of NP2 fixup uniforms into separate loop

2009-06-16 Thread Tobias Jakobi
Actually that comment was about the state change trouble NP2 fixups cause - since we can ignore the additional state handlers needed to adjust the TF2 matrices and call the NP2 constant load code, the NP2 code doesn't add much burden if its not used. OK, I see. But the same reason should

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Roderick Colenbrander
Hi Arthur, I would recommend you to also read this thread: http://www.winehq.org/pipermail/wine-devel/2009-June/076102.html As mentioned before we would like not to have a pulse audio driver if it isn't needed at all. Some suggestions have been made to use some pulseaudio rules of thumb in our

Wine MIME handling

2009-06-16 Thread Roderick Colenbrander
Hi, For the past few days I have been looking at MIME handling in Wine. A program I'm using uses CreateProcess to launch a pdf file and I would like to use the default native pdf viewer. Initially I wrote a simple script which calls xdg-open to launch the file offered by Wine. (xdg-open `wine

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Jerome Leclanche
On Tue, Jun 16, 2009 at 2:14 PM, Roderick Colenbranderthunderbir...@gmail.com wrote: I think a lot of issues can already be fixed without requiring a new driver. One of the problems is, every time one of these issues is brought up, we hear people complaining But Pulseaudio should be a drop-in

Re: (resend) kernel32: Fix error returns from CreateFile (at least the simple ones).

2009-06-16 Thread Alexandre Julliard
Guy Albertelli galbe...@neo.rr.com writes: Changelog: - CreateFile[AW] should return ERROR_PATH_NOT_FOUND when STATUS_FILE_IS_A_DIRECTORY is returned from NtCreateFile and the requested filename has a trailing \ This breaks the tests: ../../../tools/runtest -q -P wine -M

Re: wintrust: Implement WVTAsn1SpcSpOpusInfoDecode (resend)

2009-06-16 Thread Alexandre Julliard
Juan Lang juan.l...@gmail.com writes: No difference, just a rebase. Please let me know if I'm missing something obvious. Fixes bug 17696. It doesn't work here: ../../../tools/runtest -q -P wine -M wintrust.dll -T ../../.. -p wintrust_test.exe.so asn.c touch asn.ok asn.c:888: Test failed:

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Reece Dunn
2009/6/16 Jerome Leclanche adys...@gmail.com: On Tue, Jun 16, 2009 at 2:14 PM, Roderick Colenbranderthunderbir...@gmail.com wrote: I think a lot of issues can already be fixed without requiring a new driver. One of the problems is, every time one of these issues is brought up, we hear people

How to force use of DirectX8 instead of DirectX9?

2009-06-16 Thread Joerg-Cyril.Hoehle
Hi, What is the recommended way not to use Wine's DirectX9 and fall back to DirectX8 instead? Some applications list DirectX 8.1 as their minimal graphics requirement, yet they come with DirectX9 on the CD and presumably use Wine's DirectX9. The author of the screenshot at

Re: How to force use of DirectX8 instead of DirectX9?

2009-06-16 Thread Tom Wickline
In the registry :) Tom On Tue, Jun 16, 2009 at 6:35 AM, joerg-cyril.hoe...@t-systems.com wrote: Hi, What is the recommended way not to use Wine's DirectX9 and fall back to DirectX8 instead? Some applications list DirectX 8.1 as their minimal graphics requirement, yet they come with

Re: How to force use of DirectX8 instead of DirectX9?

2009-06-16 Thread Roderick Colenbrander
Likely there is just a configuration option in the game to select a different renderer. I believe the game has a opengl and d3d one. I have no idea what it means with d3d8 or d3d9. Sometimes games really use d3d8.dll instead of d3d9.dll but other times the games only use the 'd3d8 subset' of d3d9.

Re: How to force use of DirectX8 instead of DirectX9?

2009-06-16 Thread Henri Verbeet
2009/6/16 joerg-cyril.hoe...@t-systems.com: What is the recommended way not to use Wine's DirectX9 and fall back to DirectX8 instead? Some applications list DirectX 8.1 as their minimal graphics requirement, yet they come with DirectX9 on the CD and presumably use Wine's DirectX9. You could

Re: [1/4] [wined3d] move creation of NP2 fixup uniforms into separate loop

2009-06-16 Thread Stefan Dösinger
Am Dienstag, 16. Juni 2009 12:38:23 schrieb Tobias Jakobi: Erm, I think I have to make myself even more clear here. Moving the code inside a seperate loop is actually REDUCING the amount of branching. Yes - I've expressed myself badly, so you both understood it the wrong way. What I wanted to

Re: comdlg32: Delay setting the initial size of resizable file dialog until the CDN_INITDONE notification has been processed.

2009-06-16 Thread Paul Vriens
Rein Klazes wrote: With tests. Fixes bug #18516 --- dlls/comdlg32/filedlg.c |6 +- dlls/comdlg32/tests/filedlg.c | 126 + 2 files changed, 130 insertions(+), 2 deletions(-) Hi Rein, This is introducing test failures on at least NT4. (Just as

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Stefan Dösinger
Am Dienstag, 16. Juni 2009 13:41:26 schrieb Jerome Leclanche: One of the problems is, every time one of these issues is brought up, we hear people complaining But Pulseaudio should be a drop-in replacement! We shouldn't have to change our code. There is a major (and irritating) circle of

Re: How to force use of DirectX8 instead of DirectX9?

2009-06-16 Thread Stefan Dösinger
Am Dienstag, 16. Juni 2009 12:35:22 schrieb joerg-cyril.hoe...@t-systems.com: Hi, What is the recommended way not to use Wine's DirectX9 and fall back to DirectX8 instead? Some applications list DirectX 8.1 as their minimal graphics requirement, yet they come with DirectX9 on the CD and

Re: comdlg32: Delay setting the initial size of resizable file dialog until the CDN_INITDONE notification has been processed.

2009-06-16 Thread André Hentschel
Paul Vriens schrieb: Rein Klazes wrote: With tests. Fixes bug #18516 --- dlls/comdlg32/filedlg.c |6 +- dlls/comdlg32/tests/filedlg.c | 126 + 2 files changed, 130 insertions(+), 2 deletions(-) Hi Rein, This is introducing test failures

Re: Request for Patchreview

2009-06-16 Thread André Hentschel
Dmitry Timoshkov schrieb: André Hentschel n...@dawncrow.de wrote: Fair enough. We tend to mimic Windows behavior. I hadn't checked this myself. Note that it still should be Install*.exe rather than Instal*.exe, at least in English. --Juan My tests worked with Instal*.exe files on english

Re: comdlg32: Delay setting the initial size of resizable file dialog until the CDN_INITDONE notification has been processed.

2009-06-16 Thread Paul Vriens
André Hentschel wrote: Paul Vriens schrieb: Rein Klazes wrote: With tests. Fixes bug #18516 --- dlls/comdlg32/filedlg.c |6 +- dlls/comdlg32/tests/filedlg.c | 126 + 2 files changed, 130 insertions(+), 2 deletions(-) Hi Rein, This is

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Remco
On Tue, Jun 16, 2009 at 4:48 PM, Stefan Dösingerstefandoesin...@gmx.at wrote: Am Dienstag, 16. Juni 2009 13:41:26 schrieb Jerome Leclanche: One of the problems is, every time one of these issues is brought up, we hear people complaining But Pulseaudio should be a drop-in replacement! We

Re: comdlg32: Delay setting the initial size of resizable file dialog until the CDN_INITDONE notification has been processed.

2009-06-16 Thread Paul Vriens
Paul Vriens wrote: André Hentschel wrote: Paul Vriens schrieb: Rein Klazes wrote: With tests. Fixes bug #18516 --- dlls/comdlg32/filedlg.c |6 +- dlls/comdlg32/tests/filedlg.c | 126 + 2 files changed, 130 insertions(+), 2 deletions(-)

Re: [Bug 18786] patch

2009-06-16 Thread Juan Lang
Hi Guy, Could you look at bug 18786 and my suggested patch to get MINITAB working again. It is a partial revert of one of your patches from 6/25/08 (see comment #7). I have verified that the associated tests (dlls/inetmib1/tests/main.c) exercise that code both pre and post revert. However

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Stefan Dösinger
Am Dienstag, 16. Juni 2009 17:39:47 schrieb Remco: Well, but Wine doesn't fix bugs for Windows programs. If a program doesn't work in Windows, it's not a requirement that it works in Wine. I think that the PulseAudio developer means the same thing for PA. Some apps use ALSA in a way that

Re: comdlg32: Delay setting the initial size of resizable file dialog until the CDN_INITDONE notification has been processed.

2009-06-16 Thread Rein Klazes
On Tue, 16 Jun 2009 17:49:31 +0200, you wrote: So: 1. Some (all?) resizing stuff is not supported on Win95/NT4 Agreed. I can reproduce and I will fix it. 2. The size of the desktop matters for the sizing results. Indeed, I did test this on win2k, win2k3 and winXP, all tests succeeded. Making

Re: Wine MIME handling

2009-06-16 Thread Brian Vincent
On Tue, Jun 16, 2009 at 5:26 AM, Roderick Colenbrander thunderbir...@gmail.com wrote: For the past few days I have been looking at MIME handling in Wine. A program I'm using uses CreateProcess to launch a pdf file and I would like to use the default native pdf viewer. I think it would be

Re: Wine MIME handling

2009-06-16 Thread Roderick Colenbrander
On Tue, Jun 16, 2009 at 7:23 PM, Brian Vincentbrian.vinc...@gmail.com wrote: On Tue, Jun 16, 2009 at 5:26 AM, Roderick Colenbrander thunderbir...@gmail.com wrote: For the past few days I have been looking at MIME handling in Wine. A program I'm using uses CreateProcess to launch a pdf file

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Trevor Davenport
On Tue, Jun 16, 2009 at 4:14 AM, Roderick Colenbranderthunderbir...@gmail.com wrote: Hi Arthur, I would recommend you to also read this thread: http://www.winehq.org/pipermail/wine-devel/2009-June/076102.html As mentioned before we would like not to have a pulse audio driver if it isn't

Re: RFC: dmime: Implement the DirectMusicTool8 class factory.

2009-06-16 Thread Rok Mandeljc
On 16. 06. 2009 12:33, Francois Gouget wrote: --- So all the code in dlls/dmime/tool.c was unused because nothing was calling DMUSIC_CreateDirectMusicTool8Impl(). Apparently the intent was to call it from a class factory so I looked around and came up with the following patch that

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Matteo Bruni
2009/6/16 Trevor Davenport trevor.davenp...@gmail.com: On Tue, Jun 16, 2009 at 4:14 AM, Roderick Colenbranderthunderbir...@gmail.com wrote: Hi Arthur, I would recommend you to also read this thread: http://www.winehq.org/pipermail/wine-devel/2009-June/076102.html As mentioned before we

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Chris Robinson
On Tuesday 16 June 2009 3:33:12 am Arthur Taylor wrote: I can't imagine stopping pulseaudio just so I can listen to music through foobar2000, as that would stop all my voice chats, notification sounds, and other native audio, etc. There is no need to use PulseAudio if the issue you have is

Re: RFC: dmime: Implement the DirectMusicTool8 class factory.

2009-06-16 Thread Francois Gouget
On Tue, 16 Jun 2009, Rok Mandeljc wrote: [...] The honest answer would be that because back in the day when I was working on it, I didn't fully understand how COM works, particularly the difference between class object and interface. As a result, there's bunch of .c files containing stubbed

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Michael Stefaniuc
Arthur Taylor wrote: Recent activity in http://bugs.winehq.org/show_bug.cgi?id=10495 has caused some issues. This is also a response to http://www.winehq.org/pipermail/wine-devel/2009-April/074666.html [...] It is true that currently whitespace is an issue with the patches in the bug report. I

Re: RFC: dmime: Implement the DirectMusicTool8 class factory.

2009-06-16 Thread Rok Mandeljc
On 17. 06. 2009 00:19, Francois Gouget wrote: On Tue, 16 Jun 2009, Rok Mandeljc wrote: [...] The honest answer would be that because back in the day when I was working on it, I didn't fully understand how COM works, particularly the difference between class object and interface. As a

Re: [PATCH 2/2] wined3d: improved ATI Radeon HD 4xxx detection

2009-06-16 Thread Stefan Dösinger
The patches seem ok to me, although I'd probably merge them into one patch(there's no point in adding unused defines)

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Arthur Taylor
On Tue, Jun 16, 2009 at 3:24 PM, Michael Stefaniucmstef...@redhat.com wrote: Arthur Taylor wrote: Recent activity in http://bugs.winehq.org/show_bug.cgi?id=10495 has caused some issues. This is also a response to http://www.winehq.org/pipermail/wine-devel/2009-April/074666.html [...] It

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Ben Klein
2009/6/17 Arthur Taylor theycallhim...@gmail.com: As a curious aside, would it be possible write an OpenAl dll that backended to the native OpenAl library similarly to the way OpenGl is handled? Would this not mean that if the native platform supported hardware accelerated OpenAl that the

Re: Fate of PulseAudio in WINE

2009-06-16 Thread Stefan Dösinger
Am Wednesday 17 June 2009 05:24:01 schrieb Arthur Taylor: As a curious aside, would it be possible write an OpenAl dll that backended to the native OpenAl library similarly to the way OpenGl is handled? Would this not mean that if the native platform supported hardware accelerated OpenAl that

OpenAL and DSound (was Re: Fate of PulseAudio in WINE)

2009-06-16 Thread Chris Robinson
On Tuesday 16 June 2009 8:44:36 pm Stefan Dösinger wrote: There is such a DLL around - search the wine-devel and wine patches archives from it. Alexandre said he'd accept such a openal-openal thunk(but not an openal winmm driver). The problem why it is not included yet is that the latest state