Re: FW: Re: winequartz.drv Mac OS X UI discontinued?

2009-07-12 Thread Roderick Colenbrander
On Sun, Jul 12, 2009 at 2:06 AM, James McKenziejjmckenzi...@earthlink.net wrote: Rolf Kalbermatter wrote: On Thursday July 09, 2009 5:32 PM Chris Robinson wrote: If OSX will always have Obj-C support, and the Obj-C code can be restricted to OSX-only code, then the only sticking point, in my

Re: comctl32/toolbar.c: Fix Lingvo 9.0 crashes on startup

2009-07-12 Thread Nikolay Sivov
Vladimir Pankratov wrote: Hello all. Fixed Lingvo 9.0 crashes on startup. Changed files: comctl32/toolbar.c Thanks. Maybe it's better to simplify: +idealWrap = (infoPtr-nNumButtons - hidden + (rows-1)) / ((rows == 0) ? (rows + 1) : rows); --- to something like that --- +

Re: comctl32/toolbar.c: Fix Lingvo 9.0 crashes on startup [Resend 2]

2009-07-12 Thread Nikolay Sivov
Vladimir Pankratov wrote: Hello all. Fixed Lingvo 9.0 crashes on startup. Changed files: comctl32/toolbar.c Thanks. The very first one was better (when you fixed only division by zero). Now you're changing path earlier: --- + if(rows = 0) rows = 1; --- There's no tests currently for that

Re: comctl32/toolbar.c: Fix Lingvo 9.0 crashes on startup [Resend 2]

2009-07-12 Thread Nikolay Sivov
Vladimir Pankratov wrote: Nikolay Sivov wrote: The very first one was better (when you fixed only division by zero). Now you're changing path earlier: --- + if(rows = 0) rows = 1; --- There's no tests currently for that (=0 isn't tested), could you add them (to test_setrows() I suppose)?

Re: 2/2 winex11: add XRender based GetSrcAreaStretch [with patch]

2009-07-12 Thread Austin English
On Sat, Jul 11, 2009 at 2:33 PM, Roderick Colenbranderthunderbir...@gmail.com wrote: This time with patch. Roderick On Sat, Jul 11, 2009 at 9:08 PM, Roderick Colenbranderthunderbir...@gmail.com wrote: Hi, This patch adds a XRender based GetSrcAreaStretch. A lot of work is offloaded to X

Re: 2/2 winex11: add XRender based GetSrcAreaStretch [with patch]

2009-07-12 Thread Roderick Colenbrander
Could you retry this patch using the latest XRender color conversion patch? There was a division by zero error which got triggered in some cases (not all 1-bit paths pass through my code yet). Roderick On Sun, Jul 12, 2009 at 8:36 PM, Austin Englishaustinengl...@gmail.com wrote: On Sat, Jul 11,

Re: 2/2 winex11: add XRender based GetSrcAreaStretch [with patch]

2009-07-12 Thread Roderick Colenbrander
I have just tested notepad++ on my system and it works fine. I haven't tested it using the old color patch but I'm quite certain that was the issue. If you can retest some apps. Roderick On Sun, Jul 12, 2009 at 9:10 PM, Roderick Colenbranderthunderbir...@gmail.com wrote: Could you retry this

Re: comctl32/toolbar.c: Fix Lingvo 9.0 crashes on startup

2009-07-12 Thread Vladimir Pankratov
Nikolay Sivov wrote: Vladimir Pankratov wrote: Hello all. Fixed Lingvo 9.0 crashes on startup. Changed files: comctl32/toolbar.c Thanks. Maybe it's better to simplify: +idealWrap = (infoPtr-nNumButtons - hidden + (rows-1)) / ((rows == 0) ? (rows + 1) : rows); --- to something

Re: comctl32/toolbar.c: Fix Lingvo 9.0 crashes on startup [Resend 2]

2009-07-12 Thread Vladimir Pankratov
Nikolay Sivov wrote: The very first one was better (when you fixed only division by zero). Now you're changing path earlier: --- + if(rows = 0) rows = 1; --- There's no tests currently for that (=0 isn't tested), could you add them (to test_setrows() I suppose)? What's write in this test?

Re: kernel32: Fix typos in English errors messages

2009-07-12 Thread Michael Stefaniuc
Hello Frédéric, On 07/12/2009 01:16 PM, Frédéric Delanoy wrote: @@ -3266,7 +3266,7 @@ Floating underflow MessageId=1771 SymbolicName=RPC_S_FP_OVERFLOW Language=ENU -Floating overlow +Floating overflow That sounds strange. Shouldn't that better be Floating point overflow? bye

Re: [Request for review] wrc: Add support for nameID with quotes

2009-07-12 Thread James McKenzie
Alexandre Julliard wrote: Matijn Woudt tijn...@gmail.com writes: Thanks, didn't notice that one. I've checked it with the rc from visual studio 2008 and you're right, it's really mysterious(just like the rest of windows). Single and double quotes are just copied, but only if they are in

Re: kernel32: Fix typos in English errors messages

2009-07-12 Thread Frédéric Delanoy
On 07/13/2009 12:58 AM, Michael Stefaniuc wrote: Hello Frédéric, On 07/12/2009 01:16 PM, Frédéric Delanoy wrote: @@ -3266,7 +3266,7 @@ Floating underflow MessageId=1771 SymbolicName=RPC_S_FP_OVERFLOW Language=ENU -Floating overlow +Floating overflow That sounds strange. Shouldn't

kernel32: Fix typos in English errors messages (updated)

2009-07-12 Thread Frédéric Delanoy
After comment from Michael Stefaniuc From ec72eb7117e0a7fd2940b40455478847ad166582 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Fr=C3=A9d=C3=A9ric=20Delanoy?= frederic.dela...@gmail.com Date: Sun, 12 Jul 2009 13:14:30 +0200 Subject: kernel32: Fix typos in English errors messages ---

Supported applications?

2009-07-12 Thread Austin English
Looking around the wiki/website, I can't find anywhere where the 'Supported applications' are listed (Powerpoint/Word/Excel viewer and Adobe Photoshop CS 2, if I remember correctly). Are these the only applications that are being targeted for 1.2? Should others be added? Mozilla Firefox would be

re: Supported applications?

2009-07-12 Thread Dan Kegel
Austin wrote: Looking around the wiki/website, I can't find anywhere where the 'Supported applications' are listed (Powerpoint/Word/Excel viewer and Adobe Photoshop CS 2, if I remember correctly). Maybe you're thinking of http://wiki.winehq.org/WineReleaseCriteria That's for 1.0 (I don't think

Re: [Request for review] wrc: Add support for nameID with quotes

2009-07-12 Thread Dmitry Timoshkov
James McKenzie jjmckenzi...@earthlink.net wrote: As you state (AJ): A test case would be great to show what Windows(TM) and what Wine does to see if the patch really fixes the problem. Windows(TM) does nothing with resource files. -- Dmitry.