Re: d3dx9_36: Add stubbed interface for ID3DXEffect

2010-03-23 Thread Christian Costa
Hello David, Indeed. shader.c has the same problem. Feel free to send a patch or I will do it in next patches. A+ Christian David Adam a écrit : Hello, the 2 lines + #include d3dx9.h + #include d3dx9effect.h in the d3dx9_36/effect.c file are useless, since in the d3dx9_private file, one

Re: Verbose explanation about the cygwin issue

2010-03-23 Thread Peter Rosin
Den 2010-03-22 17:47 skrev Steven Edwards: On Sat, Mar 20, 2010 at 2:49 PM, Alexandre Julliardjulli...@winehq.org wrote: And what about #ifdef __CYGWIN__ ? It sounds ugly but ... why not ? You can't use #ifdefs in winegcc. I suppose you could try to resolve __wargv dynamically at run-time.

Re: [PATCH 5/6] msvcr90: Implement _encode_pointer and _decode_pointer

2010-03-23 Thread Alexandre Julliard
Piotr Caban piotr.ca...@gmail.com writes: On 03/22/10 17:27, Alexandre Julliard wrote: This doesn't build on 64-bit Mingw because it comes with its own version of these functions. He's away for a week, can I fix it? Or should I wait until he's back before sending patches that depends on this

Re: [8/10] shell32: Implement some IShellFolderView methods over IFolderView

2010-03-23 Thread Paul Vriens
On 03/22/2010 09:22 PM, Nikolay Sivov wrote: On 3/22/2010 22:09, Paul Vriens wrote: On 03/22/2010 01:01 PM, Nikolay Sivov wrote: Implement some IShellFolderView methods over IFolderView Hi Nikolay, + /* ::MoveIcons */ + hr = IShellFolderView_MoveIcons(folderview, NULL); + ok(hr ==

Fastcall calling convention

2010-03-23 Thread Damjan Jovanovic
Hi Wine doesn't seem to support the fastcall calling convention: include/winternl.h: /* These are implemented as __fastcall, so we can't let Winelib apps link with them */ dlls/hal/hal.c: #ifdef __i386__ #define DEFINE_FASTCALL1_ENTRYPOINT( name ) \ __ASM_STDCALL_FUNC( name, 4, \

Re: Fastcall calling convention

2010-03-23 Thread Paul Chitescu
On Tuesday 23 March 2010 10:59:56 am Damjan Jovanovic wrote: Hi Wine doesn't seem to support the fastcall calling convention: include/winternl.h: /* These are implemented as __fastcall, so we can't let Winelib apps link with them */ dlls/hal/hal.c: #ifdef __i386__ #define

Re: [8/10] shell32: Implement some IShellFolderView methods over IFolderView

2010-03-23 Thread Paul Vriens
On 03/23/2010 09:43 AM, Paul Vriens wrote: On 03/22/2010 09:22 PM, Nikolay Sivov wrote: On 3/22/2010 22:09, Paul Vriens wrote: On 03/22/2010 01:01 PM, Nikolay Sivov wrote: Implement some IShellFolderView methods over IFolderView Hi Nikolay, + /* ::MoveIcons */ + hr =

Re[2]: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 2]

2010-03-23 Thread Ilya Basin
PV The only thing I'm wondering is why this big piece was added in the PV first place (2004) but that in itself is of course no guarantee it was PV needed. PV Is it possible to create more tests or is everything possible already PV catered for by that one test? Add a new verb that has '%*' in

Re: rpcrt4: Added stub function CreateStubFromTypeInfo

2010-03-23 Thread Alistair Leslie-Hughes
On 22/03/2010 11:06 PM, Nikolay Sivov wrote: Hi Nikolay, + return E_NOTIMPL; Displaying messagebox is a bit questionable, ExitProcess is even worse. If you mean here that native oleaut32 uses this call, a general FIXME is enough. If you really don't want to survive from such call you don't

Re: [PATCH 2/7] msvcr90: Added strnlen implementation (try2)

2010-03-23 Thread Alexandre Julliard
Piotr Caban pi...@codeweavers.com writes: diff --git a/dlls/msvcr80/msvcr80.spec b/dlls/msvcr80/msvcr80.spec index ed283d9..cc900ca 100644 --- a/dlls/msvcr80/msvcr80.spec +++ b/dlls/msvcr80/msvcr80.spec @@ -1389,7 +1389,7 @@ @ cdecl strncmp(str str long) msvcrt.strncmp @ cdecl

Re: Fastcall calling convention

2010-03-23 Thread Damjan Jovanovic
On Tue, Mar 23, 2010 at 11:15 AM, Paul Chitescu pa...@voip.null.ro wrote: On Tuesday 23 March 2010 10:59:56 am Damjan Jovanovic wrote: Hi Wine doesn't seem to support the fastcall calling convention: include/winternl.h: /* These are implemented as __fastcall, so we can't let Winelib apps

Re: d3dx9_36: Add stubbed interface for ID3DXEffect

2010-03-23 Thread David Adam
Hello, I removed my wine git, so I am not able to send a patch. It would be great if you could do it. A+ David 2010/3/23 Christian Costa titan.co...@wanadoo.fr Hello David, Indeed. shader.c has the same problem. Feel free to send a patch or I will do it in next patches. A+ Christian

Re: [shell32/tests] Fix a crash on shell32 5.0

2010-03-23 Thread Paul Vriens
On 03/23/2010 11:29 AM, Paul Vriens wrote: Hi, This fixes a crash. We only run this test now when SHGetFolderLocation (introduces in 5.0) is available. There is not much else we can go on to deduce whether we are 4.x or lower without skipping also on WinMe and others. Changelog Fix a crash on

Re: [2/2] dxdiagn: Successfully copy to destination variants with an invalid type in IDxDiagContainer::GetProp.

2010-03-23 Thread Alexandre Julliard
Andrew Nguyen arethus...@gmail.com writes: @@ -221,9 +221,17 @@ static HRESULT WINAPI IDxDiagContainerImpl_GetProp(PDXDIAGCONTAINER iface, LPCWS p = This-properties; while (NULL != p) { -if (0 == lstrcmpW(p-vName, pwszPropName)) { - VariantCopy(pvarProp, p-v); -

Re: 4/4 wined3d: move color keyed blitting in its own function [try 2]

2010-03-23 Thread Henri Verbeet
On 23 March 2010 12:08, Roderick Colenbrander thunderbir...@gmail.com wrote: This version takes into account the 'This - Dest' change as suggested by Henri. But not the more general point.

Re: 1/4 wined3d: pass surface to blit_shader-set_shader

2010-03-23 Thread Alexandre Julliard
Roderick Colenbrander thunderbir...@gmail.com writes: In a future patch I will move 8-bit palette handling to the shader and for that I need to retrieve the palette from the surface. This patch prepares for that and it simplifies the interface to the shader. It doesn't work here:

Re: [8/10] shell32: Implement some IShellFolderView methods over IFolderView

2010-03-23 Thread Nikolay Sivov
On 3/23/2010 11:43, Paul Vriens wrote: On 03/22/2010 09:22 PM, Nikolay Sivov wrote: On 3/22/2010 22:09, Paul Vriens wrote: On 03/22/2010 01:01 PM, Nikolay Sivov wrote: Implement some IShellFolderView methods over IFolderView Hi Nikolay, + /* ::MoveIcons */ + hr =

Re: [PATCH 02/48] Added new icon build rule

2010-03-23 Thread Joel Holdsworth
I'm certainly open to suggestions on how to reduce the work needed for the first step, but it needs to be a step in the right direction. Adding 500 files and reorganizing many directories is not a good intermediate measure. I definitely want your work committed too, in fact I included it in

Re: [PATCH] user32: end scrollbar tracking if the mouse capture is lost

2010-03-23 Thread Dmitry Timoshkov
Sébastien Ramage sebastien.ram...@gmail.com wrote: -} while (msg.message != WM_LBUTTONUP); +} while (msg.message != WM_LBUTTONUP GetCapture() == hwnd); Please fix the spacing above. +SendMessage( hScroll, WM_LBUTTONDOWN, 0, 0x10001); 0 for lParam would work just fine. A magic

Re: [PATCH] user32: end scrollbar tracking if the mouse capture is lost

2010-03-23 Thread Paul Vriens
On 03/23/2010 02:08 PM, Sébastien Ramage wrote: Fixes bug #16595 --- dlls/user32/scroll.c | 5 + dlls/user32/tests/scroll.c | 17 - 2 files changed, 17 insertions(+), 5 deletions(-) Hi Sébastien Can comment too much on the patch but this patch doesn't apply cleanly to

Re: [PATCH 02/48] Added new icon build rule

2010-03-23 Thread Joel Holdsworth
Ok, I have good news and bad news. The good news is that multipage is standard now in SVG 1.2, and it is possible to embed a raster image in the SVG if you encode it in base64. Embedded images are partially supported in inkscape via python extensions. The bad news is that you can't set the

re: dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-23 Thread Dan Kegel
Hi Eric, welcome to Wine! http://msdn.microsoft.com/en-us/library/ms221240.aspx says the only time those two functions disagree on valid bstr's is if there are embedded nul chars, in which case SysStringLength probably returns a larger value. Are you quite, quite sure that your bstrs are valid?

Re: 1/2 wined3d: add helper function for retrieving front buffer coordinates

2010-03-23 Thread Henri Verbeet
On 23 March 2010 14:14, Roderick Colenbrander thunderbir...@gmail.com wrote: +IWineD3DSwapChainImpl *swapchain = (IWineD3DSwapChainImpl *) This-container; That cast isn't safe unless you already know the surface is on a swapchain.

Re: dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-23 Thread Nikolay Sivov
On 3/23/2010 16:21, Dan Kegel wrote: Hi Eric, welcome to Wine! http://msdn.microsoft.com/en-us/library/ms221240.aspx says the only time those two functions disagree on valid bstr's is if there are embedded nul chars, in which case SysStringLength probably returns a larger value. Hi Dan. It's a

Re: dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-23 Thread Eric Lanz
Sure thing, The line we call is: m_pMD5XMLDoc-createNode(varType, Lmd5report, L, pMD5RootNode); So I think we are sending the createNode function WCHAR strings like Nikolay is saying. For that call the SysStringLen function is giving a length of 0 for Lmd5report. I think that Nikolay's

Re: dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-23 Thread Nikolay Sivov
On 3/23/2010 16:48, Eric Lanz wrote: Sure thing, The line we call is: m_pMD5XMLDoc-createNode(varType, Lmd5report, L,pMD5RootNode); So it's not a BSTR. So I think we are sending the createNode function WCHAR strings like Nikolay is saying. For that call the SysStringLen function is

Re: [PATCH 02/48] Added new icon build rule

2010-03-23 Thread Alexandre Julliard
Joel Holdsworth j...@airwebreathe.org.uk writes: In this solution you have a single page with multiple icon images present. You then place on top of these images magic invisible rectangles which have been tagged so that the renderer script knows to treat these as boundary boxes. For wine's

Re: [2/2] dxdiagn: Successfully copy to destination variants with an invalid type in IDxDiagContainer::GetProp.

2010-03-23 Thread Andrew Nguyen
On Tue, Mar 23, 2010 at 5:47 AM, Alexandre Julliard julli...@winehq.org wrote: Andrew Nguyen arethus...@gmail.com writes: @@ -221,9 +221,17 @@ static HRESULT WINAPI IDxDiagContainerImpl_GetProp(PDXDIAGCONTAINER iface, LPCWS    p = This-properties;    while (NULL != p) { -    if (0 ==

Re: [PATCH] d3dxof: Increase MAX_SUBOBJECTS and do the corresponding checks at the right place

2010-03-23 Thread Henri Verbeet
I notice several of these limits have been increased in the past, sometimes multiple times. What exactly are these supposed to protect against?

msvcrt and co.

2010-03-23 Thread André Hentschel
Hi Folks, We have actually some dlls like msvcr80 that forward to msvcrt or msvcr90. The question is, should we test these forwarding dlls for the case they behave different? If yes, how? We would have to cherrypick the tests from e.g. msvcrt which tests those functions... -- Best Regards,

Re: Verbose explanation about the cygwin issue

2010-03-23 Thread André Hentschel
Peter Rosin schrieb: Den 2010-03-22 17:47 skrev Steven Edwards: On Sat, Mar 20, 2010 at 2:49 PM, Alexandre Julliardjulli...@winehq.org wrote: And what about #ifdef __CYGWIN__ ? It sounds ugly but ... why not ? You can't use #ifdefs in winegcc. I suppose you could try to resolve __wargv

Re: [1/2] wdm.h: fix IoGetCurrentIrpStackLocation

2010-03-23 Thread Alexandre Julliard
Damjan Jovanovic damjan@gmail.com writes: @@ -1021,7 +1021,7 @@ typedef enum _MM_SYSTEM_SIZE NTSTATUS WINAPI ObCloseHandle(IN HANDLE handle); -#define IoGetCurrentIrpStackLocation(_Irp) ((_Irp)-Tail.Overlay.CurrentStackLocation) +#define IoGetCurrentIrpStackLocation(_Irp)

WineD3D BltOverride overhaul

2010-03-23 Thread Roderick Colenbrander
Hi, For a while we have been discussing on how to clean up / rewrite some parts of the surface code in WineD3D. I did submit a number of patches to initiate a rewrite of some parts but not all patches were correct and it wasn't clear what final design I had in mind. I'm posting my ideas to here

Re: [PATCH 2/2] ws2_32/tests: test a WSARecv error condition

2010-03-23 Thread Paul Vriens
On 03/22/2010 07:56 PM, Mike Kaplinskiy wrote: + +bret = GetOverlappedResult((HANDLE)dest,ov,bytesReturned, FALSE); +todo_wine ok(!bret GetLastError() == ERROR_NETNAME_DELETED, Did not get disconnect event: %d, error %d\n, bret, GetLastError()); Hi Mike, This one fails on Win98 and

Re: WineD3D BltOverride overhaul

2010-03-23 Thread Henri Verbeet
On 23 March 2010 18:41, Roderick Colenbrander thunderbir...@gmail.com wrote: Hi, ... How about something along these general lines: blitter_setup_context(src, dst, rop, ...) { context = context_acquire(src/dst/NULL); select shader / setup ffp state / etc. return context; }

Re: includes: Add private alext header for OpenAL

2010-03-23 Thread Chris Robinson
It may be a good idea to remove the experimental extensions from the file: AL_EXT_buffer_sub_data AL_EXT_sample_buffer_object ALC_EXT_thread_local_context until they're finalized. I'm hoping ALC_EXT_thread_local_context will be done in time for OpenAL Soft 1.12, but there could still be changes

i7 920 not quite twice as fast as Q9300 at building wine

2010-03-23 Thread Dan Kegel
Not as exciting an improvement as I'd hoped: 4 GB RAM Intel(R) Core(TM)2 Quad CPU Q9300 @ 2.50GHz make -j5 real7m35.985s user24m54.741s sys 3m15.628s 6 GB RAM model name : Intel(R) Core(TM) i7 CPU 920 @ 2.67GHz make -j9 real4m39.577s user30m43.651s sys

Re: [PATCH 4/5] mmdevapi: Use OpenAL for finding devices

2010-03-23 Thread Chris Robinson
FWIW, you can query ALC_DEFAULT_ALL_DEVICES_SPECIFIER (with ENUMERATE_ALL), ALC_DEFAULT_DEVICE_SPECIFIER (standard playback), and ALC_CAPTURE_DEVICE_SPECIFIER (record) to get the default device as seen by OpenAL, instead of taking the first as the default. Just make sure to query the default

steam regressed?

2010-03-23 Thread Dan Kegel
Hmm. I can't start steam anymore. This worked until quite recently...?

Re: steam regressed?

2010-03-23 Thread Reece Dunn
On 24 March 2010 00:52, Dan Kegel d...@kegel.com wrote: Hmm.  I can't start steam anymore.  This worked until quite recently...? What does running `git bisect` give as the faulty commit? - Reece

Re: steam regressed?

2010-03-23 Thread Edward Savage
On Wed, Mar 24, 2010 at 11:57 AM, Reece Dunn mscl...@googlemail.com wrote: On 24 March 2010 00:52, Dan Kegel d...@kegel.com wrote: Hmm.  I can't start steam anymore.  This worked until quite recently...? What does running `git bisect` give as the faulty commit? - Reece There has been a

Re: [PATCH 2/2] ws2_32/tests: test a WSARecv error condition

2010-03-23 Thread Mike Kaplinskiy
On Tue, Mar 23, 2010 at 3:56 PM, Paul Vriens paul.vriens.w...@gmail.com wrote: On 03/22/2010 07:56 PM, Mike Kaplinskiy wrote: + +    bret = GetOverlappedResult((HANDLE)dest,ov,bytesReturned, FALSE); +    todo_wine ok(!bret  GetLastError() == ERROR_NETNAME_DELETED, Did not get disconnect

Re: Verbose explanation about the cygwin issue

2010-03-23 Thread Steven Edwards
On Tue, Mar 23, 2010 at 4:17 AM, Peter Rosin p...@lysator.liu.se wrote: So, you need to ask yourselves what you want to do. Do you want to build Cygwin dlls/executables (depends on Cygwin libc) or do you want to build MinGW dlls/executables (depends on msvcrt)? Mixing is not supported, and if

Re: steam regressed?

2010-03-23 Thread Dan Kegel
On Tue, Mar 23, 2010 at 5:57 PM, Reece Dunn mscl...@googlemail.com wrote: On 24 March 2010 00:52, Dan Kegel d...@kegel.com wrote: Hmm.  I can't start steam anymore.  This worked until quite recently...? What does running `git bisect` give as the faulty commit? Bisecting: 0 revisions left to

Re: steam regressed?

2010-03-23 Thread Charles Davis
On 3/23/10 10:49 PM, Dan Kegel wrote: Bisecting: 0 revisions left to test after this (roughly 0 steps) Uhh... You're not done yet. I would've thought you knew that! Apparently not. Chip

Re: steam regressed?

2010-03-23 Thread Dan Kegel
On Tue, Mar 23, 2010 at 10:38 PM, Charles Davis cda...@mymail.mines.edu wrote: On 3/23/10 10:49 PM, Dan Kegel wrote: Bisecting: 0 revisions left to test after this (roughly 0 steps) Uhh... You're not done yet. I would've thought you knew that! Apparently not. Oh, foo. OK, the real result