Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread James McKenzie
Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 0a6ee55..86c200f 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -2148,6 +2148,11 @@ NTSTATUS WINAPI

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Max TenEyck Woodbury
On 07/25/2010 09:45 AM, James McKenzie wrote: Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 0a6ee55..86c200f 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -2148,6

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Andrew Eikum
On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: On 07/25/2010 09:45 AM, James McKenzie wrote: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug for bug, the functionality of what Windows does. Does Windows return STATUS_NOT_IMPLEMENTED when

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread James McKenzie
Andrew Eikum wrote: On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: On 07/25/2010 09:45 AM, James McKenzie wrote: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug for bug, the functionality of what Windows does. Does Windows return

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Reece Dunn
On 24 July 2010 16:10, Max TenEyck Woodbury m...@mtew.isa-geek.net wrote: On 07/24/2010 10:58 AM, Nikolay Sivov wrote: On 7/24/2010 18:51, Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/file.c

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Alexandre Julliard
James McKenzie jjmckenzi...@earthlink.net writes: Also, strongly defending your patches without authoritative information marks you as being arrogant. After a while, your patches will be ignored. That is not a good place to be in this project. Your habit of pretending to be an authority in

Re: [PATCH] libs/wpp: Fixed bug in preventing add_text_to_macro from handling macros over 1 kb large

2010-07-25 Thread André Hentschel
Hi, Your Patch got wrapped. Try change some settings in you Mailclient please and resubmit. Thx -- Best Regards, André Hentschel

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread James McKenzie
Max TenEyck Woodbury wrote: On 07/25/2010 01:55 PM, James McKenzie wrote: Andrew Eikum wrote: On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: On 07/25/2010 09:45 AM, James McKenzie wrote: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug

Re: [PATCH 2/2] dlls/ntdll/file.c: Return a different status code.

2010-07-25 Thread Ricardo Filipe
2010/7/25 Max TenEyck Woodbury m...@mtew.isa-geek.net: ---  dlls/ntdll/file.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 86c200f..c32baa0 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -2150,7 +2150,7 @@

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Max TenEyck Woodbury
On 07/25/2010 01:55 PM, James McKenzie wrote: Andrew Eikum wrote: On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: On 07/25/2010 09:45 AM, James McKenzie wrote: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug for bug, the functionality of

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Max TenEyck Woodbury
On 07/25/2010 01:34 PM, Andrew Eikum wrote: On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: On 07/25/2010 09:45 AM, James McKenzie wrote: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug for bug, the functionality of what Windows does. Does

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Max TenEyck Woodbury
On 07/25/2010 02:25 PM, Reece Dunn wrote: On 24 July 2010 16:10, Max TenEyck Woodburym...@mtew.isa-geek.net wrote: On 07/24/2010 10:58 AM, Nikolay Sivov wrote: On 7/24/2010 18:51, Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-)

Re: [PATCH] const variables are not compile-time constants

2010-07-25 Thread Octavian Voicu
On Sun, Jul 25, 2010 at 11:36 PM, Mikko Rasa t...@tdb.fi wrote: -    static const DWORD user_flags = clip_flags | DCX_NORESETATTRS; /* flags that can be set by user */ +    static const DWORD user_flags = DCX_PARENTCLIP | DCX_CLIPSIBLINGS | DCX_CLIPCHILDREN | DCX_WINDOW +        |

Re: propsys: add stub for PSPropertyKeyFromString

2010-07-25 Thread Andrew Nguyen
On Sun, Jul 25, 2010 at 2:09 PM, Louis Lenders xerox_xerox2...@yahoo.co.uk wrote: fixes http://bugs.winehq.org/show_bug.cgi?id=23528 I don't mean to step on this patch, but I've sent a fuller implementation of PSPropertyKeyFromString which, if accepted, should take precedence over this stub.

Re: [2/4] propsys/tests: Add tests for PSStringFromPropertyKey.

2010-07-25 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3892 Your paranoid

Re: [4/4] propsys/tests: Add tests for PSPropertyKeyFromString.

2010-07-25 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3893 Your paranoid

Re: [2/4] propsys/tests: Add tests for PSStringFromPropertyKey.

2010-07-25 Thread Andrew Nguyen
On 07/25/2010 10:46 PM, (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at