Re: ntdll/tests: Remove tests for overlong instructions

2010-12-20 Thread Alexandre Julliard
Greg Geldorp ggeld...@vmware.com writes: The overlong instruction test produces different results on different test machines. Since it fails on other machines besides the TestBot VMs I don't think this is a TestBot problem. Do you have evidence that it also fails on real hardware? --

Re: shell32/tests: Mark Win7 behaviour as broken

2010-12-20 Thread Alexandre Julliard
André Hentschel n...@dawncrow.de writes: --- dlls/shell32/tests/shlview.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) When marking results as broken you have to explain why it's reasonable to consider it broken. -- Alexandre Julliard julli...@winehq.org

Re: libs/wine: check for empty string in WINEPREFIX

2010-12-20 Thread Alexandre Julliard
André Hentschel n...@dawncrow.de writes: see http://bugs.winehq.org/show_bug.cgi?id=25554 I don't think that's necessary. -- Alexandre Julliard julli...@winehq.org

Re: jscript: Added Date.setYear implementation.

2010-12-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7715 Your paranoid

Re: [PATH try2] widl: Added support for registering alternative progids.

2010-12-20 Thread Alexandre Julliard
Jacek Caban ja...@codeweavers.com writes: This will be needed for jscript registration. This seems very ad-hoc. Unless there are many other places that need it, I think it should be handled manually in jscript. -- Alexandre Julliard julli...@winehq.org

RE: ntdll/tests: Remove tests for overlong instructions

2010-12-20 Thread Greg Geldorp
From: Alexandre Julliard Greg Geldorp writes: The overlong instruction test produces different results on different test machines. Since it fails on other machines besides the TestBot VMs I don't think this is a TestBot problem. Do you have evidence that it also fails on real hardware?

RE: ntdll/tests: Remove tests for overlong instructions

2010-12-20 Thread Francois Gouget
On Mon, 20 Dec 2010, Greg Geldorp wrote: [...] http://test.winehq.org/data/17e66e06d613026387753f350aa2eaedbcb02ac1/xp_fg-winxp-sp1/ntdll:exception.html This is a virtual machine. From the description field: Compaq's English Windows XP SP1; cleaned up and moved to VMware + Creative

Re: ntdll/tests: Remove tests for overlong instructions

2010-12-20 Thread André Hentschel
Am 20.12.2010 13:43, schrieb Francois Gouget: On Mon, 20 Dec 2010, Greg Geldorp wrote: [...] http://test.winehq.org/data/17e66e06d613026387753f350aa2eaedbcb02ac1/xp_fg-winxp-sp1/ntdll:exception.html This is a virtual machine. From the description field: Compaq's English Windows XP SP1;

Re: shell32/tests: Mark Win7 behaviour as broken

2010-12-20 Thread André Hentschel
Am 20.12.2010 12:17, schrieb Alexandre Julliard: André Hentschel n...@dawncrow.de writes: --- dlls/shell32/tests/shlview.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) When marking results as broken you have to explain why it's reasonable to consider it broken. OK,

RFC: New winetricks options --optin, --optout

2010-12-20 Thread Dan Kegel
I'm interested in which winetricks verbs people are using, mostly so I can nuke the ones that nobody cares about, but also so I can pay more attention to making sure popular ones work. So I added an --optin option to winetricks; if you give that option, winetricks will report which verbs you use.

Re: [1/2] advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. SetLastError is set according to tests in tests/service.c and in accordance with platform.

2010-12-20 Thread Andrew Nguyen
On 12/20/2010 11:29 AM, Damian Dixon wrote: +if (!lpservicestatus) +{ +OSVERSIONINFOW osVi; +/* Get windows version emulating */ +osVi.dwOSVersionInfoSize = sizeof(osVi); +GetVersionExW(osVi); +if (osVi.dwPlatformId == VER_PLATFORM_WIN32_NT)

Re: [1/2] advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. SetLastError is set according to tests in tests/service.c and in accordance with platform.

2010-12-20 Thread Nikolay Sivov
On 12/20/2010 20:29, Damian Dixon wrote: --- dlls/advapi32/service.c | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) You can't split this in two patches, cause tests should run without failures after each patch. So in your case remove todo_wine in the same

Re: [2/2] advapi32/tests: Remove todo_wine so change made in QueryServiceStatus does not cause a failure

2010-12-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7718 Your paranoid

Re: jscript: Exception tests clean up.

2010-12-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7719 Your paranoid

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove

2010-12-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7720 Your paranoid

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove

2010-12-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7721 Your paranoid

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove todo_wine for QueryServiceStatus.

2010-12-20 Thread James Mckenzie
Damian Dixon damian.di...@gmail.com wrote: Sent: Dec 20, 2010 1:28 PM To: wine-patc...@winehq.org Cc: damian.di...@gmail.com Subject: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove todo_wine for

Re: user32/cursoricon: Fix an uninitialized pointer.

2010-12-20 Thread Adam Martinson
On 12/20/2010 01:40 PM, Adam Martinson wrote: --- dlls/user32/cursoricon.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) This is wrong, please ignore it.

The Windows version of the octave --version command exposes an uncommon X network transparency issue for wine

2010-12-20 Thread Alan W. Irwin
I have been downloading lots of free software packages for Windows that are dependencies of PLplot so that I can add additional components of PLplot for my tests of PLplot under wine. Normally, I do all such testing on an X-terminal, and wine normally works without X transparency issues for

Re: RFC: New winetricks options --optin, --optout

2010-12-20 Thread Jerome Leclanche
Opted in. I don't use it as much anymore, but my most common verbs are fontsmooth-rgb, python, mfc42, msxml6, dinput8, vcrun* (depends the app) and firefox. Maybe also dotnet20/ie6/{core,all}fonts. Reminds me, sound=audioio can be removed now. I'll send you a patch. J. Leclanche On Mon, Dec

Re: RFC: New winetricks options --optin, --optout

2010-12-20 Thread Austin English
On Tue, Dec 21, 2010 at 12:10 AM, Jerome Leclanche adys...@gmail.com wrote: Opted in. I don't use it as much anymore, but my most common verbs are fontsmooth-rgb, python, mfc42, msxml6, dinput8, vcrun* (depends the app) and firefox. Maybe also dotnet20/ie6/{core,all}fonts. Reminds me,