On Mon, 2013-05-06 at 19:23 -0600, Erich E. Hoover wrote:
--- a/dlls/iphlpapi/iphlpapi_main.c
+++ b/dlls/iphlpapi/iphlpapi_main.c
@@ -210,8 +210,14 @@ DWORD WINAPI
AllocateAndGetIpAddrTableFromStack(PMIB_IPADDRTABLE *ppIpAddrTable,
*/
BOOL WINAPI CancelIPChangeNotify(LPOVERLAPPED
The first memcpy() call in puts_clbk_str_w() confuses character count
and byte count. It uses the number of characters (out-len) as number
of bytes. This leaves half of the buffer undefined.
Interestingly, the second memcpy() call in the same function is
correct.
This bug potentially makes
On 05/06/2013 03:05 PM, Max TenEyck Woodbury wrote:
Just to make this clear, the most recent version of this patch is such
a graceful handling, right?
I haven't worked on gdi32/freetype.c much, so I wouldn't be the one to
say for sure (you should probably talk to Alexandre Julliard, Dmitry
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=25463
Your paranoid
Aric Stewart a...@codeweavers.com wrote:
dlls/user32/edit.c | 21 +
include/imm.h | 9 +
2 files changed, 30 insertions(+)
Using usual 4 spaces indentation would slightly improve the readability.
--
Dmitry.
On 5/7/13 8:15 AM, Dmitry Timoshkov wrote:
Aric Stewart a...@codeweavers.com wrote:
dlls/user32/edit.c | 21 +
include/imm.h | 9 +
2 files changed, 30 insertions(+)
Using usual 4 spaces indentation would slightly improve the readability.
Maybe, but
Aric Stewart a...@codeweavers.com wrote:
dlls/user32/edit.c | 21 +
include/imm.h | 9 +
2 files changed, 30 insertions(+)
Using usual 4 spaces indentation would slightly improve the readability.
Maybe, but I always to match the styling of the
In general, I think you want to send this to wine-patches, not here.
On Mon, May 6, 2013 at 12:26 PM, Max Kellermann m...@duempel.org wrote:
The first memcpy() call in puts_clbk_str_w() confuses character count
and byte count. It uses the number of characters (out-len) as number
of bytes.
On Tue, May 7, 2013 at 3:14 AM, Hans Leidekker h...@codeweavers.com wrote:
...
TerminateThread is not the right tool here. If the thread is blocked on the
recv call while being terminated it will leak the netlink socket.
You'd need a way to synchronize the threads, but an overhead of one
On 05/07/13 17:46, Juan Lang wrote:
In general, I think you want to send this to wine-patches, not here.
This patch was also sent to wine-patches.
On Mon, May 6, 2013 at 12:26 PM, Max Kellermann m...@duempel.org
mailto:m...@duempel.org wrote:
---
dlls/msvcrt/printf.h |2 +-
On Tue, May 7, 2013 at 9:10 AM, Piotr Caban piotr.ca...@gmail.com wrote:
On 05/07/13 17:46, Juan Lang wrote:
In general, I think you want to send this to wine-patches, not here.
This patch was also sent to wine-patches.
On Mon, May 6, 2013 at 12:26 PM, Max Kellermann m...@duempel.org
Jacek Caban ja...@codeweavers.com writes:
---
dlls/ole32/compobj.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
It doesn't work here:
../../../tools/runtest -q -P wine -M wscript.exe -T ../../.. -p
wscript.exe_test.exe.so run.c touch run.ok
wine: Unhandled page fault on read
On Tue, 2013-05-07 at 10:04 -0600, Erich E. Hoover wrote:
On Tue, May 7, 2013 at 3:14 AM, Hans Leidekker h...@codeweavers.com wrote:
...
TerminateThread is not the right tool here. If the thread is blocked on the
recv call while being terminated it will leak the netlink socket.
You'd
Sam Edwards cfswo...@gmail.com wrote:
It makes the most sense to get rid of this sanity check altogether, but
until then, this should be a more robust way of doing it.
+ * TODO: This sounds like a workaround for a much deeper bug
involving
+ * aveWidth's calculation. We
14 matches
Mail list logo
