On 10/14/2013 05:21, Dmitry Timoshkov wrote:
Nikolay Sivov nsi...@codeweavers.com wrote:
+FreeLibrary(mod);
Please add the tests for FreeLibrary return value.
Makes sense, thanks.
On 10/10/2013 00:36, Frédéric Delanoy wrote:
---
dlls/xmllite/reader.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c
index 0a4423c..a216951 100644
--- a/dlls/xmllite/reader.c
+++ b/dlls/xmllite/reader.c
@@
On 10/10/2013 14:58, Jeff Latimer wrote:
---
dlls/wmvcore/Makefile.in| 2 +-
dlls/wmvcore/wmvcore_main.c | 100
+++-
include/wmsdkidl.idl| 11 ++---
3 files changed, 105 insertions(+), 8 deletions(-)
+typedef struct MetadataEditorImpl {
On 10/8/2013 10:56, Alexandre Julliard wrote:
Nikolay Sivov nsi...@codeweavers.com writes:
On 10/6/2013 19:06, Nikolay Sivov wrote:
It's normal to grow destination buffer, in this case all stored
pointers will be trashed. This patch uses offsets from start of a
buffer instead.
Hi, Alexandre
On 10/6/2013 19:06, Nikolay Sivov wrote:
It's normal to grow destination buffer, in this case all stored
pointers will be trashed. This patch uses offsets from start of a
buffer instead.
Hi, Alexandre.
Patches list shows a build failure for this one, and I don't see any
failures on testbot
On 10/2/2013 12:58, Andrew Cook wrote:
+if(!pCreateJobObjectW) {
+win_skip(No job object support\n);
+return;
+}
Once you checked that I suppose you don't need to check for
pIsProcessInJob being null, or it still could happen?
+if (option strcmp(option, wait) ==
On 9/30/2013 10:10, Daniel Jeliński wrote:
2013/9/30 Nikolay Sivov bungleh...@gmail.com
mailto:bungleh...@gmail.com
On 9/30/2013 00:51, Daniel Jeliński wrote:
+struct progress_list {
+const DWORD progress_retval_init; /* value to return
from progress routine
On 9/30/2013 00:51, Daniel Jeliński wrote:
+struct progress_list {
+const DWORD progress_retval_init; /* value to return from progress
routine */
+const BOOL cancel_init;/* value to set Cancel flag to */
+const DWORD progress_retval_end; /* value to return from
On 9/25/2013 16:03, Aric Stewart wrote:
defaultContext = ImmCreateContext();
+if (defaultContext)
+((InputContextData*)defaultContext)-threadDefault = TRUE;
I think a nicer way is to let ImmCreateContext() set this attribute.
On 9/25/2013 16:03, Aric Stewart wrote:
+if (!thread_data-defaultContext)
+{
+HIMC defaultContext;
+LeaveCriticalSection(threaddata_cs);
+defaultContext = ImmCreateContext();
+thread_data = IMM_GetThreadData(0);
Why do you need to unlock/lock around
On 09/18/2013 09:47 AM, Alistair Leslie-Hughes wrote:
+LIST_FOR_EACH_ENTRY(cursor,This-errors, struct ErrorEntry, entry)
+{
+if(nCnt == ulRecordNum)
+{
+*pErrorInfo = cursor-info;
+break;
+}
+}
+
This looks wrong, cause you never update
On 09/18/2013 10:53 AM, Dmitry Timoshkov wrote:
---
dlls/ntdll/tests/file.c | 41 +
1 file changed, 41 insertions(+)
diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c
index 120fdac..5ae605b 100644
--- a/dlls/ntdll/tests/file.c
+++
On 09/15/2013 04:25 PM, Akihiro Sagawa wrote:
hr = IUnknown_QueryInterface(reader_input,IID_IStream, (void**)stream2);
-ok(hr == E_NOINTERFACE, Expected S_OK, got %08x\n, hr);
+ok(hr == E_NOINTERFACE, Expected E_NOINTERFACE, got %08x\n, hr);
As Henri said, it's not that useful
On 09/14/2013 03:25 AM, Daniel Jeliński wrote:
Could you implement necessary part of CopyFile2 instead, and use it in
CopyFileEx? I think CopyFile2 has everything to do that.
On 09/14/2013 11:46 PM, Daniel Jeliński wrote:
2013/9/14 Nikolay Sivov nsi...@codeweavers.com
mailto:nsi...@codeweavers.com
Could you implement necessary part of CopyFile2 instead, and use
it in CopyFileEx? I think CopyFile2 has everything to do that.
I suppose I could
On 9/13/2013 11:20, Dmitry Timoshkov wrote:
This test passes under Wine and shows that ReadFile after
CreateFile(GENERIC_WRITE)
is really supposed to fail.
---
dlls/ntdll/tests/file.c | 82 +
1 file changed, 82 insertions(+)
It looks like it
On 9/13/2013 12:16, Dmitry Timoshkov wrote:
Nikolay Sivov bungleh...@gmail.com wrote:
It looks like it belongs to kernel32/tests.
Since actual access checks are done by ntdll APIs I believe that ntdll/tests
is appropriate place, kernel32 file APIs are just wrappers around the tested
On 9/13/2013 13:27, Jactry Zeng wrote:
Re-based to latest git.
Does it actually accept any other value besides CP_ACP or 1200?
Documentation is unclear here, and makes impression that only two these
values are valid.
On 9/13/2013 15:05, Jactry Zeng wrote:
bUnicode = !bRtf pStruct-codepage == CP_UNICODE;
+bUTF8 = (lParam (!strncmp((char *)lParam, utf8_bom, 3)));
What will happen if both of these are true? This needs a test with BOM
and 'codepage' set to 1200.
On 9/13/2013 22:26, André Hentschel wrote:
Sorry, ignore my comment. I missed that we actually have this call
already in wine.
On 9/13/2013 22:26, André Hentschel wrote:
+if (!pCreateFile2)
+{
+win_skip(CreateFile2 is missing\n);
+return;
+}
Should be skip() so it'll show up when running with wine. Not sure how
important it is though.
On 9/10/2013 13:30, Alistair Leslie-Hughes wrote:
Hi,
Changelog:
oledb32: Implement IDataSourceLocator get/put hWnd
Best Regards
Alistair Leslie-Hughes
Hi, Alistair.
This is wrong, interface definition should be fixed as well, HWND
parameter can't be LONG:
---
On 9/4/2013 21:16, Jactry Zeng wrote:
Hi Nikolay,
2013/9/5 Nikolay Sivov bungleh...@gmail.com
mailto:bungleh...@gmail.com
On 9/4/2013 07:17, Jactry Zeng wrote:
-ME_EndToUnicode(unicode, wszText);
+ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText);
It's still ugly to use
On 9/4/2013 07:17, Jactry Zeng wrote:
-ME_EndToUnicode(unicode, wszText);
+ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText);
It's still ugly to use magic numbers like that, in a similar situation I
had some time
ago I use ~0 to mark WCHAR data encoding that does need special
On 8/30/2013 12:19, Michael Müller wrote:
This patch implements the IDirect3DSwapChain9Ex interface as an
extension of IDirect3DSwapChain9 and thus fixes bug 34252 - Silverlight
accelerated graphics cause a D3D critical section lockup since
Silverlight does no longer try to create a Direct3D
On 8/30/2013 16:28, Piotr Caban wrote:
---
dlls/oleaut32/tests/typelib.c | 13 +++--
dlls/oleaut32/typelib.c | 13 +++--
2 files changed, 22 insertions(+), 4 deletions(-)
ITypeInfoImpl *This = info_impl_from_ICreateTypeInfo2(iface);
-FIXME(%p %u %s - stub\n,
On 8/30/2013 16:33, matyapiro31 wrote:
I found many wine sources use not a pointer,but a sequence .
for example:
krnl386.exe16/dma.c:
for(i=0,p=(char*)DMA_CurrentBaseAddress[channel];iret*size;i++)
msdaps/usrmarshal.c: for(prop = 0; prop
rgPropertySets[prop_set].cProperties; prop++)
I know in
On 8/28/2013 13:41, Ralf Habacker wrote:
Signed-off-by: Ralf Habacker ralf.habac...@freenet.de
---
dlls/iphlpapi/iphlpapi.spec |1 +
dlls/iphlpapi/ipstats.c | 26 ++
dlls/iphlpapi/ipstats.h |1 +
include/tcpmib.h|3 +++
4 Dateien
On 8/26/2013 19:04, Alexandre Julliard wrote:
Nikolay Sivov nsi...@codeweavers.com writes:
+while (min = max)
+{
+int n, c;
+
+n = (min+max)/2;
+
+c = strncmpW(olemisc_values[n].name, str, len);
strncmp isn't enough.
Right, thanks.
On 8/23/2013 13:18, Alistair Leslie-Hughes wrote:
Hi,
Fix build issue
+#include rpcproxy.h
I don't think you need this.
+HINSTANCE COMSVCS_hInstance = NULL;
This should be static (and without initializer after that).
On 8/22/2013 14:55, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
On 08/22/2013 04:08 PM, Alexandre Julliard wrote:
Nikolay Sivovnsi...@codeweavers.com writes:
Some tests for LoadRegTypeLib() with activated context
From 1ea3d8c82dd77ac14f2cdec748c0284032958b2f Mon Sep 17 00:00:00 2001
From: Nikolay Sivovnsi...@codeweavers.com
Date: Wed, 21 Aug 2013
On 8/21/2013 10:16, Alistair Leslie-Hughes wrote:
Hi,
Updated naming.
You updated method names only, what's left :
+typedef struct DataSourceImpl
+HRESULT create_data_source(IUnknown *outer, void **obj)
+static const IDataSourceLocatorVtbl DataSourceVtbl =
Also you most likely don't need
On 8/21/2013 10:33, Alistair Leslie-Hughes wrote:
+typedef struct DataSourceImpl
+{
+IDataSourceLocator IDataSourceLocator_iface;
+LONG ref;
+
+} DataSourceImpl;
All good, except this one.
On 8/20/2013 13:21, Alistair Leslie-Hughes wrote:
Hi,
Yes we do just take the pointer (pErrorInfo) passed in. MSDN states
that the caller responsible for this memory.
It means caller could free it at any time (or it could be a stack
variable), so you have to make a deep copy.
Changelog:
On 8/21/2013 09:15, Alistair Leslie-Hughes wrote:
Hi,
Use helper functions for memory
Changelog:
oledb32: Add IDataSourceLocator support
Best Regards
Alistair Leslie-Hughes
It looks okay, but I suggest to fix a naming:
+typedef struct DataSourceImpl
+{
+IDataSourceLocator
On 8/17/2013 21:05, John Chadwick wrote:
Nikolay, does this patch look good to you? I was advised on
#winehackers to get some acknowledgement that the patch is OK.
Hopefully doing so can get things moving along.
Yes, it looks ok. Idea is to have xmlChar closer to actual libxml2 calls
that need
On 8/6/2013 11:09, Álvaro Nieto wrote:
This patch solves [Bug 34211]. The implementation of strncpy function
doesn't compliant with C standard [1]. Also Microsoft Visual Studio
C/C++ compiler is ok with the standard [2].
Extract from msdn;
The strncpy function copies the initial count
On 8/2/2013 12:52, Hugh McMaster wrote:
+case REG_BINARY:
+case REG_NONE:
+pValue = value;
+for (i=0; ivalueSize; i++, pValue++)
+reg_printfW(formatXW, *pValue);
+break;
There's no need for separate variable here nor for
On 8/2/2013 13:33, Alexandre Julliard wrote:
Nikolay Sivov nsi...@codeweavers.com writes:
@@ -1031,6 +1105,17 @@ static BOOL parse_window_class_elem(xmlbuf_t* xmlbuf,
struct dll_redirect* dll)
if (!(entity-u.class.name = xmlstrdupW(content))) return FALSE;
+/* each class entry
On 8/1/2013 17:44, Hugh McMaster wrote:
This patch builds significantly on the query function stub in programs/reg.exe.
The patch includes recursion for subkeys.
Some examples of usage:
wine reg.exe query HKCU
wine reg.exe query HKCU\Console
wine reg.exe query HKCU\Console /v ScreenSize
wine
On 7/29/2013 18:02, Mislav Blazevic wrote:
First of all, pardon my ignorance, I am new to wine and winapi.
I am trying to implement apphelp.dll and I ran into issues with
NtCreateFile: It always returns 0xc103, STATUS_NOT_A_DIRECTORY,
and I am not sure what that means. Here is code:
/*
On 7/26/2013 08:48, Alexei Svitkine wrote:
On Mon, Jul 22, 2013 at 10:45 PM, Alexei Svitkine
alexei.svitk...@gmail.com mailto:alexei.svitk...@gmail.com wrote:
Don't let the gdi32 driver allocate memory in the dplayx region.
Fixes bug: http://bugs.winehq.org/show_bug.cgi?id=34095
On 7/25/2013 16:35, Piotr Caban wrote:
---
dlls/scrrun/filesystem.c | 163
+++
1 file changed, 123 insertions(+), 40 deletions(-)
Why do you need this?
On 7/23/2013 12:55, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
On 7/22/2013 22:38, Damjan Jovanovic wrote:
Changelog:
* add usbioctl.h
Damjan Jovanovic
Hi, Damjan. You forgot patches.
On 7/20/2013 23:37, John Chadwick wrote:
This patch changes the create_selection interface to accept a wide string
instead of an xmlChar string. This is a transitional change, which will be
needed as libxml2's XPath parser is phased out.
The last submission had a memory leak (sorry, I isolated
On 7/18/2013 20:28, Caibin Chen wrote:
Add tests for start and end point, setting and getting text.
---
dlls/riched20/tests/Makefile.in | 3 +-
dlls/riched20/tests/txtrng.c| 343
2 files changed, 345 insertions(+), 1 deletion(-)
create mode
, but not for the tests. What does
it mean it will be used in both files by the way?
2013/7/18 Nikolay Sivov bungleh...@gmail.com:
On 7/18/2013 20:28, Caibin Chen wrote:
Add tests for start and end point, setting and getting text.
---
dlls/riched20/tests/Makefile.in | 3 +-
dlls/riched20/tests
support in
ITextService.
I see, then maybe it's better to merge two existing files first.
[1]. http://www.winehq.org/pipermail/wine-patches/2013-July/125258.html
2013/7/18 Nikolay Sivov bungleh...@gmail.com:
On 7/18/2013 23:36, Caibin Chen wrote:
ITextRange will be used in both richole.c
to add.
2013/7/18 Nikolay Sivov bungleh...@gmail.com:
On 7/19/2013 00:04, Caibin Chen wrote:
The ITextRange objects are returned by ITextDocument_Range() method.
Both IRichEditOle and ITextService supports ITextDocument interface.
Currently we don't have ITextDocument support in ITextService. my
On 7/16/2013 09:47, Dmitry Timoshkov wrote:
Nikolay Sivov nsi...@codeweavers.com wrote:
+#include ddk/wdm.h
Please don't do that, this breaks compilation with PSDK headers. If you need
some specific definitions, types or API prototypes - replicate them in the test
itself.
What breaks exactly
On 7/9/2013 16:50, Qian Hong wrote:
Fixed a crash in MS Office 2010 Chinese version.
Thanks Jiang Yike for the helps on testing :)
---
dlls/imm32/imm.c |6 ++
dlls/imm32/tests/imm32.c | 13 +
2 files changed, 19 insertions(+)
+if (IsBadReadPtr(internal,
On 7/9/2013 18:52, Qian Hong wrote:
Hi Nikolay,
Thanks for comments!
On Tue, Jul 9, 2013 at 9:01 PM, Nikolay Sivov bungleh...@gmail.com wrote:
Do you really need this for Office 2010 or null check is enough? If it's
passing 0 handle here that's what you should check imho. If HIMCC is really
On 6/29/2013 20:26, John Chadwick wrote:
On Sat, Jun 29, 2013 at 4:48 AM, Nikolay Sivov bungleh...@gmail.com wrote:
On 6/27/2013 11:46, John Chadwick wrote:
+/* msxml's selectNodes returns a document ordered nodelist,
regardless of
+ * whether or not the xpath nodelist was document
On 6/28/2013 18:21, Pavel Borecki wrote:
Hi, Pavel.
Looks like you're using poedit or something with similar habit of
touching lines location headers:
---
-#: appwiz.rc:66 appwiz.rc:42 cryptui.rc:343 msacm32.rc:37 winecfg.rc:191
-#: winecfg.rc:228 wordpad.rc:245
+#: appwiz.rc:66
+#:
On 6/27/2013 11:46, John Chadwick wrote:
+/* msxml's selectNodes returns a document ordered nodelist, regardless of
+ * whether or not the xpath nodelist was document ordered... */
+ole_check(IXMLDOMNode_selectNodes(rootNode,_bstr_(ancestor-or-self::node()),
list));
+
On 6/26/2013 13:10, Микола wrote:
Hi, please resubmit this patch with your full name transliterated in
English.
On 6/14/2013 14:12, Alistair Leslie-Hughes wrote:
+typedef struct ErrorInfoImpl
+{
+IErrorInfo IErrorInfo_iface;
+LONG ref;
+
+GUID m_Guid;
+WCHAR *source;
+WCHAR *description;
+WCHAR *help_file;
+DWORD m_dwHelpContext;
+} ErrorInfoImpl;
Please use consistent naming,
On Thu, Jun 6, 2013 at 9:55 AM, Alistair Leslie-Hughes
leslie_alist...@hotmail.com wrote:
Hi,
Corrects a spelling mistake too and
Changelog:
oledb32: Correct DBPROP_INIT_PROVIDERSTRING and DBPROP_INIT_HWND types
Best Regards
Alistair Leslie-Hughes
-{ extemdedW,
On Fri, May 31, 2013 at 9:07 PM, Fabian Müntefering cookiezz...@gmx.dewrote:
Implemented functions of text format and text layout regarding text
alignment.
Try 3: Used proper enum value to set the enum variables.
+if(alignment!=DWRITE_TEXT_ALIGNMENT_CENTER
Hi, Fabian.
You forgot to attach patches 2 and 3.
On Tue, May 21, 2013 at 3:45 PM, Jactry Zeng jactr...@gmail.com wrote:
If the whole purpose of storing flags names is to output readable debug
info I think it's better to have a single separate function
that takes flags combination and returns static buffer pointer with a name.
This way it
On 5/1/2013 01:43, Daniel Jeliński wrote:
Please fix spec file accordingly.
installation but
you're free to look at definitions.
Thanks,
Daniel
2013/5/1 Nikolay Sivov bungleh...@gmail.com
mailto:bungleh...@gmail.com
On 5/1/2013 01:43, Daniel Jeliński wrote:
Please fix spec file accordingly.
On 4/30/2013 10:20, Sergey Guralnik wrote:
When copying cyrillic text from wordpad (or any richedit)
to Open Office document I get unreadable text. It seems
like some another codepage was used to display text.
This path solves this problem.
---
dlls/riched20/writer.c |8
1 files
On 4/20/2013 13:43, Alistair Leslie-Hughes wrote:
Hi,
Changelog:
oledb32: Implement GetConversionSize DBTYPE_WSTR-DBTYPE_WSTR
Best Regards
Alistair Leslie-Hughes
Please add a test when caller supplies source length, at least one case
is interesting - supplied length is less than
On 4/15/2013 02:50, Hin-Tak Leung wrote:
--- On Sun, 14/4/13, Vincent Povirk madewokh...@gmail.com wrote:
Well, here's a simple thing you can
check: Does your zlib dll link to
_lseek or _lseeki64? The first one uses a 32-bit offset.
Wine's
implementation
On 4/11/2013 05:52, John Chadwick wrote:
Hello,
I am a student of computer science interested in entering Wine
development via GSoC 2013.
Upon looking at the various suggested proposals, the project of
reimplementing XPath without libxml2 looked particularly interesting.
I am familiar with
Why not use DECLARE_INTERFACE_ here? And why bother checking UNICODE?
On Mon, Apr 8, 2013 at 12:10 PM, Dmitry Timoshkov dmi...@baikal.ru wrote:
---
dlls/uuid/uuid.c | 1 +
include/commdlg.h | 80
+++
2 files changed, 81 insertions(+)
On Mon, Apr 8, 2013 at 3:53 PM, Hugh McMaster
hugh.mcmas...@masterindexing.com wrote:
This file recreates most, if not all, of the source found in
dlls/advapi32/registry.c in dlls/kernel32. It provides registry
functionality.
Tested on Linux Mint 14 and Mac OS X 10.8 (Mountain Lion).
---
On Mon, Apr 8, 2013 at 4:47 PM, Hugh McMaster
hugh.mcmas...@masterindexing.com wrote:
From: Nikolay Sivov [mailto:bungleh...@gmail.com]
Sent: Monday, 8 April 2013 11:08 PM
To: wine-devel; Hugh McMaster
Subject: Re: [3/13] wineconsole and kernel32: set
GetLargestConsoleWindowSize based
Please use your real name.
On Sun, Apr 7, 2013 at 7:46 PM, mog422 ad...@mog422.net wrote:
On Wed, Apr 3, 2013 at 1:31 PM, Tatyana Fokina taty...@etersoft.ru wrote:
Function DocumentPropertiesA calling GDI_CallExtDeviceMode16: If value
pDeviceName is , from GDI_CallExtDeviceMode16 return -1.
Is it possible to add a test for that?
On 3/25/2013 07:48, Dmitry Timoshkov wrote:
Why not just call GetParent() every time when a
notification is being sent?
Because it won't work if you create a control without WS_CHILD.
How is that different from the WM_WINDOWPOSCHANGING handler?
How what is different? There's a check for
On 3/27/2013 09:05, Alistair Leslie-Hughes wrote:
Hi,
Changelog:
iads.idl: Add missing interfaces
Best Regards
Alistair Leslie-Hughes
+typedef enum
+{
+ADS_SEARCHPREF_ASYNCHRONOUS = 0,
+ADS_SEARCHPREF_DEREF_ALIASES= 1,
You don't need to do it manually, widl will
On 3/27/2013 00:10, Daniel Jeliński wrote:
2013/3/26 Nikolay Sivov nsi...@codeweavers.com:
Is there any reliable way to test send mouse messages? Cause it looks like
if I send WM_LBUTTONDOWN directly it doesn't trigger tab selection code on
windows, but works in wine.
Do you want to figure out
On 3/25/2013 07:24, Dmitry Timoshkov wrote:
Nikolay Sivov nsi...@codeweavers.com wrote:
+case WM_WINDOWPOSCHANGING:
+{
+ HWND parent = GetParent(hwnd);
+ if (parent) infoPtr-hwndNotify = parent;
+ return DefWindowProcW(hwnd, uMsg, wParam, lParam);
+}
What
On 3/25/2013 07:34, Dmitry Timoshkov wrote:
Nikolay Sivov nsi...@codeweavers.com wrote:
+case WM_WINDOWPOSCHANGING:
+{
+ HWND parent = GetParent(hwnd);
+ if (parent) infoPtr-hwndNotify = parent;
+ return DefWindowProcW(hwnd, uMsg, wParam, lParam);
+}
What
On 3/22/2013 10:08, Ken Thomases wrote:
On Mar 21, 2013, at 3:41 PM, C.W. Betts wrote:
On Mar 18, 2013, at 3:22 PM, Ken Thomases k...@codeweavers.com wrote:
On Mar 18, 2013, at 4:04 PM, Charles Davis wrote:
At this point, though, I'm wondering if it wouldn't just be easier to have
On 3/15/2013 21:43, Nikolay Sivov wrote:
try2: fixed builder leak
Please ignore this one, it removes too much, I have a better version.
On 3/11/2013 10:27, Jeff Latimer wrote:
---
include/nserror.h | 226
++
1 file changed, 226 insertions(+)
create mode 100644 include/nserror.h
+#ifndef _NSERROR_H
+#define _NSERROR_H
This doesn't look right.
+#define
On 3/11/2013 13:41, Jeff Latimer wrote:
On 11/03/13 17:43, Nikolay Sivov wrote:
On 3/11/2013 10:27, Jeff Latimer wrote:
---
include/nserror.h | 226
++
1 file changed, 226 insertions(+)
create mode 100644 include/nserror.h
+#ifndef
On 3/11/2013 16:36, Jeff Latimer wrote:
+if (!ppv) return E_INVALIDARG;
You don't need this most likely.
+IUnknown_AddRef((IUnknown*)*ppv);
A cleaner way is to AddRef original iface, but that's a matter of taste.
+static ULONG WINAPI WMCreateEditor_AddRef(IWMMetadataEditor *iface)
On 3/9/2013 10:03, Daniel Jelinski wrote:
Makes sense, thanks. I briefly searched for such cases and
LISTVIEW_FindItemW() seems to be broken the same way.
On 3/6/2013 09:11, Alistair Leslie-Hughes wrote:
Hi,
Changelog:
msxml3: Implement IXMLParser Get/Set Factory
You also need to release factory reference on parser release it seems.
Best Regards
Alistair Leslie-Hughes
On 3/4/2013 19:30, Dmitry Timoshkov wrote:
Francois Gouget fgou...@codeweavers.com wrote:
The goal of the Wine tests is to document the Windows behavior that
Windows applications expect.
Skipping a test because your VM is broken doesn't qualify as a documentation
of Windows behaviour.
Why is
On 2/24/2013 17:52, Daniel Jelinski wrote:
2013/2/24 Nikolay Sivov bungleh...@gmail.com:
This doesn't look very clean. I mean invoking *up handler from a *down one.
Is this something that could be resolved with message loop like rbutton
dragging was fixed?
TrackMouse contains the message loop
On 2/24/2013 10:07, Max TenEyck Woodbury wrote:
On 02/23/2013 02:54 AM, Eric Pouech wrote:
Le 21/02/2013 14:33, Max TenEyck Woodbury a écrit :
Would it be appropriate to add a test to the name demangler that:
1) Scans all '.dll' and '.spec' files for mangled names, and
2) Tries to decode
On 2/24/2013 01:33, Daniel Jelinski wrote:
@@ -10178,6 +10139,19 @@ static LRESULT LISTVIEW_LButtonDown(LISTVIEW_INFO
*infoPtr, WORD wKey, INT x, IN
if (infoPtr-dwLvExStyle LVS_EX_ONECLICKACTIVATE)
if(lvHitTestInfo.iItem != -1)
notify_itemactivate(infoPtr,lvHitTestInfo);
+
On 2/24/2013 15:13, Eric Pouech wrote:
Le 24/02/2013 10:18, Nikolay Sivov a écrit :
On 2/24/2013 10:07, Max TenEyck Woodbury wrote:
On 02/23/2013 02:54 AM, Eric Pouech wrote:
Le 21/02/2013 14:33, Max TenEyck Woodbury a écrit :
Would it be appropriate to add a test to the name demangler
On 2/25/2013 09:29, Dmitry Timoshkov wrote:
It seems your system time is an hour ahead. Probably old timezone info?
On 2/22/2013 14:09, Alexandre Julliard wrote:
Nikolay Sivov nsi...@codeweavers.com writes:
@@ -2101,9 +2102,17 @@ TREEVIEW_GetItemT(const TREEVIEW_INFO *infoPtr,
LPTVITEMEXW tvItem, BOOL isW)
{
if (!item) return FALSE;
-TRACE(got item from different tree %p, called
On 2/21/2013 02:19, Daniel Jelinski wrote:
/* disable per item notifications on LVS_OWNERDATA style
FIXME: single LVN_ODSTATECHANGED should be used */
bOldChange = infoPtr-bDoChangeNotify;
-if (infoPtr-dwStyle LVS_OWNERDATA) infoPtr-bDoChangeNotify = FALSE;
+/*if
to attach to a bug report to test with,
but it shouldn't be committed.
If you want to fix this, please do. If not, I'll get back to it later.
I do not plan to look at this right now. Anyway thanks for looking at
this code and fixing other things.
Regards,
Daniel
2013/2/21, Nikolay Sivov nsi
+ ok(hr == FUSION_E_PRIVATE_ASM_DISALLOWED, Expected S_OK, got %08x\n,
hr);
You could just strip excepted value message part to avoid typos like that.
On Fri, Feb 1, 2013 at 8:10 AM, Alistair Leslie-Hughes
leslie_alist...@hotmail.com wrote:
Hi,
The other fusion patch is superseded by this
On 1/31/2013 12:35, Alistair Leslie-Hughes wrote:
Hi,
Changelog:
fusion: Allow null to be the value of the public key
+static const WCHAR nullpublickey[] = {
+
'm','s','c','o','r','l','i','n',',','v','e','r','s','i','o','n','=','0',
+
On 1/25/2013 12:47, Daniel Jelinski wrote:
Hello,
Thanks for reviewing. What's the preferred way of checking whether the
code is compiled for 32 or 64bit?
Regards,
Daniel
Check for pointer size.
2013/1/24 Alexandre Julliard julli...@winehq.org:
Daniel Jelinski djelins...@gmail.com writes:
On 1/15/2013 00:53, Daniel Jelinski wrote:
+if(lParam == -1)
+ return LISTVIEW_SetIconSpacing(infoPtr, -1, -1);
+return LISTVIEW_SetIconSpacing(infoPtr, LOWORD(lParam), HIWORD(lParam));
Why do you need to handle this case specially? If it's -1 for 64bit
comctl32 it should give you
On 1/15/2013 01:15, Daniel Jelinski wrote:
2013/1/14 Nikolay Sivov bungleh...@gmail.com:
On 1/15/2013 00:53, Daniel Jelinski wrote:
+if(lParam == -1)
+ return LISTVIEW_SetIconSpacing(infoPtr, -1, -1);
+return LISTVIEW_SetIconSpacing(infoPtr, LOWORD(lParam),
HIWORD(lParam));
Why
1 - 100 of 954 matches
Mail list logo
