It took a while but I found the culprit. The crash is most likely because
the window is (about to be) destroyed.
The only thing left to do is to fix the 211 test failures on NT4.
I fixed a typo while at it and used a define instead of a magic value.
Are you sure this is the right fix?
Is
But maybe not with a window that's in the process (or already) of being
destroyed (in the callback).
OK, but in the the first run of the loop we are not in the process of
destroying the window, as DestroyWindow has not been called yet. Am i
missing something? Are there other things that cause
Forgot wine-devel,
I'm lost here as TrackPopupMenu() is not called in a loop. It's only
called once. So which API function are you referring to?
I was referring to the loop we got into on NT4 where the proc handler
would be re-entered again and again. My idea was that if this happened on 9x
as
Hey Paul,
Thanks for cleaning up the crashing 9x test-case so fast.
This patch has introduced test failures on NT4 and below (tested locally):
http://test.winehq.org/data/tests/user32:win.html
Sorry for that.
The callback is entered several times on NT4 (only once on XP) so it
seems. The
Simply use wine_server_call instead of wine_server_call_err.
That is my point. That will not work. The existing the error codes
*should* be translated, but this new one should not. So if i use
wine_server_call i would have to filter which ones to translate
manually.
It would also give me the
On Mon, 2010-01-11 at 14:00 -0600, Alexandre Julliard wrote:
Is there actually an app that depends on this?
http://bugs.winehq.org/show_bug.cgi?id=9369
This bug requires the function to fail, but you are probably right that
no-one checks the error code. I will change the patch/test to be less
this.
Thanks,
/pedro
On Fri, 2010-01-08 at 10:06 +0100, Alexandre Julliard wrote:
Peter Dons Tychsen donpe...@tdcadsl.dk writes:
@@ -85,6 +85,17 @@ BOOL set_capture_window( HWND hwnd, UINT gui_flags, HWND
*prev_ret )
HWND previous = 0;
UINT flags = 0;
BOOL ret
On Fri, 2009-12-25 at 19:55 -0800, Dan Kegel wrote:
So, where should the tests live? I had been thinking
programs/cmd/tests,
but maybe something like programs/tests would be better
given that it can test more than just cmd.
I think it would make most sense to follow the current strategy of
On Sat, 2009-12-26 at 20:53 +0100, Jacek Caban wrote:
We can't really change the language as Windows doesn't provide English
resources for most binaries and executables on on non-English
installations.
Why not just have the tests file check the locale, and then do skip()
for the language
On Tue, 2009-12-22 at 15:36 -0600, Austin English wrote:
Sure. FWIW, I'm working on some AutoHotKey/Appinstall tests for cmd,
but it's a bit difficult, since the only way to capture the stdout is
to pipe it to a file first.
Hey, i think a test suite for cmd is an excellent idea, and is surely
On Thu, 2009-10-15 at 19:19 -0500, Ken Thomases wrote:
+static int once;
+
+if (!once++) FIXME(independent left/right volume not implemented
(%f, %f)\n, left, right);
I know it is a detail, but is it not a bit misleading having a variable
called once when it will trigger the code
Yes I understand your comments, but they show that you don't
understand
the code.
Of course i dont understand the code as well as you, as i only have used
a little amount of time studying it.
I was only hoping that my comments would spark a response which would
allow me continue with the
So... i have investigated other ways of fixing this. Would you accept a
patch that uses _NET_WM_MOVERESIZ to move the window? That might also
fix the issue. That message requests the WM to move the window at not X.
I have now tested with _NET_WM_MOVERESIZ _NET_MOVERESIZE_WINDOW
No cigar. They
What you should do first is spend a lot more time studying the code,
before deciding that it has major problems and needs major
changes. It's a very sensitive area where the smallest change has big
consequences, and you have to be sure to know what you are doing.
I already spent time on this
I am posting your response, as you are not on CC in the bug.
You can't do that sort of thing. If you really don't want the window
manager to
control the windows there's an option for it, but you can't have it both ways.
I am not sure i agree. Everywhere i looked they referred to
Hello,
You can do it at window creation time, but you can't
change the window back and forth just because you want some move request
to not be intercepted.
Eh? Did you read the xlib manual i linked to? This is *exactly* what
they recommend for this type of scenario:
On Tue, 2009-10-06 at 14:37 +0200, Peter Dons Tychsen wrote:
Hello,
You can do it at window creation time, but you can't
change the window back and forth just because you want some move request
to not be intercepted.
Eh? Did you read the xlib manual i linked to? This is *exactly
On Thu, 2009-10-01 at 12:33 +0200, Alexandre Julliard wrote:
Peter Dons Tychsen donpe...@tdcadsl.dk writes:
Just out of interest: You changed this to a write. Fine.
But why the volatile? Can GCC assume predetermined results when writing
to NULL? I don't see any reason to use volatile
Til: Peter Dons Tychsen donpe...@tdcadsl.dk
Cc: wine-devel@winehq.org
Dato: Tir, 08. sep 2009 22:25
Emne: Re: ntdll: Do not accept device control requests with invalid
and/or incompatible handles
Peter Dons Tychsen donpe...@tdcadsl.dk writes:
+static void test_device_control(void
+0100, Michael Stefaniuc wrote:
Hello Peter,
Peter Dons Tychsen wrote:
I knew it.
We are getting close to Christmas, and then this starts happening
Every year around this time, small elves creep down from the roof, and
tamper with my computer while i am sleeping. They open
they did to my
desktop!
I will have a chat with them and try to make sure it does not happen
again!
I will resend the patch when that is done,
Thanks for the tip,
/pedro
On Thu, 2008-11-27 at 11:16 +0100, Michael Stefaniuc wrote:
Hello Peter,
Peter Dons Tychsen wrote:
Fixed a problem
On Sun, 2008-10-19 at 20:56 -0700, Dan Kegel wrote:
Hey, that CGA video support patch today from Peter Dons Tychsen,
http://winehq.org/pipermail/wine-patches/2008-October/063417.html
reminded me there's an old downloadable DOS game my wife likes
to dig out every now and then. I tried it today
is a no-go.
I think this patch needs to be applied.
I will try out the patch, and re-sync it if it has come out-of-date.
Thanks,
/pedro
On Mon, 2008-10-20 at 09:44 +0200, Markus Amsler wrote:
Peter Dons Tychsen wrote:
Hello.
It starting with me trying to figure out why i was loosing
Don't forget the .com files those wonderful real-mode 64K wonders...
I noticed that the distros do not map .com files to wine.
They probably should.
/p
On Mon, 2008-10-20 at 16:18 -0700, Dan Kegel wrote:
Jochen wrote:
I would love to see support for games like paratrooper and
police
Hello.
It starting with me trying to figure out why i was loosing keyboard
events in winedos.
1) I then traced the keyboard events to a call to signal(SIGUSR2) in
function DOSVM_QueueEvent().
2) The signal() triggers code in ntdll, which generates an exception
EXCEPTION_VM86_STI for the current
Hi Vitaliy.
Thanks for your comments,
My first question: what will you do with that pointer if that driver is
loaded in the separate instance of ntoskrnl? Driver that calls
IoGetDeviceObjectPointer will most likely try to dereference the pointer it
got back.
You are right. Something is not
Hi V.
Well I'm not sure what good will it be? The caller asks for the pointer to
the DEVICE_OBJECT to do something with that structure. You can't just give
it some handle. It needs to be complete structure. And not just any
structure but the one for that device.
Sorry. I did not mean the
Hello Michael.
Thanks for your input (and Juan and Austin).
Peter, are you sure that windows will handle REG_SZ *only* in the
DependOnService case and fail if you have a REG_SZ in DependOnGroup?
No. But i did not want to change the behavior for anything else than the
scenario that i had been
:00 2001
From: Peter Dons Tychsen [EMAIL PROTECTED](none)
Date: Tue, 12 Feb 2008 03:24:53 +0100
Subject: [PATCH] Fixed listview bug, when client sends bogus SETITEMSTATE request,
requesting all items to be focused.
Added test-case to proove correctness tested on Linux and WinXP.
---
dlls/comctl32
... would be appropriate... :-)
/p
On Thu, 2008-02-14 at 09:18 +0100, Stefan Dösinger wrote:
Am Donnerstag, 14. Februar 2008 04:22:16 schrieb Peter Dons Tychsen:
Why does the SwapChain-destroy function play around with the resolution
at all. Is that really necessary? I think it should not do
On Thu, 2008-02-14 at 09:18 +0100, Stefan Dösinger wrote:
Am Donnerstag, 14. Februar 2008 04:22:16 schrieb Peter Dons Tychsen:
Why does the SwapChain-destroy function play around with the resolution
at all. Is that really necessary? I think it should not do it if the
caller is ddraw
etc.).
In this case Maarten probably knows what he is doing (he usually does).
But thanks for the follow up!
And now i will go to Sleep().
Thanks,
/p
On Wed, 2008-02-13 at 11:28 +0100, Stefan Dösinger wrote:
Am Mittwoch, 13. Februar 2008 03:11:24 schrieb Peter Dons Tychsen:
Eh, this does
Hi Stefan/Devs.
The funny old game Insane has a resolution bug when it exits.
I am not sure exactly how to fix this.
1) It call SetDisplayMode() - switches from 1280 x 1024 - 640 x 480.
OK.
2) It creates a 3D surface which starts the SwapChain - swapchain saves
current resolution.
3) Exit. It
Hi Devs.
I had this patch silently rejected.
Can anybody spot what is wrong with this patch?
It is really needed for some older games like Grand Theft Auto,
and other oldies (but goodies!).
/pedro
---BeginMessage---
Implement correct behavior for the DDEDM_REFRESHRATES flag,
as the old
Hi Maarten Devs.
Great to see that audio is so much better in Wine now.
But
On fedora core 6 and 8 i get this every time i start Wine:
ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0
ALSA lib pcm.c:2145:(snd_pcm_open_noupdate) Unknown PCM default:0
ALSA lib
Hello M.
What is wrong with detecting the version, and branching the test code
accordingly? Other tests do that IIRC. I think that is a better
solution, if the version selector in winecfg is still going to be
meaningful (registry).
How about fixing the functions as well (like IsWindowUnicode),
Hi Stefan.
OK thanks for the fast, precise and well-cut review (and probably
correct).
I will fix the 3 issues and re-submit.
/p
On Wed, 2008-02-13 at 00:50 +0100, Stefan Dösinger wrote:
Am Mittwoch, 13. Februar 2008 00:39:52 schrieb Peter Dons Tychsen:
Hi Devs.
I had this patch
Eh, this does not seem like a proper way to get a unit test to pass.
Sleep()... that leads to the dark side! :-)
Why does it need a Sleep()? If its failing on Wine, then shouldn't it be
fixed in the libs? And if its on orig-winxp-vista then there must be a
better way to wait? Or no?
The string
SPI_GETMOUSE should work just fine, do you have a sample code which
doesn't work? Is the app trying to read the registry directly without
using SystemParametersInfo?
The application is the game World In Conflict.
The application is reading correctly through SystemParametersInfo().
The
I do not think patents which are blocking your ability to use the DLLs
in Wine. It is your Windows license.
I believe that if you have a Windows license for your machine, you are
free to use Windows or its DLLs. This includes all the free downloads
from their web-pages. I think, if you do not
On Thu, 2008-01-03 at 22:46 -0600, Clarence Risher wrote:
I regularly use 640x512 in wine, when that resolution wouldnt be
reported by the driver in windows. Dunno if you consider that a
normal resolution.
Just out of curiosity, what do you use this for?
Whats wrong with the 640 x 480? Why do
640x480 does not integer-scale to my 1280x1024 display. With 640x512
I have perfect pixel alignment (2x zoom), no blurriness from the
scaling. I'll take 640x512 over 800x600 even because of the graphical
nicety of it, and there are plenty of games (with options turned all
the way up) that I
The xrandx X11 extension is very handy.
Using it for wine makes great sense.
But... the extension also enumerates a whopping amount of modes.
Each resolution has a multitude of frequencies and bit-depth variants.
Some applications are simply not prepared for that magnitude of
information when
I have an app which is bailing out because it cannot get valid data
from SPI_GETMOUSE - and indeed this reg key does not exist.
The key should be in Control Panel\\Colors under CURRENT_USER.
There are similar values in the Control Panel folder in the registry.
Is there a reason this value is
On Tue, 2007-08-07 at 17:35 +0200, Alexandre Julliard wrote:
Peter Dons Tychsen [EMAIL PROTECTED] writes:
I tried to submit a patch for this missing lib,
but got zero response.
Probably because there was something wrong with my commit.
Any guess on what was wrong?
You need
On Tue, 2007-08-07 at 23:15 +0200, Alexandre Julliard wrote:
Peter Dons Tychsen [EMAIL PROTECTED] writes:
You need to write a proper spec file with all exported functions,
There are no exported functions (for now). So i guess an empty spec file
is OK ?
No, there are exported functions
Hello.
Wine is missing the library faultrep.
The library comes with Windows, and is used by apps for error reporting.
Most apps don't really need it (unless something goes wrong), but simply
require the DLL to be present.
To start with i just wanted to add the DLL to Wine.
I tried to submit a
On Sun, 2007-08-05 at 17:27 +0200, Peter Dons Tychsen wrote:
On Sun, 2007-08-05 at 09:58 +0200, Kai Blin wrote:
On Sunday 05 August 2007 04:23:15 Peter Dons Tychsen wrote:
It was regarding the fact that it is not allowed to disassemble and
reverse engineer Microsoft DLLs. I understand
On Sun, 2007-08-05 at 09:58 +0200, Kai Blin wrote:
On Sunday 05 August 2007 04:23:15 Peter Dons Tychsen wrote:
It was regarding the fact that it is not allowed to disassemble and
reverse engineer Microsoft DLLs. I understand this part, as their
license prohibits it (EULA).
Please note
On Sat, 2007-08-04 at 12:04 +0900, Dmitry Timoshkov wrote:
Peter Dons Tychsen [EMAIL PROTECTED] wrote:
1) Yes i did testing on Windows-XP. I did it by putting together various
examples and by checking with InSendMessage() for all cases. This
clearly showed that WM_ACTIVATEAPP was always
On Sun, 2007-08-05 at 21:12 +0200, Peter Dons Tychsen wrote:
On Sat, 2007-08-04 at 12:04 +0900, Dmitry Timoshkov wrote:
Peter Dons Tychsen [EMAIL PROTECTED] wrote:
1) Yes i did testing on Windows-XP. I did it by putting together various
examples and by checking with InSendMessage
On Sun, 2007-08-05 at 23:23 +0200, Alexandre Julliard wrote:
Peter Dons Tychsen [EMAIL PROTECTED] writes:
This piece of code, if inserted into the test system, could (on original
Windows) show us which messages we are incorrectly posting or sending. I
can probably also be used for other
On Sun, 2007-08-05 at 21:13 +0200, Peter Dons Tychsen wrote:
On Sun, 2007-08-05 at 21:12 +0200, Peter Dons Tychsen wrote:
On Sat, 2007-08-04 at 12:04 +0900, Dmitry Timoshkov wrote:
Peter Dons Tychsen [EMAIL PROTECTED] wrote:
1) Yes i did testing on Windows-XP. I did it by putting
On Mon, 2007-08-06 at 01:26 +0200, Peter Dons Tychsen wrote:
I will go back and redo the tests with this approach, now that you have
torpedoed my idea, which i probably deserved.
OK. To recover from my earlier brain-dead idea, i think i have came up
with a much simpler solution, based on your
On Sat, 2007-08-04 at 12:04 +0900, Dmitry Timoshkov wrote:
Peter Dons Tychsen [EMAIL PROTECTED] wrote:
1) Yes i did testing on Windows-XP. I did it by putting together various
examples and by checking with InSendMessage() for all cases. This
clearly showed that WM_ACTIVATEAPP was always
Hello James/Wine.
1)
I noticed your comment the forums here:
http://article.gmane.org/gmane.comp.emulators.wine.devel/52810
It was regarding the fact that it is not allowed to disassemble and
reverse engineer Microsoft DLLs. I understand this part, as their
license prohibits it (EULA).
.
/Pedro
On Thu, 2007-08-02 at 20:34 -0600, Vitaliy Margolen wrote:
Peter Dons Tychsen wrote:
Hello Wine.
On original Windows, the messages WM_ACTIVATEAPP are sent using
PostMessage() and not SendMessage() like in the current Wine
implementation.
I have thoroughly verified
On Thu, 2007-08-02 at 06:54 -0600, Vitaliy Margolen wrote:
Peter Dons Tychsen wrote:
On Tue, 2007-07-31 at 20:05 -0600, Vitaliy Margolen wrote:
Peter Dons Tychsen wrote:
On Tue, 2007-07-31 at 06:34 -0600, Vitaliy Margolen wrote:
Peter Dons Tychsen wrote:
On Mon, 2007-07-30 at 21:20
On Fri, 2007-08-03 at 01:02 +0200, Peter Dons Tychsen wrote:
On Thu, 2007-08-02 at 06:54 -0600, Vitaliy Margolen wrote:
Peter Dons Tychsen wrote:
On Tue, 2007-07-31 at 20:05 -0600, Vitaliy Margolen wrote:
Peter Dons Tychsen wrote:
On Tue, 2007-07-31 at 06:34 -0600, Vitaliy Margolen
On Mon, 2007-07-30 at 22:18 +0200, Peter Dons Tychsen wrote:
On Sun, 2007-07-29 at 23:08 +0200, Stefan Dösinger wrote:
Am Sonntag, 29. Juli 2007 21:28 schrieb Peter Dons Tychsen:
Hello Wine!
I have fixed a small bug in FastBlt(), which caused Wine to crash if the
application tried
On Tue, 2007-07-31 at 20:05 -0600, Vitaliy Margolen wrote:
Peter Dons Tychsen wrote:
On Tue, 2007-07-31 at 06:34 -0600, Vitaliy Margolen wrote:
Peter Dons Tychsen wrote:
On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote:
On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote
On Tue, 2007-07-31 at 06:34 -0600, Vitaliy Margolen wrote:
Peter Dons Tychsen wrote:
On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote:
On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote:
Peter Dons Tychsen wrote:
OK. Please review this diff:
I will re-submit
On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote:
Peter Dons Tychsen wrote:
OK. Please review this diff:
I will re-submit it if you like it.
/Pedro
Alright looks good now (you might want to remove the extra white space your
patch adds - git complains about those). Just
On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote:
On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote:
Peter Dons Tychsen wrote:
OK. Please review this diff:
I will re-submit it if you like it.
/Pedro
Alright looks good now (you might want to remove
On Sun, 2007-07-29 at 23:08 +0200, Stefan Dösinger wrote:
Am Sonntag, 29. Juli 2007 21:28 schrieb Peter Dons Tychsen:
Hello Wine!
I have fixed a small bug in FastBlt(), which caused Wine to crash if the
application tried to do FastBlt() to a surface using a bad destination
setup
On Sun, 2007-07-29 at 23:08 +0200, Stefan Dösinger wrote:
Am Sonntag, 29. Juli 2007 21:28 schrieb Peter Dons Tychsen:
Hello Wine!
I have fixed a small bug in FastBlt(), which caused Wine to crash if the
application tried to do FastBlt() to a surface using a bad destination
setup
66 matches
Mail list logo
