Is it possible to add a test to show that Wine crashes?
On Mon, 01 Aug 2011 14:11:31 +0400, Nikolay Sivov wrote:
On 8/1/2011 14:04, Vitaly Perov wrote:
Is it possible to add a test to show that Wine crashes?
You mean inside exception handler? Test that crashes comes with or
after a fix that fix a crash.
Yes, I have sent a patch that fix a crash
On Mon, 01 Aug 2011 12:45:12 +0200, Alexandre Julliard wrote:
You should not be trying to write a test that proves that Wine
crashes,
that's not interesting. What you should do is demonstrate Windows
behavior for various types of invalid input, and then make Wine
conform
to that.
As I
On Mon, 01 Aug 2011 14:05:29 +0200, Alexandre Julliard wrote:
Vitaly Perov vitpe...@etersoft.ru writes:
Then, my second qustion is:
I need a big-size pictures (jpg, png, gif, bmp) for my tests.
I think I am unable to generate them in the test.
Is it normal to add them as files?
You should
it correctly.
--
Best regards,
Vitaly Perov
From cc4c05398c7dc993e2caea032c81eb69b5d4510e Mon Sep 17 00:00:00 2001
From: Vitaly Perov vitpe...@etersoft.ru
Date: Thu, 30 Jun 2011 18:19:36 +0400
Subject: [PATCH] programs/explorer: Try to open registered file types
(eterbug #7398)
---
programs/explorer
+if (!hKey) RegCloseKey(hKey);
This one is still not fixed.
Thank you very much for your patience!
I am sorry for such trivial mistakes. I didn't have enough sleep last time.
--
Best regards,
Vitaly Perov
В сообщении от 23 февраля 2011 21:43:49 автор Alexandre Julliard написал:
Vitaly Perov vitpe...@etersoft.ru writes:
@@ -7247,7 +7247,7 @@ static BOOL get_job_info_2(job_t *job, JOB_INFO_2W
*ji2, LPBYTE buf, DWORD cbBuf
else
{
/* align
On Monday 15 November 2010 17:16:32 Piotr Caban wrote:
On 11/15/10 14:53, Vitaly Perov wrote:
This function should be implemented without memory allocations.
Why? I don't think it is possible to implement it without any memory
allocations.
I mean without copying the strings.
Using
don't think it is possible to implement it without any memory
allocations.
--
Best regards,
Vitaly Perov
On Monday 04 October 2010 19:03:21 Alexandre Julliard wrote:
Vitaly Perov vitpe...@etersoft.ru writes:
@@ -1398,7 +1398,7 @@ static void convert_printerinfo_W_to_A(LPBYTE out,
LPBYTE pPrintersW, dmA = DEVMODEdupWtoA(piW-pDevMode);
if (dmA
Thank you for your help!
--
Best regards,
Vitaly Perov
On Friday 05 June 2009 20:10:12 Stefan Leichter wrote:
You need to check if GetProcAddress succeeded. If GetProcAddress failed
call win_skip and don't try to execute WNetGetUniversalNameW
Thank you!
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
/Projects/wine-dev/dlls/ole32/tests/usrmarshal.c:448: undefined
reference to `_wdtpinterfacepointer_usermars...@20'
...
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
On Friday 13 February 2009 14:18:17 Huw Davies wrote:
On Fri, Feb 13, 2009 at 02:01:35PM +0300, Vitaly Perov wrote:
Hi!
Does anybody have a problem compilling the crosstest of ole32?
Or maybe it's only my fault?
I have:
usrmarshal.cross.o: In function `func_usrmarshal':
/srv
What is wrong with my patch?
mshtml: Add TRACE for unsupported IStdMarshalInfo
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
From 86d9e1416913a4820593eb5f737fed32c9e97697 Mon Sep 17 00:00:00 2001
From: Vitaly Perov vitpe...@etersoft.ru
Date: Wed, 14 Jan 2009 19:56:53
be created, there's a setup problem or some other
unrecoverable error. A TRACE is fine.
+ /* FIXME: A duplicate patch checking should be implemented here */
Do you mean a duplicate path?
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
From
On Monday 01 December 2008 18:45:22 Alexandre Julliard wrote:
Vitaly Perov [EMAIL PROTECTED] writes:
+GetCurrentDirectoryA(MAX_PATH, tmpPath);
+result = SetCurrentDirectoryW(path);
+SetCurrentDirectoryA(tmpPath);
+if (!result) return ERROR_FILE_NOT_FOUND
On Friday 28 November 2008 07:53:40 Dmitry Timoshkov wrote:
Vitaly Perov [EMAIL PROTECTED] wrote:
Changes since last send:
- Used local mlang_data structure instead of calling internal function
wine_cp_enum_table.
- Used macro instead of iface-lpVtbl-
Looks good to me
2008/10/31 Vitaly Perov [EMAIL PROTECTED]:
This patch add a stub implementation of IMarshal interface.
I have no experience at implementing interfaces, so I'm not sure it's
implemented correctly.
Please, look at this patch. I'll be grateful for any remarks.
What makes you think
it. This calculation works perfect, but maybe there is more easy
way to obtain it?
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
passed.
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
Hi,
This patch add a stub implementation of IMarshal interface.
I have no experience at implementing interfaces, so I'm not sure it's
implemented correctly.
Please, look at this patch. I'll be grateful for any remarks.
Thank you.
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg
Vitaly Perov [EMAIL PROTECTED] wrote:
It doesn't really matter what code pages Windows supports, it does
matter though what code pages are valid. You need to use Win32 APIs
EnumSystemCodePages/GetCPInfo/MultiByteToWideChar instead of accessing
Wine internals directly.
I used
(but I am definitely not an expert in this area), that the
patch Vitaly Perov sent:
| + /* move many files into directory with FOF_MULTIDESTFILES */
| + set_curr_dir_path(from, test?.txt\0);
| + set_curr_dir_path(to, testdir2\0);
| + retval = SHFileOperationA(shfo2);
| + todo_wine
FOF_MULTIDESTFILES)
!flFrom-bAnyDirectories
flFrom-dwNumFiles flTo-dwNumFiles)
{
return ERROR_CANCELLED;
}
and SHFileOperationW return error.
Ok, I write a test, but it wouldn't be soon.
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
think
it's just waste of time.
I have a lot of patches which I could send, but I think they wouldn't be
applied just because they don't fix any real world bug.
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
on the #winehackers IRC channel?
No, I doesn't use IRC. It's very hard to me to write in english in real-time
Ok, I try to resend my old tests, and write tests to other patches.
Also there are some functions and stubs implemented, wchich doesn't require
(as I think) a tests.
--
Best wishes,
Vitaly
before, but in this case GetCharCodePages set some
extra bits in result. So the result differ from Windows
... or rather use mlang internal mlang_data structures.
I's good idea! Thank you!
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
I am sorry. It was wrong file attached.
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
From a11d55bebddff866ce1e5af3f9b393e90bab442a Mon Sep 17 00:00:00 2001
From: Vitaly Perov [EMAIL PROTECTED]
Date: Tue, 22 Jul 2008 13:19:58 +0400
Subject: [PATCH] netapi32: Add stub
by regedit.
2) The folder of .Net installation doesn't exist.
So, does somebody know how to solve these problems?
Thank you!
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
I'm sorry. I forgot to attach a patch.
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
From 85cc12d39b616865a5a7f44854f24086f79a4342 Mon Sep 17 00:00:00 2001
From: Vitaly Perov [EMAIL PROTECTED]
Date: Tue, 27 May 2008 20:30:35 +0400
Subject: [PATCH] mscoree: add
;
const GUID IID_IMultiLanguage2_n = { 0xdccfc164, 0x2b38, 0x11d2,
{ 0xb7, 0xec, 0x00, 0xc0, 0x4f,0x8f,0x5d,0x9a } };
and then use IID_IMultiLanguage2_n instead of IID_IMultiLanguage2.
But it is not good decision!
Does anybody know the correct way to fix these tests?
--
Best wishes,
Vitaly
uncommited changes?
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
You're using fileDest when it hasn't been initialized (as the warning
says). Second, the tests fail:
Thank you! I forgot insert a line when I was rewriting it for the patch.
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
The move operation can already do this. Why is this patch necessary?
The test you sent in already passes, so this 'fix' is not being tested
at all.
Really? I'm sorry! I was testing at old version of wine.
Thank you very much! I'll test it again!
--
Best wishes,
Vitaly Perov
Russia, Saint
.txt to not exist
shlfileop.c:1233: Test failed: Expected one.txt to exist
shlfileop.c:1234: Test failed: Expected one.txt to exist
shlfileop: 582 tests executed (0 marked as todo, 7 failures), 0 skipped.
Could you check it again, please.
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg
Vitaliy Margolen wrote:
Vitaly Perov wrote:
Changelog: cmd.exe: MSI packages execution implemented
That doesn't look right. You sure this information is hard-coded into
cmd.exe and it's not coming from the registry CLASSES hive?
Vitaliy
I haven't found any information about how
still persist?
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
after last page of each copy.
I'm sure it's not good way to solve this problem.
So, if anybody have something to say, I would be appreciate.
Thank you.
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
39 matches
Mail list logo
