I can change the tests a bit, and change the currently empty functions
to return E_NOTIMPL instead of S_OK.
Then I can do it piecemeal.
Is that how y'all want it?
Clint
Clinton Stimpson wrote:
Ok. There are 4 functions that have to be implemented at the same
time in order to not break any
Ok. There are 4 functions that have to be implemented at the same time
in order to not break any tests, because of how the tests were written.
A few days ago, I sent a single patch that implemented those 4
functions, including an update of the tests.
It wasn't accepted, and it was suggested to
I think that what James Hawkins had meant something like this:
Apply patch one, run the tests. If patch one fixed any of them, remove
the todo_wine's for those tests as a part of patch one. Otherwise,
leave them todo_wine.
Apply patch two, run the tests. If patch two fixed any of them, remove
On 12/14/06, Clinton Stimpson [EMAIL PROTECTED] wrote:
Hi,
Part 5 of 5.
Remove many todo_wine's from the tests, now that the functions are
implemented.
You have to remove the todo_wine's in the same patch that fixes the
tests, or the tests will fail for at least one commit. Patches have
to
On 12/15/06, Clinton Stimpson [EMAIL PROTECTED] wrote:
Ok. There are 4 functions that have to be implemented at the same time
in order to not break any tests, because of how the tests were written.
A few days ago, I sent a single patch that implemented those 4
functions, including an update of
