Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-03-16 Thread Francois Gouget
On Thu, 25 Feb 2010, joerg-cyril.hoe...@t-systems.com wrote: Charles Davis wrote: I have noticed a change in configure behavior, though. Me too. On MacOS. Since 1.1.39, Makefiles are created at the rate of ~ 1 per sec. It was much faster in 1.1.38 and before, I estimate ~6 files per

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-02-28 Thread James McKenzie
joerg-cyril.hoe...@t-systems.com wrote: Charles Davis wrote: I have noticed a change in configure behavior, though. Me too. On MacOS. Since 1.1.39, Makefiles are created at the rate of ~ 1 per sec. It was much faster in 1.1.38 and before, I estimate ~6 files per second. Anyone

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-02-28 Thread Erich Hoover
On Thu, Feb 25, 2010 at 5:38 AM, joerg-cyril.hoe...@t-systems.com wrote: Charles Davis wrote: I have noticed a change in configure behavior, though. Me too. On MacOS. Since 1.1.39, Makefiles are created at the rate of ~ 1 per sec. It was much faster in 1.1.38 and before, I estimate ~6

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-02-28 Thread James McKenzie
Erich Hoover wrote: On Thu, Feb 25, 2010 at 5:38 AM, joerg-cyril.hoe...@t-systems.com mailto:joerg-cyril.hoe...@t-systems.com wrote: Charles Davis wrote: I have noticed a change in configure behavior, though. Me too. On MacOS. Since 1.1.39, Makefiles are created at the

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-02-25 Thread Joerg-Cyril.Hoehle
Charles Davis wrote: I have noticed a change in configure behavior, though. Me too. On MacOS. Since 1.1.39, Makefiles are created at the rate of ~ 1 per sec. It was much faster in 1.1.38 and before, I estimate ~6 files per second. Anyone to confirm this? I always do git fetch; git rebase

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer (try 2).

2010-02-19 Thread Henri Verbeet
On 19 February 2010 05:22, Erich Hoover ehoo...@mines.edu wrote: Real Name:   Erich Hoover Description:   The attached patch adds a test for SetThreadAffinityMask(thread,-1), which succeeds on Windows Vista and newer.  This version uses broken() rather than specifically testing versions.  

[PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-02-19 Thread Joerg-Cyril.Hoehle
Hi, Erich Hoover wrote: so if we're not testing the version we wouldn't know that it got removed. This is a very valid point. For instance, I'm currently writing a test that will read ok(1234123123==mhdr.dwOffset || broken(0==mhdr.dwOffset/*w9x,nt*/) ...) i.e. w2k+xp+Vista+7 differ from

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-02-18 Thread Andrew Nguyen
On Thu, Feb 18, 2010 at 8:51 PM, Erich Hoover ehoo...@mines.edu wrote: Real Name:    Erich Hoover Description:    The attached patch adds a test for SetThreadAffinityMask(thread,-1), which succeeds on Windows Vista and newer.  This all processors flag is not documented, but was discovered

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-02-18 Thread Erich Hoover
On Thu, Feb 18, 2010 at 8:29 PM, Andrew Nguyen arethus...@gmail.com wrote: On Thu, Feb 18, 2010 at 8:51 PM, Erich Hoover ehoo...@mines.edu wrote: ...    The attached patch adds a test for SetThreadAffinityMask(thread,-1), which succeeds on Windows Vista and newer. ... The test shouldn't

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-02-18 Thread Juan Lang
Then the test could only be triggered in Wine.  What if this feature gets removed again in some later version of Windows? broken() only applies to Windows versions, Wine never succeeds with a broken feature. It really is what you want. --Juan

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-02-18 Thread Erich Hoover
On Thu, Feb 18, 2010 at 8:45 PM, Juan Lang juan.l...@gmail.com wrote: Then the test could only be triggered in Wine.  What if this feature gets removed again in some later version of Windows? broken() only applies to Windows versions, Wine never succeeds with a broken feature.  It really is

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-02-18 Thread Juan Lang
I'm not arguing with the behavior of broken().  I'm saying that since this feature is undocumented it's entirely possible that it could get removed in some future version of Windows*, so if we're not testing the version we wouldn't know that it got removed.  We were lucky to stumble upon this

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-02-18 Thread Erich Hoover
On Thu, Feb 18, 2010 at 8:59 PM, Juan Lang juan.l...@gmail.com wrote: I'm not arguing with the behavior of broken().  I'm saying that since this feature is undocumented it's entirely possible that it could get removed in some future version of Windows*, so if we're not testing the version we