On Mon, 10 Oct 2005, Lionel Ulmer wrote:
I still havent got the grasp of what dwSize is for if it does not reflect
the size allocated?, nor the size of the struct current in the mem.
As the DDSURFACEDESC2 structure starts exactly like the DDSURFACEDESC2 one,
the hack here is to use 'dwSize'
On Mon, Oct 10, 2005 at 10:18:21PM +0200, Peter Berg Larsen wrote:
> > I would first merge both our patches replacing the following lines with an
> > 'assert(to != from)':
> >
> >if ((to) == (from))
> >break;
>
> I think thats execellent idea; I hadnt though of asserts, did not new
>
On Mon, 10 Oct 2005, Lionel Ulmer wrote:
Nor did I say that; just that it had nothing to with bug 3487 as the
subject said it had.
Yeah, got confused too (it really took me a while to understand that we went
out of the Lock function before crashing).
Yep.
/* __tosize can be set too larg
On Mon, Oct 10, 2005 at 01:43:04AM +0200, Peter Berg Larsen wrote:
> > Could you try it and tell if it fixes the problem ?
>
> It, the patch on the bug page, does (e.i. without the locking). Could I
> suggest a comment in the code.
Well, you can suggest a comment or even send a patch adding comm
>
> PS: and Raphael's patch while not fixing your bug is not technically wrong
> as Windows checks for the surface description pointer being non-NULL
> :-)
I was trying to reproduce his bug but i always crashed on function with a null
description :(
Seem you are more "rapide" than me
Regard
On Sun, 9 Oct 2005, Lionel Ulmer wrote:
Well, while your patch was lying in the moderation queue, I sent what I
feel is a better solution to this problem (which fixes also a severe
reference counting issue).
I had more than one goal with the patch, more below.
Could you try it and tell i
Peter Berg Larsen wrote:
Walking backwards the bug was introduced in
http://www.winehq.org/pipermail/wine-patches/2002-November/004161.html
and altered in
http://www.winehq.org/pipermail/wine-patches/2004-March/010091.html
which states
Apps should initialize correctly the dwSize member of
> So here is better patch that does not open 2070 again.
>
> Changelog:
> Bug in copying structs if to == from as to was memset first.
Well, while your patch was lying in the moderation queue, I sent what I feel
is a better solution to this problem (which fixes also a severe reference
co
