Re: Patches / a proposal for the mystic DIB engine

2007-04-12 Thread Alexandre Julliard
Felix Nawothnig [EMAIL PROTECTED] writes: 2. Export LockDIBSection/Unlock to gdi32. Adding more exports is not nice but there really is no way around that, right? No, LockDIBSection is a driver internal detail, gdi32 has no business knowing about this. 3. Move dc-funcs to

Re: Patches / a proposal for the mystic DIB engine

2007-04-12 Thread Felix Nawothnig
Alexandre Julliard wrote: 2. Export LockDIBSection/Unlock to gdi32. Adding more exports is not nice but there really is no way around that, right? No, LockDIBSection is a driver internal detail, gdi32 has no business knowing about this. In my code the call to LockDIBSection serves two

RE: Patches / a proposal for the mystic DIB engine

2007-04-12 Thread Rolf Kalbermatter
Felix Nawothnig [mailto:[EMAIL PROTECTED] Okay, I've spent the last days looking into this matter and I'd like to suggest a way to get it started. So. This is the plan: 1. In winex11.drv: -INT X11DRV_LockDIBSection(X11DRV_PDEVICE *physDev, INT req, BOOL lossy) +HBITMAP

Patches / a proposal for the mystic DIB engine

2007-04-11 Thread Felix Nawothnig
Okay, I've spent the last days looking into this matter and I'd like to suggest a way to get it started. So. This is the plan: 1. In winex11.drv: -INT X11DRV_LockDIBSection(X11DRV_PDEVICE *physDev, INT req, BOOL lossy) +HBITMAP X11DRV_LockDIBSection(X11DRV_PDEVICE *physDev, INT req, BOOL

Re: Patches / a proposal for the mystic DIB engine

2007-04-11 Thread Felix Nawothnig
Oops. Forgot the patches. Here they are. And the very second I sent the last E-Mail the DIB engine work got accepted as a SoC project (by someone else)... I've no idea what this means to me. Someone clarify please. :) diff --git a/dlls/winex11.drv/bitblt.c b/dlls/winex11.drv/bitblt.c index

Re: Patches / a proposal for the mystic DIB engine

2007-04-11 Thread Matt Finnicum
As a returning GSoC student, I had asked about this last year: It's primarily the student's responsibility to work out the conflicts, but it'd be best for you two to talk to one another. The student's obligation is do do what they said they would, so if you complete their proposal for them it

Re: Patches / a proposal for the mystic DIB engine

2007-04-11 Thread Jesse Allen
On 4/11/07, Matt Finnicum [EMAIL PROTECTED] wrote: As a returning GSoC student, I had asked about this last year: It's primarily the student's responsibility to work out the conflicts, but it'd be best for you two to talk to one another. The student's obligation is do do what they said they

Re: Patches / a proposal for the mystic DIB engine

2007-04-11 Thread Tom Wickline
On 4/11/07, Jesse Allen [EMAIL PROTECTED] wrote: That'd be me apparently. http://code.google.com/soc/wine/about.html Jesse -- Tom Wickline Respectable computing - Linux/FOSS