Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-12 Thread Nicolas Le Cam
2009/4/12 James McKenzie jjmckenzi...@earthlink.net: Nicolas Le Cam wrote: 2009/4/11 Ben Klein shackl...@gmail.com: 2009/4/11 Nicolas Le Cam niko.le...@gmail.com: 2009/4/11 James Hawkins trui...@gmail.com: Let met explain : Running test on wine in folder C:\test : works (expected C:\test

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-12 Thread Nicolas Le Cam
James, Here are updated patches for part 3 4 of my previous patch set. Tell me if you think I could submit them to wine-patches. For patch 3, the only todo_wine is when launched from root drive dir as explained in my previous mail. For patch 4, I skip a test if test is executed on root drive

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-12 Thread Nicolas Le Cam
2009/4/13 James McKenzie jjmckenzi...@earthlink.net: Nicolas Le Cam wrote: James, Here are updated patches for part 3 4 of my previous patch set. Tell me if you think I could submit them to wine-patches. For patch 3, the only todo_wine is when launched from root drive dir as explained in

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-12 Thread James McKenzie
Nicolas Le Cam wrote: 2009/4/13 James McKenzie jjmckenzi...@earthlink.net: Nicolas Le Cam wrote: James, Here are updated patches for part 3 4 of my previous patch set. Tell me if you think I could submit them to wine-patches. For patch 3, the only todo_wine is when launched from

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-12 Thread Nicolas Le Cam
2009/4/13 James McKenzie jjmckenzi...@earthlink.net: Nicolas Le Cam wrote: 2009/4/13 James McKenzie jjmckenzi...@earthlink.net: Nicolas Le Cam wrote: James, Here are updated patches for part 3 4 of my previous patch set. Tell me if you think I could submit them to wine-patches. For

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-11 Thread James McKenzie
Nicolas Le Cam wrote: 2009/4/11 Ben Klein shackl...@gmail.com: 2009/4/11 Nicolas Le Cam niko.le...@gmail.com: 2009/4/11 James Hawkins trui...@gmail.com: Let met explain : Running test on wine in folder C:\test : works (expected C:\test got C:\test) Running test on wine in folder

Re: [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-10 Thread James Hawkins
On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam niko.le...@gmail.com wrote: Try2: This time with the patch. Tested on Win2k/WinXP. Marked two tests as todo_wine. I was serious before. You can't change the old tests. Please add new tests for the exposed bugs. Same goes for patch 3/4. --

Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-10 Thread Nicolas Le Cam
2009/4/10, James Hawkins trui...@gmail.com: On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam niko.le...@gmail.com wrote: Try2: This time with the patch. Tested on Win2k/WinXP. Marked two tests as todo_wine. I was serious before. You can't change the old tests. Please add new tests for

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-10 Thread James Hawkins
On Fri, Apr 10, 2009 at 2:36 PM, Nicolas Le Cam niko.le...@gmail.com wrote: 2009/4/10, James Hawkins trui...@gmail.com: On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam niko.le...@gmail.com wrote: Try2: This time with the patch. Tested on Win2k/WinXP. Marked two tests as todo_wine. I was

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-10 Thread Nicolas Le Cam
2009/4/11 James Hawkins trui...@gmail.com: On Fri, Apr 10, 2009 at 2:36 PM, Nicolas Le Cam niko.le...@gmail.com wrote: 2009/4/10, James Hawkins trui...@gmail.com: On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam niko.le...@gmail.com wrote: Try2: This time with the patch. Tested on

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-10 Thread Ben Klein
2009/4/11 Nicolas Le Cam niko.le...@gmail.com: 2009/4/11 James Hawkins trui...@gmail.com: Let met explain : Running test on wine in folder C:\test : works (expected C:\test got C:\test) Running test on wine in folder C:\ : works (expected C:\ got C:\) Running test on wine in folder

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-10 Thread Nicolas Le Cam
2009/4/11 Ben Klein shackl...@gmail.com: 2009/4/11 Nicolas Le Cam niko.le...@gmail.com: 2009/4/11 James Hawkins trui...@gmail.com: Let met explain : Running test on wine in folder C:\test : works (expected C:\test got C:\test) Running test on wine in folder C:\ : works (expected C:\ got