Re: Winecfg - browse for folder

2004-12-02 Thread Mike Hearn
On Wed, 2004-12-01 at 20:32 +0100, Robert van Herk wrote: What do you mean? Does s/x/y/ mean that I should change x into y? Yep, it's from vi regex syntax. Rather obscure geek notation I agree ... I did that, because the original code had some weird indentation and didn't want to change that

Re: Winecfg - browse for folder

2004-12-01 Thread Mike Hearn
On Tue, 30 Nov 2004 22:08:26 +0100, Robert van Herk wrote: Oops, I guess this suggestion was a bit too late, since I commited my patch this afternoon... I wouldn't worry too much. I'm not sure a PIDL extension is a good idea anyway - it's probably the Microsoft way, but this is a Wine

Re: Winecfg - browse for folder

2004-12-01 Thread Robert van Herk
Mike Hearn wrote: On Tue, 30 Nov 2004 22:08:26 +0100, Robert van Herk wrote: Oops, I guess this suggestion was a bit too late, since I commited my patch this afternoon... I wouldn't worry too much. I'm not sure a PIDL extension is a good idea anyway - it's probably the Microsoft way, but

Re: Winecfg - browse for folder

2004-11-30 Thread Steven Edwards
Hi, --- Francois Gouget [EMAIL PROTECTED] wrote: If there's something preventing it, wouln't a Shell Namespace extension be the right solution? This would be ideal. You there is lots of example code for extending the namespace for CVS and SVN so adding support for a Unix filesystem should

Re: Winecfg - browse for folder

2004-11-30 Thread Robert van Herk
Steven Edwards wrote: Hi, --- Francois Gouget [EMAIL PROTECTED] wrote: If there's something preventing it, wouln't a Shell Namespace extension be the right solution? This would be ideal. You there is lots of example code for extending the namespace for CVS and SVN so adding support for a

Re: Winecfg - browse for folder

2004-11-28 Thread Robert van Herk
Mike Hearn wrote: On Sat, 27 Nov 2004 10:37:10 +0100, Robert van Herk wrote: Thus, if I'd make an extra flag in the dialog, I would have to extent pidls to, so that they can hold unix paths. Is that a wise thing to do? Or should I take another approach? Hmm, I'm not sure you want to do

Re: Winecfg - browse for folder

2004-11-28 Thread Mike Hearn
On Sun, 28 Nov 2004 17:02:05 +0100, Robert van Herk wrote: Ofcourse, but the api call SHBrowseForFolder returns a pidl. So making unix browsing an extra flag wouldn't be useful, if I couldn't return a valid pidl in the unix case. Hmm, I guess perhaps it is best to make an extra api

Re: Winecfg - browse for folder

2004-11-28 Thread Robert van Herk
Mike Hearn wrote: On Sun, 28 Nov 2004 17:02:05 +0100, Robert van Herk wrote: Ofcourse, but the api call SHBrowseForFolder returns a pidl. So making unix browsing an extra flag wouldn't be useful, if I couldn't return a valid pidl in the unix case. Hmm, I guess perhaps it is best to make an

Re: Winecfg - browse for folder

2004-11-28 Thread Robert van Herk
Never mind, doing a new make from the root directory of the wine source solved it... Robert Robert van Herk wrote: Mike Hearn wrote: On Sun, 28 Nov 2004 17:02:05 +0100, Robert van Herk wrote: Ofcourse, but the api call SHBrowseForFolder returns a pidl. So making unix browsing an extra flag

Re: Winecfg - browse for folder

2004-11-28 Thread Mike Hearn
On Sun, 28 Nov 2004 18:47:18 +0100, Robert van Herk wrote: I added a new function SHBrowseForUNIXDirectory in brsfolder.c and added it to shlobj.h. Reinstalled the shlobj.h, compiled the shell32.dll, and installed that new one too. Also runned ldconfig (don't know if that is a must). I

Re: Winecfg - browse for folder

2004-11-28 Thread Ivan Leo Puoti
Also runned ldconfig (don't know if that is a must). It isn't, expecially if you run out of the source tree. Ivan. Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su

Re: Winecfg - browse for folder

2004-11-27 Thread Robert van Herk
Mike Hearn wrote: On Thu, 25 Nov 2004 14:42:24 +0100, Robert van Herk wrote: 3. Nice, but we loose strict win32 compatibility, since there will be a magic flags that doesn't exist in win32. This is the most lightweight so I'd go for it for now. If we find that the flag value we pick is

Re: Winecfg - browse for folder

2004-11-27 Thread Mike Hearn
On Sat, 27 Nov 2004 10:37:10 +0100, Robert van Herk wrote: Thus, if I'd make an extra flag in the dialog, I would have to extent pidls to, so that they can hold unix paths. Is that a wise thing to do? Or should I take another approach? Hmm, I'm not sure you want to do that. You may wish to

Re: Winecfg - browse for folder

2004-11-25 Thread Robert van Herk
Alexandre Julliard wrote: Mike Hearn [EMAIL PROTECTED] writes: Yes, this was expected. Just ensure only Z: is mapped during the directory browser operation. See the code in drive.c to find out how to modify drive mappings using win32 but to be honest the easiest way would be to make a copy of

Winecfg - browse for folder

2004-11-24 Thread Robert van Herk
Hi all, Thanks to Mike's help, I succeeded in showing a SHBrowseForFolder thingy, in the winecfg program, so that people can pick a directory they want to use as virtual C drive. However, ofcourse, this directory choosing thingy shows the virtual Windows file system, not the Unix file system.

Re: Winecfg - browse for folder

2004-11-24 Thread Andreas Mohr
Hi, On Wed, Nov 24, 2004 at 09:58:14AM +0100, Robert van Herk wrote: Hi all, Thanks to Mike's help, I succeeded in showing a SHBrowseForFolder thingy, in the winecfg program, so that people can pick a directory they want to use as virtual C drive. However, ofcourse, this directory

Re: Winecfg - browse for folder

2004-11-24 Thread Robert van Herk
Hi, Is Z:\ always mapped to the root of the unix file system? Because that would seem to solve it: just let them choose a directory from Z:\ and then probably modify the returned string by removing Z: and replacing all /'s bij \'s. Hopefully it isn't: you may not always want to expose the

Re: Winecfg - browse for folder

2004-11-24 Thread Andreas Mohr
Hi, On Wed, Nov 24, 2004 at 12:45:20PM +0100, Robert van Herk wrote: Hi, Is Z:\ always mapped to the root of the unix file system? Because that would seem to solve it: just let them choose a directory from Z:\ and then probably modify the returned string by removing Z: and replacing all

Re: Winecfg - browse for folder

2004-11-24 Thread Robert van Herk
Hi, Is it possible (as in: not too dangerous) to make a special API that does not exist in Windows, but then does exist in Wine, that would allow a program to mount the full Unix tree read only, such that only Wine programs can do that? I don't think that's a clean solution. Since NT-based

Re: Winecfg - browse for folder

2004-11-24 Thread Andreas Mohr
Hi, On Wed, Nov 24, 2004 at 02:03:16PM +0100, Robert van Herk wrote: In fact, the only ways I can think of to make this feature available just for Wine programs, is - Calling the Unix api directly from winecfg (I guess that is possible?) just to read out the directory contents and then put

Re: Winecfg - browse for folder

2004-11-24 Thread Mike Hearn
On Wed, 24 Nov 2004 09:58:14 +0100, Robert van Herk wrote: Thanks to Mike's help, I succeeded in showing a SHBrowseForFolder thingy, in the winecfg program, so that people can pick a directory they want to use as virtual C drive. Cool. However, ofcourse, this directory choosing thingy

Re: Winecfg - browse for folder

2004-11-24 Thread Robert van Herk
Is Z:\ always mapped to the root of the unix file system? Because that would seem to solve it: just let them choose a directory from Z:\ and then probably modify the returned string by removing Z: and replacing all /'s bij \'s. No not always, it's not enforced by Wine. It could be any

Re: Winecfg - browse for folder

2004-11-24 Thread Saulius Krasuckas
On Wed, 24 Nov 2004, Andreas Mohr wrote: On Wed, Nov 24, 2004 at 12:45:20PM +0100, Robert van Herk wrote: Ofcourse, another solution would be to make a Unix server that communicates with winecfg and tells it how the Unix directory structure is, but that would be overkill I guess :-).

Re: Winecfg - browse for folder

2004-11-24 Thread Dmitry Timoshkov
Robert van Herk [EMAIL PROTECTED] wrote: Therefore, I'd say that using this approach, it is probably nicer to have a magic wine flag that let the SHBrowseForFolder thingy show the unix directory listing I wonder whether using a callback in SHBrowseForFolder and reinitializing dialog with

Re: Winecfg - browse for folder

2004-11-24 Thread Mike Hearn
On Wed, 2004-11-24 at 15:53 +0100, Robert van Herk wrote: Also, we'd have the problem that when other processes are active and using the disks, these disks will be unmounted :-). Good point. I was assuming that if you're reconfiguring drives in winecfg while other apps are running you'd be

Re: Winecfg - browse for folder

2004-11-24 Thread Robert van Herk
Yes that'd work as well. I'd rather have a magic winecfg flag than copy/paste the code as that way we get bugfixes in shell32 automatically. But Alexandre tends to prefer copy/paste over hacking code around or using static libraries, so I'm not sure which way he'd prefer here. Anyways: the

Re: Winecfg - browse for folder

2004-11-24 Thread Alexandre Julliard
Mike Hearn [EMAIL PROTECTED] writes: Yes, this was expected. Just ensure only Z: is mapped during the directory browser operation. See the code in drive.c to find out how to modify drive mappings using win32 but to be honest the easiest way would be to make a copy of the current configuration

Re: Winecfg - browse for folder

2004-11-24 Thread Robert van Herk
Alexandre Julliard wrote: Mike Hearn [EMAIL PROTECTED] writes: Yes, this was expected. Just ensure only Z: is mapped during the directory browser operation. See the code in drive.c to find out how to modify drive mappings using win32 but to be honest the easiest way would be to make a copy of

Re: Winecfg - browse for folder

2004-11-24 Thread Rolf Kalbermatter
Robert van Herk [EMAIL PROTECTED] wrote: Also, I am having some troubles into tricking the SHBrowseForFolder thingy into using a different root folder, since I guess I need to use SHParseDisplayName