Hi,
Is there something wrong with this patch / a reason it's not being accepted?
Sorry if this might have been answered this on IRC last night - X died
while I was away, so I'd have missed it.
Thanks,
--Matt Finnicum
On 8/19/06, Matt Finnicum [EMAIL PROTECTED] wrote:
Hi,
I've cleaned up /
Matt Finnicum [EMAIL PROTECTED] writes:
Hi,
Is there something wrong with this patch / a reason it's not being accepted?
Sorry if this might have been answered this on IRC last night - X died
while I was away, so I'd have missed it.
When resending a patch, especially a patch by someone
Nice touch including the link to the bug!
Did you run the new test on Windows?
+if(range.cpMin 0)
+{
+range.cpMin = end;
+range.cpMax = end;
+}
+ ...
+
+return (range.cpMax textlen+1 ? range.cpMax : textlen+1) ;
MSDN says the return value is the range, not just
Brian wrote:
+/* FIXME: EM_GETSEL needs to return proper ending value */
+todo_wine
+{
+ok(start == 0 end == 18, EM_EXSETSEL: expected (0,18)
actual:(%d,%d)\n, start,end);
+}
What does EM_GETSEL return right now?
It might be worth looking at that to see if you can fix it
Indeed. Thanks for pointing that out. The modifications will be made and
posted.
On Thu, 16 Mar 2006 22:31:40 -0800 (PST)
Brian Chang [EMAIL PROTECTED] wrote:
+/* get the current selection and text length */
+RichEditANSIWndProc(hWnd, EM_GETSEL, (WPARAM) start, (LPARAM)
end);
+
Hi Dan,
Thanks again for the suggestions. I did indeed run the conformance tests
on Windows -- passes with no problem. The conformance tests confirm that
the return value is not the range. Good catch for the limiting of cpMax,
it simplified the return logic. I also fixed the whitespace
On Thu, 16 Mar 2006 22:31:40 -0800 (PST)
Brian Chang [EMAIL PROTECTED] wrote:
+/* get the current selection and text length */
+RichEditANSIWndProc(hWnd, EM_GETSEL, (WPARAM) start, (LPARAM) end);
+textlen = RichEditANSIWndProc(hWnd, WM_GETTEXTLENGTH, 0, 0);
This looks strange...
