Re: Work legalities

2007-03-08 Thread Shachar Shemesh
Nathan Williams wrote: but I did sign a contract and think there may be an issue with one of the sections. If you want, post those sections here. There are some contracts that say anything you do is ours. A reasonable contract, however, will say everything you do using work equipment and on

Re: Don't compare file handles to NULL

2007-03-08 Thread Alexandre Julliard
Francois Gouget [EMAIL PROTECTED] writes: These are not false positives. Any file handle that is not INVALID_HANDLE_VALUE must be closed with CloseHandle(). So these checks should be against INVALID_HANDLE_VALUE, not NULL. In fact they may possibly be removed altogether. Note that a valid

Re: Don't compare file handles to NULL

2007-03-08 Thread Francois Gouget
On Thu, 8 Mar 2007, Alexandre Julliard wrote: [...] Note that a valid file handle will never be NULL, so while these checks are wrong in theory, in practice it makes no difference. Right. But the invalid check means that in some cases we will call CloseHandle(INVALID_HANDLE_VALUE) which the

Re: Don't compare file handles to NULL

2007-03-08 Thread Francois Gouget
On Thu, 8 Mar 2007, Alexandre Julliard wrote: [...] Sure, it's best to avoid closing an invalid handle. We don't throw an exception but we do set last error, and this could conceivably break something. But the NULL check is not going to cause us to forget to close a valid handle, which would

Re: [winealsa] Mind buffer loops when pausing

2007-03-08 Thread Jan Zerebecki
On Wed, Mar 07, 2007 at 02:41:42AM -0500, Chris Bandy wrote: It looks correct on paper, but I don't seem to have any applications that even attempt to pause. Can anyone suggest an application to test this with? All feedback welcome. The winmm wave testcase does pause. Jan

re: Writing a winelib plugin

2007-03-08 Thread Dan Kegel
Shachar wrote: It used to not be possible to write a plugin, to be loaded from a standard Linux ELF program, that will be itself a winelib shared object. All sorts of issues regarding running wineserver and memory layout initializations were problematic. I'm wondering whether there is any news

Re: Command and Conquer 3 Demo

2007-03-08 Thread Alexander Nicolaysen Sørnes
Onsdag 07 mars 2007 09:40, skrev H. Verbeet: On 07/03/07, Matthew Clark [EMAIL PROTECTED] wrote: I just wanted to write to let all of the devs know how proud of the wine project I am. This Demo seems to work for the most part except for the movies in it don't seem to want to resize and

Re: Command and Conquer 3 Demo

2007-03-08 Thread H. Verbeet
On 08/03/07, Alexander Nicolaysen Sørnes [EMAIL PROTECTED] wrote: Running with OSS gives you no sound (this already has a bug report). Well yeah, just looking if we can blame winealsa :-)

Re: quartz: Use proper alloc/free functions for COM objects

2007-03-08 Thread Detlef Riekenberg
On Do, 2007-03-08 at 03:06 -0800, Chris Robinson wrote: Subject: [PATCH] quartz: Use proper alloc/free functions for COM objects +omr-messages = CoTaskMemAlloc(omr-ring_buffer_size * sizeof(Event)); +ZeroMemory(omr-messages, omr-ring_buffer_size * sizeof(Event)); +fimpl =

Re: user32: avoid NULL pointer access in DefWindowProcA WM_NCCREATE

2007-03-08 Thread Jan Zerebecki
On Thu, Mar 08, 2007 at 05:08:46PM +0100, Felix Nawothnig wrote: Jan Zerebecki wrote: CREATESTRUCTA *cs = (CREATESTRUCTA *)lParam; /* check for string, as static icons, bitmaps (SS_ICON, SS_BITMAP) * may have child window IDs instead of

Re: Work legalities

2007-03-08 Thread Jeremy White
I asked James Vasile, of the Software Freedom Law Center, to comment on this. (For those who don't recall, the SFLC officially represents the Wine project on legal matters). This is essentially what he had to say (and James, correct me if I get anything wrong :-/): If you are employed to do

Serial port problem - again

2007-03-08 Thread Aleš Rom
Hello. I'm new to this list. First I must say that I apologise for posting this mail again here. I hope you wine gurus can see what is going wrong here. If I run this app http://appdb.winehq.org/appview.php?iAppId=4165 with WINEDEBUG=+relay , I can transfer data from my device to PC, but not

modification to allow -Wcast-qual to find potential warnings without unicode.h causing them

2007-03-08 Thread Andrew Talbot
Assuming it is valid and does what is required, maybe the following pragma would be more precise. #pragma GCC diagnostic warning -Wwrite-strings -- Andy.

Re: modification to allow -Wcast-qual to find potential warnings without unicode.h causing them

2007-03-08 Thread Andrew Talbot
Of course, what I should have written was: Assuming it is valid and does what is required, maybe the following pragma would be more precise. #pragma GCC diagnostic ignored -Wcast-qual Sorry. I did too much cutting and pasting, and not enough thinking. -- Andy.

Re: modification to allow -Wcast-qual to find potential warnings without unicode.h causing them

2007-03-08 Thread Andrew Talbot
Mike Schaadt wrote: I attempted using the suggested '#pragma GCC diagnostic ignored -Wcast-qual' in replace of what I submited, however I received the warning 'ignoring #pragma GCC diagnostic' message, plus the normal warnings from unicode.h My guess is that I might be using an older

-Wcast-qual result

2007-03-08 Thread Mike Schaadt
I submited a patch today that modified unicode.h that disables warnings(which allows for -Wcast-qual to actually give relevant results) I don't know if it will be accepted or not(it has the potential of being problematic if modifying unicode.h that would normally result in a warning, but this

Fwd: wined3d: Update cursor position on ShowCursor

2007-03-08 Thread Erich Hoover
Request for comments, as per http://www.winehq.com/site/sending_patches. For details on the need for this patch please see Bug #7542http://bugs.winehq.org/show_bug.cgi?id=7542. Thanks! Erich Hoover [EMAIL PROTECTED] -- Forwarded message -- From: Erich Hoover [EMAIL PROTECTED]

Fwd: kernel32: Implement ReplaceFileA/ReplaceFileW (revised)

2007-03-08 Thread Erich Hoover
Request for comments, as per http://www.winehq.com/site/sending_patches. Thanks! Erich Hoover [EMAIL PROTECTED] -- Forwarded message -- From: Erich Hoover [EMAIL PROTECTED] Date: Mar 3, 2007 2:37 PM Subject: kernel32: Implement ReplaceFileA/ReplaceFileW (revised) To: [EMAIL

Re: Alexandre Julliard : advapi32: Fixed registry test that failed because of a buffer overflow.

2007-03-08 Thread James Hawkins
On 3/8/07, Alexandre Julliard [EMAIL PROTECTED] wrote: Module: wine Branch: master Commit: 7e2228f15aa7a6fc0d63fe36c34906035422e95a URL: http://source.winehq.org/git/wine.git/?a=commit;h=7e2228f15aa7a6fc0d63fe36c34906035422e95a Author: Alexandre Julliard [EMAIL PROTECTED] Date: Thu Mar 8

Re: Command and Conquer 3 Demo

2007-03-08 Thread Matthew Clark
Alexander Nicolaysen Sørnes wrote: Not all users are experiencing the crashes, perhaps a SMP issue? may be it I do have a dual-core system

Re: quartz: Use proper alloc/free functions for COM objects

2007-03-08 Thread Chris Robinson
On Thursday 08 March 2007 08:14:54 am you wrote: While reading your Patch, I see the above Places, where the result from the allocation is used without a NULL-check. The other allocations are checked for NULL before used. Is this correct? It should NULL check, but I was mainly concerned with

Re: comctl32: listview tests

2007-03-08 Thread Lei Zhang
On 3/8/07, George Gov [EMAIL PROTECTED] wrote: @@ -573,10 +699,242 @@ static void test_redraw(void) trace(invalidate update\n); InvalidateRect(hwnd, NULL, TRUE); UpdateWindow(hwnd); -ok_sequence(sequences, LISTVIEW_SEQ_INDEX, redraw_listview_seq, redraw listview, FALSE); +

Tackling gdiplus?

2007-03-08 Thread Dan Kegel
An increasing number of apps need gdiplus.dll. Seems like it's time for Wine to include it. Since Mono has implemented much of gdiplus already ( http://www.mono-project.com/Libgdiplus ), we ought to be able to just slurp that into Wine and get quite a ways. Any objections? I'm thinking of