Re: richedit: Added tests to show that options are stored internally.

2009-01-11 Thread Paul Vriens
Dylan Smith wrote: Wine is currently getting the window styles and using them directly, but the tests I added show that an internal copy is being stored by native richedit controls. --- dlls/riched20/tests/editor.c | 23 +++ 1 files changed, 23 insertions(+), 0

Re: richedit: Added tests for autoscrolling options based on WS_V/HSCROLL.

2009-01-11 Thread Paul Vriens
Dylan Smith wrote: It seems as if the autoscrolling options can be set based on whether WS_VSCROLL or WS_HSCROLL styles are used to create the window, but this is done differently between version 1.0 and 3.0 of the richedit control. I noticed this indirectly before because wordwrap is

Re: richedit: Added tests to show that options are stored internally.

2009-01-11 Thread Detlef Riekenberg
On So, 2009-01-11 at 02:58 -0500, Dylan Smith wrote: Hi Dylan. First of all, thanks for working on riched* +/* EM_SETOPTIONS changes the window style, but changing the + * window style does not change the options. */ +dwStyle = GetWindowLongW(hwndRichEdit, GWL_STYLE); Almost all

Re: richedit: Added tests for autoscrolling options based on WS_V/HSCROLL.

2009-01-11 Thread Detlef Riekenberg
On So, 2009-01-11 at 02:58 -0500, Dylan Smith wrote: It seems as if the autoscrolling options can be set based on whether WS_VSCROLL or WS_HSCROLL styles are used to create the window, but this is done differently between version 1.0 and 3.0 of the richedit control. I noticed this indirectly

setupapi:parser - suspicious test results

2009-01-11 Thread Rico Schüller
Hi, concerning to http://test.winehq.org/data/tests/setupapi:parser.html there are some suspicious results for the test from 6-10. January. On my system (F10-x86_64) the setupapi:parser test (setupapi_test.exe) from the test site has 15 additional failures (17 failures) on wine. I checked

Re: setupapi:parser - suspicious test results

2009-01-11 Thread Paul Vriens
Rico Schüller wrote: Hi, concerning to http://test.winehq.org/data/tests/setupapi:parser.html there are some suspicious results for the test from 6-10. January. On my system (F10-x86_64) the setupapi:parser test (setupapi_test.exe) from the test site has 15 additional failures (17

Re: setupapi:parser - suspicious test results

2009-01-11 Thread Rico Schüller
Paul Vriens schrieb: Hi Rico, I guess the results on the website came from running the Windows winetest.exe? Could you try the following: - download winetest.exe - remove .wine (or move it away, use a different prefix, whatever) - run 'wine winetest.exe setupapi:parser' - check the

Re: setupapi:parser - suspicious test results

2009-01-11 Thread Rico Schüller
Rico Schüller schrieb: Paul Vriens schrieb: Hi Rico, I guess the results on the website came from running the Windows winetest.exe? Could you try the following: - download winetest.exe - remove .wine (or move it away, use a different prefix, whatever) - run 'wine winetest.exe

Re: setupapi:parser - suspicious test results

2009-01-11 Thread Michael Karcher
Am Sonntag, den 11.01.2009, 16:02 +0100 schrieb Rico Schüller: just want to say problem found, the if (*need) *need = len; in SetupEnumInfSectionsA/W is wrong. I'll send a patch. This looks like a typical problem valgrind is designed for. It should report an uninitialized memory read at that

Re: wcmd: Fix redirecting a pipe to another pipe

2009-01-11 Thread Andrew Nguyen
On Sun, Jan 11, 2009 at 12:52 PM, Erich Hoover ehoo...@mines.edu wrote: Real Name: Erich Hoover Description: Fix a problem with Wine's cmd.exe that causes redirecting a pipe to another pipe to fail. Can be tested by executing 'echo test 21' in cmd.exe. Without the patch the redirect

gecko regressions; debug build of gecko?

2009-01-11 Thread Dan Kegel
I've been doing some random qa of popular apps lately, and think I've found some regressions caused by the gecko update: http://bugs.winehq.org/show_bug.cgi?id=16869 - Sketchup 7 crashes when bringing up 3d Warehouse http://bugs.winehq.org/show_bug.cgi?id=16892 - Yahoo Messenger 8.1 crashes after

Re: wcmd: Fix redirecting a pipe to another pipe

2009-01-11 Thread Reece Dunn
2009/1/11 Erich Hoover ehoo...@mines.edu: +/* If a redirect is immediately followed by '' (ie. 21) then +do nor process that ampersand as an AND operator */ Shouldn't that be do *not* process that ampersand? - Reece

Re: gecko regressions; debug build of gecko?

2009-01-11 Thread Jacek Caban
Dan Kegel wrote: I've been doing some random qa of popular apps lately, and think I've found some regressions caused by the gecko update: http://bugs.winehq.org/show_bug.cgi?id=16869 - Sketchup 7 crashes when bringing up 3d Warehouse http://bugs.winehq.org/show_bug.cgi?id=16892 - Yahoo

WIDL 'import' question

2009-01-11 Thread Nikolay Sivov
Hi, I've a small question on using 'import' in .idl. Sorry if it's too dummy, it's my first try to use widl. Trying to get commoncontrols.idl port compile on Wine I've got the following problems - this file contains struct definitions already defined in commctrl.h. Adding import commctrl.h

Re: [1/4] mshtml: Implement IHTMLStyle get/put borderRightStyle

2009-01-11 Thread Jacek Caban
Hi Alistair, Alistair Leslie-Hughes wrote: Hi, Changelog: mshtml: Implement IHTMLStyle get/put borderRightStyle +static BOOL IsValidBorderStyle(BSTR v) - Please use the same name convention as other functions in this file - There is no test proving that the style is validated - You

Re: gecko regressions; debug build of gecko?

2009-01-11 Thread Dan Kegel
On Sun, Jan 11, 2009 at 11:12 AM, Jacek Caban ja...@codeweavers.com wrote: Hmm, can we have a debug version of the gecko download so we can give more useful backtraces? We already have it, it's on SourceForge. To use it you have to replace existing Wine Gecko installation in

Re: wcmd: Fix redirecting a pipe to another pipe

2009-01-11 Thread Erich Hoover
Indeed, apparently my fingers are too fat for my keyboard. Do comment typos involve a resubmit? Erich Hoover ehoo...@mines.edu On Sun, Jan 11, 2009 at 12:08 PM, Reece Dunn mscl...@googlemail.com wrote: 2009/1/11 Erich Hoover ehoo...@mines.edu: +/* If a redirect is immediately

Re: wcmd: Fix redirecting a pipe to another pipe

2009-01-11 Thread Austin English
On Sun, Jan 11, 2009 at 1:55 PM, Erich Hoover ehoo...@mines.edu wrote: Indeed, apparently my fingers are too fat for my keyboard. Do comment typos involve a resubmit? Erich Hoover ehoo...@mines.edu On Sun, Jan 11, 2009 at 12:08 PM, Reece Dunn mscl...@googlemail.com wrote: 2009/1/11 Erich

Re: wcmd: Fix redirecting a pipe to another pipe

2009-01-11 Thread Erich Hoover
On Sun, Jan 11, 2009 at 11:59 AM, Andrew Nguyen arethus...@gmail.com wrote: Please set your real e-mail address in your Git configuration; see http://wiki.winehq.org/GitWine#head-8631765a8d71509690613c9191ed2094c7775722 for directions. Done, I don't know who maintains

Re: wcmd: Fix redirecting a pipe to another pipe

2009-01-11 Thread Erich Hoover
On Sun, Jan 11, 2009 at 12:59 PM, Austin English austinengl...@gmail.com wrote: Also, please bottom post on wine mailing lists. Sorry, I forget for short messages and gmail's reply system always sticks the cursor at the top. Erich Hoover ehoo...@mines.edu

Re: gecko regressions; debug build of gecko?

2009-01-11 Thread Dan Kegel
On Sun, Jan 11, 2009 at 11:36 AM, Dan Kegel d...@kegel.com wrote: Thanks, I updated http://wiki.winehq.org/Gecko with that info. I see a more verbose log, but sadly, backtraces in xul crashes are still not symbolic. WINEDEBUG=+gecko seems to turn on assertions in gecko. Can you add a note

cmd.exe AppDB page

2009-01-11 Thread Erich Hoover
Is there a reason that the cmd.exe AppDB page is locked (http://appdb.winehq.org/objectManager.php?sClass=applicationiId=1196)? Erich Hoover ehoo...@mines.edu

Re: cmd.exe AppDB page

2009-01-11 Thread Alexander Nicolaysen Sørnes
Søndag 11 januar 2009 23:03:08 skrev Erich Hoover: Is there a reason that the cmd.exe AppDB page is locked (http://appdb.winehq.org/objectManager.php?sClass=applicationiId=1196)? Erich Hoover ehoo...@mines.edu It doesn't appear to have any version entries. Could you submit one? Alexander

Re: cmd.exe AppDB page

2009-01-11 Thread Erich Hoover
On Sun, Jan 11, 2009 at 4:03 PM, Alexander Nicolaysen Sørnes a...@thehandofagony.com wrote: It doesn't appear to have any version entries. Could you submit one? I don't see a way to do that, there's no maintainer/version buttons like on other entries - it just says You do not have permission to

Re: cmd.exe AppDB page

2009-01-11 Thread Alexander Nicolaysen Sørnes
Mandag 12 januar 2009 00:10:20 skrev du: On Sun, Jan 11, 2009 at 4:03 PM, Alexander Nicolaysen Sørnes a...@thehandofagony.com wrote: It doesn't appear to have any version entries. Could you submit one? I don't see a way to do that, there's no maintainer/version buttons like on other

Re: cmd.exe AppDB page

2009-01-11 Thread Ben Klein
Why, exactly, should there be an appdb page for cmd.exe? 2009/1/12 Alexander Nicolaysen Sørnes a...@thehandofagony.com: Mandag 12 januar 2009 00:10:20 skrev du: On Sun, Jan 11, 2009 at 4:03 PM, Alexander Nicolaysen Sørnes a...@thehandofagony.com wrote: It doesn't appear to have any version

Re: cmd.exe AppDB page

2009-01-11 Thread Rosanne DiMesio
It doesn't appear to have any version entries. Could you submit one? I don't see a way to do that, there's no maintainer/version buttons like on other entries - it just says You do not have permission to view this entry. Try submitting it as a new app. -- Rosanne DiMesio

Re: cmd.exe AppDB page

2009-01-11 Thread Erich Hoover
On Sun, Jan 11, 2009 at 4:31 PM, Ben Klein shackl...@gmail.com wrote: Why, exactly, should there be an appdb page for cmd.exe? I'm trying to get an application working that depends on executing batch commands through cmd.exe. Personally, I think it's relevant to know how well different

re:cmd.exe AppDB page

2009-01-11 Thread nn
Eric, I have created a new AppDB page for cmd.exe as the existing one would not accept new test reports: new AppDB page is: http://appdb.winehq.org/objectManager.php?sClass=applicationiId=8995 Submit a test and I will delete the fake report. Nat Stay connected to the people that matter

Re: cmd.exe AppDB page

2009-01-11 Thread Ben Klein
2009/1/12 Erich Hoover ehoo...@mines.edu: On Sun, Jan 11, 2009 at 4:31 PM, Ben Klein shackl...@gmail.com wrote: Why, exactly, should there be an appdb page for cmd.exe? I'm trying to get an application working that depends on executing batch commands through cmd.exe. Personally, I think

Re: cmd.exe AppDB page

2009-01-11 Thread Erich Hoover
On Sun, Jan 11, 2009 at 5:04 PM, Ben Klein shackl...@gmail.com wrote: 2009/1/12 Erich Hoover ehoo...@mines.edu: ... For my purposes I'm submitting patches for the things that I find that don't work, but it would be nice to have something to compare against and be able to say this

Re: [1/4] mshtml: Implement IHTMLStyle get/put borderRightStyle

2009-01-11 Thread Alistair Leslie-Hughes
Hi Jakek, Jacek Caban ja...@codeweavers.com wrote in message news:496a47af.50...@codeweavers.com... Hi Alistair, Alistair Leslie-Hughes wrote: Hi, Changelog: mshtml: Implement IHTMLStyle get/put borderRightStyle +static BOOL IsValidBorderStyle(BSTR v) - Please use the same name

Re: [1/4] mshtml: Implement IHTMLStyle get/put borderRightStyle

2009-01-11 Thread Jacek Caban
Hi Alistair, Alistair Leslie-Hughes wrote: The problem is hres is DISP_E_EXCEPTION, whereas I'm expecting E_INVALIDARG (Tested on windows). It appears in ITypeInfo_fnInvoke, if an error is returned from the function call, the result is changed to return DISP_E_EXCEPTION (~ line 6320).

Re: cmd.exe AppDB page

2009-01-11 Thread Rosanne DiMesio
I do hope you're talking about Wine's cmd, and not Windows ;) Yeah, I need to get this program working right away - I can't afford to wait 3 years for bugs/features to be fixed by a new version of Windows ;) Now I'm confused. Were you expecting to find test results on Wine's cmd.exe

Re: cmd.exe AppDB page

2009-01-11 Thread Erich Hoover
On Sun, Jan 11, 2009 at 5:42 PM, Rosanne DiMesio dime...@earthlink.netwrote: I do hope you're talking about Wine's cmd, and not Windows ;) Yeah, I need to get this program working right away - I can't afford to wait 3 years for bugs/features to be fixed by a new version of Windows

Re: richedit: Added tests for autoscrolling options based on WS_V/HSCROLL.

2009-01-11 Thread Dylan Smith
On Sun, Jan 11, 2009 at 6:32 AM, Detlef Riekenberg wine@web.de wrote: Hi Dylan. After testing your first Patch, i tried this one: patching file dlls/riched20/tests/editor.c Hunk #1 succeeded at 5826 (offset 23 lines). Hunk #2 succeeded at 5856 (offset 23 lines). Hunk #3 succeeded at

Re: [TOOLS] Add Windows 7

2009-01-11 Thread James Hawkins
On Sat, Jan 10, 2009 at 3:32 AM, Paul Vriens paul.vriens.w...@gmail.com wrote: Hi, We have our first Windows 7 test results : http://test.winehq.org/data/a69c86d3f517f659ba47495f77deac2df671fb03/vista_windows7-virtualbox/version.html I'm not sure if '7' is a nice/correct header though. Maybe

Re: [TOOLS] Add Windows 7

2009-01-11 Thread Paul Vriens
Austin English wrote: On Sun, Jan 11, 2009 at 11:24 PM, James Hawkins trui...@gmail.com wrote: On Sat, Jan 10, 2009 at 3:32 AM, Paul Vriens paul.vriens.w...@gmail.com wrote: Hi, We have our first Windows 7 test results :