Re: ws2tcpip.h: Define socklen_t

2004-11-13 Thread Felix Nawothnig
On 11/13/2004 02:22:18 AM, I wrote: We don't have socklen_t defined anywhere and that's the place where it's defined in the official headers so... WASTE compiles fine now... (I'm sure there is a reason why it isn't defined but I can't see it - so tell me why this will be rejected... err... if

Re: ALSA: Allow configuration of output devices to use and change standard output plugin requested to default

2004-03-30 Thread Felix Nawothnig
On 03/26/2004 04:56:00 PM, Mike Hearn wrote: in ALSA_WaveInit(): +wwo-device = ALSA_GetDeviceFromReg(PlaybackDevice); in wodClose(): + HeapFree(GetProcessHeap(), 0, wwo-device); and in widClose(): + HeapFree(GetProcessHeap(), 0, wwi-device); Thats wrong. wods and wids can be

Re: dsound/tests: The tests link with dsound.dll so use GetModuleHandle() instead of LoadLibrary().

2007-01-11 Thread Felix Nawothnig
Francois Gouget wrote: This is a NOP, it just seems a bit cleaner to me. -hDsound = LoadLibraryA(dsound.dll); -if (!hDsound) { -trace(dsound.dll not found\n); -return; -} - +hDsound = GetModuleHandleA(dsound.dll); +ok(hDsound != NULL, dsound.dll not

test.winehq.com status

2007-01-30 Thread Felix Nawothnig
Hi. Anyone knows what happened to test.winehq.com/data? There has been no new crossbuilds for quite some time now... Felix

Re: Getting Fallout 2 to work well

2007-02-02 Thread Felix Nawothnig
Joonas Koivunen wrote: The problem I have is that fallout2.exe takes all the available CPU power, optimizing that might make other old games work better too. I'm interested in the task, though I haven't got much of an idea how GDI or DirectDraw api's work and I'd need some pointers where to

Re: [PATCH] coverity: CID35: fixed wrong condition

2007-02-05 Thread Felix Nawothnig
Marcus Meissner wrote: - if(nRelPos=0) { /* if this or preceding row */ + if(nRelPos=0) { /* if this or preceding row */ while(nRelPos=0) { Shouldn't that become a do { ... } while() then?

Re: [PATCH] coverity: CID35: fixed wrong condition

2007-02-06 Thread Felix Nawothnig
Marcus Meissner wrote: - if(nRelPos=0) { /* if this or preceding row */ + if(nRelPos=0) { /* if this or preceding row */ while(nRelPos=0) { Shouldn't that become a do { ... } while() then? No, since there is a return item; after the while () loop. I meant replacing just the while(),

Re: msi: InstallPackage check for UI level must not disregard flags (updated)

2007-02-06 Thread Felix Nawothnig
Koshelev, Misha Vladislavo wrote: So do you think I should add a define like INSTALLUILEVEL_NOFLAGS somewhere set to 0xf then? Shouldn't that be 0x7?

Re: msi: InstallPackage check for UI level must not disregard flags (updated)

2007-02-06 Thread Felix Nawothnig
Misha Koshelev wrote: So do you think I should add a define like INSTALLUILEVEL_NOFLAGS somewhere set to 0xf then? Shouldn't that be 0x7? I guess either one would work since the first flag is 0x20. Do I need to change it to 0x7 or leave as is? So would 0x1f or 0xfe1f. Doesn't make it

Undoc. comctl32 mem management functions

2007-02-06 Thread Felix Nawothnig
Hi. comctl32 exports (undocumented) Alloc() and friends which call LocalAlloc = GlobalAlloc = HeapAlloc since it's doesn't use any fancy LMEM / GMEM flags... so shouldn't Alloc() call HeapAlloc() directly? If Global/Local* behave different than Heap* on Windows - wouldn't it then be desirable

Re: comctl32: tab: update the item mask after a TB_SETITEM (fixes bug #7345)

2007-02-06 Thread Felix Nawothnig
Mikołaj Zalewski wrote: Tab uses a mask to mark which fields are set but it new fields were set by SetItem the mask wasn't updated. Actually all members are always valid (for the internal structure at least). I already sent a patch which removes the mask. Felix

Re: Some thoughts about the ominous DIB Engine

2007-02-09 Thread Felix Nawothnig
Ken Thomases wrote: Pierre could speak to this better than I, but my understanding is that the Quartz driver does not need the DIB engine. Quartz (the Mac's imaging and windowing API) is capable of drawing to offscreen bitmaps directly, at color depths that need not match the display's.

Re: Some thoughts about the ominous DIB Engine

2007-02-09 Thread Felix Nawothnig
Felix Nawothnig wrote: Pierre could speak to this better than I, but my understanding is that the Quartz driver does not need the DIB engine. Quartz (the Mac's imaging and windowing API) is capable of drawing to offscreen bitmaps directly, at color depths that need not match the display's

Re: Comctl32 Status Bar Test

2007-02-10 Thread Felix Nawothnig
Alex Arazi wrote: -ok(rc.top == 2, Expected 2, got %d\n, rc.top); -ok(rc.bottom == 21, Expected 21, got %d\n, rc.bottom); -ok(rc.left == 0, Expected 0, got %d\n, rc.left); -ok(rc.right == 50, Expected 50, got %d\n, rc.right); I didn't really look at your new tests but the

Re: wineboot: Start items in StartUp folder on boot, includes security measures.

2007-02-11 Thread Felix Nawothnig
[EMAIL PROTECTED] wrote: This sounds almost perfect. I think the counterpoint raised by James Hawkins would be adequately addressed by adding a winecfg option as follows: Since we want winecfg to be gone in the long-term a registry key alone would probably do fine. Felix

Re: version: Constify a formal parameter of VerQueryValue{A|W}()

2007-02-13 Thread Felix Nawothnig
Andrew Talbot wrote: -BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPSTR lpSubBlock, +BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPCSTR lpSubBlock, This is wrong - in the PSDK headers it's LPSTR (the first parameter should be const though). Felix

Re: comctl32: move up-down msg seq tests into new 'msg' test

2007-02-13 Thread Felix Nawothnig
James Hawkins wrote: This is not what needs to happen. The generic message sequence testing code needs to be factored into msg.c, but the specific tests need to stay in each control's test file. Guessed so... How about putting it into include/wine/test.h to share the code with user32/msg?

Re: version: Constify a formal parameter of VerQueryValue{A|W}()

2007-02-13 Thread Felix Nawothnig
Andrew Talbot wrote: I've seen this function represented with the first two parameters constified. Is anyone aware of a more const-correct version in the field than the one Felix mentions? Sorry about that, seems they changed the declaration in the new headers - I misinterpreted your comment

Re: Add RegisterRawInputDevices stub implementation

2007-02-13 Thread Felix Nawothnig
Kovács András wrote: +BOOL WINAPI RegisterRawInputDevices(PRAWINPUTDEVICE pRawInputDevices, UINT uiNumDevices, UINT cbSize) +{ +int i; Please keep the indentation style of the original file.

Re: wineboot: Start items in StartUp folder on boot, includes security measures.

2007-02-14 Thread Felix Nawothnig
[EMAIL PROTECTED] wrote: And I have never advocated for putting this in the registry, my suggestion has always been to store these settings in a file outside the .wine/drive_c jail area that is accessbile via wine's Win32 API. Wine is *not* a sandbox. Any .exe run can make use of native

Message spy log viewer

2007-02-23 Thread Felix Nawothnig
Hi. I just figured I never told anyone (did I?) - a while ago I wrote a Ruby/GTK2 tool to parse +message logs (along with other channels mixed in) and display them in a treeview - makes debugging message related problems much easier. I suppose others wrote similar scripts for their own use -

Re: test.winehq.com status

2007-02-24 Thread Felix Nawothnig
Hi. A new crossbuild appeared today but the site shows all tests failing. See http://test.winehq.org/data/200702241000/ Felix

Re: New wintest executable is there (but there are some issues due to introduction of skip)

2007-02-24 Thread Felix Nawothnig
And while we're at it, there seems to be some misconfiguration of the httpd (for quite some time), as the following URL generates an 500 Internal Server Error: http://test.winehq.org/data/200702241000/2003_W2K3-SE-IE7/ntdll:error.txt

Re: [PATCH] user32: do not call NULL message callback

2007-02-24 Thread Felix Nawothnig
Fabian Bieler wrote: Windows silently ignores NULL pointers supplied to SendMessageCallback as callback function. A testcase would be nice. Felix

Re: [PATCH] user32: do not call NULL message callback

2007-02-24 Thread Felix Nawothnig
Fabian Bieler wrote: The only way I know of to test this behavior would be to pass a NULL pointer as callback. Naturally this results in a segfault without this patch. Is this okay for a testcase? Use if(0) instead of todo_wine then (and let the second patch, which fixes the bug, remove the

Re: Wine and XP Themes

2007-02-26 Thread Felix Nawothnig
Frank Richter wrote: WRT speed: themes usually use alpha-blending extensively; however, the speed of Wine's AlphaBlend() can almost be measured in geological terms; Why is that? Looking at it it seems to be using XRender - since theming doesn't require Aero and stuff what way would there be

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-02-26 Thread Felix Nawothnig
Erich Hoover wrote: Real Name: Erich Hoover Description: Implements the functions ReplaceFileA and ReplaceFileW in kernel32 (Bug #7544). Also provides conformance test code to ensure proper functionality. Changelog: kernel32: Implement ReplaceFileA/ReplaceFileW Your patch seems

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-02-26 Thread Felix Nawothnig
Erich Hoover wrote: I assume you're referring to the file existence check and file delete, followed by the actual copy and move. I implemented these checks in this manner in order to provide error codes consistent with the documentation. I am not incredibly familiar with the Wine internals,

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-02-26 Thread Felix Nawothnig
Erich Hoover wrote: Is the attached more like what you're looking for? I did some investigation and... actually I'm looking for an equivalent to the linux splice syscall. Win32 is the most braindead API ever. Duh. The right way would probably to do the copying yourself by read/write.. but

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-02-28 Thread Felix Nawothnig
(CC-ing wine-devel again) Erich Hoover wrote: The right way would probably to do the copying yourself by read/write.. but I dunno. Except that it would ignore the permissions issues that have already been coded into the copy routines (and any updates that may eventually No, CreateFile (and

Using ex-user32 controls from native comctl32 6

2007-02-28 Thread Felix Nawothnig
(CC-ing to Frank Richter because I hope he knows the answer :) Hi. I've been trying to make wine use the ex-user32 controls (listbox, scrollbox, etc.) in comctl32 where Microsoft copied them to in version 6 to get message traces of those controls (I know I could use msg spy tools on Windows

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-02-28 Thread Felix Nawothnig
Erich Hoover wrote: The right way would probably to do the copying yourself by read/write.. but I dunno. Except that it would ignore the permissions issues that have already been coded into the copy routines (and any updates that may eventually No, CreateFile (and friends) does the permissions

Re: Using ex-user32 controls from native comctl32 6

2007-02-28 Thread Felix Nawothnig
Frank Richter wrote: So, any idea how Windows makes comctl32 register the user classes? I think it just re-registered the classes, but I'm not sure. A trace with class registrations (ie +class) might give some hint at what native does. Okay, I was stupid. I removed registration of all the

Re: Wine's Wiki Defaced

2007-02-28 Thread Felix Nawothnig
Francois Gouget wrote: Someone has defaced Wine's Wiki frontpage. Also I have either forgotten my password or the user accounts don't work anymore. Could someone look into this? Reverted it (no idea about the accounts, I was still logged in).

Re: Forum proposal

2007-03-01 Thread Felix Nawothnig
(Score:-1, Flaimbait) Wojciech 'arab' Arabczyk wrote: Well - one could setup a forum-mailing list gateway. Not easily doable due to the nature of SMTP. Also a forum would be completly useless for anything but wine-users... But let's be honest here: Most people who use webforums are too

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-03-02 Thread Felix Nawothnig
Erich Hoover wrote: I see your point. However, since the function you are implementing is in kernel32 anyway you could abstract it away and make both functions (CopyFile and ReplaceFile) call some internal function. That way you would get rid of the locking completly which is argueably somewhat

Re: Work legalities

2007-03-07 Thread Felix Nawothnig
Nathan Williams wrote: What do I need from my employer to clear me to work on wine? Is something verbal ok, or should I get it in writing? The FSF says: http://www.gnu.org/licenses/gpl.html | You should also get your employer (if you work as a programmer) or | your school, if any, to sign a

Re: user32: avoid NULL pointer access in DefWindowProcA WM_NCCREATE

2007-03-09 Thread Felix Nawothnig
Jan Zerebecki wrote: cs is never NULL at that point. Where should it be checked for NULL, then? Or what does it prevent to be NULL? cs == lParam. And this code is inside if (lParam != NULL).

Re: quartz: Check allocation failure and clear memory in DSound Renderer

2007-03-09 Thread Felix Nawothnig
Detlef Riekenberg wrote: @@ -325,9 +328,15 @@ HRESULT DSoundRender_create(IUnknown * pUnkOuter, LPVOID * ppv) pDSoundRender-pClock = NULL; pDSoundRender-init = FALSE; pDSoundRender-started = FALSE; ... there is no need to clear it again. However, note that NULL is not always all

Re: quartz: Check allocation failure and clear memory inDSound Renderer

2007-03-09 Thread Felix Nawothnig
Dmitry Timoshkov wrote: However, note that NULL is not always all binary zero in memory. :) I don't believe it's true since NULL is defined as (void *)0. Actually it may aswell be just 0 in C. Just in C++ it's defined to be (void *)0. But even with just 0 an assignment/compare/whatever will

Re: kernel32: MultiByteToWideChar: MB_USEGLYPHCHARS fix

2007-03-10 Thread Felix Nawothnig
Andrew O.Shadoura wrote: +#if 0 static int once; +#endif if (!src || (!dst dstlen)) { @@ -1774,11 +1783,13 @@ INT WINAPI MultiByteToWideChar( UINT pag if (srclen 0) srclen = strlen(src) + 1; +#if 0 if (!once (flags MB_USEGLYPHCHARS)) { once = 1;

Re: appdb needs to allow untested applications sometimes

2007-03-10 Thread Felix Nawothnig
Chris Morgan wrote: What would the purpose of having untested applications in the appdb be? Users would search for the app and find that it shows up but then find that it doens't work. At which point the application would qualify as been tested, no? Felix

Re: comctl32: register all the controls in DllMain (fixes bug #7641)

2007-03-14 Thread Felix Nawothnig
Mikołaj Zalewski wrote: comctl32 version 5.82 (at least the one that comes with a fully patched Windows XP) and 6.0 register all the controls in DllMain. InitCommonControlsEx is just a dummy function. Could it be that 6.0 only registers those controls listed using window class dependencies

Defining COM interfaces without IDL

2007-03-15 Thread Felix Nawothnig
Hi. The PSDK headers sometimes use IDL to define an interface, sometimes it's done by hand (or rather using macros). I don't know if there is any reason for that (someone in the channel said it's just sloppiness by MS) - so, are there any resulting differences regarding source compatibility

Re: [2/3] comctl32: Never draw item text with OPAQUE.

2007-03-16 Thread Felix Nawothnig
Dimi Paun wrote: But this ends up creating and deleting the brush for each of the cells Well - yes. But other controls do this too (statusbar for example) and considering all the stuff we do during refresh this is hardly a bottleneck. And even if it is we should optimize this codepath in

Re: [2/3] comctl32: Never draw item text with OPAQUE.

2007-03-16 Thread Felix Nawothnig
(CCing wine-devel again) Dimi Paun wrote: Problem is that DrawText() for the subitems will also use the background color - which is wrong. Why is it wrong? Because the background color isn't the background color of the list. And it's definitly not the text bkclr in gdi-context either - I

Re: Supreme Commander Up and running!

2007-03-20 Thread Felix Nawothnig
Stephan Rose wrote: Figure, that'd be as good as a start as any as something for me to implement. Easy to test toojust before I dive into it, anyone potentially already working on it (or is there a good way to check)? Figured I'd ask first before 2 people work on the same thing. Someone

Re: x11drv: XDND: Fix file drop to properly support file:/// URIs(debugging problem)

2007-03-22 Thread Felix Nawothnig
Maciej Katafiasz wrote: +if(GetLastError()) +{ + TRACE(Can't convert to WCHAR: %d\n, GetLastError()); + goto clean_wfn; +} This is not an appropriate way of testing for an API failure. What is inappropriate and how should I fix it? Most APIs don't change GLE on success.

WineD3D: Make CreateCubeTexture fail when not supported

2007-03-28 Thread Felix Nawothnig
Not tested under Windows (does _anyone_ besides me have a Matrox? :) - would be nice if someone with either an MGA or an really ancient GPU could run the test on windows (if the pool=0 trace has an hr!=0 you got one of those ancient cards :). CCing to wine-devel for that reason. ---

Re: WineD3D: Make CreateCubeTexture fail when not supported

2007-03-28 Thread Felix Nawothnig
Luke Bratch wrote: Somewhere I have an ancient Matrix MGA G200 AGP card... If this would be of any use, I'll dig it out and run any tests in Wine/Windows that you'd like? Sure, if you're willing to do that just because I'm lazy. :-) I was just hoping someone might be running a box with an

Re: WineD3D: Make CreateCubeTexture fail when not supported

2007-03-28 Thread Felix Nawothnig
Duane Clark wrote: On a Matrox G550, Win2k, crosscompiled on Linux with MingW: I:\dlls\d3d8\testsd3d8_crosstest texture texture.c:122:texture caps: 0x41c7 texture.c:110:pool=0 hr=0x8876086c texture.c:110:pool=1 hr=0x8876086c texture.c:110:pool=2 hr=0x8876086c texture.c:110:pool=3

Re: gdi32: Add failing metrics test for negative font widths

2007-03-28 Thread Felix Nawothnig
Felix Nawothnig wrote: --- dlls/gdi32/tests/font.c | 37 + 1 files changed, 37 insertions(+), 0 deletions(-) Anything wrong with this patch?

Re: Is Wine a platform for Codeweaver to make money?! Please help me understand.

2007-03-29 Thread Felix Nawothnig
Sasan Iman wrote: I know that if you fiddle around with the stock release long enough you can get MS Office working on Wine as I have on a number of occasions, but shouldn't making this work for everyone be the highest priority for getting Wine to be adopted more widely?! Or is Wine more

Re: Setting debug channels in 20040914 version

2007-04-02 Thread Felix Nawothnig
Bill Medland wrote: Can someone remind me how we used to set the debug channels back in late 2004? wine --debugmsg +relay ... Or maybe it was -debugmsg? Felix

Re: [1/2] wined3d: Downgrade some ERRs to FIXMEs

2007-04-04 Thread Felix Nawothnig
Stefan Dösinger wrote: Some of them should technically be ERRs because we tell the application that we do not support those features, so they should never be used. Application bugs shouldn't trigger ERRs, Wine bugs should. Felix.

Re: notepad: Fix the wrong '' operator use.

2007-04-05 Thread Felix Nawothnig
Byeong-Sik Jeon wrote: FormatMessage( FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, NULL, error, 0, -(LPTSTR) lpMsgBuf, 0, NULL); +lpMsgBuf, 0, NULL); This patch is wrong. When FORMAT_MESSAGE_ALLOCATE_BUFFER is used

Patches / a proposal for the mystic DIB engine

2007-04-11 Thread Felix Nawothnig
Okay, I've spent the last days looking into this matter and I'd like to suggest a way to get it started. So. This is the plan: 1. In winex11.drv: -INT X11DRV_LockDIBSection(X11DRV_PDEVICE *physDev, INT req, BOOL lossy) +HBITMAP X11DRV_LockDIBSection(X11DRV_PDEVICE *physDev, INT req, BOOL

Re: Patches / a proposal for the mystic DIB engine

2007-04-11 Thread Felix Nawothnig
; SetRectRgn( dc-hVisRgn, 0, 0, bitmap-bitmap.bmWidth, bitmap-bitmap.bmHeight); diff --git a/dlls/gdi32/dibdrv.c b/dlls/gdi32/dibdrv.c new file mode 100644 index 000..e4a216e --- /dev/null +++ b/dlls/gdi32/dibdrv.c @@ -0,0 +1,190 @@ +/* + * DIB driver + * + * Copyright 2007 Felix Nawothnig

Re: Patches / a proposal for the mystic DIB engine

2007-04-12 Thread Felix Nawothnig
Alexandre Julliard wrote: 2. Export LockDIBSection/Unlock to gdi32. Adding more exports is not nice but there really is no way around that, right? No, LockDIBSection is a driver internal detail, gdi32 has no business knowing about this. In my code the call to LockDIBSection serves two

Re: Add Windows Vista option to winecfg

2007-04-12 Thread Felix Nawothnig
Kovács András wrote: This patch is needed, because DirectX 10 is Vindows Vista only feature. Nothing wrong with adding Vista to the list but how is this needed? You don't want to disallow usage of dx10 unless Vista is selected, do you? Felix

ComboBoxEx focus bug

2005-04-26 Thread felix . nawothnig
Hi. I'm trying to fix PR 1114 and ran into the following problem: The listbox of WinRAR isn't updated because CBN_SELENDOK isn't sent. CBN_SELENDOK is supposed to be sent by CBRollUp() called by the LBN_SELCHANGE handler but isn't because the listbox (of the combobox) is already rolled up when

Re: Bug 2131 - 16-bit support?

2005-05-07 Thread Felix Nawothnig
On 05/08/2005 03:09:39 AM, Dustin Navea wrote: Basically, I just need to know for the purposes of resolving this bug, should I leave it open and confirmed so that someone knows to implement the 16-bit functions (32 - 16 bit conversions?), or should I just go ahead and close it as WONTFIX?

Re: Stable release builds with fixme output (Wine 20050310 debian sarge/testing)

2005-05-08 Thread Felix Nawothnig
On 05/07/2005 05:55:35 PM, J. Grant wrote: On 07/05/05 16:15, Paul van Schayck wrote: On 5/7/05, J. Grant [EMAIL PROTECTED] wrote: I typically launch applications using wine from the terminal, I get pages of these fixme debug messages. I wonder if there is a reason these fixme harmless messages

Re: ignore requested height for non-menubar ownerdraw popups

2005-05-08 Thread Felix Nawothnig
On 05/08/2005 12:25:18 PM, Rein Klazes wrote: That does not seem correct on the Win2k system that I am using for testing. Right. Windows sets itemHeight before and not after WM_MEASUREITEM. Sorry for that. And it also seems not to be GetSystemMetrics(SM_CYMENU)-1 but a rather strange magic

Re: ignore requested height for non-menubar ownerdraw popups

2005-05-08 Thread Felix Nawothnig
On 05/08/2005 04:21:46 PM, Rein Klazes wrote: About the magic number: I looked at the value on Win2k and WinME with different resolutions ( desktop-properties-settings, click on advanced tab and change what windows calls font size but is really changing the DPI, dots-per-inch, which is also

ERROR_NOT_READY (21) in ne_module.c

2005-05-08 Thread Felix Nawothnig
Since bug 2131 was closed I'll paste it here again: ne_module.c explicitly sets errorcode 21 (ERROR_NOT_READY) when ( LoadLibraryA()ing the owner of a 16bit dll failed or the search for the 16bit dll returned a real (.so) dll and not a symlink to the owner ) and trying to load a native

Re: ERROR_NOT_READY (21) in ne_module.c

2005-05-08 Thread Felix Nawothnig
(seems WD doesn't like being CCed? Resending...) Dustin Navea wrote: You can still comment to the bug even though it is closed. I know, but my question was neigher related to bug 2131 (it's just that it triggers the code in question) nor am I sure that the behaviour is wrong - the person who

Re: ERROR_NOT_READY (21) in ne_module.c

2005-05-09 Thread Felix Nawothnig
Dustin Navea wrote: You can still comment to the bug even though it is closed. I know, but my question was neigher related to bug 2131 (it's just that it triggers the code in question) nor am I sure that the behaviour is wrong - the person who wrote that line must have had something in his

Re: Menu with multi columns fix take 2

2005-05-10 Thread Felix Nawothnig
Rein Klazes wrote: +case WM_MEASUREITEM: How about an ok( ((MEASUREITEMSTRUCT*)lparam)-itemHeight 0, ... ) here? :) -flx

ExtTextOut() for paths

2005-05-10 Thread Felix Nawothnig
Hi. The attached patch implements ExtTextOut() for open paths. It seems to be working correctly for my tests but... well, the code I copied from xrender.c is a total mess IMHO. Calculating cell deltas and calculating the base line origin has to be done for all kind of TrueType rendering (and

Re: Software patents

2005-05-12 Thread Felix Nawothnig
gslink wrote: The easiest way to resolve this business with Borland is to contact Borland. They may also have an interest in Wine. If they have no objection to what Wine wants to do then there is no one else to complain. They might even help Wine. Borland probably doesn't even realize that

Re: Software patents

2005-05-12 Thread Felix Nawothnig
Jonathan Wilson wrote: Its highly likely that GCC and WINE are already infringing on some software patent somewhere (since its well nigh impossible not to in the current patent everything you can climate inside a number of big companies) What makes this particular borland patent any different?

Re: ERROR_NOT_READY (21) in ne_module.c

2005-05-12 Thread Felix Nawothnig
Alexandre Julliard wrote: Error 21 in LoadModule16 means that the file exists but is 32-bit, which seems to be the appropriate error in that case. I dunno about LoadModule16() (no means to test it since it's a Win16 function...) but for LoadLibrary16() (which is just a one-line wrapper around

Re: Make winelib resource data writeable

2005-05-16 Thread Felix Nawothnig
Dmitry Timoshkov wrote: For PE files there is a hack in kernel/except.c which does COW for resource data - but winelib apps crash when they try to write to it. (If this is a design-decision please tell me) As it's clearly indicated in the error message in kernel/except.c only broken apps try to

Re: Implement NtQuerySystemInformation(SystemTimeOfDayInformation)

2005-05-18 Thread Felix Nawothnig
Rein Klazes wrote: On Tue, 17 May 2005 23:06:51 +0200, you wrote: +RtlSystemTimeToLocalTime(sys_time, local_time); +/* liExpTimeZoneBias is not the same as tzi.Bias since it takes + * disabled DST correction into account (tested on WinXP). */ +

Re: Small fix for GetCurrentDirectoryA()

2005-06-10 Thread Felix Nawothnig
Andreas Mohr wrote: Does Win9x GetCurrentDirectoryA() really use an IsBadWritePtr to protect against invalid output buffers? Somehow I slightly doubt it... (IsBadWritePtr isn't the fastest thing in the world...) Well, no. Looking at the disassembly it does about this: static

Re: Small fix for GetCurrentDirectoryA()

2005-06-10 Thread Felix Nawothnig
(IsBadWritePtr isn't the fastest thing in the world...) Just looked at the implementation - it does at most (buflen-1)/pagesize+1 memory-references, and since buflen will be MAX_PATH in most cases this just costs us the calling-overhead - which is worth the increased readability. -flx

Re: wine and gdi+

2005-06-13 Thread Felix Nawothnig
Michael Büttner wrote: I was checking wine for GDI+ support and noticed that there are no headers or anything at all. I did not find any further information, so i guess there's no work being done there? Seems so. Might be related to the fact that it's not widely used yet and not shipped with

Re: wine and gdi+

2005-06-13 Thread Felix Nawothnig
Andreas Mohr wrote: AFAIR there used to be huge bitmap image insecurities in GDI+, thus Microsoft offered a tool on Windows Update which could scan your system for GDI+ apps that would need to be fixed. Maybe just get that tool and say hello to your selection of GDI+ apps... You mean GDIScan?

Re: [ntdll/tests/info.c] ProcessBasicInformation

2005-06-16 Thread Felix Nawothnig
Paul Vriens wrote: Changelog W2K3 returns STATUS_INVALID_HANDLE instead of STATUS_ACCESS_VIOLATION If no apps depends on it returning STATUS_ACCESS_VIOLATION - should we maybe do this too? Seems more clean to me since we don't actually catch page faults and passing (void*)1 will crash it

Re: WinelibVersion() [was: bit-blit ops]

2005-06-17 Thread Felix Nawothnig
cdr wrote: much appreciated, cdr Now... would you tell us what the misbehaviour in Wine is your application suffers from? Since bitblt isn't exactly rocket science this one should be easy to fix... (no?) Felix

Re: Bug in dlls/comctl32/comctl32undoc.c

2005-07-01 Thread Felix Nawothnig
Sascha Cunz wrote: In lines 1944 and 1977 of dlls/comctl32/comctl32undoc.c the value 0x7FFF is used to check for the boundary of a 32 bit integer. However, there should be used MAX_INT instead. I somehow doubt that this function will ever encounter an INT greater than MAX_INT... :) Anyway,

Re: Get FireFox button ?

2005-07-02 Thread Felix Nawothnig
Marcus Meissner wrote: Would anyone object to a Get FireFox button on our front page? I know I can send a patch and wait and see if there is objection to it. I just think its better to ask before hand. If there is NO objection ill send a patch in a couple days, or Jer can beat me to it ;)

Re: Bug in dlls/comctl32/comctl32undoc.c

2005-07-02 Thread Felix Nawothnig
First of all: I sent a new DPA testsuite to wine-patches some hours ago (http://tinyurl.com/ddlp4) which tests DPA_InsertPtr() with both (nItems idx 0x7fff) and (0x7fff idx). Our behaviour does not match Windows in both cases (besides several other differences). The tests are marked as

Re: Failure in gdi/tests/metafile.c

2005-07-03 Thread Felix Nawothnig
Uwe Bonnes wrote: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so metafile.c failes like: metafile.c:457: Test failed: (0,0)-(10,10), expected (0,0)-(18,67) metafile.c:457: Test failed: (0,0)-(10,10), expected (0,0)-(18,67) Some discussion on #winehackers

Re: Failure in gdi/tests/metafile.c

2005-07-04 Thread Felix Nawothnig
Robert Shearman wrote: I wrote the test, but I'm beginning to wish I hadn't. The failures are either one of two things: differences in when the transforms are updated in Win9x mode or possibly because it is too sensitive to the DPI of the screen. It's definitly not caused by differing DPIs

Re: Wrapping around stdcall

2005-07-05 Thread Felix Nawothnig
Marcus Meissner wrote: I wonder how I can do this cleaner (Meaning no compiler warnings without ugly hacks). Also I would like to know how to call a function like __thiscall_fnTextSrv_TxSendMessage, because some methods I need are implemented in windows' stdcall. And I would like to know wether

Re: Wrapping around stdcall

2005-07-05 Thread Felix Nawothnig
Marcus Meissner wrote: Adding thiscall to gcc would perhaps help in the long run ... :/ Fun fun fun... Considering that gcc already knows regparm and we just need regparm(1) with ecx instead eax hacking in thiscall for C code shouldn't be too hard I think. But since this would be a very

Re: Wrapping around stdcall

2005-07-05 Thread Felix Nawothnig
Marcus Meissner wrote: On second thought... What about abusing the regparm(3) attribute for this. It gets eax, edx, ecx, stackparam1, stackparam2, ... So what about using a construct like this (cloaked in some macros)? #define THISCALL0(name,this) __thiscall_#name(int unused_eax,int

Re: Wrapping around stdcall

2005-07-05 Thread Felix Nawothnig
Maarten Lankhorst wrote: It looks evil, and those functions are not exactly what I want, because I need them in a vtable, which requires them to be something like HRESULT ... fnTextServ_blah(ITextServices *iface, args), I could recast those functions, but that is not exactly a 'clean'

Re: [USER32] Zero out buffer in SYSPARAMS_Load

2005-07-06 Thread Felix Nawothnig
Dmitry Timoshkov wrote: Don't you think that your patch is a bit too large although the only thing it does is adding the only a single memset call? Please get rid of all not necessary formatting changes and resubmit. I did - about 5 minutes before you sent that mail. :) Felix

Re: Get FireFox button ?

2005-07-06 Thread Felix Nawothnig
Sijmen Mulder wrote: He's got a point there. The target audience is mostly the Linux user - which won't be using Internet Explorer anyways! I'd think that a large percentage of the people visiting WineHQ are using MSIE - even on Slashdot the vast majority of the viewers use it, although

Re: wine-devel -- confirmation of subscription -- request 548612 (wine-devel: message 1 of 1 -last one!-)

2005-07-07 Thread Felix Nawothnig
[EMAIL PROTECTED] wrote: I may be sending this to the wrong mailing list, if so my appologies. You are. Please file a bug report at http://bugs.winehq.org/ instead. Felix

Re: [Wine]june 2005 release and 'registry' ?

2005-07-08 Thread Felix Nawothnig
Brian Vincent wrote: What may not be obvious is the Applications tab in winecfg is tied to the other tabs. The current design is totally braindead from a usability standpoint: * As you pointed out it's not very intuitive that selecting an item in the first tab affects the semantics of the

Re: FWIW, news of SFU and wine

2005-07-10 Thread Felix Nawothnig
Wesley Parish wrote: I've installed MS SFU successfully. I can now use gcc under wine on Linux to compile source for Linux under wine on Linux ... ;) Are the SFU not implemented on top of ntdll? Considering that we don't even have NtCreateProcess it's hard to believe for me that it

Re: [Wine]june 2005 release and 'registry' ?

2005-07-10 Thread Felix Nawothnig
Sylvain Petreolle wrote: It seems that the native only choice doesnt work into winecfg - I tried to set one dll as 'Native(Windows)' and got native,builtin into the registry. Could you have a look for this ? Works fine for me... Felix

Re: Managementness of borderless windows

2005-07-10 Thread Felix Nawothnig
Stefan Dösinger wrote: Hello List, Wine has problems with Windows which don't have the WS_CAPTION flag set. These Windows are usually not managed, which leads to focus problems(no keyboard) and the window constantly stays on top. [...] Can anyone suggest a solution? How about fixing the

Re: Looking for a good disassembler

2005-07-10 Thread Felix Nawothnig
Nick Burns wrote: REC is an impressive free deCompiler (better than a simple disassembler) its based off of boomarang REC uses compiler dependend pattern matching which often fails miserably for modern code, it doesn't recognize a huge amount of i386 opcodes (even some i386 opcodes) and I've

Re: commctrl.h: Add WC_STATIC

2005-07-12 Thread Felix Nawothnig
Frank Richter wrote: +#define WC_STATICA Static +#if defined(__GNUC__) +# define WC_STATICW (const WCHAR []){ 'S','t','a', 't','i','c',0 } +#elif defined(_MSC_VER) +# define WC_STATICW LStatic +#else +static const WCHAR WC_STATICW[] = { 'S','t','a','t','i','c',0 }; +#endif +#define WC_STATIC

Re: commctrl.h: Add WC_STATIC

2005-07-12 Thread Felix Nawothnig
Dmitry Timoshkov wrote: +#define WC_STATICA Static +#if defined(__GNUC__) +# define WC_STATICW (const WCHAR []){ 'S','t','a', 't','i','c',0 } +#elif defined(_MSC_VER) +# define WC_STATICW LStatic +#else +static const WCHAR WC_STATICW[] = { 'S','t','a','t','i','c',0 }; +#endif +#define WC_STATIC

  1   2   >