Re: msi: Fix a couple of leaks (coverity)

2012-11-16 Thread Hans Leidekker
On Fri, 2012-11-16 at 11:50 +0100, Frédéric Delanoy wrote: diff --git a/dlls/msi/files.c b/dlls/msi/files.c index 11913ef..98d7513 100644 --- a/dlls/msi/files.c +++ b/dlls/msi/files.c @@ -336,6 +336,7 @@ UINT ACTION_InstallFiles(MSIPACKAGE *package) if (rc != ERROR_SUCCESS)

Re: [1/2] schannel/tests: Fix test on win8

2012-12-06 Thread Hans Leidekker
On Thu, 2012-12-06 at 12:56 +0100, André Hentschel wrote: diff --git a/dlls/schannel/tests/main.c b/dlls/schannel/tests/main.c index b576848..9c28e8b 100644 --- a/dlls/schannel/tests/main.c +++ b/dlls/schannel/tests/main.c @@ -179,8 +179,8 @@ static void testGetInfo(void) /* First

Re: msi: Fix logical expressions that always evaluate to FALSE

2012-12-10 Thread Hans Leidekker
On Sat, 2012-12-08 at 21:59 +, Andrew Talbot wrote: diff --git a/dlls/msi/action.c b/dlls/msi/action.c index 076d1b3..677a43f 100644 --- a/dlls/msi/action.c +++ b/dlls/msi/action.c @@ -6763,7 +6763,7 @@ static UINT ACTION_RemoveODBC( MSIPACKAGE *package ) #define ENV_MOD_PREFIX

Re: wininet: Don't perform revocation checks when verifying a certificate.

2012-12-11 Thread Hans Leidekker
On Tue, 2012-12-11 at 14:52 +0100, Jacek Caban wrote: On 12/11/12 09:45, Hans Leidekker wrote: https://testbot.winehq.org/JobDetails.pl?Key=23300 is a test which shows that revocation checks fail for the certificate on outlook.com when passed straight to CertVerifyRevocation

Re: wininet: Don't perform revocation checks when verifying a certificate.

2012-12-11 Thread Hans Leidekker
On Tue, 2012-12-11 at 11:52 -0800, Juan Lang wrote: On Tue, Dec 11, 2012 at 6:10 AM, Hans Leidekker h...@codeweavers.com wrote: On Tue, 2012-12-11 at 14:52 +0100, Jacek Caban wrote: On 12/11/12 09:45, Hans Leidekker wrote: https://testbot.winehq.org/JobDetails.pl?Key

Re: wininet: Don't perform revocation checks when verifying a certificate.

2012-12-12 Thread Hans Leidekker
On Tue, 2012-12-11 at 12:59 -0800, Juan Lang wrote: Getting the client to trust the server cert can be as easy as ignoring untrusted root errors, if you don't think this impacts the revocation results. Returning revocation is straightforward enough, assuming you have a server under your

Re: wininet: Map socket errors to ERROR_INTERNET_CANNOT_CONNECT in create_netconn_socket.

2012-12-19 Thread Hans Leidekker
On Wed, 2012-12-19 at 12:25 +0100, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at

Re: [PATCH 6/8] winhttp: Added schannel-based netconn_get_cipher_strength implementation

2013-01-22 Thread Hans Leidekker
On Tue, 2013-01-22 at 16:49 +0100, Jacek Caban wrote: @@ -1460,6 +1460,13 @@ int netconn_get_cipher_strength( netconn_t *conn ) pSSL_CIPHER_get_bits( cipher, bits ); return bits; #else -return 0; +SecPkgContext_ConnectionInfo conn_info; +SECURITY_STATUS res; + +

Re: windowscodecs: Implement GetThumbnail in the ICO frame decoder.

2013-01-30 Thread Hans Leidekker
On Wed, 2013-01-30 at 18:02 +0800, Dmitry Timoshkov wrote: diff --git a/dlls/windowscodecs/icoformat.c b/dlls/windowscodecs/icoformat.c index 7aec245..da5a733 100644 --- a/dlls/windowscodecs/icoformat.c +++ b/dlls/windowscodecs/icoformat.c @@ -200,8 +200,12 @@ static HRESULT WINAPI

Re: windowscodecs: Implement GetThumbnail in the ICO frame decoder.

2013-01-30 Thread Hans Leidekker
On Wed, 2013-01-30 at 18:52 +0800, Dmitry Timoshkov wrote: The test added by 6395af1ae7b0cc5f2f1f82796502e2a605bc5a6b says otherwise, GetThumbnail is supported for ICO frames. It's still better to return WINCODEC_ERR_CODECNOTHUMBNAIL instead of E_INVALIDARG. Real implementation depends

Re: fusion: Allow null to be the value of the public key

2013-01-31 Thread Hans Leidekker
On Thu, 2013-01-31 at 19:35 +1100, Alistair Leslie-Hughes wrote: diff --git a/dlls/fusion/asmname.c b/dlls/fusion/asmname.c index 162a76b..2c4b379 100644 --- a/dlls/fusion/asmname.c +++ b/dlls/fusion/asmname.c @@ -561,6 +561,10 @@ static HRESULT parse_pubkey(IAssemblyNameImpl *name, LPCWSTR

Re: [4/4] windowscodecs: Implement IWICComponentFactory::CreateDecoderFromFileHandle.

2013-02-06 Thread Hans Leidekker
On Wed, 2013-02-06 at 10:25 -0600, Vincent Povirk wrote: +hr = map_file(file, map, mem, size); +if (FAILED(hr)) return hr; + ... + +hr = IWICStreamImpl_InitializeFromMemory(stream, mem, size.u.LowPart); +if (FAILED(hr)) goto error; This makes me sad. Is this

Re: [1/4] windowscodecs: Implement IWICColorContext::InitializeFromFilename.

2013-02-06 Thread Hans Leidekker
On Wed, 2013-02-06 at 18:10 +0100, Ludger Sprenker wrote: On Wed, 06 Feb 2013 13:51:32 +0100, Hans Leidekker wrote: + handle = CreateFileW(filename, GENERIC_READ, 0, NULL, OPEN_EXISTING, 0, NULL); + if (handle == INVALID_HANDLE_VALUE) return HRESULT_FROM_WIN32(GetLastError

Re: webservices: Add new dll

2013-02-21 Thread Hans Leidekker
On Thu, 2013-02-21 at 18:47 +1100, Alistair Leslie-Hughes wrote: +#include wine/debug.h + +WINE_DEFAULT_DEBUG_CHANNEL(wincodecs); That channel is already taken :)

Re: wbemprox: Implement some properties of Win32_ComputerSystem and Win32_DiskPartition.

2013-04-08 Thread Hans Leidekker
On Mon, 2013-04-08 at 01:56 +0900, Kim Jung Eon (김중언) wrote: @@ -241,18 +243,21 @@ static const struct column col_compsys[] = { prop_modelW,CIM_STRING }, { prop_numlogicalprocessorsW, CIM_UINT32, VT_I4 }, { prop_numprocessorsW,CIM_UINT32, VT_I4 }, -{

Re: [PATCH 2/2] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

2013-05-01 Thread Hans Leidekker
On Wed, 2013-05-01 at 12:40 +0200, Christian Costa wrote: diff --git a/dlls/msi/media.c b/dlls/msi/media.c index 612624d..4145c76 100644 --- a/dlls/msi/media.c +++ b/dlls/msi/media.c @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet(FDINOTIFICATIONTYPE fdint, if (strcmpiW(

Re: [PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify.

2013-05-07 Thread Hans Leidekker
On Mon, 2013-05-06 at 19:23 -0600, Erich E. Hoover wrote: --- a/dlls/iphlpapi/iphlpapi_main.c +++ b/dlls/iphlpapi/iphlpapi_main.c @@ -210,8 +210,14 @@ DWORD WINAPI AllocateAndGetIpAddrTableFromStack(PMIB_IPADDRTABLE *ppIpAddrTable, */ BOOL WINAPI CancelIPChangeNotify(LPOVERLAPPED

Re: [PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify.

2013-05-07 Thread Hans Leidekker
On Tue, 2013-05-07 at 10:04 -0600, Erich E. Hoover wrote: On Tue, May 7, 2013 at 3:14 AM, Hans Leidekker h...@codeweavers.com wrote: ... TerminateThread is not the right tool here. If the thread is blocked on the recv call while being terminated it will leak the netlink socket. You'd

Re: [PATCH] mscms: Use lcms2, when available

2013-05-09 Thread Hans Leidekker
On Thu, 2013-05-09 at 18:56 +0200, wine@web.de wrote: Hi Hans. lcms2 was released on 8. May 2010 lcms v1 is on the way to be phased out in the newest distribution versions. Are there any distributions that have released without v1? I don't know, but Ubuntu has a bug for

Re: [PATCH] mscms: Use lcms2, when available

2013-05-10 Thread Hans Leidekker
On Fri, 2013-05-10 at 02:05 +0200, Detlef Riekenberg wrote: For most apps it will be a matter of adding a configure check for lcms2 and then recompiling. This is not the case for Wine as you have pointed out. - cmsCreateLabProfile was renamed to cmsCreateLab2Profile cmsvirt.c (1.19: 570)

Re: [PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify.

2013-05-10 Thread Hans Leidekker
On Wed, 2013-05-08 at 15:34 -0600, Erich E. Hoover wrote: +#ifdef HAVE_LINUX_NETLINK_H +# include linux/netlink.h +#endif +#ifdef HAVE_LINUX_RTNETLINK_H +# include linux/rtnetlink.h +#endif + +#ifdef NLMSG_OK +# define WINE_LINKMON_FAMILY PF_NETLINK +# define WINE_LINKMON_TYPE

Re: [PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify.

2013-05-10 Thread Hans Leidekker
On Fri, 2013-05-10 at 08:00 -0600, Erich E. Hoover wrote: On Fri, May 10, 2013 at 3:48 AM, Hans Leidekker h...@codeweavers.com wrote: On Wed, 2013-05-08 at 15:34 -0600, Erich E. Hoover wrote: ... +#ifdef NLMSG_OK +# define WINE_LINKMON_FAMILY PF_NETLINK +# define

Re: [PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify.

2013-05-13 Thread Hans Leidekker
On Fri, 2013-05-10 at 20:07 -0600, Erich E. Hoover wrote: +/*** + * IPHLPAPI_createmonitorhandle (INTERNAL) + * + * Routine to create the interface monitoring handle for NotifyAddrChange requests. + */

Re: [PATCH] winhttp: initialize schemes (Coverity) (resubmit)

2013-05-28 Thread Hans Leidekker
On Tue, 2013-05-28 at 22:46 +0200, Marcus Meissner wrote: 1020943 Uninitialized scalar variable schemes is |= in the called function, but not initialized before. Was submitted 2 weeks ago already, I think it is good. It's good but query_auth_schemes is called from more places, so it

Re: [1/2] explorer: Initial implementation of desktop launchers.

2013-05-31 Thread Hans Leidekker
On Fri, 2013-05-31 at 03:30 +0800, Qian Hong wrote: On Tue, May 28, 2013 at 6:42 PM, Hans Leidekker h...@codeweavers.com wrote: +hr = SHGetKnownFolderPath( FOLDERID_Desktop, 0, NULL, desktop_folder ); +if (FAILED( hr )) +{ +WINE_ERR(Could not get user desktop folder

Re: [PATCH] mscms: Use lcms2, when available [try 2]

2013-06-03 Thread Hans Leidekker
On Sun, 2013-06-02 at 22:49 +0200, Detlef Riekenberg wrote: try2: import the unchanged icc34.h from the lcms (v1) dev. package. (Do we need to add a Wine LGPL licence header for icc34.h?) The plan is to remove this include, when changing Wine to use the new getter/setter functions of lcms2

Re: mscms: Use lcms2, when available [try 2]

2013-06-04 Thread Hans Leidekker
On Tue, 2013-06-04 at 00:48 +0200, Detlef Riekenberg wrote: Hans, you found a way to change Wine to use getter/setter functions while still linking to lcms v1 and than switch to lcms2? No, I'm not interested in doing that.

Re: [Lcms-user] mscms: Use lcms2, when available [try 2]

2013-06-04 Thread Hans Leidekker
On Tue, 2013-06-04 at 01:36 +0200, Marti Maria wrote: (specifically cmsReadRawTag and cmsWriteRawTag don't do what we want), Ops, so I did something wrong. These functions were in the API to implement mscms and JDK APIs. Could you please elaborate what the issue is? They don't allow

Re: wbemprox: Implement some properties of Win32_BIOS. (resend 4)

2013-06-24 Thread Hans Leidekker
On Sat, 2013-06-22 at 12:17 +0900, Kim Jung Eon (김중언) wrote: static const struct column col_bios[] = { +{ prop_biosversionW, CIM_STRING|CIM_FLAG_ARRAY}, { prop_descriptionW, CIM_STRING }, { prop_manufacturerW, CIM_STRING }, { prop_releasedateW, CIM_DATETIME }, @@

Re: wbemprox: Implement Win32_OperatingSystem.LocalDateTime.

2013-06-24 Thread Hans Leidekker
On Sun, 2013-06-23 at 18:55 +0200, Sylvain Petreolle wrote: +static WCHAR *get_localdatetime(void) +{ +static const WCHAR fmtW[] = + {'%','0','4','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u', + '.','%','0','6','u','+','0','0','0',0};

Re: [PATCH]winhttp:session.c fix a bug(return value is null)

2013-06-24 Thread Hans Leidekker
On Mon, 2013-06-24 at 19:57 +0900, 中川祥 wrote: diff --git a/dlls/winhttp/session.c b/dlls/winhttp/session.c index 660eae5..dfe23d4 100644 --- a/dlls/winhttp/session.c +++ b/dlls/winhttp/session.c @@ -1316,6 +1316,8 @@ BOOL WINAPI WinHttpDetectAutoProxyConfigUrl( DWORD flags, LPWSTR *url )

Re: [wbemprox] Patches for adding currentclockspeed in record_processor

2013-07-01 Thread Hans Leidekker
On Mon, 2013-07-01 at 08:56 +0900, Rosen Diankov wrote: diff -ru wine-1.6-rc3-old/dlls/wbemprox/builtin.c wine-1.6-rc3/dlls/wbemprox/builtin.c --- wine-1.6-rc3-old/dlls/wbemprox/builtin.c2013-06-22 03:24:01.0 +0900 +++ wine-1.6-rc3/dlls/wbemprox/builtin.c2013-06-27

Re: [wbemprox] Patches for adding currentclockspeed in record_processor

2013-07-02 Thread Hans Leidekker
On Mon, 2013-07-01 at 18:08 +0900, Rosen Diankov wrote: you are right, i'm attaching a new patch. You didn't address all comments.

Re: [wbemprox] Patches for adding currentclockspeed in record_processor

2013-07-03 Thread Hans Leidekker
On Tue, 2013-07-02 at 20:34 +0900, Rosen Diankov wrote: you are right again, i'll be more careful. now, i've addressed every problem except creating the patches with git. any help would be appreciated. See http://wiki.winehq.org/GitWine --- wine-1.6-rc4-old/dlls/wbemprox/builtin.c

Re: Is it a little bug in wbemprox?

2013-08-10 Thread Hans Leidekker
On Sat, 2013-08-10 at 15:55 +0800, Jing Li wrote: Hi, When I ran a simple win32 program just via WMI with query of SELECT * from Win32_Directory, wine1.6 crashed. And when I checked the related code I found that the function of static UINT seed_dirs( struct dirstack *dirstack, const struct

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-28 Thread Hans Leidekker
On Wed, 2013-08-28 at 11:41 +0200, Ralf Habacker wrote: diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec index 36ba13f..cad2ca9 100644 --- a/dlls/iphlpapi/iphlpapi.spec +++ b/dlls/iphlpapi/iphlpapi.spec @@ -6,6 +6,7 @@ @ stdcall AllocateAndGetIpForwardTableFromStack(

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-28 Thread Hans Leidekker
On Wed, 2013-08-28 at 12:21 +0200, Ralf Habacker wrote: diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec index 36ba13f..1eed5ae 100644 --- a/dlls/iphlpapi/iphlpapi.spec +++ b/dlls/iphlpapi/iphlpapi.spec @@ -6,6 +6,7 @@ @ stdcall AllocateAndGetIpForwardTableFromStack(

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-28 Thread Hans Leidekker
On Wed, 2013-08-28 at 14:49 +0200, Ralf Habacker wrote: diff --git a/dlls/iphlpapi/ipstats.h b/dlls/iphlpapi/ipstats.h index bf5bb92..efdb1cc 100644 --- a/dlls/iphlpapi/ipstats.h +++ b/dlls/iphlpapi/ipstats.h @@ -33,6 +33,7 @@ DWORD getInterfaceStatsByName(const char *name,

Re: wininet: Don't start the next chunk if the read is satisfied.

2013-09-04 Thread Hans Leidekker
On Wed, 2013-09-04 at 13:11 +0200, Jacek Caban wrote: On 09/04/13 09:22, Hans Leidekker wrote: --- dlls/wininet/http.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 1832b4f..521e4aa 100644 --- a/dlls/wininet

Re: [2/2] rpcrt4: Clear the connection pool when closing an http connection.

2013-09-04 Thread Hans Leidekker
On Wed, 2013-09-04 at 15:28 +0200, Jacek Caban wrote: On 09/04/13 15:01, Hans Leidekker wrote: --- dlls/rpcrt4/rpc_transport.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c index d0857fa..1eb0151 100644 --- a/dlls

Re: [2/2] rpcrt4: Clear the connection pool when closing an http connection.

2013-09-04 Thread Hans Leidekker
On Wed, 2013-09-04 at 18:16 +0200, Jacek Caban wrote: On 09/04/13 15:36, Hans Leidekker wrote: On Wed, 2013-09-04 at 15:28 +0200, Jacek Caban wrote: On 09/04/13 15:01, Hans Leidekker wrote: + /* don't allow this connection to be reused */ + InternetSetOptionW(NULL

Re: wininet: Don't assume that end of chunk means end of stream.

2013-09-11 Thread Hans Leidekker
On Wed, 2013-09-11 at 16:38 +0200, Jacek Caban wrote: Hi Hans, On 09/11/13 13:50, Hans Leidekker wrote: static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t *req) { -/* Allow reading only from read buffer */ +chunked_stream_t *chunked_stream

Re: wininet: Don't assume that end of chunk means end of stream.

2013-09-11 Thread Hans Leidekker
On Wed, 2013-09-11 at 17:53 +0200, Jacek Caban wrote: Network traces tell me that native also performs a read on the first call to InternetQueryDataAvailable. Are you sure it's not an asynchronous read from a separated thread that is ordered by InternetQueryDataAvailable if no data is

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)

2013-09-23 Thread Hans Leidekker
On Thu, 2013-09-19 at 17:38 +0200, Jacek Caban wrote: I was hoping for a test like the attached one, which shows that there is still more work to do. But it's a step in the right direction, so I'm fine with your patch. The issue here is that HTTP_ReceiveRequestData calls refill_read_buffer,

Re: [3/3] ws2_32: Always return the source address from WSAAccept.

2013-10-01 Thread Hans Leidekker
On Tue, 2013-10-01 at 09:32 -0300, Bruno Jesus wrote: On Tue, Oct 1, 2013 at 6:37 AM, Hans Leidekker h...@codeweavers.com wrote: --- dlls/ws2_32/socket.c | 9 + dlls/ws2_32/tests/sock.c | 6 +++--- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/dlls/ws2_32

<    1   2   3   4   5   6