Re: Problems unveiled by the last version.c patch

2004-12-17 Thread Paul Vriens
Hi Dmitry, [EMAIL PROTECTED] wrote: trace:shell:SHELL_GetPathFromIDListA -- F:\temp, 0x ... trace:shell:SHGetPathFromIDListW -- LF:\\temp, 0x The main difference (apart from the A/W) is that SHGetPathFromIDListW returns an extra backslash compared to the A-counterpart.

Re: Problems unveiled by the last version.c patch

2004-12-17 Thread Paul Vriens
Hi Rein, SHGetPathFromIDList seems to be the wrong one here (looking at native shell32.dll from Win2K and Win98), it should be synonymous for SHGetPathFromIDListA. Can you try attached patch? Rein. This fixes my problem. I've cross-checked and indeed SHGetPathFromIDList should be

Version Detection (this time for dcom98.exe)

2004-12-18 Thread Paul Vriens
Hi, one of the first things I normally do after a fresh wine install is installing dcom98. This wasn't a problem before (use the correct overrides). Just tell me if I don't need this (anymore). Installing dcom98 with the current version checking is a different ballgame. Just running it with

Changed files to use interlocked functions

2005-01-04 Thread Paul Vriens
Hi, the Janitorial page shows that the Use Interlocked functions in AddRef and Release methods project is finished. There are however several files (at least 135) that still use the non-interlocked method. Especially ddraw, d3*, dm*, avifil32 and some ole/oleaut32. Do they still need to be

Re: Changed files to use interlocked functions

2005-01-04 Thread Paul Vriens
Hi Mike, Paul Vriens wrote: the Janitorial page shows that the Use Interlocked functions in AddRef and Release methods project is finished. There are however several files (at least 135) that still use the non-interlocked method. Especially ddraw, d3*, dm*, avifil32 and some ole/oleaut32

Re: [QUARTZ] Use Interlocked* functions in AddRef and Release (RESEND)

2005-01-04 Thread Paul Vriens
On Tue, 2005-01-04 at 21:48, Alexandre Julliard wrote: Paul Vriens [EMAIL PROTECTED] writes: TRACE((%p)-()\n, iface); -if (!--This-refCount) +if (!InterlockedDecrement(This-refCount)) { CoTaskMemFree(This-ppFilters); CoTaskMemFree(This); You

[QUARTZ] Fixes to regsvr.c (RESEND)

2005-01-05 Thread Paul Vriens
(and Extensions) should use Source Filter instead of File Source - Removed filesource_valuename - Fixed typo for some class-names - Fixed typo in MPEG1System Media Type Cheers, Paul Vriens. Index: dlls/quartz/regsvr.c === RCS file

Re: Correction to COINIT_MULTITHREADED test

2005-01-10 Thread Paul Vriens
On Mon, 2005-01-10 at 21:20, Bill Medland wrote: Bill Medland ([EMAIL PROTECTED]) Correct testing for multithreaded (as spotted by Paul Vriens; fix suggested by Robert Shearman) Hi Bill, it wasn't the check that was way over my head. The thing is, that with this code change we walk a new

ole32: questions about the COINIT flags

2005-01-11 Thread Paul Vriens
Hi, I was looking through some MSDN doc: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/com/htm/cmf_a2c_5iyg.asp there it's stated that: If neither concurrency model is specified by the dwCoInit parameter, the default is COINIT_MULTITHREADED. Does this mean we should change

Re: Correction to COINIT_MULTITHREADED test

2005-01-11 Thread Paul Vriens
On Tue, 2005-01-11 at 12:19, Christian Costa wrote: All the time ? Looking at COM_CreateApartment it seems COINIT_APARTMENTTHREADED works but indeed COINIT_MULTITHREADED always return NULL. I think the code at the beginning of COM_CreateApartment is wrong. TRACE(thread 0x%lx is

Re: Correction to COINIT_MULTITHREADED test

2005-01-11 Thread Paul Vriens
On Tue, 2005-01-11 at 12:19, Christian Costa wrote: All the time ? Looking at COM_CreateApartment it seems COINIT_APARTMENTTHREADED works but indeed COINIT_MULTITHREADED always return NULL. I think the code at the beginning of COM_CreateApartment is wrong. TRACE(thread 0x%lx

[AVIFIL32] question about ACMStream_fn[AddRef|Release] in acmstream.c

2005-01-11 Thread Paul Vriens
Hi, during my code cleanup I came to acmstream.c and found the following: static ULONG WINAPI ACMStream_fnAddRef(IAVIStream *iface) { IAVIStreamImpl *This = (IAVIStreamImpl *)iface;

Re: [AVIFIL32] question about ACMStream_fn[AddRef|Release] in acmstream.c

2005-01-11 Thread Paul Vriens
Hi Michael, I don't really know what you want to cleanup here, looks very clean to me. The cleanup I'm currently working on is changing This-ref[++|--] and friends into Interlocked * functions for thread safety (see Janitorial page on WineHQ). You are right, the release method is buggy. the

Re: [AVIFIL32] question about ACMStream_fn[AddRef|Release] in acmstream.c

2005-01-12 Thread Paul Vriens
One question remains though, what do I do with: /* also release reference to the nested stream */ if (This-pStream != NULL) IAVIStream_Release(This-pStream); should this be done regardless of the value of This-ref ? Hi Michael, forget the question. I just saw that the above is

Janitorial : check all refcounts in Wine?

2005-01-12 Thread Paul Vriens
Hi, for the described Janitorial task 'Use Interlocked functions in AddRef and Release methods' I'm currently looking at This-ref. If I however do a wider search I find a bit more, for example: kernel/atom.c:256: entryPtr-refCount++; msi/handle.c:188:ret =

The use of a zero flag

2005-01-12 Thread Paul Vriens
Hi, a few days ago I found a bug in ole32/compobj.c where we did something like: if ( foo FLAG) where FLAG=0 This 'inspired' me to check for more of these kind of checks. One that I already found is in dlls/dplayx/dplay.c We are checking for DPSET_REMOTE (which is zero) where we should

[COMCTL32] The use of the PGS_VERT flag

2005-01-12 Thread Paul Vriens
Hi, the flag PGS_VERT is zero and should not be checked against. It's only the lack of PGS_HORZ that should be checked. Is the following piece of code needed in dll//comctl32/pager.c: 851 if (!(dwStyle PGS_HORZ) !(dwStyle PGS_VERT)) 852 { 853 dwStyle |= PGS_VERT;

NOTIFY_PRE and NOTIFY_POST definitions in include files

2005-01-13 Thread Paul Vriens
Hi, just found the following: [EMAIL PROTECTED] include]$ grep -e NOTIFY_PRE -e NOTIFY_POST * netspi.h:#define NOTIFY_PRE 0x00 netspi.h:#define NOTIFY_POST 0x01 npapi.h:#define NOTIFY_PRE 0x0001 npapi.h:#define NOTIFY_POST 0x0002 this doesn't look right

[DPLAYX] Get rid of check for DPSET_REMOTE in dplayx.c

2005-01-13 Thread Paul Vriens
Hi, as DPSET_REMOTE is 0 we cannot check for it, like it's currently done in dplayx.c: if( dwFlags DPSET_REMOTE ) we have to use some other method. As DPSET_REMOTE and DPSET_LOCAL (which is 1) are mutually exclusive we could do: if (!(dwFlags DPSET_LOCAL)) { } or if (dwFlags DPSET_LOCAL)

Running dxdiag

2005-01-13 Thread Paul Vriens
Hi, I was trying to run dxdiag (just for the fun of it). Dxdiag complains that it cannot find any dll. This is correct because what it does is check the directories in the Path. The dll's are of course not present on a clean install as all are builtin. Loading a dll takes care of this by

Re: listview: fix alignment tests

2005-01-14 Thread Paul Vriens
Dimitrie O. Paun wrote: ChangeLog Use the LVCFMT_{LEFT,RIGHT,CENTER} enumeration flags properly. /* set text alignment (leftmost column must be left-aligned) */ -if (nColumn == 0 || lpColumn-fmt LVCFMT_LEFT) +if (nColumn == 0 || (lpColumn-fmt LVCFMT_JUSTIFYMASK)

Re: [7/7] setupapi/tests: start dialog.c test file with a test for SetupPromptForDiskA

2009-02-22 Thread Paul Vriens
Ricardo Filipe wrote: Hi, Could you turn that skip() into a win_skip()? Usually it's a good idea to do a SetLastError(0xdeadbeef or something like that) before calling the function, especially because you are

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

2009-02-23 Thread Paul Vriens
Nicolas Le Cam wrote: 2009/2/23 Francois Gouget fgou...@free.fr: On Sun, 22 Feb 2009, Nicolas Le Cam wrote: This avoid a messagebox in regression tests on systems that don't have GdiPlus. This seems wrong because winetest.exe is already supposed to check for missing dlls. If I remember

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

2009-02-23 Thread Paul Vriens
Nicolas Le Cam wrote: 2009/2/23 Paul Vriens paul.vriens.w...@gmail.com: Nicolas Le Cam wrote: 2009/2/23 Francois Gouget fgou...@free.fr: On Sun, 22 Feb 2009, Nicolas Le Cam wrote: This avoid a messagebox in regression tests on systems that don't have GdiPlus. This seems wrong because

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

2009-02-24 Thread Paul Vriens
Vincent Povirk wrote: On Mon, Feb 23, 2009 at 6:15 AM, Paul Vriens paul.vriens.w...@gmail.com wrote: The reason you see this is because next to a normal LoadLibrary we also use the .NET variant. On some boxes gdiplus.dll cannot be found through LoadLibrary but will trough LoadLibraryShim

Re: [programs/winetest] Extend PATH if we have dll's that only come with .NET

2009-02-24 Thread Paul Vriens
Nicolas Le Cam wrote: 2009/2/24 Paul Vriens paul.vriens.w...@gmail.com: Hi, This makes sure that if we have a dll that's only provided via .NET it can still be found. Now both our extraction (and the generation of the subtest list) and the real test will find the dll. The downside

Re: [2/2] WineD3D: Create a common sampling function in GLSL

2009-02-24 Thread Paul Vriens
Stefan Dösinger wrote: You forgot the patch ;) -- Cheers, Paul.

Re: [programs/winetest] Extend PATH if we have dll's that only come with .NET (Try2)

2009-02-25 Thread Paul Vriens
Nicolas Le Cam wrote: Hi Paul, minor comments : +static void append_path( const char *path) +{ +char *newpath; + +newpath = xmalloc(strlen(curpath) + 1 + strlen(path) + 1); +strcpy(newpath, curpath); +strcat(newpath, ;); +strcat(newpath, path); +

Re: [programs/winetest] Extend PATH if we have dll's that only come with .NET (Try2)

2009-02-25 Thread Paul Vriens
Nicolas Le Cam wrote: + +/* We have a dll that cannot be found through LoadLibraryExA. This + * is the case for .NET provided dll's. We will add the directory + * where the dll resides to the PATH variable when dealing with + * the tests for

Re: crypt32: Fix more test failures on Win9x

2009-02-25 Thread Paul Vriens
Juan Lang wrote: --Juan Hi Juan, The first 4 changes are not correct. Win9x returns TRUE (1) here. -- Cheers, Paul.

Re: crypt32: Fix more test failures on Win9x

2009-02-25 Thread Paul Vriens
Paul Vriens wrote: Juan Lang wrote: --Juan Hi Juan, The first 4 changes are not correct. Win9x returns TRUE (1) here. Well actually the first two on Win95 and the last two on Win95/Win98. -- Cheers, Paul.

Re: fusion/tests: Fix tests for .NET 1.x

2009-03-01 Thread Paul Vriens
Ge van Geldorp wrote: Changelog: fusion/tests: Fix tests for .NET 1.x --- dlls/fusion/tests/asmname.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/dlls/fusion/tests/asmname.c b/dlls/fusion/tests/asmname.c index 98004ea..0ea7aa8 100644 ---

Re: kernel32/tests: Mark debugger test broken for Win9x and WinME behavior

2009-03-02 Thread Paul Vriens
Drew Ronneberg wrote: Hi, Could you change those magic constants? (defined in winerror.h and winbase.h): #define ERROR_WAIT_NO_CHILDREN 128 () #define WAIT_FAILED 0x -- Cheers, Paul.

Re: kernel32/tests: Mark debugger test broken for Win9x and WinME behavior

2009-03-02 Thread Paul Vriens
Paul Vriens wrote: Drew Ronneberg wrote: Hi, Could you change those magic constants? (defined in winerror.h and winbase.h): #define ERROR_WAIT_NO_CHILDREN 128 () #define WAIT_FAILED 0x Oh

Re: kernel32/tests: Mark debugger test broken for Win9x and WinME behavior

2009-03-02 Thread Paul Vriens
Paul Vriens wrote: Paul Vriens wrote: Drew Ronneberg wrote: Hi, Could you change those magic constants? (defined in winerror.h and winbase.h): #define ERROR_WAIT_NO_CHILDREN 128 () #define WAIT_FAILED

Re: ole32/tests: Add a few CoGetMalloc tests.

2009-03-03 Thread Paul Vriens
Rob Shearman wrote: 2009/3/3 Huw Davies h...@codeweavers.com: diff --git a/dlls/ole32/tests/compobj.c b/dlls/ole32/tests/compobj.c index a332d27..9720e52 100644 --- a/dlls/ole32/tests/compobj.c +++ b/dlls/ole32/tests/compobj.c @@ -1162,6 +1162,28 @@ static void test_CoInitializeEx(void)

Re: ole32/tests: Add a few CoGetMalloc tests.

2009-03-03 Thread Paul Vriens
Paul Vriens wrote: Rob Shearman wrote: 2009/3/3 Huw Davies h...@codeweavers.com: diff --git a/dlls/ole32/tests/compobj.c b/dlls/ole32/tests/compobj.c index a332d27..9720e52 100644 --- a/dlls/ole32/tests/compobj.c +++ b/dlls/ole32/tests/compobj.c @@ -1162,6 +1162,28 @@ static void

Re: New test failures (out of the blue?)

2009-03-04 Thread Paul Vriens
Reece Dunn wrote: 2009/3/4 Paul Vriens paul.vriens.w...@gmail.com: Hi, We suddenly have a new test failure on NT4 and above for advapi32:security : security.c:1202: Test failed: GetTokenInformation failed with error 998 998 = ERROR_NOACCESS -- Invalid access to memory location. Google

Re: [shell32/tests] Don't crash on Win95

2009-03-04 Thread Paul Vriens
On Wed, Mar 4, 2009 at 5:45 PM, Paul Vriens paul.vriens.w...@gmail.com wrote: Hi, For whatever reason Win95 was always failing this test with i greater than 5 and now it's less than 5 (since yesterday!). This will crash as the rest of the tests rely on that exact number (we have 5 files

Re: [programs/winetest] Show dll versions again for Win9x/WinME

2009-03-05 Thread Paul Vriens
Paul Vriens wrote: Hi, GetModuleFileNameA should not work on dlls loaded using LOAD_LIBRARY_AS_DATAFILE according to MSDN. This happens to be only true for Win9x/WinME (sigh) otherwise we probably would have noted this much earlier. As of Feb-3-2009 we didn't have version numbers

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (6)

2009-03-06 Thread Paul Vriens
Andreas Rosenberg wrote: Hi, Error during compilation: userenv_main.c:181: warning: passing argument 1 of ‘GetUserNameW’ from incompatible pointer type Shouldn't that line be: res = GetUserNameW( userName,

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (6)

2009-03-06 Thread Paul Vriens
Paul Vriens wrote: Paul Vriens wrote: Andreas Rosenberg wrote: Hi, Error during compilation: userenv_main.c:181: warning: passing argument 1 of ‘GetUserNameW’ from incompatible pointer type Shouldn't that line

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (6)

2009-03-06 Thread Paul Vriens
Paul Vriens wrote: Andreas Rosenberg wrote: Hi, Error during compilation: userenv_main.c:181: warning: passing argument 1 of ‘GetUserNameW’ from incompatible pointer type Shouldn't that line be: res

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (7)

2009-03-06 Thread Paul Vriens
Andreas Rosenberg wrote: It's quite common for these functions to check for the needed buffersize when buffer=NULL and size=0 is passed. I did a quick check on W2K3 and this is what is returned: sizePath = 0;

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (6)

2009-03-06 Thread Paul Vriens
Andreas Rosenberg wrote: On Friday 06 March 2009 14:12:11 you wrote: Paul Vriens wrote: Andreas Rosenberg wrote: Hi, Error during compilation: userenv_main.c:181: warning: passing argument 1 of ‘GetUserNameW’ from

Re: [2/5] resend ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

2009-03-08 Thread Paul Vriens
Jeff Latimer wrote: Note that Inet_Ntop is only available in Vista and Windows 2008. This patch removes the version testing. --- dlls/ws2_32/tests/sock.c | 67 ++ 1 files changed, 67 insertions(+), 0 deletions(-)

Re: Wow, 2003 is almost all green... only rpcrt4:server failing

2009-03-08 Thread Paul Vriens
Dan Kegel wrote: The wine test suite is making great progress towards passing on all platforms. http://test.winehq.org/data/tests/rpcrt4:server.html seems to be the sore thumb at the moment; it passes on XP and Wine, but fails everywhere else. I think this is the test that fails on the most

Re: Sufficient 1.2 release criterion: passing all tests on all platforms?

2009-03-08 Thread Paul Vriens
Dan Kegel wrote: On Sun, Mar 8, 2009 at 5:05 PM, Paul Vriens paul.vriens.w...@gmail.com wrote: For that sole reason I started with installing a basic W2K box without servicepacks and patches. The last remaining few failures on my boxes are not the easiest ones but there are loads of (easier

Re: [wininet/tests 2/2] Skip some tests on IE5

2009-03-08 Thread Paul Vriens
Paul Vriens wrote: Hi, Ordinal 117 is CreateUrlCacheContainerA so these tests crashed on systems with IE5. I also guess that IsDomainLegalCookieDomainW is only present on IE6 and higher. Changelog Skip some tests on IE5 I of course meant to say Ordinal 117 is CreateUrlCacheContainerA

Re: [5/5] ws2_32/tests: Tests for invalid conditions in InetNtop

2009-03-09 Thread Paul Vriens
Jeff Latimer wrote: MSDN defines an number of conditions that inet_ntop will return errors. This patch tests for them. --- dlls/ws2_32/socket.c | 30 +++- dlls/ws2_32/tests/sock.c | 83 - 2 files changed, 109 insertions(+), 4

Re: [2/5] resend ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

2009-03-09 Thread Paul Vriens
Jeff Latimer wrote: Note that Inet_Ntop is only available in Vista and Windows 2008. This patch removes the version testing. This one removes the redundant test after GetModuleHandle and adds win_skip(). --- dlls/ws2_32/tests/sock.c | 68 ++ 1

Re: [5/5] ws2_32/tests: Tests for invalid conditions in InetNtop

2009-03-09 Thread Paul Vriens
Jeff Latimer wrote: Paul Vriens wrote: Jeff Latimer wrote: MSDN defines an number of conditions that inet_ntop will return errors. This patch tests for them. - Secondly you shouldn't use magic number if you no the name: WSASetLastError(0xc00d); In the tests you do: +ok

Re: [5/5] ws2_32/tests: Tests for invalid conditions in InetNtop

2009-03-09 Thread Paul Vriens
Paul Vriens wrote: Jeff Latimer wrote: Paul Vriens wrote: Jeff Latimer wrote: MSDN defines an number of conditions that inet_ntop will return errors. This patch tests for them. - Secondly you shouldn't use magic number if you no the name: WSASetLastError(0xc00d); In the tests you do

Re: msi: Trace the username to help debug test failures on certain machines.

2009-03-09 Thread Paul Vriens
James Hawkins wrote: --- dlls/msi/tests/source.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Hi, The issue seems to be present on boxes that are part of a domain. I guess we have to check for domain

shlwapi/shreg test: difference in results when crosscompiling just the test and the full winetest (Win95)

2009-03-09 Thread Paul Vriens
Hi, I'm trying to fix the last remaining test failures for shlwapi/shreg on my Win95 box. When I crosscompile the full winetest and run winetest shlwapi:shreg on my Win95 box the test results are: shreg.c:248: Test failed: Expected ERROR_MORE_DATA, got (127) shreg.c:274: Test failed:

Re: shlwapi/shreg test: difference in results when crosscompiling just the test and the full winetest (Win95)

2009-03-09 Thread Paul Vriens
Reece Dunn wrote: 2009/3/9 Paul Vriens paul.vriens.w...@gmail.com: Hi, I'm trying to fix the last remaining test failures for shlwapi/shreg on my Win95 box. When I crosscompile the full winetest and run winetest shlwapi:shreg on my Win95 box the test results are: shreg.c:248: Test failed

Re: [6/6] d3d8: Handles aren't supposed to be pointers.

2009-03-10 Thread Paul Vriens
Henri Verbeet wrote: Hi, +EnterCriticalSection(d3d8_cs); +*pToken = d3d8_allocate_handle(This-handle_table, object); LeaveCriticalSection(d3d8_cs); Is there a need for that extra EnterCriticalSection()

Re: [PATCH 1/5] gdi32/tests: Fix is_win9x test.

2009-03-10 Thread Paul Vriens
Huw Davies wrote: --- dlls/gdi32/tests/bitmap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Wouldn't it be better to do something like: SetLastError(0xdeadbeef); GetWindowLongPtrW(GetDesktopWindow(),

Re: [PATCH 1/4] gdi32/tests: Don't use bmType to skip tests on win9x - it's equal to 0 for monochrome bitmaps.

2009-03-10 Thread Paul Vriens
Alexandre Julliard wrote: Huw Davies h...@codeweavers.com writes: --- dlls/gdi32/tests/bitmap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) The is_win9x test is broken, that GetWindowLongPtrW call will return 0 on all platforms, so it breaks the tests on Wine: But that's

Re: Wow, 2003 is almost all green... only rpcrt4:server failing

2009-03-10 Thread Paul Vriens
Dan Kegel wrote: The wine test suite is making great progress towards passing on all platforms. http://test.winehq.org/data/tests/rpcrt4:server.html seems to be the sore thumb at the moment; it passes on XP and Wine, but fails everywhere else. I think this is the test that fails on the most

Re: Wow, 2003 is almost all green... only rpcrt4:server failing

2009-03-10 Thread Paul Vriens
Paul Vriens wrote: Dan Kegel wrote: The wine test suite is making great progress towards passing on all platforms. http://test.winehq.org/data/tests/rpcrt4:server.html seems to be the sore thumb at the moment; it passes on XP and Wine, but fails everywhere else. I think this is the test

ddraw/visual tests

2009-03-11 Thread Paul Vriens
Hi Stefan, As you wrote most of the tests: I'm looking into some of the ddraw:visual failures (windows 2000 and I guess only VMware). Several tests draw quads but only if _BeginScene succeeded. Is it useful at all to check the colors afterwards if the quads are not drawn in the first place?

Re: [ddraw/tests 2/2] Mark some more tests are broken() on W2K

2009-03-11 Thread Paul Vriens
Stefan Dösinger wrote: Am Mittwoch, 11. März 2009 12:07:27 schrieb Paul Vriens: +ok(hr == D3D_OK || + broken(hr == D3DERR_SCENE_IN_SCENE), /* W2K */ + IDirect3DDevice7_BeginScene failed with %08x\n, hr); I don't like that one. I think I wrote those tests on Win2K partially, so

Re: [ddraw/tests 1/2] Fix a few test failures on W2K (VMware?)

2009-03-11 Thread Paul Vriens
Paul Vriens wrote: Hi, As acknowledged by Stefan, there is no point in testing colors if something isn't drawn. I'm not sure if this is W2K specific or W2K in combination with VMware. Changelog Fix a few test failures on W2K (VMware?) Please ignore this series of 2. I'm first going

Crashes on Win9x and NT4 in rpcrt4/tests/ndr_marshall

2009-03-12 Thread Paul Vriens
Hi, As the authors of these tests, I'd thought to write directly to you. This rpcrt4 stuff is way over my head. The attached patch shows where Win95, Win98 and NT4 crash. The crash in test_ndr_allocate() actually happens at the assignment mem_list_v2 = StubMsg.pMemoryList;. Any idea(s).

Re: riched20: add tests for EM_FORMATRANGE

2009-03-13 Thread Paul Vriens
Lei Zhang wrote: Hi, In my last attempt, I submitted Troy Rollo's EM_FORMATRANGE implementation and with my test cases. I'm not sure what was wrong with the implementation, but the test cases should be ok. Hi Lei,

Re: riched20: add tests for EM_FORMATRANGE

2009-03-13 Thread Paul Vriens
On Mar 13, 2009, at 23:17, Lei Zhang thes...@google.com wrote: On Fri, Mar 13, 2009 at 12:01 PM, Paul Vriens paul.vriens.w...@gmail.com wrote: Lei Zhang wrote: Hi, In my last attempt, I submitted Troy Rollo's EM_FORMATRANGE implementation and with my test cases. I'm not sure what was wrong

Re: riched20: add tests for EM_FORMATRANGE

2009-03-14 Thread Paul Vriens
Lei Zhang wrote: On Fri, Mar 13, 2009 at 12:01 PM, Paul Vriens paul.vriens.w...@gmail.com wrote: Lei Zhang wrote: Hi, In my last attempt, I submitted Troy Rollo's EM_FORMATRANGE implementation and with my test cases. I'm not sure what was wrong with the implementation, but the test cases

Re: [try2] schannel/tests: Fix test on Win2k

2009-03-14 Thread Paul Vriens
Nicolas Le Cam wrote: Try2: This time with the patch... Win2k pro returns 1 Lsa package and 4 user packages. Mark them as broken. Also skip verification of second package's values if only one is reported. Nicolas Le Cam

Re: riched20: add tests for EM_FORMATRANGE

2009-03-15 Thread Paul Vriens
James McKenzie wrote: Lei Zhang wrote: On Fri, Mar 13, 2009 at 12:01 PM, Paul Vriens paul.vriens.w...@gmail.com wrote: Lei Zhang wrote: Hi, In my last attempt, I submitted Troy Rollo's EM_FORMATRANGE implementation and with my test cases. I'm not sure what was wrong

Re: riched20: add tests for EM_FORMATRANGE

2009-03-16 Thread Paul Vriens
Paul Vriens wrote: James McKenzie wrote: Lei Zhang wrote: On Fri, Mar 13, 2009 at 12:01 PM, Paul Vriens paul.vriens.w...@gmail.com wrote: Lei Zhang wrote: Hi, In my last attempt, I submitted Troy Rollo's EM_FORMATRANGE implementation and with my test cases. I'm not sure what was wrong

[riched20/tests] Changed tests for EM_FORMATRANGE

2009-03-16 Thread Paul Vriens
Hi, I've been playing with this and just wanted to see if anybody has comments on these changed tests. Tests succeed on Win95/Win98 and W2K3 with every possible resolution (as we are not relying on the resolution anymore) and 96/120 dpi. -- Cheers, Paul. diff --git

New Coverity run

2009-03-17 Thread Paul Vriens
Hi, Just wanted to mention that there is a new Coverity run. There were some issues the last weeks that made sure the source wasn't updated (most likely started with the disk issue on winehq.org early February). -- Cheers, Paul.

Re: shell32/tests: Fix a test on Win2k platform and above.

2009-03-18 Thread Paul Vriens
Nicolas Le Cam wrote: On Win2k (and according to test.winehq.org on above platforms) an ABN_POSCHANGED message is sent to the last window that is removed. This patch change the ok to a win_skip in this case. Tell me if you have a better solution. Nicolas Le Cam

Re: [urlmon/tests] Skip some tests on Vista and higher

2009-03-18 Thread Paul Vriens
Jacek Caban wrote: Hi Paul, Paul Vriens wrote: Hi, The Gopher protocol has been removed from Vista (and later versions). hres = CoGetClassObject(CLSID_GopherProtocol, CLSCTX_INPROC_SERVER, NULL, IID_IUnknown, (void**)unk); +if (hres == REGDB_E_CLASSNOTREG) { +win_skip(Gopher

Re: advapi32: base implementation of LsaLookupNames2

2009-03-19 Thread Paul Vriens
Aric Stewart wrote: --- dlls/advapi32/lsa.c | 51 ++- dlls/advapi32/tests/lsa.c | 75 + 2 files changed, 125 insertions(+), 1 deletions(-)

Re: shell32/tests: Fix a test on Win2k platform and above.

2009-03-19 Thread Paul Vriens
Nicolas Le Cam wrote: Try2: Follow Vincent Povirk's suggestion of removing calls to SetWindowLongPtr before destroying windows Could someone test this patch on Win9x or WinNT ? On Win2k (and according to test.winehq.org on above platforms) an ABN_POSCHANGED message is sent to the last window

Re: shell32/tests: Fix a test on Win2k platform and above.

2009-03-19 Thread Paul Vriens
Nicolas Le Cam wrote: 2009/3/19 Paul Vriens paul.vriens.w...@gmail.com: Nicolas Le Cam wrote: Try2: Follow Vincent Povirk's suggestion of removing calls to SetWindowLongPtr before destroying windows Could someone test this patch on Win9x or WinNT ? On Win2k (and according to test.winehq.org

Re: (try 2)advapi32: base implementation of LsaLookupNames2

2009-03-19 Thread Paul Vriens
Aric Stewart wrote: fix tests for win95 --- dlls/advapi32/lsa.c | 51 +++- dlls/advapi32/tests/lsa.c | 82 - 2 files changed, 131 insertions(+), 2 deletions(-)

Re: WineHQ.org Downtime

2009-03-24 Thread Paul Vriens
Jeremy Newman wrote: Server is back on-line. -Newman Jeremy Newman wrote: WineHQ.org (websites [www,appdb,bugzilla,forums,source,test], git, mailing lists) will be off-line tomorrow starting at 10:00 CDT and lasting at least 2 hours. We will be putting up a temp website that will display

Re: WineHQ.org Downtime

2009-03-24 Thread Paul Vriens
Jeremy Newman wrote: I didn't do any further OS updates since the Lenny upgrade over 2 weeks prior. This downtime was a full hardware migration. I copied the entire OS over to a new system. I can't see how that would effect any tests, unless they care about differences in chipset, CPU or NIC.

Re: [PATCH 1/6] kernel32: Add tests for WritePrivateProfileString.

2009-03-24 Thread Paul Vriens
James Hawkins wrote: --- dlls/kernel32/tests/profile.c | 227 + 1 files changed, 227 insertions(+), 0 deletions(-) Two of these new tests crash on Windows (see attached patch

Re: [PATCH 3/6] kernel32: Handle writing empty sections and keys in WritePrivateProfileString.

2009-03-25 Thread Paul Vriens
James Hawkins wrote: --- dlls/kernel32/profile.c | 32 dlls/kernel32/tests/profile.c |5 + 2 files changed, 21 insertions(+), 16 deletions(-) Hi James, Sorry if you've

Re: [kernel32] Fix inf file parsing

2009-03-25 Thread Paul Vriens
James Hawkins wrote: On Wed, Mar 25, 2009 at 8:25 AM, Paul Vriens paul.vriens.w...@gmail.com wrote: Hi, This fixes bug 17843 but I'm not sure it's a 100% correct. James didn't change this just for the fun of it. If you're unsure of the correct fix, you should write a test case that fails

Re: [kernel32] Fix inf file parsing

2009-03-25 Thread Paul Vriens
On Mar 25, 2009, at 20:44, James Hawkins trui...@gmail.com wrote: On Wed, Mar 25, 2009 at 11:50 AM, Paul Vriens paul.vriens.w...@gmail.com wrote: James Hawkins wrote: On Wed, Mar 25, 2009 at 8:25 AM, Paul Vriens paul.vriens.w...@gmail.com wrote: Hi, This fixes bug 17843 but I'm

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A

2009-03-27 Thread Paul Vriens
Andreas Rosenberg wrote: There is no need for that GetVersionExA call/test. Just do an if (0) and leave that comment about NT4 crashing in. -- Cheers, Paul.

Re: GetTempFileName should return 0 when the path isn't valid

2009-03-30 Thread Paul Vriens
Oskar Eisemuth wrote: Hello GetTempFileName should check the path and should return zero if it isn't a directory. See Bug 17875 --- dlls/kernel32/path.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) Can you add a testcase for this? That would need something like an

Tracing weirdness in the kernel32:profile tests

2009-03-31 Thread Paul Vriens
Hi, I'm trying to fix the remaining issues in the kernel32 profile tests. They have to do with the fact that we have extra '\r\n' on Win9x and that we need a timeout. The timeout is already in (1000 msec) but apparently that is not even enough on some boxes. If I check the current results

Re: [1/2](try 2)advapi32: alias some sids in LookupAccountName and make comparison case insensitive

2009-03-31 Thread Paul Vriens
Aric Stewart wrote: with tests --- dlls/advapi32/security.c | 10 +-- dlls/advapi32/tests/security.c | 56 2 files changed, 63 insertions(+), 3 deletions(-)

Re: Tracing weirdness in the kernel32:profile tests

2009-03-31 Thread Paul Vriens
Michael Karcher wrote: Am Dienstag, den 31.03.2009, 09:42 +0200 schrieb Paul Vriens: When I now run the test I get (and I omitted the buf/data output here): profile.c:835: Test failed: File doesn't match profile.c:835: Test failed: File doesn't match profile.c:835: Test failed: File doesn't

Re: advapi32/tests: Skip some tests using English names when running on non-English locales

2009-04-01 Thread Paul Vriens
Ge van Geldorp wrote: Account names are localized. Similar to existing skip in line 1806. Changelog: Skip some tests using English names when running on non-English locales --- dlls/advapi32/tests/security.c | 45 ++- 1 files changed, 25 insertions(+),

Re: [3/3] user32: Implemented GetWindowRgnBox with tests

2009-04-02 Thread Paul Vriens
Nikolay Sivov wrote: IE8 requested this. Changelog: - Implemented GetWindowRgnBox with tests +static void test_winregion() +{ +HWND hwnd; +RECT r; +int ret; +HRGN hrgn; + +hwnd = CreateWindowExA(0, static, NULL, WS_VISIBLE, 10, 10, 10, 10, NULL, 0, 0, NULL); +if

Re: msi/tests: Skip the tests if we are unable to identify the user SID. This fixes crashes on Win9x.

2009-04-03 Thread Paul Vriens
Francois Gouget wrote: --- dlls/msi/tests/source.c | 50 ++ 1 files changed, 41 insertions(+), 9 deletions(-) diff --git a/dlls/msi/tests/source.c b/dlls/msi/tests/source.c index 49e40c7..5f75159 100644 --- a/dlls/msi/tests/source.c +++

Re: mscms/tests: The presence of an ICM file in the color directory has nothing to do with the presence of a registered RGB profile.

2009-04-03 Thread Paul Vriens
ClamAV 0.93 Status: RO X-Status: X-Keywords: X-UID: 128893 Francois Gouget wrote: --- The tests were failing on my Windows systems because they have ICM files in the color directory but they are not registered, i.e. they don't even have the HKLM\Software\Microsoft\Windows

urlmon/misc test and the use of URLZONEREG_DEFAULT

2009-04-03 Thread Paul Vriens
Hi, Just build me a fresh W2K3 box with SP2 and all updates (including IE7). I get some errors when I run winetest: urlmon:misc misc.c:884: Test failed: (1400) policy=3, expected 0 misc.c:884: Test failed: (1e05) policy=1, expected 2 This particular test test_url_action() checks the

Re: urlmon/misc test and the use of URLZONEREG_DEFAULT

2009-04-03 Thread Paul Vriens
Paul Vriens wrote: Hi, Just build me a fresh W2K3 box with SP2 and all updates (including IE7). I get some errors when I run winetest: urlmon:misc misc.c:884: Test failed: (1400) policy=3, expected 0 misc.c:884: Test failed: (1e05) policy=1, expected 2 This particular test

Re: urlmon/misc test and the use of URLZONEREG_DEFAULT

2009-04-03 Thread Paul Vriens
Paul Vriens wrote: Paul Vriens wrote: Hi, Just build me a fresh W2K3 box with SP2 and all updates (including IE7). I get some errors when I run winetest: urlmon:misc misc.c:884: Test failed: (1400) policy=3, expected 0 misc.c:884: Test failed: (1e05) policy=1, expected 2

Re: urlmon/misc test and the use of URLZONEREG_DEFAULT

2009-04-04 Thread Paul Vriens
Detlef Riekenberg wrote: On Fr, 2009-04-03 at 20:49 +0200, Paul Vriens wrote: urlmon:misc misc.c:884: Test failed: (1400) policy=3, expected 0 misc.c:884: Test failed: (1e05) policy=1, expected 2 So the question is, does somebody now what URLZONEREG_DEFAULT defaults to? HKCR or HKLM

Re: NTFS filesystem features - WONTFIX?

2009-04-06 Thread Paul Vriens
Ben Klein wrote: 2009/4/6 Chris Robinson chris.k...@gmail.com: On Sunday 05 April 2009 6:45:42 pm Ben Klein wrote: That might be fine for mount points and mountable devices, but how could you accurately determine the filesystem type for an arbitrary directory like $HOME/.wine/drive_c? Expand

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

2009-04-06 Thread Paul Vriens
Andreas Rosenberg wrote: Just had a look again on your resend: this doesn't seem correct: +if ( lpcchSize lpcchSize ) I also think that your addition of _GetAccountNameFromTokenW is holding the committing of

  1   2   3   4   5   6   7   8   9   10   >