Re: [1/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 3)

2013-09-30 Thread Bruno Jesus
On Fri, Sep 27, 2013 at 8:16 AM, Akihiro Sagawa sagawa@gmail.com wrote:

 Fixes bug 18440, 20847.

 Try 3:
- Rebase to recent source.
- Separate ABC metrics change.
- Use conditional operator.
 ---
  dlls/gdi32/freetype.c   |4 ++--
  dlls/gdi32/tests/font.c |   24 
  2 files changed, 10 insertions(+), 18 deletions(-)

 +ok(gm.gmBlackBoxY == 1, %2d:expected 1, got %u\n, fmt[i], 
 gm.gmBlackBoxX);

There seems to be a copypaste issue in all lines related to
gmBlackBoxY reporting the error as gmBlackBoxX.

Regards,
Bruno




Re: [1/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 3)

2013-09-27 Thread Alexandre Julliard
Akihiro Sagawa sagawa@gmail.com writes:

 Fixes bug 18440, 20847.

 Try 3: 
- Rebase to recent source.
- Separate ABC metrics change.
- Use conditional operator.

It breaks the tests:

../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so 
dib.c  touch dib.ok
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 1
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 1
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 1
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 1
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 1
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 0
dib.c:2827: Test failed: hash mismatch - aa 0
make[1]: *** [dib.ok] Error 19

-- 
Alexandre Julliard
julli...@winehq.org