[WireGuard] wg set - unexpected change of routes

2016-08-29 Thread Ivan Labáth
Hello, I have noticed that adding a route (allowedips) to a peer automatically removes any such route from other peers, as has been explained in some email. It seems to me as unexpected behaviour, as I wouldn't expect the configuration of a peer to be (silently) affected when changing the configu

Re: [WireGuard] fq, ecn, etc with wireguard

2016-08-29 Thread Dave Taht
:whew: On Mon, Aug 29, 2016 at 10:16 AM, Jason A. Donenfeld wrote: > Hey Dave, > > You're exactly the sort of person I've been hoping would appear during the > last several months. The bufferbloat project has had a lot of people randomly show up at the party to make a contribution, getting a lit

Re: [WireGuard] fq, ecn, etc with wireguard

2016-08-29 Thread Jason A. Donenfeld
> well, you should see ect(3) if you pound the network interface. Things > like tcp small queues get in the way so you won't see it with a simple > single flow test against cake/codel/etc. > > something like 4 netperfs will do it. It works! 01:40:57.962131 IP (tos 0x3,CE, ttl 64, id 51647, offset

Re: [WireGuard] fq, ecn, etc with wireguard

2016-08-29 Thread Dave Taht
On Mon, Aug 29, 2016 at 2:00 PM, Jason A. Donenfeld wrote: >> Nice to see you so quickly being productive. I am still constructing a >> reply to your previous message. > > Awaiting it's arrival :) > >> In re-reading over your message, I think not dropping the packet when >> there is an outer CE ma

Re: [WireGuard] fq, ecn, etc with wireguard

2016-08-29 Thread Dave Taht
well, you should see ect(3) if you pound the network interface. Things like tcp small queues get in the way so you won't see it with a simple single flow test against cake/codel/etc. something like 4 netperfs will do it. Since you are so fast at getting code running, I think you'll like flent as

Re: [WireGuard] fq, ecn, etc with wireguard

2016-08-29 Thread Jason A. Donenfeld
> Nice to see you so quickly being productive. I am still constructing a > reply to your previous message. Awaiting it's arrival :) > In re-reading over your message, I think not dropping the packet when > there is an outer CE marking and no ecn enabling in in the inner > packet is probably the r

Re: [WireGuard] fq, ecn, etc with wireguard

2016-08-29 Thread Dave Taht
To try and answer your actual questions... On Mon, Aug 29, 2016 at 12:23 PM, Jason A. Donenfeld wrote: > Hi again, > > So I implemented a first stab of this, which I intend to refine with > your feedback: > > > https://git.zx2c4.com/WireGuard/commit/?id=a2dfc902e942cce8d5da4a42d6aa384413e7fc

Re: [WireGuard] fq, ecn, etc with wireguard

2016-08-29 Thread Dave Taht
Nice to see you so quickly being productive. I am still constructing a reply to your previous message. Rather than try to expand your macros, my mental model on encode is if(inner_dscp & 3) outer_dscp = (outer_dscp & 3) | (inner_dscp & 3); decode is different. A bad actor could, for example, fli

Re: [WireGuard] fq, ecn, etc with wireguard

2016-08-29 Thread Jason A. Donenfeld
Hi again, So I implemented a first stab of this, which I intend to refine with your feedback: https://git.zx2c4.com/WireGuard/commit/?id=a2dfc902e942cce8d5da4a42d6aa384413e7fc81 On the way out, the ECN is set to: outgoing_skb->tos = encap_ecn(0, inner_skb->tos); where encap_ecn is define

Re: [WireGuard] fq, ecn, etc with wireguard

2016-08-29 Thread Jason A. Donenfeld
Hey Dave, You're exactly the sort of person I've been hoping would appear during the last several months. Indeed there's a lot of interesting queueing things happening with WireGuard. I'll detail them inline below. > I have been running a set of tinc based vpns for a long time now, and > based on