[PATCH compat] Update and improve detection of CentOS Stream 8

2021-04-19 Thread Peter Georg
CentOS Stream 8 by now (4.18.0-301.1.el8) reports RHEL_MINOR=5. The current RHEL 8 minor release is still 3. RHEL 8.4 is in beta. Replace equal comparison by greater equal to (hopefully) be a little bit more future proof. Signed-off-by: Peter Georg --- src/compat/compat-asm.h | 2 +-

Re: [PATCH] babel: Drop check for IF_MULTICAST interface flag

2021-04-19 Thread Ondrej Zajicek
On Mon, Apr 19, 2021 at 03:55:18PM +0200, Toke Høiland-Jørgensen wrote: > Ondrej Zajicek writes: > > > Is there a reason why to disregard the IF_MULTICAST flag? This seems to me > > more like a bug in FreeBSD Wireguard implementation that should be fixed > > there. Is this flag properly checked

Re: [PATCH] babel: Drop check for IF_MULTICAST interface flag

2021-04-19 Thread Ondrej Zajicek
On Thu, Apr 15, 2021 at 03:44:50PM +0200, Toke Høiland-Jørgensen wrote: > The babel protocol code was checking interfaces for the IF_MULTICAST flag > and refusing to run if this isn't present. However, there are cases where > this flag doesn't correspond to the actual capability of sending

[PATCH] sysdep/bsd: propagate OS-level IFF_MULTICAST to internal IF_MULTICAST flag

2021-04-19 Thread Toke Høiland-Jørgensen
The BSD code did not propagate the OS-level IFF_MULTICAST flag to the Bird-internal IF_MULTICAST flag, which causes problems with Wireguard interfaces on FreeBSD. The Linux sysdep code does propagate the flag already, so just copy over the same check and flag update. Tested-by: Stefan Haller

Re: FreeBSD if_wg POINTTOPOINT and MULTICAST behaviour

2021-04-19 Thread Toke Høiland-Jørgensen
Stefan Haller writes: > On Mon, Apr 19, 2021 at 01:42:58PM -0600, Jason A. Donenfeld wrote: >> On Mon, Apr 19, 2021 at 1:42 PM Stefan Haller wrote: >> > >> > On Mon, Apr 19, 2021 at 08:25:46PM +0200, Toke Høiland-Jørgensen wrote: >> > > Stefan, any chance you could test this patch to Bird

Re: FreeBSD if_wg POINTTOPOINT and MULTICAST behaviour

2021-04-19 Thread Stefan Haller
On Mon, Apr 19, 2021 at 01:42:58PM -0600, Jason A. Donenfeld wrote: > On Mon, Apr 19, 2021 at 1:42 PM Stefan Haller wrote: > > > > On Mon, Apr 19, 2021 at 08:25:46PM +0200, Toke Høiland-Jørgensen wrote: > > > Stefan, any chance you could test this patch to Bird (*instead of* the > > > previous

Re: FreeBSD if_wg POINTTOPOINT and MULTICAST behaviour

2021-04-19 Thread Jason A. Donenfeld
On Mon, Apr 19, 2021 at 1:42 PM Stefan Haller wrote: > > On Mon, Apr 19, 2021 at 08:25:46PM +0200, Toke Høiland-Jørgensen wrote: > > Stefan, any chance you could test this patch to Bird (*instead of* the > > previous one that removes the check from the Babel code)? > > The patch is working on

Re: FreeBSD if_wg POINTTOPOINT and MULTICAST behaviour

2021-04-19 Thread Stefan Haller
On Mon, Apr 19, 2021 at 08:25:46PM +0200, Toke Høiland-Jørgensen wrote: > Stefan, any chance you could test this patch to Bird (*instead of* the > previous one that removes the check from the Babel code)? The patch is working on FreeBSD 13.0. Kind regards, Stefan

Re: FreeBSD if_wg POINTTOPOINT and MULTICAST behaviour

2021-04-19 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen writes: > Stefan Haller writes: > >> Hi Jason, >> >> On Thu, Apr 15, 2021 at 06:05:03PM -0600, Jason A. Donenfeld wrote: >>> I spent the day playing around with bird and babel and sorted out >>> FreeBSD's v6 situation. Basically, ff00::/8 addresses are treated >>>

Re: [PATCH] babel: Drop check for IF_MULTICAST interface flag

2021-04-19 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Mon, Apr 19, 2021 at 03:55:18PM +0200, Toke Høiland-Jørgensen wrote: >> Ondrej Zajicek writes: >> >> > Is there a reason why to disregard the IF_MULTICAST flag? This seems to me >> > more like a bug in FreeBSD Wireguard implementation that should be fixed >> >

Re: [PATCH] babel: Drop check for IF_MULTICAST interface flag

2021-04-19 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Thu, Apr 15, 2021 at 03:44:50PM +0200, Toke Høiland-Jørgensen wrote: >> The babel protocol code was checking interfaces for the IF_MULTICAST flag >> and refusing to run if this isn't present. However, there are cases where >> this flag doesn't correspond to the actual