Re: [PATCH net-next] genetlink: start to validate reserved header bytes

2022-08-29 Thread Jason A. Donenfeld
Hi Jakub, On Wed, Aug 24, 2022 at 05:18:30PM -0700, Jakub Kicinski wrote: > diff --git a/drivers/net/wireguard/netlink.c b/drivers/net/wireguard/netlink.c > index d0f3b6d7f408..0c0644e762e5 100644 > --- a/drivers/net/wireguard/netlink.c > +++ b/drivers/net/wireguard/netlink.c > @@ -621,6 +621,7

Re: FreeBSD current socket-src changed. Wireguard not compiling.

2022-08-29 Thread Jason A. Donenfeld
On Tue, Aug 23, 2022 at 12:26:21PM +0300, Michael Pro wrote: > Tonight after updating kernel freebsd current I got coredump with > wireguard enabled kernel module. > > As is > https://reviews.freebsd.org/D36232 > D36232 protosw: refactor protosw and domain static declaration and > load

Re: [PATCH net-next] genetlink: start to validate reserved header bytes

2022-08-29 Thread Paul Moore
On Wed, Aug 24, 2022 at 8:18 PM Jakub Kicinski wrote: > > We had historically not checked that genlmsghdr.reserved > is 0 on input which prevents us from using those precious > bytes in the future. > > One use case would be to extend the cmd field, which is > currently just 8 bits wide and 256 is

Re: [PATCH wireguard-go] tun/netstack: bump to latest gvisor

2022-08-29 Thread Shengjing Zhu
Hi, On Mon, Aug 29, 2022 at 11:59 PM Jason A. Donenfeld wrote: > > Hi Shengjing, > > Thanks for the patch. I'll apply this. But one question: > > On Fri, Aug 19, 2022 at 01:27:28AM +0800, Shengjing Zhu wrote: > > dev := { > > + ep: channel.New(1024, uint32(mtu),

Re: [PATCH wireguard-go] tun/netstack: bump to latest gvisor

2022-08-29 Thread Jason A. Donenfeld
Hi Shengjing, Thanks for the patch. I'll apply this. But one question: On Fri, Aug 19, 2022 at 01:27:28AM +0800, Shengjing Zhu wrote: > dev := { > + ep: channel.New(1024, uint32(mtu), ""), How did you come up with 1024 here? And more generally, how's performance

Re: [PATCH net-next] genetlink: start to validate reserved header bytes

2022-08-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Wed, 24 Aug 2022 17:18:30 -0700 you wrote: > We had historically not checked that genlmsghdr.reserved > is 0 on input which prevents us from using those precious > bytes in the future. > > One use case would