Re: [PATCH] remove CONFIG_ANDROID

2022-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2022 at 07:30:35PM +0200, Jason A. Donenfeld wrote: > Properly resolved by whom? It sounds like you're up for intentionally > allowing a userspace regression, and also volunteering other people's > time into fixing that regression? The way I understand the kernel > development proce

Re: [PATCH] remove CONFIG_ANDROID

2022-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2022 at 06:38:09PM +0200, Jason A. Donenfeld wrote: > On the technical topic, an Android developer friend following this > thread just pointed out to me that Android doesn't use PM_AUTOSLEEP and > just has userspace causing suspend frequently. So by his rough > estimation your patch

Re: [PATCH] remove CONFIG_ANDROID

2022-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2022 at 09:34:44AM -0700, Paul E. McKenney wrote: > So you are OK if your patch is accepted, and then CONFIG_ANDROID is > re-introduced but used only for building kernels intended to run on > Android systems? I don't think that is a good config. In general you want APIs to express

Re: [PATCH] remove CONFIG_ANDROID

2022-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2022 at 06:25:32PM +0200, Jason A. Donenfeld wrote: > Anyway, instead of the slow drip of "facts" and ≤three sentence emails, > can you just write up a paragraph that indicates this is safe to do (for > both (1) and (2)) in your v+1? Why would I care? If your config wakeups up so

Re: [PATCH] remove CONFIG_ANDROID

2022-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2022 at 06:13:05PM +0200, Jason A. Donenfeld wrote: > Good! It sounds like you're starting to develop opinions on the matter. No, I provide facts. Look at both the definition of the symbol, and various distribution kernel that enabled it and think hard if they run on "Android" har

[PATCH] remove CONFIG_ANDROID

2022-06-29 Thread Christoph Hellwig
The ANDROID config symbol is only used to guard the binder config symbol and to inject completely random config changes. Remove it as it is obviously a bad idea. Signed-off-by: Christoph Hellwig --- drivers/Makefile| 2 +- drivers/android/Kconfig

remove CONFIG_ANDROID

2022-06-29 Thread Christoph Hellwig
Hi Greg, this series removes the CONFIG_ANDROID. It just guards the Kconfig option for binder and then changes a bunch of random defaults and settings, which makes no sense whatsoever and none of those changes had any good justifcation in their commit logs either.

Re: [PATCH] remove CONFIG_ANDROID

2022-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2022 at 06:09:18PM +0200, Jason A. Donenfeld wrote: > CONFIG_ANDROID is used here for a reason. As somebody suggested in > another thread of which you were a participant, it acts as a proxy for > "probably running on Android hardware", No, it does not in any way.