Re: [PATCH] pm/sleep: Add PM_USERSPACE_AUTOSLEEP Kconfig

2022-06-30 Thread Kalesh Singh
On Thu, Jun 30, 2022 at 2:14 PM Jason A. Donenfeld wrote: > > On Thu, Jun 30, 2022 at 01:41:40PM -0700, Kalesh Singh wrote: > > Our latest supported kernels in Android are based on 5.15 so the > > config change isn't yet needed. Once there are newer versions with the > >

Re: [PATCH] pm/sleep: Add PM_USERSPACE_AUTOSLEEP Kconfig

2022-06-30 Thread Kalesh Singh
On Thu, Jun 30, 2022 at 12:49 PM Jason A. Donenfeld wrote: > > Hi Kalesh, > > On Thu, Jun 30, 2022 at 07:12:29PM +0000, Kalesh Singh wrote: > > Systems that initiate frequent suspend/resume from userspace > > can make the kernel aware by enabling PM_USERSP

[PATCH] pm/sleep: Add PM_USERSPACE_AUTOSLEEP Kconfig

2022-06-30 Thread Kalesh Singh
. This patch was prompted by the discussion at [1] which attempts to remove CONFIG_ANDROID that currently guards these code paths. [1] https://lore.kernel.org/r/20220629150102.1582425-1-...@lst.de/ Suggested-by: Jason A. Donenfeld Signed-off-by: Kalesh Singh --- drivers/char/random.c | 4

Re: [PATCH] remove CONFIG_ANDROID

2022-06-29 Thread Kalesh Singh
On Wed, Jun 29, 2022 at 5:30 PM Jason A. Donenfeld wrote: > > Hey again, > > On Thu, Jun 30, 2022 at 2:24 AM Jason A. Donenfeld wrote: > > 1) Introduce a simple CONFIG_PM_CONTINUOUS_AUTOSLEEPING Kconfig thing > >with lots of discouraging help text. > > > > 2) Go with the /sys/power tunable

Re: [PATCH] remove CONFIG_ANDROID

2022-06-29 Thread Kalesh Singh
On Wed, Jun 29, 2022 at 4:02 PM Jason A. Donenfeld wrote: > > Hi Kalesh, > > On Wed, Jun 29, 2022 at 03:26:33PM -0700, Kalesh Singh wrote: > > Thanks for taking a look. I'm concerned holding the sys/power/state > > open would have unintentional side effects. A

Re: [PATCH] remove CONFIG_ANDROID

2022-06-29 Thread Kalesh Singh
On Wed, Jun 29, 2022 at 1:47 PM Jason A. Donenfeld wrote: > > Hi Kalesh, > > On Wed, Jun 29, 2022 at 12:05:23PM -0700, Kalesh Singh wrote: > > Thanks for raising this. > > > > Android no longer uses PM_AUTOSLEEP, is correct. libsuspend is > > also

Re: [PATCH] remove CONFIG_ANDROID

2022-06-29 Thread Kalesh Singh
On Wed, Jun 29, 2022 at 07:34:58PM +0200, Jason A. Donenfeld wrote: > On Wed, Jun 29, 2022 at 06:38:09PM +0200, Jason A. Donenfeld wrote: > > On the technical topic, an Android developer friend following this > > thread just pointed out to me that Android doesn't use PM_AUTOSLEEP and > > just has