Re: [PATCH v4 2/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Dan Carpenter
Last time you sent this we couldn't decide which tree it should go through. Either the crypto tree or through Andrew seems like the right thing to me. Also the other issue is that it risks breaking things if people add new kzfree() instances while we are doing the transition. Could you just add

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Matthew Wilcox
On Wed, Jun 17, 2020 at 01:01:30AM +0200, David Sterba wrote: > On Tue, Jun 16, 2020 at 11:53:50AM -0700, Joe Perches wrote: > > On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote: > > > v4: > > > - Break out the memzero_explicit() change as suggested by Dan Carpenter > > > so that it can

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Matthew Wilcox
On Tue, Jun 16, 2020 at 11:53:50AM -0700, Joe Perches wrote: > To this larger audience and last week without reply: > https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.ca...@perches.com/ > > Are there _any_ fastpath uses of kfree or vfree? I worked on adding a 'free' a couple

Re: [PATCH] wg-quick: add restart command

2020-06-17 Thread Jason A. Donenfeld
Thanks for the patchset. I'm wondering what the intended use case of this is. When do you need to set the interface down and then immediately up again? Most changes to the config file can be reflected with a more simple: wg syncconf wg0 <(wg-quick strip wg0)

Re: Ubuntu 18.04 kernel 4.15.0-106-generic breaks wireguard-1.0.20200520

2020-06-17 Thread Ada Sauce
On Thursday, June 11, 2020 14:49 ADT, "Ada Sauce" wrote: > I'm now also observing the same failure mode as Martin. > > However, the kernel is 4.15.0-101-generic. > > ``` > /var/lib/dkms/wireguard/1.0.20200611/build/socket.c: In function ‘send6’: >

Re: Ubuntu 18.04 kernel 4.15.0-106-generic breaks wireguard-1.0.20200520

2020-06-17 Thread Ada Sauce
I'm now also observing the same failure mode as Martin. However, the kernel is 4.15.0-101-generic. ``` /var/lib/dkms/wireguard/1.0.20200611/build/socket.c: In function ‘send6’: /var/lib/dkms/wireguard/1.0.20200611/build/socket.c:139:20: error: ‘const struct ipv6_stub’ has no member named

Problems with Ubuntu 16.04 kernels and wireguard 1.0.20200611

2020-06-17 Thread Gregory ORIOL
Hi, Since commit e24c9a9265af40781fa27b5de11dd5b78925c5be to wireguard-linux-compat with a fix for some Ubuntu versions, we are experiencing a problem with some older, but still LTS, versions of Ubuntu 16.04: older kernels 4.4.0-148, 4.4.0-166 fail to build with wireguard 1.0.20200611 So, any

Re: Windows Client - UI improvement

2020-06-17 Thread Jason A. Donenfeld
On Wed, Jun 17, 2020 at 12:49 AM Phillip McMahon wrote: > I'm no Picasso, but take a look at the attached. > > Essentially pin the standard set of options to be always visible, and > make the conf area scrollable. Oohh ho ho, that is a really nice idea. I have no idea how to do that with

Re: [PATCH] wg-quick: add restart command

2020-06-17 Thread Eric Light
As a purely Debian user, the 'service x restart' pattern is far more memorable than the syncconf method. I know personal preference isn't a great reason to add a knob, but Garrit's method is probably going to be much more familiar to many users. As to _when_ you'd need this... during a config

Re: Windows Client - UI improvement

2020-06-17 Thread Phillip McMahon
I'm no Picasso, but take a look at the attached. Essentially pin the standard set of options to be always visible, and make the conf area scrollable. On Wed, 17 Jun 2020 at 07:49, Jason A. Donenfeld wrote: > > I agree that having everything in the context menu can be a bit > unwieldy. I'm not

Wireguard with Network Namespaces

2020-06-17 Thread Archit Pandey
Hello all, I'm trying to set-up a wireguard peer-to-peer test using namespaces as the diagram below. |--||--||--| | wg0, ns1 |--| lo, ns0 |--| wg1, ns2 | |--||--||--|

wireguard-dkms build fails with ubuntu 18.04

2020-06-17 Thread Daniel Rudd
Hi Non-technical user here so please forgive any errors on my part. Wireguard-dkms build fails on Ubuntu 18.04 kernel 4.15.0-102-generic (and previous) with error: ERROR: Cannot create report: [Errno 17] File exists: '/var/crash/wireguard-dkms.0.crash' Error! Bad return status for module build

[PATCH 1/6] wg-quick: linux: add restart command

2020-06-17 Thread Garrit Franke
--- src/wg-quick/linux.bash | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/wg-quick/linux.bash b/src/wg-quick/linux.bash index e4d4c4f..6f42b7f 100755 --- a/src/wg-quick/linux.bash +++ b/src/wg-quick/linux.bash @@ -298,7 +298,7 @@ execute_hooks() {

[PATCH] Do not assign in if condition wg_noise_handshake_consume_initiation()

2020-06-17 Thread Frank Werner-Krippendorf
Fixes an error condition reported by checkpatch.pl which caused by assigning a variable in an if condition in wg_noise_handshake_consume_initiation(). Signed-off-by: Frank Werner-Krippendorf --- drivers/net/wireguard/noise.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] wg-quick: add restart command

2020-06-17 Thread Jason A. Donenfeld
On Wed, Jun 17, 2020 at 2:17 AM Eric Light wrote: > > As a purely Debian user, the 'service x restart' pattern is far more > memorable than the syncconf method. I know personal preference isn't a great > reason to add a knob, but Garrit's method is probably going to be much more > familiar to

Re: [PATCH] wg-quick: add restart command

2020-06-17 Thread Eric Light
Sorry, failure to complete my thought before I sent: "wg-quick wg0 restart" fits much more tightly with the familiar "service x restart" pattern. E Q: Why is this email five sentences or less? A: http://five.sentenc.es On Wed, 17 Jun 2020, at

Re: [PATCH v4 1/3] mm/slab: Use memzero_explicit() in kzfree()

2020-06-17 Thread Dan Carpenter
On Tue, Jun 16, 2020 at 08:42:08AM +0200, Michal Hocko wrote: > On Mon 15-06-20 21:57:16, Waiman Long wrote: > > The kzfree() function is normally used to clear some sensitive > > information, like encryption keys, in the buffer before freeing it back > > to the pool. Memset() is currently used

Ubuntu 18.04 broken

2020-06-17 Thread Doug Walker
I see that build issues have been reported, but after updating the server I'm having the same issue with the release from http://ppa.launchpad.net/wireguard/wireguard/ubuntu bionic main. Any eta for an update of the ppa? I've had to switch everyone back to OpenVPN, so it may really be a moot

Kernel Panic after updating Kernel

2020-06-17 Thread dx...@xirihosting.com
Posted this on IRC but got no response, probably this will be a better place: I updated my Centos7 server yesterday and wireguard is causing a kernel panic, wanted to know if this is a known issue? Using kernel 3.10.0-1127.10.1.el7.x86_64 I Tried with 2 different repos (elrepo and Copr repo

Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Dan Carpenter
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote: > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 23c7500eea7d..c08bc7eb20bd 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -1707,17 +1707,17 @@ void *krealloc(const void *p, size_t new_size, gfp_t > flags) >

Re: why multiple call to fmt.Fprintln for printing warning

2020-06-17 Thread Jason A. Donenfeld
On Wed, Jun 17, 2020 at 2:01 AM kolokd wrote: > > reply > > Jun 15, 2020, 4:09 PM by kol...@tutanota.com: > > > https://git.zx2c4.com/wireguard-go/tree/main.go#n39 > > > > why multiple call? > > Patches welcome.

Re: Ubuntu 18.04 broken

2020-06-17 Thread Jason A. Donenfeld
On Wed, Jun 17, 2020 at 2:01 AM Doug Walker wrote: > I see that build issues have been reported, but after updating the > server I'm having the same issue with the release from > http://ppa.launchpad.net/wireguard/wireguard/ubuntu bionic main. > > Any eta for an update of the ppa? > > I've had to

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Michal Hocko
On Tue 16-06-20 17:37:11, Matthew Wilcox wrote: > On Wed, Jun 17, 2020 at 01:01:30AM +0200, David Sterba wrote: > > On Tue, Jun 16, 2020 at 11:53:50AM -0700, Joe Perches wrote: > > > On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote: > > > > v4: > > > > - Break out the memzero_explicit()

[PATCH 2/6] wg-quick: add restart man page

2020-06-17 Thread Garrit Franke
--- src/man/wg-quick.8 | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/man/wg-quick.8 b/src/man/wg-quick.8 index c693a89..01b99ff 100644 --- a/src/man/wg-quick.8 +++ b/src/man/wg-quick.8 @@ -10,6 +10,8 @@ wg-quick - set up a WireGuard interface simply | .I down

[PATCH 6/6] wg-quick: darwin: add restart command

2020-06-17 Thread Garrit Franke
--- src/wg-quick/darwin.bash | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/wg-quick/darwin.bash b/src/wg-quick/darwin.bash index cde1b54..1d32fbe 100755 --- a/src/wg-quick/darwin.bash +++ b/src/wg-quick/darwin.bash @@ -418,7 +418,7 @@ execute_hooks() {

[PATCH 4/6] wg-quick: linux: add notice to restart command

2020-06-17 Thread Garrit Franke
--- src/wg-quick/linux.bash | 1 + 1 file changed, 1 insertion(+) diff --git a/src/wg-quick/linux.bash b/src/wg-quick/linux.bash index 6f42b7f..b888d63 100755 --- a/src/wg-quick/linux.bash +++ b/src/wg-quick/linux.bash @@ -353,6 +353,7 @@ cmd_down() { } cmd_restart() { + [[ " $(wg show

[PATCH] wg-quick: add restart command

2020-06-17 Thread Garrit Franke
This feature seems quite trivial, so I was wondering if there is any reason not to have this command implemented. I didn’t bother implementing it for android, since there is probably next to no chance of anyone using it on that platform. I’d be happy to take your feedback! Thanks, Garrit

[PATCH 3/6] wg-quick: freebsd: add restart command

2020-06-17 Thread Garrit Franke
--- src/wg-quick/freebsd.bash | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/wg-quick/freebsd.bash b/src/wg-quick/freebsd.bash index e1ee67f..81c341b 100755 --- a/src/wg-quick/freebsd.bash +++ b/src/wg-quick/freebsd.bash @@ -387,7 +387,7 @@ execute_hooks() {

[PATCH 5/6] wg-quick: openbsd: add restart command

2020-06-17 Thread Garrit Franke
--- src/wg-quick/openbsd.bash | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/wg-quick/openbsd.bash b/src/wg-quick/openbsd.bash index ffd1834..5ccba03 100755 --- a/src/wg-quick/openbsd.bash +++ b/src/wg-quick/openbsd.bash @@ -390,7 +390,7 @@ execute_hooks()

Re: Problems with Ubuntu 16.04 kernels and wireguard 1.0.20200611

2020-06-17 Thread Jason A. Donenfeld
Hi Gregory, On Wed, Jun 17, 2020 at 2:01 AM Gregory ORIOL wrote: > Since commit e24c9a9265af40781fa27b5de11dd5b78925c5be to > wireguard-linux-compat with a fix for some Ubuntu versions, we are > experiencing a problem with some older, but still LTS, versions of > Ubuntu 16.04: older kernels

Re: Kernel Panic after updating Kernel

2020-06-17 Thread Jason A. Donenfeld
Hi Diego, On Wed, Jun 17, 2020 at 2:01 AM dx...@xirihosting.com wrote: > > Posted this on IRC but got no response, probably this will be a better place: > > I updated my Centos7 server yesterday and wireguard is causing a kernel > panic, wanted to know if this is a known issue? > > Using kernel

Re: why multiple call to fmt.Fprintln for printing warning

2020-06-17 Thread kolokd
reply Jun 15, 2020, 4:09 PM by kol...@tutanota.com: > https://git.zx2c4.com/wireguard-go/tree/main.go#n39 > > why multiple call? >

Re: Android Kernel Backend Bug

2020-06-17 Thread Harsh Shandilya
On Jun 14 2020, at 11:59 pm, ND wrote: > I've been trying to report an issue regarding the Android Kernel > backend on > irc freenode. I was told to email here. > > The problem: > On LTE, my LTE carrier assigns two DNS servers, a private 10.x.x.x IP and > 8.8.8.8. > When using KERNEL

why multiple call to fmt.Fprintln for printing warning

2020-06-17 Thread kolokd
https://git.zx2c4.com/wireguard-go/tree/main.go#n39 why multiple call?

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Michal Hocko
On Wed 17-06-20 05:23:21, Matthew Wilcox wrote: > On Wed, Jun 17, 2020 at 01:31:57PM +0200, Michal Hocko wrote: > > On Wed 17-06-20 04:08:20, Matthew Wilcox wrote: > > > If you call vfree() under > > > a spinlock, you're in trouble. in_atomic() only knows if we hold a > > > spinlock for

dkms packages for rhel/centos have returned

2020-06-17 Thread Jason A. Donenfeld
Hi folks, We switched from dkms to elrepo's kmod a while ago. Unfortunately, while kmod is convenient for some people, it's a disaster for others, especially for folks using custom kernels. For that reason, Joe will be maintaining his copr repo again for dkms packages, for el7 and el8.

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Joe Perches
On Thu, 2020-06-18 at 00:31 +0300, Denis Efremov wrote: > > On 6/16/20 9:53 PM, Joe Perches wrote: > > On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote: > > > v4: > > > - Break out the memzero_explicit() change as suggested by Dan Carpenter > > > so that it can be backported to stable.

Any progress on R_ARM_THM_JUMP11 issues?

2020-06-17 Thread Jason A. Donenfeld
Hi ARM folks, Rui emailed the OpenWRT list and me about an issue he found when compiling WireGuard. He was compiling kernels with CONFIG_THUMB2_AVOID_R_ARM_THM_JUMP11=n -- which I'm well aware the Kconfig advices people not to do -- and got the dreaded "unknown relocation 102" error when trying

Re: Ubuntu 18.04 broken

2020-06-17 Thread Doug Walker
Yep, I just read that. Thank you for your response and all the hard work you guys are putting in. Doug On 6/17/2020 4:21 AM, Jason A. Donenfeld wrote: On Wed, Jun 17, 2020 at 2:01 AM Doug Walker wrote: I see that build issues have been reported, but after updating the server I'm having the

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Matthew Wilcox
On Wed, Jun 17, 2020 at 01:31:57PM +0200, Michal Hocko wrote: > On Wed 17-06-20 04:08:20, Matthew Wilcox wrote: > > If you call vfree() under > > a spinlock, you're in trouble. in_atomic() only knows if we hold a > > spinlock for CONFIG_PREEMPT, so it's not safe to check for in_atomic() > > in

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Matthew Wilcox
On Wed, Jun 17, 2020 at 09:12:12AM +0200, Michal Hocko wrote: > On Tue 16-06-20 17:37:11, Matthew Wilcox wrote: > > Not just performance critical, but correctness critical. Since kvfree() > > may allocate from the vmalloc allocator, I really think that kvfree() > > should assert that it's

Re: wireguard: unknown relocation: 102 [ARMv7 Thumb-2]

2020-06-17 Thread Jason A. Donenfeld
On Wed, Jun 17, 2020 at 02:45:12PM -0600, Jason A. Donenfeld wrote: > Looks like my explanation there wasn't 100% accurate, but it does seem > like the issue occurs when gcc sees a clear tail call that it can > optimize into a B instruction instead of a BL instruction. > > The below patch avoids

RE: Windows Client - UI improvement

2020-06-17 Thread Simon Rozman
> I'm no Picasso, but take a look at the attached. > > Essentially pin the standard set of options to be always visible, and > make the conf area scrollable. No, that's unfortunately not possible with the stock Win32 menu. However, it is possible to move the tunnel list to a submenu. Maybe when

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Jo -l
Bonjour, Désolé, aucune traduction possible, En français pour comprendre! Merci slts > Le 17 06 2020 à 02:37, Matthew Wilcox a écrit : > > On Wed, Jun 17, 2020 at 01:01:30AM +0200, David Sterba wrote: >> On Tue, Jun 16, 2020 at 11:53:50AM -0700, Joe Perches wrote: >>> On Mon, 2020-06-15 at

Wireguard blocks Canon document scanner on macOS Mojave

2020-06-17 Thread Robert Federle
We recently changed the VPN on a Mac computer running the latest 10.14.6 macOS Mojave from OpenVPN to WireGuard and now we have to deal with a weird problem. We use a Canon MB5350 multifunction printer with integrated scanner unit in our office that is connected via Ethernet to our local

Re: Problems with Ubuntu 16.04 kernels and wireguard 1.0.20200611

2020-06-17 Thread Gregory ORIOL
Hi, Thanks for your feedback! Couldn't that issue be fixed by adapting the IF condition that has been changed in commit e24c9a9265af40781fa27b5de11dd5b78925c5be? I know it's not very practical to support/check this, plus it's not wireguard's fault, but that will likely cause trouble to other

Re: wireguard: unknown relocation: 102 [ARMv7 Thumb-2]

2020-06-17 Thread Jason A. Donenfeld
On Wed, Jun 17, 2020 at 02:33:49PM -0600, Jason A. Donenfeld wrote: > So, some more research: it looks like the R_ARM_THM_JUMP11 symbol is > actually wg_packet_send_staged_packets, a boring C function with > nothing fancy about it. That github issue you pointed to suggested > that it might have

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-17 Thread Michal Hocko
On Wed 17-06-20 04:08:20, Matthew Wilcox wrote: > On Wed, Jun 17, 2020 at 09:12:12AM +0200, Michal Hocko wrote: > > On Tue 16-06-20 17:37:11, Matthew Wilcox wrote: > > > Not just performance critical, but correctness critical. Since kvfree() > > > may allocate from the vmalloc allocator, I really

Re: Kernel Panic after updating Kernel

2020-06-17 Thread Jason A. Donenfeld
Hmm, still not able to reproduce. Are you sure you're running the latest up to date module? Try uninstalling kmod-wireguard and reinstalling? What driver is your ethernet NIC using?

Re: Kernel Panic after updating Kernel

2020-06-17 Thread dx...@xirihosting.com
-Original Message- From: "Jason A. Donenfeld" Sent: Wednesday, June 17, 2020 4:32am To: "dx...@xirihosting.com" Cc: "WireGuard mailing list" , "ElRepo" Subject: Re: Kernel Panic after updating Kernel Hi Diego, On Wed, Jun 17, 2020 at 2:01 AM dx...@xirihosting.com wrote: > > Posted