Re: [PATCH net-next] genetlink: start to validate reserved header bytes

2022-08-29 Thread Jason A. Donenfeld
Hi Jakub, On Wed, Aug 24, 2022 at 05:18:30PM -0700, Jakub Kicinski wrote: > diff --git a/drivers/net/wireguard/netlink.c b/drivers/net/wireguard/netlink.c > index d0f3b6d7f408..0c0644e762e5 100644 > --- a/drivers/net/wireguard/netlink.c > +++ b/drivers/net/wireguard/netlink.c > @@ -621,6 +621,7

Re: [PATCH net-next] genetlink: start to validate reserved header bytes

2022-08-29 Thread Paul Moore
On Wed, Aug 24, 2022 at 8:18 PM Jakub Kicinski wrote: > > We had historically not checked that genlmsghdr.reserved > is 0 on input which prevents us from using those precious > bytes in the future. > > One use case would be to extend the cmd field, which is > currently just 8 bits wide and 256 is

Re: [PATCH net-next] genetlink: start to validate reserved header bytes

2022-08-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Wed, 24 Aug 2022 17:18:30 -0700 you wrote: > We had historically not checked that genlmsghdr.reserved > is 0 on input which prevents us from using those precious > bytes in the future. > > One use case would

[PATCH net-next] genetlink: start to validate reserved header bytes

2022-08-24 Thread Jakub Kicinski
We had historically not checked that genlmsghdr.reserved is 0 on input which prevents us from using those precious bytes in the future. One use case would be to extend the cmd field, which is currently just 8 bits wide and 256 is not a lot of commands for some core families. To make sure that