Re: MacOS app update needed
> On Sep 22, 2022, at 04:48, Jason A. Donenfeld wrote:
>
> On Wed, Sep 21, 2022 at 9:31 AM Simon Karberg
> wrote:
>>
>> Hi,
>>
>> I've been testing the Domain Search functionality on all 3 OS'
>> (Windows, Mac & Linux) and the setting:
>>
>> DNS=,
>> Is only being applied on Windows & Linux.
>>
>> Further testing on MacOS I've found that the homebrew installation works.
>> wiregurd-go is version 0.0.20220316 and wireguard-tools is version
>> 1.0.20210914
>>
>> The App Store app is version:
>> App: 1.0.15 (26)
>> Go backend: 2ef39d47
>
> Huh, that's surprising. This was added a few years ago with 9231c035
> ("global: support DNS search domains"), so it definitely *should* be
> supported. Might be a bug with the network config from
> PacketTunnelSettingsGenerator. I'll look into this when circling back
> to wireguard-apple development. Thanks for mentioning it.
>
> Jason
>
Oh, I have a pretty simple patch that fixes this bug that I've been running
locally for months. I keep meaning to figure out the right place to send it,
but keep not having time to look up where that is. Patch included below, anyone
is welcome to use it (attributed or not) or to direct me to send it somewhere
else!
Cheers,
Ken
---
Subject: [PATCH] Qualify routed DNS queries based on search domains.
Rather than unconditionally routing all DNS queries through the
associated tunnel's DNS, only route queries when no search domains
have been specified. When search domains _have_ been specified, route
those domains to the tunnel's DNS but let other domains continue to be
routed to other network interfaces.
---
Sources/WireGuardKit/PacketTunnelSettingsGenerator.swift | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Sources/WireGuardKit/PacketTunnelSettingsGenerator.swift
b/Sources/WireGuardKit/PacketTunnelSettingsGenerator.swift
index c53a82c..5b7f63c 100644
--- a/Sources/WireGuardKit/PacketTunnelSettingsGenerator.swift
+++ b/Sources/WireGuardKit/PacketTunnelSettingsGenerator.swift
@@ -88,7 +88,13 @@ class PacketTunnelSettingsGenerator {
let dnsSettings = NEDNSSettings(servers: dnsServerStrings)
dnsSettings.searchDomains = tunnelConfiguration.interface.dnsSearch
if !tunnelConfiguration.interface.dns.isEmpty {
-dnsSettings.matchDomains = [""] // All DNS queries must first
go through the tunnel's DNS
+if tunnelConfiguration.interface.dnsSearch.isEmpty {
+// Since no search domains were listed, use this tunnel's
DNS for all queries
+dnsSettings.matchDomains = [""]
+} else {
+// Only use this tunnel for the listed search domains
+dnsSettings.matchDomains =
tunnelConfiguration.interface.dnsSearch
+}
}
networkSettings.dnsSettings = dnsSettings
}
-- 2.37.0 (Apple Git-136)
Re: MacOS app update needed
- On Sep 22, 2022, at 6:43 AM, Jason A. Donenfeld ja...@zx2c4.com wrote: > On Wed, Sep 21, 2022 at 10:22 AM Bruno wrote: >> >> Hi, >> >> Windows Client project don't feel alive either. Last commit has 6 months >> and last release is 9 month old. >> >> Same, here https://git.zx2c4.com/wireguard-windows/log/ and here >> https://github.com/WireGuard/wireguard-windows >> >> Version 0.5.3 works well, but I suppose it can be even better! > > That seems pretty uncalled for. Folks asking for a wireguard-apple > update have good reason to do so -- there are outstanding bugs and > pull requests. But for wireguard-windows/wireguard-nt? C'mon now -- > that's received some *extremely* active development, stabilizing after > nearly weekly updates for some time. Are there outstanding pull > requests for it? So your note here really isn't appreciated. The > WireGuard project doesn't churn out code and updates just for the sake > of writing code and doing updates. Things need to have rationale. > There will be updates to wireguard-windows/wireguard-nt at some point > when development makes sense there. But right now? Is there something > pending? Instead maybe be thankful that that software has reached a > point of stability where project development energies can go into more > pressing tasks, such as wireguard-apple. > > Jason I could not agree more. What a world we live in where code that hasn't been touched for a few months is considered stale, rather than being rewarded and appreciated for reliability and stability. Jason, congratulations on not needing to touch that code for six months! Much of the beauty of Wireguard is its simplicity, to the point that it can be done "right", and it really shouldn't need to be touched!
Re: MacOS app update needed
On Thu, Sep 22, 2022 at 03:26:11PM +0200, Bruno wrote: > We also had a constructive chat in November (with Diab Neiroukh) on this > list. You made an appreciated change, but the question remained opened. The change from that discussion is in 0.5.3: https://git.zx2c4.com/wireguard-windows/commit/?id=8120d07dd5fc9a5e545419fe13490086ce920f31
Re: MacOS app update needed
Hi, I'm sorry if my question was awkward. Like I said, it works well. I never asked for useless development. I'm just surprised last commits are not included in a release. We also had a constructive chat in November (with Diab Neiroukh) on this list. You made an appreciated change, but the question remained opened. I really admire your work and simply asked if something was planned. I understand you have priorities and won't bother you any longer. Regards. Bruno Le 22/09/2022 à 14:04, Lewis Donzis a écrit : - On Sep 22, 2022, at 6:43 AM, Jason A. Donenfeld ja...@zx2c4.com wrote: On Wed, Sep 21, 2022 at 10:22 AM Bruno wrote: Hi, Windows Client project don't feel alive either. Last commit has 6 months and last release is 9 month old. Same, here https://git.zx2c4.com/wireguard-windows/log/ and here https://github.com/WireGuard/wireguard-windows Version 0.5.3 works well, but I suppose it can be even better! That seems pretty uncalled for. Folks asking for a wireguard-apple update have good reason to do so -- there are outstanding bugs and pull requests. But for wireguard-windows/wireguard-nt? C'mon now -- that's received some *extremely* active development, stabilizing after nearly weekly updates for some time. Are there outstanding pull requests for it? So your note here really isn't appreciated. The WireGuard project doesn't churn out code and updates just for the sake of writing code and doing updates. Things need to have rationale. There will be updates to wireguard-windows/wireguard-nt at some point when development makes sense there. But right now? Is there something pending? Instead maybe be thankful that that software has reached a point of stability where project development energies can go into more pressing tasks, such as wireguard-apple. Jason I could not agree more. What a world we live in where code that hasn't been touched for a few months is considered stale, rather than being rewarded and appreciated for reliability and stability. Jason, congratulations on not needing to touch that code for six months! Much of the beauty of Wireguard is its simplicity, to the point that it can be done "right", and it really shouldn't need to be touched!
Re: MacOS app update needed
On Wed, Sep 21, 2022 at 9:31 AM Simon Karberg wrote:
>
> Hi,
>
> I've been testing the Domain Search functionality on all 3 OS'
> (Windows, Mac & Linux) and the setting:
>
> DNS=,
> Is only being applied on Windows & Linux.
>
> Further testing on MacOS I've found that the homebrew installation works.
> wiregurd-go is version 0.0.20220316 and wireguard-tools is version
> 1.0.20210914
>
> The App Store app is version:
> App: 1.0.15 (26)
> Go backend: 2ef39d47
Huh, that's surprising. This was added a few years ago with 9231c035
("global: support DNS search domains"), so it definitely *should* be
supported. Might be a bug with the network config from
PacketTunnelSettingsGenerator. I'll look into this when circling back
to wireguard-apple development. Thanks for mentioning it.
Jason
Re: MacOS app update needed
On Wed, Sep 21, 2022 at 10:22 AM Bruno wrote: > > Hi, > > Windows Client project don't feel alive either. Last commit has 6 months > and last release is 9 month old. > > Same, here https://git.zx2c4.com/wireguard-windows/log/ and here > https://github.com/WireGuard/wireguard-windows > > Version 0.5.3 works well, but I suppose it can be even better! That seems pretty uncalled for. Folks asking for a wireguard-apple update have good reason to do so -- there are outstanding bugs and pull requests. But for wireguard-windows/wireguard-nt? C'mon now -- that's received some *extremely* active development, stabilizing after nearly weekly updates for some time. Are there outstanding pull requests for it? So your note here really isn't appreciated. The WireGuard project doesn't churn out code and updates just for the sake of writing code and doing updates. Things need to have rationale. There will be updates to wireguard-windows/wireguard-nt at some point when development makes sense there. But right now? Is there something pending? Instead maybe be thankful that that software has reached a point of stability where project development energies can go into more pressing tasks, such as wireguard-apple. Jason
Re: MacOS app update needed
On Thu, Sep 22, 2022 at 1:32 PM Harald Dunkel wrote: > Maybe Apple would include wireguard into MacOS' kernel as well, > if there is sufficient demand for this feature? Make I offered to do a kernel implementation for them, but they never got back to me.
Re: MacOS app update needed
On Wed, Sep 21, 2022 at 9:55 AM Houman wrote: > > Hi Simon, > > Not only that, even the repo > https://github.com/WireGuard/wireguard-apple hasn't been updated since > 27 Sep 2021. > There are a number of useful contributions in the form of pull > requests waiting there to be approved for over 8 months. > > The project feels abandoned, which is such a shame. It really isn't abandoned. Please don't worry. No reason to start freaking out.
Re: MacOS app update needed
I would love to have an update for Wireguard on MacOS and Ios. Maybe Apple would include wireguard into MacOS' kernel as well, if there is sufficient demand for this feature? Make yourself heard at Apple's feedback page for MacOS. Regards Harri
Re: MacOS app update needed
Hi, Windows Client project don't feel alive either. Last commit has 6 months and last release is 9 month old. Same, here https://git.zx2c4.com/wireguard-windows/log/ and here https://github.com/WireGuard/wireguard-windows Version 0.5.3 works well, but I suppose it can be even better! Any plans for some update? Regards Bruno Le 21/09/2022 à 09:52, Houman a écrit : Hi Simon, Not only that, even the repo https://github.com/WireGuard/wireguard-apple hasn't been updated since 27 Sep 2021. There are a number of useful contributions in the form of pull requests waiting there to be approved for over 8 months. The project feels abandoned, which is such a shame. Regards, Houman
Re: MacOS app update needed
Hi Simon, Not only that, even the repo https://github.com/WireGuard/wireguard-apple hasn't been updated since 27 Sep 2021. There are a number of useful contributions in the form of pull requests waiting there to be approved for over 8 months. The project feels abandoned, which is such a shame. Regards, Houman On Wed, 21 Sept 2022 at 08:33, Simon Karberg wrote: > > Hi, > > I've been testing the Domain Search functionality on all 3 OS' > (Windows, Mac & Linux) and the setting: > > DNS=, > Is only being applied on Windows & Linux. > > Further testing on MacOS I've found that the homebrew installation works. > wiregurd-go is version 0.0.20220316 and wireguard-tools is version > 1.0.20210914 > > The App Store app is version: > App: 1.0.15 (26) > Go backend: 2ef39d47 > > The app in the App Store hasn't been updated in 11 months, maybe it's > time to get it on the newest backend?
