https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14289

            Bug ID: 14289
           Summary: BSSAP packet dissector issue -
                    BSSAP_UPLINK_TUNNEL_REQUEST message
           Product: Wireshark
           Version: 2.4.2
          Hardware: x86
                OS: Windows 7
            Status: UNCONFIRMED
          Severity: Normal
          Priority: Low
         Component: Dissection engine (libwireshark)
          Assignee: bugzilla-ad...@wireshark.org
          Reporter: konstantinos.matsiou...@nokia.com
  Target Milestone: ---

Build Information:
Version 2.4.2 (v2.4.2-0-gb6c63ae086)

Copyright 1998-2017 Gerald Combs <ger...@wireshark.org> and contributors.
License GPLv2+: GNU GPL version 2 or later
<http://www.gnu.org/licenses/old-licenses/gpl-2.0.html>
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with Qt 5.6.3, with WinPcap (4_1_3), with GLib 2.42.0, with
zlib 1.2.8, with SMI 0.4.8, with c-ares 1.12.0, with Lua 5.2.4, with GnuTLS
3.4.11, with Gcrypt 1.7.6, with MIT Kerberos, with GeoIP, with nghttp2 1.14.0,
with LZ4, with Snappy, with libxml2 2.9.4, with QtMultimedia, with AirPcap,
with
SBC, with SpanDSP.

Running on 64-bit Windows 7 Service Pack 1, build 7601, with        Intel(R)
Core(TM) i5-3340M CPU @ 2.70GHz (with SSE4.2), with 16263 MB of physical
memory,
with locale Greek_Greece.1253, with WinPcap version 4.1.3 (packet.dll version
4.1.0.2980), based on libpcap version 1.0 branch 1_0_rel0b (20091008), with
GnuTLS 3.4.11, with Gcrypt 1.7.6, without AirPcap.

Built using Microsoft Visual C++ 14.0 build 24215

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information
--
Hello,

I noticed that in message BSSAP+-UPLINK-TUNNEL-REQUEST Wireshark reports in
decoded packet below errors: 

Mandatory IE SGSN number expected but IE IMSI Found

Mandatory IE Uplink Tunnel Payload Control and Info expected but IE IMSI detach
from GPRS service type Found


According to TS 3GPP 29.018(Gs interface layer 3 specification) paragraph
17.1.23       BSSAP+-UPLINK-TUNNEL-REQUEST message 

Table 17.1.23 shows that Mandatory IEs are : IMSI, SGSN number and Uplink
Tunnel Payload Control and Info

Packet actually contains as per 3GPP all mandatory IEs.

Searched a bit and found the BSSAP packet dissector:
https://github.com/boundary/wireshark/blob/master/epan/dissectors/packet-bssap.c

It seems that in static void dissect_bssap_plus function, mandatory IE IMSI is
not encoded, check below part:

 case BSSAP_UPLINK_TUNNEL_REQUEST:           /*  17.1.23 */
        /* SGSN number 18.4.22 M TLV 5-11 */
        if (check_ie(tvb, tree, &offset, BSSAP_SGSN_NUMBER))
            offset = dissect_bssap_sgsn_number(tvb, bssap_tree, offset);

        /* Uplink Tunnel Payload Control and Info 18.4.25 M TLV 3-223 */
        if (check_ie(tvb, tree, &offset, BSSAP_ULINK_TNL_PLD_CTR_AND_INF))
            offset = dissect_bssap_ulink_tunnel_payload_control_and_info(tvb,
pinfo, bssap_tree, offset);

        if (tvb_length_remaining(tvb, offset) <= 0)
            return;
        proto_tree_add_text(tree, tvb, offset, -1, "Extraneous data");
break;


Could you please let me know if my concern is right and this can be fixed in
later WS release?

Best regards,
Konstantinos

-- 
You are receiving this mail because:
You are watching all bug changes.
___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
             mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

Reply via email to