https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14979

            Bug ID: 14979
           Summary: Wireshark main window crashes because df_combo_box_
                    isn't initialized
           Product: Wireshark
           Version: Git
          Hardware: x86
                OS: Windows 10
            Status: UNCONFIRMED
          Severity: Major
          Priority: Low
         Component: Qt UI
          Assignee: bugzilla-ad...@wireshark.org
          Reporter: mman...@netscape.net
  Target Milestone: ---

Build Information:
Version 2.9.0 (v2.9.0rc0-1227-gdc28665d) 
Copyright 1998-2018 Gerald Combs <ger...@wireshark.org> and contributors.
License GPLv2+: GNU GPL version 2 or later
<http://www.gnu.org/licenses/old-licenses/gpl-2.0.html> This is free software;
see the source for copying conditions. There is NO warranty; not even for
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. 
Compiled (64-bit) with Qt 5.11.1, with WinPcap (4_1_3), with GLib 2.52.2, with
zlib 1.2.11, with SMI 0.4.8, with c-ares 1.14.0, with Lua 5.2.4, with GnuTLS
3.4.11, with Gcrypt 1.7.6, with MIT Kerberos, with MaxMind DB resolver, with
nghttp2 1.14.0, with LZ4, with Snappy, with libxml2 2.9.4, with QtMultimedia,
with AirPcap, with SBC, with SpanDSP, with bcg729. 
Running on 64-bit Windows 10 (1709), build 16299, with Intel(R) Core(TM)
i7-8550U CPU @ 1.80GHz (with SSE4.2), with 16218 MB of physical memory, with
locale English_United States.1252, with WinPcap version 4.1.3 (packet.dll
version 4.1.0.2980), based on libpcap version 1.0 branch 1_0_rel0b (20091008),
with GnuTLS 3.4.11, with Gcrypt 1.7.6, with AirPcap 4.1.0 build 1622, binary
plugins supported (15 loaded). Built using Microsoft Visual C++ 14.14 build
26431 
Wireshark is Open Source Software released under the GNU General Public
License. 
Check the man page and http://www.wireshark.org for more information. 
--
When I start Wireshark on Windows 10 (development, Release build), I get an
immediate crash.  I switched to Debug build and was able to trace the problem
to the df_combo_box_ member variable being NULL in MainWindow::resizeEvent. 
The patch below fixes it, but I'm worried it's masking the symptom of a bigger
problem (otherwise I would just push the patch).

diff --git a/ui/qt/main_window.cpp b/ui/qt/main_window.cpp
index a8d98568f3..81ed62915e 100644
--- a/ui/qt/main_window.cpp
+++ b/ui/qt/main_window.cpp
@@ -2405,7 +2405,8 @@ void MainWindow::changeEvent(QEvent* event)

 void MainWindow::resizeEvent(QResizeEvent *event)
 {
-    df_combo_box_->setMinimumWidth(width() * 2 / 3); // Arbitrary
+    if (df_combo_box_)
+        df_combo_box_->setMinimumWidth(width() * 2 / 3); // Arbitrary
     QMainWindow::resizeEvent(event);
 }

-- 
You are receiving this mail because:
You are watching all bug changes.
___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
             mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

Reply via email to