[Wireshark-bugs] [Bug 15235] New: ?

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15235

Bug ID: 15235
   Summary: ?
   Product: Wireshark
   Version: unspecified
  Hardware: All
OS: Windows 7
Status: UNCONFIRMED
  Severity: Major
  Priority: Low
 Component: Qt UI
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: lovebaby19890...@gmail.com
  Target Milestone: ---

Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15235] ?

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15235

Pascal Quantin  changed:

   What|Removed |Added

 CC||pascal.quan...@gmail.com
 Resolution|--- |NOTABUG
Product|Wireshark   |Web sites
  Component|Qt UI   |Bugzilla Spam
 Status|UNCONFIRMED |RESOLVED
Version|unspecified |N/A

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15132] Invalid write in dissect_segment_ofstable()

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15132

--- Comment #6 from Gerrit Code Review  ---
Change 30347 had a related patch set uploaded by Peter Wu:
LBMPDM: fix heap-buffer-overflow (write) in dissect_segment_ofstable

https://code.wireshark.org/review/30347

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15132] Invalid write in dissect_segment_ofstable()

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15132

--- Comment #5 from Gerrit Code Review  ---
Change 30346 merged by Peter Wu:
LBMPDM: fix heap-buffer-overflow (write) in dissect_segment_ofstable

https://code.wireshark.org/review/30346

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15132] Invalid write in dissect_segment_ofstable()

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15132

--- Comment #4 from Gerrit Code Review  ---
Change 30346 had a related patch set uploaded by Peter Wu:
LBMPDM: fix heap-buffer-overflow (write) in dissect_segment_ofstable

https://code.wireshark.org/review/30346

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15132] Invalid write in dissect_segment_ofstable()

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15132

--- Comment #7 from Gerrit Code Review  ---
Change 30347 merged by Peter Wu:
LBMPDM: fix heap-buffer-overflow (write) in dissect_segment_ofstable

https://code.wireshark.org/review/30347

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15132] Invalid write in dissect_segment_ofstable()

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15132

Peter Wu  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #8 from Peter Wu  ---
Fixed heap-buffer-overflow (write) in:
v2.9.0rc0-2305-g5797f60274
v2.6.5rc0-54-g1ec5a933e1
v2.4.11rc0-20-g9c8645ec7b

This has a quite high severity as an attacker can write arbitrary data at
arbitrary addresses before the packet-scoped memory.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15234] Add CableLabs vendor option /* 61 */ CCAP-CORES to packet-dhcpv6.c

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15234

Alexis La Goutte  changed:

   What|Removed |Added

 Status|UNCONFIRMED |INCOMPLETE
 Ever confirmed|0   |1
 CC||alexis.lagou...@gmail.com

--- Comment #1 from Alexis La Goutte  ---
Hi Jeff,

Can you push your fix directly on Gerrit ? https://code.wireshark.org/review/
http://wiki.wireshark.org/Development/SubmittingPatches

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15236] New: ISUP (ANSI) packets malformed in WS versions later than 2.4.8

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15236

Bug ID: 15236
   Summary: ISUP (ANSI) packets malformed in WS versions later
than 2.4.8
   Product: Wireshark
   Version: 2.6.3
  Hardware: x86
OS: Windows 10
Status: UNCONFIRMED
  Severity: Major
  Priority: High
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: ha...@radcom.com
  Target Milestone: ---

Created attachment 16673
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=16673=edit
Reference PCAP that demonstrates the problem

Build Information:
Version 2.6.3 (v2.6.3-0-ga62e6c27) 
Copyright 1998-2018 Gerald Combs  and contributors.
License GPLv2+: GNU GPL version 2 or later
 This is free software;
see the source for copying conditions. There is NO warranty; not even for
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. 
Compiled (64-bit) with Qt 5.9.5, with WinPcap (4_1_3), with GLib 2.42.0, with
zlib 1.2.11, with SMI 0.4.8, with c-ares 1.14.0, with Lua 5.2.4, with GnuTLS
3.4.11, with Gcrypt 1.7.6, with MIT Kerberos, with MaxMind DB resolver, with
nghttp2 1.14.0, with LZ4, with Snappy, with libxml2 2.9.4, with QtMultimedia,
with AirPcap, with SBC, with SpanDSP, with bcg729. 
Running on 64-bit Windows 10, build 17134, with Intel(R) Core(TM) i5-6200U CPU
@ 2.30GHz (with SSE4.2), with 8072 MB of physical memory, with locale
English_United States.1255, with WinPcap version 4.1.3 (packet.dll version
4.1.0.2980), based on libpcap version 1.0 branch 1_0_rel0b (20091008), with
GnuTLS 3.4.11, with Gcrypt 1.7.6, without AirPcap, binary plugins supported (14
loaded). Built using Microsoft Visual C++ 14.12 build 25835 
Wireshark is Open Source Software released under the GNU General Public
License. 
Check the man page and http://www.wireshark.org for more information. 
--
SS7 IAM is marked as "Malformed packet", the capture was tested in several WS
versions and the problem appears in 2.4.8 onward.

***
Frame 1: 150 bytes on wire (1200 bits), 150 bytes captured (1200 bits)
Ethernet II, Src: Microtel_10:04:04 (f0:6e:32:10:04:04), Dst: fa:16:3e:49:a1:bc
(fa:16:3e:49:a1:bc)
Internet Protocol Version 4, Src: 10.0.0.1, Dst: 10.0.0.2
Stream Control Transmission Protocol, Src Port: 2904 (2904), Dst Port: 2904
(2904)
MTP 2 User Adaptation Layer
Message Transfer Part Level 3
ISDN User Part
[Malformed Packet: ISUP]
[Expert Info (Error/Malformed): Malformed Packet (Exception occurred)]
[Malformed Packet (Exception occurred)]

[Severity level: Error]
[Group: Malformed]

***

reference PCAP attached.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15209] Feature request: support for the Secure Reliable Transport (SRT) protocol

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15209

--- Comment #5 from Maxim  ---
Created attachment 16675
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=16675=edit
SRT file transmission in client/listener mode

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15234] Add CableLabs vendor option /* 61 */ CCAP-CORES to packet-dhcpv6.c

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15234

--- Comment #2 from Jeff Forhan  ---
(In reply to Alexis La Goutte from comment #1)
> Hi Jeff,
> 
> Can you push your fix directly on Gerrit ?
> https://code.wireshark.org/review/
> http://wiki.wireshark.org/Development/SubmittingPatches

Sure. I realized I put the wrong diff here. I have a more current one with the
order correct so Wireshark does not go into a non-linear search.

I also updated the CableLabs TLV5 options to be up to date:

--- epan/dissectors/packet-dhcpv6.orig  2018-10-23 10:54:43.0 -0400
+++ epan/dissectors/packet-dhcpv6.c 2018-10-23 10:53:42.0 -0400
@@ -624,6 +624,7 @@
 #define CL_OPTION_RFC868_SERVERS  0x0025 /* 37 */
 #define CL_OPTION_TIME_OFFSET 0x0026 /* 38 */
 #define CL_OPTION_IP_PREF 0x0027 /* 39 */
+#define CL_OPTION_CCAP_CORES  0x003D /* 61 */

 /** CableLabs DOCSIS Project Vendor Specific Options */
 #define CL_OPTION_DOCS_CMTS_CAP 0x0401  /* 1025 */
@@ -657,6 +658,7 @@
 /*   37 */ { CL_OPTION_RFC868_SERVERS,  "Time Protocol Servers : "
},
 /*   38 */ { CL_OPTION_TIME_OFFSET, "Time Offset = " },
 /*   39 */ { CL_OPTION_IP_PREF, "IP preference : " },
+/*   61 */ { CL_OPTION_CCAP_CORES,  "CCAP-CORES : " },
 /* 1025 */ { CL_OPTION_DOCS_CMTS_CAP,   "CMTS Capabilities Option
: " },
 /* 1026 */ { CL_CM_MAC_ADDR,"CM MAC Address Option = "
},
 /* 1027 */ { CL_EROUTER_CONTAINER_OPTION,   "eRouter Container Option
: " },
@@ -760,8 +762,27 @@
 { 40,  "Extended Upstream Transmit Power Capability" },
 { 41,  "Optional 802.1ad, 802.1ah, MPLS Classification Support" },
 { 42,  "D-ONU Capabilities Encoding" },
-{ 43,  "TBD" },
+{ 43,  "Reserved" },
 { 44,  "Energy Management Capabilities" },
+/* Added TLV5.45-62 from CL-SP-CANN-I18-180509 */
+{ 45,  "C-DOCSIS Capability Encoding" },
+{ 46,  "CM-STATUS-ACK" },
+{ 47,  "Energy Management Preferences" },
+{ 48,  "Extended Packet Length Support Capability" },
+{ 49,  "Multiple Receive OFDM Channel Support" },
+{ 50,  "Multiple Transmit OFDMA Channel Support" },
+{ 51,  "Downstream OFDM Profile Support" },
+{ 52,  "Downstream OFDM channel subcarrier QAM modulation support" },
+{ 53,  "Upstream OFDM channel subcarrier QAM modulation support" },
+{ 54,  "Downstream Lower Band Edge Support" },
+{ 55,  "Downstream Upper Band Edge Support" },
+{ 56,  "Upstream Upper Band Edge Support" },
+{ 57,  "DOCSIS Time Protocol Support" },
+{ 58,  "DOCSIS Time Protocol Performance Support" },
+{ 59,  "Pmax" },
+{ 60,  "Diplexer Downstream Lower Band Edge" },
+{ 61,  "Diplexer Downstream Upper Band Edge" },
+{ 62,  "Diplexer Upstream Upper Band Edge" },
 { 0, NULL },
 };
 static value_string_ext modem_capabilities_encoding_ext =
VALUE_STRING_EXT_INIT(modem_capabilities_encoding);
@@ -1166,6 +1187,7 @@
 case CL_OPTION_TFTP_SERVERS:
 case CL_OPTION_SYSLOG_SERVERS:
 case CL_OPTION_RFC868_SERVERS:
+case CL_OPTION_CCAP_CORES:
 field_len = 16;
 opt_len = tlv_len;
 subtree = proto_item_add_subtree(ti,
ett_dhcpv6_vendor_option);



I will upload the diff and file to the link you gave.

Jeff

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15209] Feature request: support for the Secure Reliable Transport (SRT) protocol

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15209

--- Comment #6 from Maxim  ---
Guys, I've updated the SRT dissector.
There is one issue with both UDT and SRT dissectors. Basically, SRT has a
handshake packet version 5, which UDT does not handle. However, in a listener /
caller mode the connection starts with a handshake packet v.4, that is accepted
by the UDT dissector, even though the following HS packets have v.5 (unless one
of the parties does not support it). Example: attachment 16675 [details].

I wonder what would be the best way to handle this? It looks like we have to
either modify the existing UDT dissector to handle both SRT and UDT, like Uli
has advised. Or to take over the UDT dissector by the the new one, that has to
handle UDT as well. And there should be the way to remember the state iof the
dissector: UDT or SRT.
Another option I see is to modify the UDT dissector to pass the packet on to
the SRT. But I am bnot sure if this fits well the architecture of WireShark.
Or, the final one, to have both dissectors separately.

Here is an SRT Protocol Technical Overview (PDF)
https://github.com/Haivision/srt/issues/479 for more details on the protocol.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15209] Feature request: support for the Secure Reliable Transport (SRT) protocol

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15209

--- Comment #4 from Maxim  ---
Created attachment 16674
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=16674=edit
SRT Rendezvous network capture

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15207] Changing language setting doesn't change the language used

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15207

Samuel  changed:

   What|Removed |Added

 CC||samu...@nurfuerspam.de

--- Comment #12 from Samuel  ---
The file ui/qt/wireshark_de.ts in the master-2.6 branch is only 277 lines long.
The one in the master branch contains over 12000 lines. Is seems that the most
of the translated strings were removed in commit
066ab657c4d1e77547c908c81b1bd76b7cca881c .

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15234] Add CableLabs vendor option /* 61 */ CCAP-CORES to packet-dhcpv6.c

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15234

--- Comment #3 from Jeff Forhan  ---
Committed via https://code.wireshark.org/review/#/c/30353/

Added 'Bug: 15234' to Commit Message

Jeff

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15231] [oss-fuzz] ASAN: 22 bytes leaked in epan/dissectors/packet-rtp-ed137.c:688

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15231

--- Comment #5 from Jiri Novak  ---
Hi Peter,

> So are both times effectively relative?

yes, they are.

I prepared patch based on your idea, but it doesn't work. I mean it creates
segfault, because code is:

tmp = rel_time_to_secs_str(NULL, _time);

proto_tree_add_uint_format_value( tree, time_item, tvb, hdrext_offset, 3,
time_value, "%s s", tmp);

wmem_free(NULL, tmp);

In other words, I allocate tmp_time, but free it once it is formated. If I
allocate it from packed (or any other) wmem, it is double freed and it fails.

Back to the original request - you observed memory leak, but I'm afraid it is
not caused by this piece of code. Do you have more information from where it
can come?

Best regards,

Jirka Novak

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15234] Add CableLabs vendor option /* 61 */ CCAP-CORES to packet-dhcpv6.c

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15234

--- Comment #4 from Gerrit Code Review  ---
Change 30353 merged by Alexis La Goutte:
DHCPv6: Added CableLabs Option 61 for "CCAP-CORES"

https://code.wireshark.org/review/30353

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15234] Add CableLabs vendor option /* 61 */ CCAP-CORES to packet-dhcpv6.c

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15234

Alexis La Goutte  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|INCOMPLETE  |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15207] Changing language setting doesn't change the language used

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15207

--- Comment #13 from Gerald Combs  ---
(In reply to Samuel from comment #12)
> The file ui/qt/wireshark_de.ts in the master-2.6 branch is only 277 lines
> long.
> The one in the master branch contains over 12000 lines. Is seems that the
> most of the translated strings were removed in commit
> 066ab657c4d1e77547c908c81b1bd76b7cca881c .

That was a result of running tools/update-tx. It doesn't do any checks for
removed lines. It probably should.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15231] [oss-fuzz] ASAN: 22 bytes leaked in epan/dissectors/packet-rtp-ed137.c:688

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15231

--- Comment #6 from Peter Wu  ---
(In reply to Jiri Novak from comment #5)
> I prepared patch based on your idea, but it doesn't work. I mean it creates
> segfault, because code is:
> 
> tmp = rel_time_to_secs_str(NULL, _time);
> 
> proto_tree_add_uint_format_value( tree, time_item, tvb, hdrext_offset,
> 3, time_value, "%s s", tmp);
> 
> wmem_free(NULL, tmp);
> 
> In other words, I allocate tmp_time, but free it once it is formated. If I
> allocate it from packed (or any other) wmem, it is double freed and it fails.

The idea of using wmem scopes is that it'll be freed when the scope is
destroyed. So you can omit wmem_free completely when using wmem_packet_scope().

> Back to the original request - you observed memory leak, but I'm afraid it
> is not caused by this piece of code. Do you have more information from where
> it can come?

It happens in the else branch (which did not have a wmem_free(NULL, tmp) call).
While that could simply be added, I thought about going one step further and
merge both branches (and use wmem_packet_scope()) since they are equivalent.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15207] Changing language setting doesn't change the language used

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15207

--- Comment #14 from Anders Broman  ---
(In reply to Gerald Combs from comment #13)
> (In reply to Samuel from comment #12)
> > The file ui/qt/wireshark_de.ts in the master-2.6 branch is only 277 lines
> > long.
> > The one in the master branch contains over 12000 lines. Is seems that the
> > most of the translated strings were removed in commit
> > 066ab657c4d1e77547c908c81b1bd76b7cca881c .
> 
> That was a result of running tools/update-tx. It doesn't do any checks for
> removed lines. It probably should.

Still if the source lost all those lines that's not good either.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15207] Changing language setting doesn't change the language used

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15207

--- Comment #15 from Gerald Combs  ---
(In reply to Anders Broman from comment #14)
> Still if the source lost all those lines that's not good either.

It looks like `tx pull` clobbers our translation files, which are then
overwritten when we run `tx push`. I reverted commit 066ab657c4 and disabled
`tx pull -f` in change 30360.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 15231] [oss-fuzz] ASAN: 22 bytes leaked in epan/dissectors/packet-rtp-ed137.c:688

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15231

--- Comment #7 from Gerrit Code Review  ---
Change 30362 had a related patch set uploaded by Jirka Novak:
RTP.ED-137: Memleak fixed

https://code.wireshark.org/review/30362

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe