[Wireshark-bugs] [Bug 13018] New: abi-compliance-checker isn't finding glib in the "check abi" step

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13018

Bug ID: 13018
   Summary: abi-compliance-checker isn't finding glib in the
"check abi" step
   Product: Wireshark
   Version: Git
  Hardware: x86-64
OS: Debian
Status: UNCONFIRMED
  Severity: Major
  Priority: Low
 Component: Build process
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: g...@alum.mit.edu

Build Information:
Current master, 2.2, and 2.0 branches
--
The "check abi" step is failing with:

rm -rf abi-check-headers abi_dumps .libs/*.abi.tar.gz
mkdir abi-check-headers
cp *.h ../ws_symbol_export.h abi-check-headers/
abi-compliance-checker -log-path abi_logs/log.txt -l libwiretap -v1 `readlink
.libs/libwiretap.so | sed 's/.*\.so\.//'` \
-relpath
/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/build/wiretap
-dump-abi abi-descriptor.xml || \
cat abi_logs/log.txt
Using GCC 5.4.0 (x86_64-linux-gnu, target: x86_64)
checking header(s) 0.0.0 ...
ERROR: some errors occurred when compiling headers
ERROR: see log for details:
 
/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/build/wiretap/abi_logs/log.txt

ERROR: can't compile header(s)
Temporary header file '/tmp/gDlYQSHa01/dump1.h' with the following content will
be compiled to create GCC translation unit dump:

  // add includes
  #include
"/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/build/config.h"
  #include
"/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/build/wiretap/abi-check-headers/libpcap.h"

...


The GCC parameters:
  gcc -fdump-translation-unit -fkeep-inline-functions -c -x c++-header
-fpermissive -w  -D_U_="__attribute((unused))" "/tmp/gDlYQSHa01/dump1.h" 
-I/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/build
-I/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/build/wiretap

In file included from /tmp/gDlYQSHa01/dump1.h:4:0:
/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/build/wiretap/abi-check-headers/libpcap.h:24:18:
fatal error: glib.h: No such file or directory
compilation terminated.

Do we need to pass some flag to the ABI checker to tell it where to look for
GLib headers, or something such as that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13018] abi-compliance-checker isn't finding glib.h in the "check abi" step

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13018

Guy Harris  changed:

   What|Removed |Added

Summary|abi-compliance-checker  |abi-compliance-checker
   |isn't finding glib in the   |isn't finding glib.h in the
   |"check abi" step|"check abi" step

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 2803] Wireshark build fails if c-ares version < 1.5

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2803

Guy Harris  changed:

   What|Removed |Added

  Component|GTK+ UI |Dissection engine
   ||(libwireshark)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 7134] Wireshark is unable to display the correct IEEE802.11 MCS data rates due to header definition is unsigned 8-bit integer

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7134

Guy Harris  changed:

   What|Removed |Added

  Component|TShark  |Dissection engine
   ||(libwireshark)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 6354] Calling proto_tree_add_item with FT_BYTES causing failed assertion

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6354

Guy Harris  changed:

   What|Removed |Added

  Component|GTK+ UI |Dissection engine
   ||(libwireshark)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 7401] wireshark crashes when starting due to out-of-date plugin left behind from earlier installation

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7401

Guy Harris  changed:

   What|Removed |Added

  Component|GTK+ UI |Build process

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 4346] TOC relocation error on PPC64

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4346

Guy Harris  changed:

   What|Removed |Added

  Component|GTK+ UI |Build process
 Resolution|NOTABUG |NOTOURBUG

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

--- Comment #10 from Gerrit Code Review  ---
Change 18202 merged by Anders Broman:
Retrieve CLNP option values from the right place

https://code.wireshark.org/review/18202

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

Gerrit Code Review  changed:

   What|Removed |Added

 Status|VERIFIED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

--- Comment #9 from Gerrit Code Review  ---
Change 18201 merged by Anders Broman:
Retrieve CLNP option values from the right place

https://code.wireshark.org/review/18201

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13012] sshdump does not save password

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13012

--- Comment #4 from djcanadianj...@gmail.com ---
even if it had a checkbox to offer to save the password?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12951] Implement RFC 6551 dissection in ICMPv6 dissector

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12951

--- Comment #5 from Jaap Keuter  ---
The errored packet is related to line 2533 in your change of packet-icmpv6.c. 

The (incorrect) length value '1' causes the metric_len variable to underflow,
rolling over to 255. Then it continues to dissect the data as DAG Metric
Container ad infinitum. Or more precisely, until that TVB runs out of data.

This should not happen, as in, your dissector should withstand protocol errors
in the packet it receives (which are the circumstances Wireshark gets called in
to help) as well as possible. Changing this to gint should work fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13017] Lua dissector crashes on "string.format("%s", tree.text)"

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13017

--- Comment #2 from Redford  ---
(In reply to Jaap Keuter from comment #1)
> See the very last section (2.11) of README.dissector[1], which states that
> tree may be NULL and your code has to work either way.
> 
> [1]
> https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob_plain;f=doc/
> README.dissector

This README is for writing dissectors in C, not Lua. Even if you would pass
`nil` to string.format that doesn't cause a crash in standard Lua interpreter.
The bug here seems to break Lua safety - you can't dereference invalid pointer
in Lua, this is only possible when there's a bug in its engine or in
Wireshark's extensions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13013] SNMP trap bindings for NON scalar OIDs

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13013

--- Comment #9 from Gerrit Code Review  ---
Change 18207 had a related patch set uploaded by Jaap Keuter:
Append Integer32 value to varbind also.

https://code.wireshark.org/review/18207

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13017] Lua dissector crashes on "string.format("%s", tree.text)"

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13017

--- Comment #1 from Jaap Keuter  ---
See the very last section (2.11) of README.dissector[1], which states that tree
may be NULL and your code has to work either way.

[1]
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob_plain;f=doc/README.dissector

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe