[Wireshark-bugs] [Bug 14317] I/O graph shows nothing

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14317

Guy Harris  changed:

   What|Removed |Added

Summary|I/O grap shows nothing  |I/O graph shows nothing

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14341] Buildbot crash output: fuzz-2018-01-13-1912.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14341

--- Comment #2 from Guy Harris  ---
(In reply to Guy Harris from comment #1)
> It looks as if it might have timed out:
> 
> ./tools/fuzz-test.sh: line 204: 21195 CPU time limit exceeded (core dumped)
> "$RUNNER" $COMMON_ARGS $ARGS $TMP_DIR/$TMP_FILE > /dev/null 2>>
> $TMP_DIR/$ERR_FILE.$SUBSHELL_PID

Running on my 2.8 GHz Intel Core i7 MacBook Pro (Retina, 15 inch, Mid 2015, so
Crystalwell):

$ time ./tshark -n -V -r ~/Downloads/fuzz-2018-01-13-1912.pcap >/dev/null

real0m53.630s
user0m52.374s
sys 0m0.842s

so it eventually finishes - it doesn't appear to be stuck in an infinite loop.

That fits within the 600 seconds that tools/test-common.sh specifies - and the
1800 seconds that would be used with Valgrind - but maybe it's too small for
the test machine, or maybe there's something that causes it to loop infinitely
on the test machine.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14341] Buildbot crash output: fuzz-2018-01-13-1912.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14341

--- Comment #1 from Guy Harris  ---
It looks as if it might have timed out:

./tools/fuzz-test.sh: line 204: 21195 CPU time limit exceeded (core dumped)
"$RUNNER" $COMMON_ARGS $ARGS $TMP_DIR/$TMP_FILE > /dev/null 2>>
$TMP_DIR/$ERR_FILE.$SUBSHELL_PID

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

--- Comment #7 from Roland Knall  ---
(In reply to Guy Harris from comment #6)
> OK, so I'm not sure where ProtoNode fits in the Qt class hierarchy, but its
> isExpanded method is only being called for the top-level nodes, *even
> though, when it returns true, there are other nodes underneath it, so the
> TreeView needs to know whether those nodes are expanded as well*.
> 
> This is not the proper behavior.  I don't know whether Qt is just being
> stupid here or whether we haven't put the proper classes in the proper
> places.

I'll try to take a run at it. It is hard getting Qt and our own proprietary
stuff of doing things acting together. But this should be a rather simple fix.
It's not so much the proper classes, but rather emitting the right signals.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14335] Wireshark installs on macOS with permissions that are too restrictive

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14335

Guy Harris  changed:

   What|Removed |Added

 CC|g...@alum.mit.edu|

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

--- Comment #6 from Guy Harris  ---
OK, so I'm not sure where ProtoNode fits in the Qt class hierarchy, but its
isExpanded method is only being called for the top-level nodes, *even though,
when it returns true, there are other nodes underneath it, so the TreeView
needs to know whether those nodes are expanded as well*.

This is not the proper behavior.  I don't know whether Qt is just being stupid
here or whether we haven't put the proper classes in the proper places.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14335] Wireshark installs on macOS with permissions that are too restrictive

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14335

Jaap Keuter  changed:

   What|Removed |Added

 CC||g...@alum.mit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14315] -T ek enterprise private entry

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14315

Jaap Keuter  changed:

   What|Removed |Added

   Severity|Critical|Normal
   Priority|High|Medium

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Guy Harris  changed:

   What|Removed |Added

 CC||ger...@wireshark.org

--- Comment #5 from Guy Harris  ---
I think this is a side-effect of

commit bdb6baa7405d259fa2cd2f6f7d2fb21e13315885
Author: Gerald Combs 
Date:   Thu Dec 7 08:15:30 2017 -0800

Qt: Switch ProtoTree to a treeview+model.

Add a ProtoTreeModel and use it in ProtoTree. This should make the UI
more responsive when we have lots of items in the tree.

Change-Id: Id26e6bcff84663867a8da17fd9ae86ff639b633f
Reviewed-on: https://code.wireshark.org/review/24774
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Guy Harris  changed:

   What|Removed |Added

   Priority|Low |Medium

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Guy Harris  changed:

   What|Removed |Added

Summary|Subtree expand/collapse |Subtree expand/collapse
   |tracking sometimes doesn't  |tracking only works for
   |work|top-level items in the
   ||packet details pane

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking sometimes doesn't work

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Guy Harris  changed:

   What|Removed |Added

 CC||rkn...@gmail.com

--- Comment #4 from Guy Harris  ---
When you click on a new packet, ProtoTree::rowsInserted() is handed start and
end values that correspond to what you see in a *completely unexpanded* tree,
so it only checks the *top-level* rows to see if *they* should be expanded.

I'm not sure whether, when a row is expanded, ProtoTree::rowsInserted() is then
called to reflect the additional rows.  That doesn't *appear* to be happening.

We probably need to handle expanded vs. collapsed differently in the ProtoTree
class.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking sometimes doesn't work

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

--- Comment #3 from Guy Harris  ---
It looks as if ProtoNode::isExpanded() isn't being called for *all* nodes when
you click on a packet.  It needs to be.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking sometimes doesn't work

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Guy Harris  changed:

   What|Removed |Added

Summary|Subtree expand/collapse |Subtree expand/collapse
   |tracking doesn't work   |tracking sometimes doesn't
   ||work

--- Comment #2 from Guy Harris  ---
But, to open up tcp.flags, I first have to open up tcp - and that *does* open
up when I click on another packet.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking doesn't work

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Guy Harris  changed:

   What|Removed |Added

Summary|Subtree expand/collapse |Subtree expand/collapse
   |tracking|tracking doesn't work

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Guy Harris  changed:

   What|Removed |Added

 OS|Windows 7   |All
   Hardware|x86 |All
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Guy Harris  ---
Happens on macOS 10.12.6 with that capture and tcp.flags with a recent Git
build, doesn't happen on macOS 10.12.6 with that capture and tcp.flags with the
official 2.4.4 build.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14342] New: Buildbot crash output: randpkt-2018-01-13-5392.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14342

Bug ID: 14342
   Summary: Buildbot crash output: randpkt-2018-01-13-5392.pcap
   Product: Wireshark
   Version: unspecified
  Hardware: x86-64
OS: Ubuntu
Status: CONFIRMED
  Severity: Major
  Priority: High
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: buildbot-do-not-re...@wireshark.org
  Target Milestone: ---

Problems have been found with the following capture file:

https://www.wireshark.org/download/automated/captures/randpkt-2018-01-13-5392.pcap

stderr:
Input file: 

Build host information:
Linux wsbb04 4.4.0-109-generic #132-Ubuntu SMP Tue Jan 9 19:52:39 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux
Distributor ID: Ubuntu
Description:Ubuntu 16.04.3 LTS
Release:16.04
Codename:   xenial

Buildbot information:
BUILDBOT_REPOSITORY=ssh://wireshark-build...@code.wireshark.org:29418/wireshark
BUILDBOT_WORKERNAME=fuzz-test
BUILDBOT_BUILDNUMBER=159
BUILDBOT_URL=http://buildbot.wireshark.org/wireshark-2.4/
BUILDBOT_BUILDERNAME=Fuzz Test
BUILDBOT_GOT_REVISION=8d4398752e49b33407da29f423b636afb72cce72

Return value:  2

Dissector bug:  0

Valgrind error count: 




Command and args: ./tshark -nVxr

tshark: The file
"/fuzz/buildbot/fuzztest/randpkt-2.4/randpkt-2018-01-13-5392.pcap" appears to
be damaged or corrupt.
(pcap: File has 1867595186-byte packet, bigger than maximum of 262144)

[ no debug trace ]

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14341] New: Buildbot crash output: fuzz-2018-01-13-1912.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14341

Bug ID: 14341
   Summary: Buildbot crash output: fuzz-2018-01-13-1912.pcap
   Product: Wireshark
   Version: unspecified
  Hardware: x86-64
OS: Ubuntu
Status: CONFIRMED
  Severity: Major
  Priority: High
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: buildbot-do-not-re...@wireshark.org
  Target Milestone: ---

Problems have been found with the following capture file:

https://www.wireshark.org/download/automated/captures/fuzz-2018-01-13-1912.pcap

stderr:
Input file: /home/wireshark/menagerie/menagerie/sercosiii.pcap

Build host information:
Linux wsbb04 4.4.0-109-generic #132-Ubuntu SMP Tue Jan 9 19:52:39 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux
Distributor ID: Ubuntu
Description:Ubuntu 16.04.3 LTS
Release:16.04
Codename:   xenial

Buildbot information:
BUILDBOT_REPOSITORY=ssh://wireshark-build...@code.wireshark.org:29418/wireshark
BUILDBOT_WORKERNAME=clang-code-analysis
BUILDBOT_BUILDNUMBER=4577
BUILDBOT_URL=http://buildbot.wireshark.org/wireshark-master/
BUILDBOT_BUILDERNAME=Clang Code Analysis
BUILDBOT_GOT_REVISION=4fdf79332798732a18dbf1877c46353cd1b6250b

Return value:  0

Dissector bug:  0

Valgrind error count:  0



Git commit
commit 4fdf79332798732a18dbf1877c46353cd1b6250b
Author: Gerald Combs 
Date:   Fri Jan 12 15:14:17 2018 -0800

PortableApps: Exclude a bunch of files.

Add

fuzzshark.exe
idl2wrs.exe
lemon.exe
make-
test.exe
uninstall.exe

to the xcopy exlusion patterns.

Change-Id: Ibf7b4711a51b9eca2b5947edc8d3d007c718a395
Reviewed-on: https://code.wireshark.org/review/25291
Reviewed-by: Anders Broman 



[ no debug trace ]

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14271] Unknown system/peer event codes in NTP control messages

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14271

Michael Mann  changed:

   What|Removed |Added

 Status|IN_PROGRESS |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14271] Unknown system/peer event codes in NTP control messages

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14271

--- Comment #4 from Gerrit Code Review  ---
Change 25296 merged by Michael Mann:
NTP: Updated system and peer status codes

https://code.wireshark.org/review/25296

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14339] Buildbot crash output: fuzz-2018-01-13-21858.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14339

--- Comment #6 from Gerrit Code Review  ---
Change 25303 merged by Pascal Quantin:
UMTS MAC: protect against an out of bounds access

https://code.wireshark.org/review/25303

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14339] Buildbot crash output: fuzz-2018-01-13-21858.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14339

--- Comment #5 from Gerrit Code Review  ---
Change 25302 merged by Michael Mann:
UMTS MAC: protect against an out of bounds access

https://code.wireshark.org/review/25302

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14339] Buildbot crash output: fuzz-2018-01-13-21858.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14339

--- Comment #4 from Gerrit Code Review  ---
Change 25303 had a related patch set uploaded by Pascal Quantin:
UMTS MAC: protect against an out of bounds access

https://code.wireshark.org/review/25303

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14339] Buildbot crash output: fuzz-2018-01-13-21858.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14339

Pascal Quantin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|IN_PROGRESS |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14339] Buildbot crash output: fuzz-2018-01-13-21858.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14339

--- Comment #3 from Gerrit Code Review  ---
Change 25302 had a related patch set uploaded by Pascal Quantin:
UMTS MAC: protect against an out of bounds access

https://code.wireshark.org/review/25302

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14339] Buildbot crash output: fuzz-2018-01-13-21858.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14339

--- Comment #2 from Gerrit Code Review  ---
Change 25297 merged by Pascal Quantin:
UMTS MAC: protect against an out of bounds access

https://code.wireshark.org/review/25297

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14339] Buildbot crash output: fuzz-2018-01-13-21858.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14339

--- Comment #1 from Gerrit Code Review  ---
Change 25297 had a related patch set uploaded by Pascal Quantin:
UMTS MAC: protect against an out of bounds access

https://code.wireshark.org/review/25297

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14339] Buildbot crash output: fuzz-2018-01-13-21858.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14339

Pascal Quantin  changed:

   What|Removed |Added

 CC||pascal.quan...@gmail.com
 Status|CONFIRMED   |IN_PROGRESS

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14271] Unknown system/peer event codes in NTP control messages

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14271

--- Comment #3 from Gerrit Code Review  ---
Change 25296 had a related patch set uploaded by Uli Heilmeier:
NTP: Updated system and peer status codes

https://code.wireshark.org/review/25296

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] New: Subtree expand/collapse tracking

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Bug ID: 14340
   Summary: Subtree expand/collapse tracking
   Product: Wireshark
   Version: Git
  Hardware: x86
OS: Windows 7
Status: UNCONFIRMED
  Severity: Normal
  Priority: Low
 Component: Qt UI
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: th.wi...@gmx.de
  Target Milestone: ---

Created attachment 16070
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=16070=edit
Sample capture with 2 packets, works with every other capture

Build Information:
Version 2.5.0-TWiensBuild (Git Rev Unknown from unknown)

Compiled (32-bit) with Qt 5.5.1, with WinPcap (4_1_3), with GLib 2.38.0, with
zlib 1.2.11, with SMI 0.4.8, with c-ares 1.13.0, with Lua 5.2.4, with GnuTLS
3.4.11, with Gcrypt 1.7.6, with MIT Kerberos, with GeoIP, with nghttp2 1.14.0,
with LZ4, with Snappy, with libxml2 2.9.4, with QtMultimedia, with AirPcap,
with
SBC, with SpanDSP, with bcg729.

Running on 32-bit Windows 7 Service Pack 1, build 7601, with Intel(R) Core(TM)2
CPU  6400  @ 2.13GHz, with 2047 MB of physical memory, with locale
German_Germany.1252, with WinPcap version 4.1.3 (packet.dll version
4.1.0.2980),
based on libpcap version 1.0 branch 1_0_rel0b (20091008), with GnuTLS 3.4.11,
with Gcrypt 1.7.6, with AirPcap 4.1.0 build 1622, binary plugins supported (14
loaded).

Built using Microsoft Visual C++ 12.0 build 31101
--
Hi,
when I build Wireshark from the current git repository, I get a different
behaviour in tracking expanded/collapsed subtrees compared to the latest stable
2.4.4.

In 2.4.4 if I have expanded a 2nd level (or deeper) subtree element like
tcp.flags and then selected another packet, then also the tree was expanded to
this level.
I thought the intention of the ett_ variables are to keep track of which
subtrees are expanded.

With my compiled version from the git repository, the expanded nodes are only
tracked on the root node. In tcp for example, if I expand the tcp tree then all
other tcp root nodes are expanded in all other packets I select.

Attached example capture with 2 packets.
Demo:
Select #1, expand tree-node tcp.flags.
Select #2, tcp-tree is expanded, but tcp.flags is collapsed.

Same with every other capture, and also on other computer when Wireshark is
build under 64 Bit Windows 7.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14339] New: Buildbot crash output: fuzz-2018-01-13-21858.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14339

Bug ID: 14339
   Summary: Buildbot crash output: fuzz-2018-01-13-21858.pcap
   Product: Wireshark
   Version: unspecified
  Hardware: x86-64
OS: Ubuntu
Status: CONFIRMED
  Severity: Major
  Priority: High
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: buildbot-do-not-re...@wireshark.org
  Target Milestone: ---

Problems have been found with the following capture file:

https://www.wireshark.org/download/automated/captures/fuzz-2018-01-13-21858.pcap

stderr:
Input file: /home/wireshark/menagerie/menagerie/12719-test.pcap

Build host information:
Linux wsbb04 4.4.0-109-generic #132-Ubuntu SMP Tue Jan 9 19:52:39 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux
Distributor ID: Ubuntu
Description:Ubuntu 16.04.3 LTS
Release:16.04
Codename:   xenial

Buildbot information:
BUILDBOT_REPOSITORY=ssh://wireshark-build...@code.wireshark.org:29418/wireshark
BUILDBOT_WORKERNAME=clang-code-analysis
BUILDBOT_BUILDNUMBER=4576
BUILDBOT_URL=http://buildbot.wireshark.org/wireshark-master/
BUILDBOT_BUILDERNAME=Clang Code Analysis
BUILDBOT_GOT_REVISION=807a6c93d8c04403c10196ae3ba2b96136899e96

Return value:  0

Dissector bug:  0

Valgrind error count:  0



Git commit
commit 807a6c93d8c04403c10196ae3ba2b96136899e96
Author: Gerald Combs 
Date:   Fri Jan 12 14:05:14 2018 -0800

netfilter: Make sure our bitmask field arrays are NULL terminated.

Add a trailing NULLs so that we don't read past the end of
hfi_nfct_attr_status_flags and hfi_nfexp_attr_flags_bitfield.

Bug: 14336
Change-Id: I1e96a89f60df2d653c4f3ad63f29cf57eb0224a5
Reviewed-on: https://code.wireshark.org/review/25290
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 


=
==18726==ERROR: AddressSanitizer: global-buffer-overflow on address
0x7ffab0888490 at pc 0x7ffaa690b1e4 bp 0x7ffdb12add90 sp 0x7ffdb12add88
READ of size 1 at 0x7ffab0888490 thread T0
#0 0x7ffaa690b1e3 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x94601e3)
#1 0x7ffaa7a6ac74 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5bfc74)
#2 0x7ffaa7a60401 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5b5401)
#3 0x7ffaa7a6754c 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5bc54c)
#4 0x7ffaa7a5c704 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5b1704)
#5 0x7ffaa68fb2cc 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x94502cc)
#6 0x7ffaa68efa5d 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x9444a5d)
#7 0x7ffaa68e94e2 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x943e4e2)
#8 0x7ffaa68e6470 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x943b470)
#9 0x7ffaa7a6ac74 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5bfc74)
#10 0x7ffaa7a60401 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5b5401)
#11 0x7ffaa7a6754c 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5bc54c)
#12 0x7ffaa7a189d2 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa56d9d2)
#13 0x7ffaa68c365d 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x941865d)
#14 0x7ffaa68cd36f 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x942236f)
#15 0x7ffaa68c68cf 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x941b8cf)
#16 0x7ffaa7a6ac74 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5bfc74)
#17 0x7ffaa7a60401 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5b5401)
#18 0x7ffaa7a5fd6a 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5b4d6a)
#19 0x7ffaa5b765a0 

[Wireshark-bugs] [Bug 14336] Buildbot crash output: fuzz-2018-01-12-17504.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14336

--- Comment #4 from Pascal Quantin  ---
*** Bug 14338 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14338] Buildbot crash output: fuzz-2018-01-13-19900.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14338

Pascal Quantin  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |DUPLICATE
 CC||pascal.quan...@gmail.com

--- Comment #1 from Pascal Quantin  ---


*** This bug has been marked as a duplicate of bug 14336 ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14336] Buildbot crash output: fuzz-2018-01-12-17504.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14336

--- Comment #3 from Pascal Quantin  ---
*** Bug 14337 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14337] Buildbot crash output: fuzz-2018-01-12-18423.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14337

Pascal Quantin  changed:

   What|Removed |Added

 CC||pascal.quan...@gmail.com
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Pascal Quantin  ---


*** This bug has been marked as a duplicate of bug 14336 ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14336] Buildbot crash output: fuzz-2018-01-12-17504.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14336

Pascal Quantin  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
 CC||pascal.quan...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14336] Buildbot crash output: fuzz-2018-01-12-17504.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14336

--- Comment #2 from Gerrit Code Review  ---
Change 25290 merged by Pascal Quantin:
netfilter: Make sure our bitmask field arrays are NULL terminated.

https://code.wireshark.org/review/25290

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14338] New: Buildbot crash output: fuzz-2018-01-13-19900.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14338

Bug ID: 14338
   Summary: Buildbot crash output: fuzz-2018-01-13-19900.pcap
   Product: Wireshark
   Version: unspecified
  Hardware: x86-64
OS: Ubuntu
Status: CONFIRMED
  Severity: Major
  Priority: High
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: buildbot-do-not-re...@wireshark.org
  Target Milestone: ---

Problems have been found with the following capture file:

https://www.wireshark.org/download/automated/captures/fuzz-2018-01-13-19900.pcap

stderr:
Input file: /home/wireshark/menagerie/menagerie/netlink-conntrack.pcap

Build host information:
Linux wsbb04 4.4.0-109-generic #132-Ubuntu SMP Tue Jan 9 19:52:39 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux
Distributor ID: Ubuntu
Description:Ubuntu 16.04.3 LTS
Release:16.04
Codename:   xenial

Buildbot information:
BUILDBOT_REPOSITORY=ssh://wireshark-build...@code.wireshark.org:29418/wireshark
BUILDBOT_WORKERNAME=clang-code-analysis
BUILDBOT_BUILDNUMBER=4575
BUILDBOT_URL=http://buildbot.wireshark.org/wireshark-master/
BUILDBOT_BUILDERNAME=Clang Code Analysis
BUILDBOT_GOT_REVISION=777932efc61a62d6ad56ecd620a76972e438478a

Return value:  0

Dissector bug:  0

Valgrind error count:  0



Git commit
commit 777932efc61a62d6ad56ecd620a76972e438478a
Author: Gerald Combs 
Date:   Fri Jan 12 15:46:38 2018 -0800

make-dissectors depends on copy_cli_dlls.

Have the make-dissectors CMake target explicitly depend on copy_cli_dlls,
otherwise we might try to create dissectors.c before libglib-2.0-0.dll
has been copied into place. It looks like this is what's been causing
our random Windows PD failures.

Change-Id: Ia2445f17abd2c73113ab269ba6c606f48e724d93
Reviewed-on: https://code.wireshark.org/review/25292
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs 


=
==5520==ERROR: AddressSanitizer: global-buffer-overflow on address
0x7fca45e42cd0 at pc 0x7fca3f2262f5 bp 0x7fff2304a5b0 sp 0x7fff2304a5a8
READ of size 8 at 0x7fca45e42cd0 thread T0
#0 0x7fca3f2262f4 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa65b2f4)
#1 0x7fca3f225df3 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa65adf3)
#2 0x7fca3f225398 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa65a398)
#3 0x7fca3d73cb01 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x8b71b01)
#4 0x7fca3d746473 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x8b7b473)
#5 0x7fca3d745cf9 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x8b7acf9)
#6 0x7fca3d73c407 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x8b71407)
#7 0x7fca3d73c119 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x8b71119)
#8 0x7fca3f18ac74 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5bfc74)
#9 0x7fca3f180401 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5b5401)
#10 0x7fca3f17fd6a 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5b4d6a)
#11 0x7fca3d74752d 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x8b7c52d)
#12 0x7fca3f18ac74 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5bfc74)
#13 0x7fca3f180401 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5b5401)
#14 0x7fca3f17fd6a 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5b4d6a)
#15 0x7fca3cf7d3a2 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0x83b23a2)
#16 0x7fca3f18ac74 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5bfc74)
#17 0x7fca3f180401 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5b5401)
#18 0x7fca3f18754c 
(/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install.asan/lib/libwireshark.so.0+0xa5bc54c)
#19 0x7fca3f17c704