[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 Alexis La Goutte changed: What|Removed |Added Resolution|--- |FIXED CC||alexis.lagou...@gmail.com Status|IN_PROGRESS |RESOLVED -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #24 from Gerrit Code Review --- Change 22892 merged by Anders Broman: protobuf: add support for Protocol Buffers Language (*.proto) files https://code.wireshark.org/review/22892 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #23 from Huang Qiangxiong --- (In reply to Huang Qiangxiong from comment #22) > (In reply to Martin Mathieson from comment #21) > > (In reply to Huang Qiangxiong from comment #20) > > > (In reply to Alexander Petrossian (PAF) from comment #19) > > > > Michael, friends. > > > > Is this anywhere near releasing? > > > > > > > > Judging from comments most (all?) work is already done. > > > > > > There are still two tasks in progress: > > > > > > 1. GRPC ressambling: The code is OK, but it is in merge confict status > > > before commit. (May need only rebase) > > > https://code.wireshark.org/review/#/c/23988/ > > > > > > > > > 2. Protobuf support parsing according to *.proto file: I'm working parsing > > > *.proto file by flex c insteadof using official c++ in my spare time. > > > https://code.wireshark.org/review/#/c/22892/ > > > > > > But recently, I am busy in my own work, I will check them and finish them > > > in > > > my spare time later. > > > > Any progress on 2. Huang? > > > Progress is slow because I am busy in my work, but I may get some spare time > recently. I will try to pick it up. Michael, I have written a C Parser for *.proto file in flex and bison recently. And It seems works well to me (at least in windows version of 3.1.1). I have committed the change (based on newest code of 3.1.1) to https://code.wireshark.org/review/#/c/22892/. But I can not do rebase for this change. I don't know what should I do next step. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #22 from Huang Qiangxiong --- (In reply to Martin Mathieson from comment #21) > (In reply to Huang Qiangxiong from comment #20) > > (In reply to Alexander Petrossian (PAF) from comment #19) > > > Michael, friends. > > > Is this anywhere near releasing? > > > > > > Judging from comments most (all?) work is already done. > > > > There are still two tasks in progress: > > > > 1. GRPC ressambling: The code is OK, but it is in merge confict status > > before commit. (May need only rebase) > > https://code.wireshark.org/review/#/c/23988/ > > > > > > 2. Protobuf support parsing according to *.proto file: I'm working parsing > > *.proto file by flex c insteadof using official c++ in my spare time. > > https://code.wireshark.org/review/#/c/22892/ > > > > But recently, I am busy in my own work, I will check them and finish them in > > my spare time later. > > Any progress on 2. Huang? Progress is slow because I am busy in my work, but I may get some spare time recently. I will try to pick it up. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 Martin Mathieson changed: What|Removed |Added CC||martin.r.mathieson@googlema ||il.com --- Comment #21 from Martin Mathieson --- (In reply to Huang Qiangxiong from comment #20) > (In reply to Alexander Petrossian (PAF) from comment #19) > > Michael, friends. > > Is this anywhere near releasing? > > > > Judging from comments most (all?) work is already done. > > There are still two tasks in progress: > > 1. GRPC ressambling: The code is OK, but it is in merge confict status > before commit. (May need only rebase) > https://code.wireshark.org/review/#/c/23988/ > > > 2. Protobuf support parsing according to *.proto file: I'm working parsing > *.proto file by flex c insteadof using official c++ in my spare time. > https://code.wireshark.org/review/#/c/22892/ > > But recently, I am busy in my own work, I will check them and finish them in > my spare time later. Any progress on 2. Huang? -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #20 from Huang Qiangxiong --- (In reply to Alexander Petrossian (PAF) from comment #19) > Michael, friends. > Is this anywhere near releasing? > > Judging from comments most (all?) work is already done. There are still two tasks in progress: 1. GRPC ressambling: The code is OK, but it is in merge confict status before commit. (May need only rebase) https://code.wireshark.org/review/#/c/23988/ 2. Protobuf support parsing according to *.proto file: I'm working parsing *.proto file by flex c insteadof using official c++ in my spare time. https://code.wireshark.org/review/#/c/22892/ But recently, I am busy in my own work, I will check them and finish them in my spare time later. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 Alexander Petrossian (PAF) changed: What|Removed |Added CC||p...@yandex.ru --- Comment #19 from Alexander Petrossian (PAF) --- Michael, friends. Is this anywhere near releasing? Judging from comments most (all?) work is already done. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #18 from Huang Qiangxiong --- Created attachment 15952 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15952&action=edit many cases which need support of reassembling feature of GRPC dissector (json) This capture is generated by grpc java library. Case1: In frame28, one http DATA contains 4 completed grpc messages. Case2: In frame28, last grpc message (the 5th) only has 4 bytes, which need one more byte to be a message head. a completed message is reassembled in frame45. Case3: In frame45, one http DATA frame contains two partial fragment, one is part of grpc message of previous http DATA (frame28), another is first part of grpc message of next http DATA (which will be reassembled in next http DATA frame61). Case4: A more big grpc message across frame100, frame113, frame126 and finally reassembled in frame 139. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 Peter Wu changed: What|Removed |Added Status|CONFIRMED |IN_PROGRESS CC||pe...@lekensteyn.nl -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #17 from Huang Qiangxiong --- Created attachment 15908 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15908&action=edit test big http2 data which need be reassembled by GRPC dissector (json) Test reassembled DATA with big json. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #16 from Huang Qiangxiong --- Created attachment 15907 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15907&action=edit test big http2 data which need be reassembled by GRPC dissector (protobuf) test big http2 data which need be reassembled by GRPC dissector (protobuf) refer to https://code.wireshark.org/review/#/c/23988 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #15 from Huang Qiangxiong --- Created attachment 15906 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15906&action=edit ETCD watch capture file (not END_STREAM until several cmds) if working in streaming RPC mode, many grpc messages will be contained in one http2 stream, the stream will end very late (for example ETCD watch stream). So we could not rely on http2 to reassemble data which call sub-dissector only END_STREAM appeared. Now we let http2 don't reassemble when content-type=application/grpc*. grpc dissector do reassemble work itself. Please refer to Change-Id: Id9e5337a0e3ca9f8c8119d74d2c1fe4cc263afc3 (https://code.wireshark.org/review/#/c/23988) -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932
--- Comment #14 from Huang Qiangxiong ---
(In reply to Huang Qiangxiong from comment #13)
> (In reply to Michael Mann from comment #12)
> > (In reply to Huang Qiangxiong from comment #0)
> > > Created attachment 15730 [details]
> > > grpc/protobuf sample cap file. (message compress by gzip)
> >
> > I don't see in https://developers.google.cn/protocol-buffers/docs/encoding
> > how bitmasks are explained. When looking at this capture file, packet 9 has
> > 5 fields, and the field number for the 5th buffer is 536870910 (i.e. really
> > large number). But ProtoBuf is trying to apply a bitmask of 0xF8 (maybe
> > because it's presumed that field number should be a UINT8). It seems like
> > the current logic is "if varint has more bytes that bitmask covers, treat
> > other bytes with bitmask 0xFF". I don't think that's how bitmasks should
> > work.
> >
> > I'm working on https://code.wireshark.org/review/23813 (using
> > packet-protobuf.c in other patches for testing) and I have it so that the
> > varint number is retrieved and then the bitmask is applied, which makes the
> > field number 30, not 536870910. This seems "more correct" to me, but
> > wanted other opinions (possibly documentation showing how bitmasks are
> > applied)
>
> The 536870910 is correct field number. This is a test case made by me for
> testing parsing a big field number. This package is generated by offical
> protobuf library (for java) according to the attachment of "A more
> complicated grpc/protobuf proto file -- helloworld.proto". You can see the
> definition of this field in helloworld.proto:
>
> message HelloRequest {
>...
>sfixed32 sfixed32param_largefn = 536870910;
>...
> }
>
>
> Dissected result like this: (with *.proto file supported)
> Frame 9: 245 bytes on wire (1960 bits), 245 bytes captured (1960 bits) on
> interface 0
> Ethernet II, Src: Vmware_c0:00:08 (00:50:56:c0:00:08), Dst: Vmware_94:16:c4
> (00:0c:29:94:16:c4)
> Internet Protocol Version 4, Src: 192.168.65.1, Dst: 192.168.65.10
> Transmission Control Protocol, Src Port: 61063, Dst Port: 50051, Seq: 80,
> Ack: 50, Len: 191
> HyperText Transfer Protocol 2
> Stream: HEADERS, Stream ID: 3, Length 124, POST
> /helloworld.Greeter/SayHello
> Stream: DATA, Stream ID: 3, Length 49
> GRPC Message: /helloworld.Greeter/SayHello, Request
> Protocol Buffers: /helloworld.Greeter/SayHello,request
> Message: helloworld.HelloRequest
> [Message Name: helloworld.HelloRequest]
> Field[1]: name = world (string)
> Field[2]: sint32param = -6 (sint32)
> Field[3]: uint64param = 10 (uint64)
> Field[4]: int32param = -5 (int32)
> Field[536870910]: sfixed32param_largefn = 888 (sfixed32)
More detail about 'sfixed32param_largefn' field:
HyperText Transfer Protocol 2
Stream: HEADERS, Stream ID: 3, Length 124, POST
/helloworld.Greeter/SayHello
Stream: DATA, Stream ID: 3, Length 49
GRPC Message: /helloworld.Greeter/SayHello, Request
Protocol Buffers: /helloworld.Greeter/SayHello,request
Message: helloworld.HelloRequest
[Message Name: helloworld.HelloRequest]
Field[1]: name = world (string)
Field[2]: sint32param = -6 (sint32)
Field[3]: uint64param = 10 (uint64)
Field[4]: int32param = -5 (int32)
Field[536870910]: sfixed32param_largefn = 888 (sfixed32)
[Field Name: sfixed32param_largefn]
[Field Type: sfixed32 (15)]
s111 0... s111 s111 s111 z000 = Field
Number: 536870910
.101 = Wire Type: 32-bit (5)
Value: 7803
--
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932
--- Comment #13 from Huang Qiangxiong ---
(In reply to Michael Mann from comment #12)
> (In reply to Huang Qiangxiong from comment #0)
> > Created attachment 15730 [details]
> > grpc/protobuf sample cap file. (message compress by gzip)
>
> I don't see in https://developers.google.cn/protocol-buffers/docs/encoding
> how bitmasks are explained. When looking at this capture file, packet 9 has
> 5 fields, and the field number for the 5th buffer is 536870910 (i.e. really
> large number). But ProtoBuf is trying to apply a bitmask of 0xF8 (maybe
> because it's presumed that field number should be a UINT8). It seems like
> the current logic is "if varint has more bytes that bitmask covers, treat
> other bytes with bitmask 0xFF". I don't think that's how bitmasks should
> work.
>
> I'm working on https://code.wireshark.org/review/23813 (using
> packet-protobuf.c in other patches for testing) and I have it so that the
> varint number is retrieved and then the bitmask is applied, which makes the
> field number 30, not 536870910. This seems "more correct" to me, but
> wanted other opinions (possibly documentation showing how bitmasks are
> applied)
The 536870910 is correct field number. This is a test case made by me for
testing parsing a big field number. This package is generated by offical
protobuf library (for java) according to the attachment of "A more complicated
grpc/protobuf proto file -- helloworld.proto". You can see the definition of
this field in helloworld.proto:
message HelloRequest {
...
sfixed32 sfixed32param_largefn = 536870910;
...
}
Dissected result like this: (with *.proto file supported)
Frame 9: 245 bytes on wire (1960 bits), 245 bytes captured (1960 bits) on
interface 0
Ethernet II, Src: Vmware_c0:00:08 (00:50:56:c0:00:08), Dst: Vmware_94:16:c4
(00:0c:29:94:16:c4)
Internet Protocol Version 4, Src: 192.168.65.1, Dst: 192.168.65.10
Transmission Control Protocol, Src Port: 61063, Dst Port: 50051, Seq: 80, Ack:
50, Len: 191
HyperText Transfer Protocol 2
Stream: HEADERS, Stream ID: 3, Length 124, POST
/helloworld.Greeter/SayHello
Stream: DATA, Stream ID: 3, Length 49
GRPC Message: /helloworld.Greeter/SayHello, Request
Protocol Buffers: /helloworld.Greeter/SayHello,request
Message: helloworld.HelloRequest
[Message Name: helloworld.HelloRequest]
Field[1]: name = world (string)
Field[2]: sint32param = -6 (sint32)
Field[3]: uint64param = 10 (uint64)
Field[4]: int32param = -5 (int32)
Field[536870910]: sfixed32param_largefn = 888 (sfixed32)
--
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #12 from Michael Mann --- (In reply to Huang Qiangxiong from comment #0) > Created attachment 15730 [details] > grpc/protobuf sample cap file. (message compress by gzip) I don't see in https://developers.google.cn/protocol-buffers/docs/encoding how bitmasks are explained. When looking at this capture file, packet 9 has 5 fields, and the field number for the 5th buffer is 536870910 (i.e. really large number). But ProtoBuf is trying to apply a bitmask of 0xF8 (maybe because it's presumed that field number should be a UINT8). It seems like the current logic is "if varint has more bytes that bitmask covers, treat other bytes with bitmask 0xFF". I don't think that's how bitmasks should work. I'm working on https://code.wireshark.org/review/23813 (using packet-protobuf.c in other patches for testing) and I have it so that the varint number is retrieved and then the bitmask is applied, which makes the field number 30, not 536870910. This seems "more correct" to me, but wanted other opinions (possibly documentation showing how bitmasks are applied) -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #11 from Pascal Quantin --- (In reply to Huang Qiangxiong from comment #10) > Created attachment 15871 [details] > source file of protobuf-cpp-3.4.1.zip > > Exactly the same as > https://github.com/google/protobuf/releases/download/v3.4.1/protobuf-cpp-3.4. > 1.zip. > > It should be uploaded to > https://anonsvn.wireshark.org/wireshark-$($Platform)-libs/tags/ > $($CurrentTag)/packages if compile wireshark with *.proto file support. > > Thanks to Pascal Quantin, I verified the newest protobuf source, it works. Please see my comments in Gerrit: I would *really* prefer is we switched to a C implementation and uploaded cross-compiled libraries instead of source code to avoid the cost of recompilation each time you build Wireshark from scratch. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #10 from Huang Qiangxiong --- Created attachment 15871 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15871&action=edit source file of protobuf-cpp-3.4.1.zip Exactly the same as https://github.com/google/protobuf/releases/download/v3.4.1/protobuf-cpp-3.4.1.zip. It should be uploaded to https://anonsvn.wireshark.org/wireshark-$($Platform)-libs/tags/$($CurrentTag)/packages if compile wireshark with *.proto file support. Thanks to Pascal Quantin, I verified the newest protobuf source, it works. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 Huang Qiangxiong changed: What|Removed |Added Attachment #15864|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #9 from Gerrit Code Review --- Change 23814 had a related patch set uploaded by Michael Mann: WIP: Add Protobuf (Protocol Buffers) dissector. https://code.wireshark.org/review/23814 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 Pascal Quantin changed: What|Removed |Added CC||pascal.quan...@gmail.com --- Comment #8 from Pascal Quantin --- (In reply to Huang Qiangxiong from comment #7) > Created attachment 15864 [details] > protobuf-3.3.0 source file used to build wireshark on win32/win64 > > On windows, protobuf will be built as dll when wireshark is building (like > zlib). Is this really required? Can't we provide instead a pre-build dll (like what we do for all others 3rd party libraries) that would be cross compiled with MinGW so as to avoid any dependency on a given MSVC version? That would also better match Linux / macOS where we would use libraries provided by the system. CMake / autofoo would need to be modified to check Protobuf library presence and the corresponding code in the dissector should be made conditional (like what is done for many other libraries). > Attachement is actually repacked > https://github.com/google/protobuf/releases/download/v3.3.0/protobuf-cpp-3.3. > 0.zip (unzip protobuf-cpp-3.3.0.zip sources into protobuf-3.3.0-ws > directory, and rezip) > > I have tried, currently protobuf 3.4.0 has some compile errors, 3.3.0 is OK > (regardless of many warnings). Protobuf 3.4.1 is now available and the release notes say: "Fixed the missing files in 3.4.0 tarballs, affecting windows and cmake users" So hopefully the issue is now fixed. > > It should be uploaded to > https://anonsvn.wireshark.org/wireshark-$($Platform)-libs/tags/ > $($CurrentTag)/packages This will be done once everything is ready for merge and the questions above are clarified. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #7 from Huang Qiangxiong --- Created attachment 15864 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15864&action=edit protobuf-3.3.0 source file used to build wireshark on win32/win64 On windows, protobuf will be built as dll when wireshark is building (like zlib). Attachement is actually repacked https://github.com/google/protobuf/releases/download/v3.3.0/protobuf-cpp-3.3.0.zip (unzip protobuf-cpp-3.3.0.zip sources into protobuf-3.3.0-ws directory, and rezip) I have tried, currently protobuf 3.4.0 has some compile errors, 3.3.0 is OK (regardless of many warnings). It should be uploaded to https://anonsvn.wireshark.org/wireshark-$($Platform)-libs/tags/$($CurrentTag)/packages -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #6 from Huang Qiangxiong --- Created attachment 15863 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15863&action=edit ETCD3 grpc/protobuf needed proto files If using upgraded protobuf dissectors, please open edit->preferrences->protocol->ProtoBuf configuration window, and add following directories (unzipped from attachment): xx/protobuf-standard-protofiles (or point to /usr/local/include if protobuf installed) xx/proto-of-google1 (one of google proto libraries used by etcd api) xx/proto-of-google2 (another google proto libraries used by etcd api) xx/proto-etcd3.2.0 (etcd3.x proto files from github) -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #5 from Huang Qiangxiong --- Created attachment 15862 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15862&action=edit ETCD3 grpc/protobuf capture file ETCD3.x is beginning to use GRPC as its communication protocol. To dissect it should with help of etcd3.2.0 proto files and some other proto sources of google. Please refer to 'ETCD3 grpc/protobuf needed proto files'. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #4 from Huang Qiangxiong --- Created attachment 15861 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15861&action=edit A more complicated grpc/protobuf proto file -- helloworld.proto Plan to upgrade protobuf dissector which can read and parse helloworld.proto file by invoking offical protobuf library of goodle, and dissect capture file according to proto file information. With supporting read proto file information, protobuf dissector can show field name, type and value correctly, and can support to dissect sub message type of a field. With help of proto file, dissector can show sint, enum, sub message (like embededparam parameter of HelloRequest)... -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #3 from Huang Qiangxiong --- Created attachment 15860 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15860&action=edit A more complicated grpc/protobuf sample of helloworld.proto This is a more complicated sample capture file of grpc protobuf. Please refer to the modified helloworld.proto attachment. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 Michael Mann changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED CC||mman...@netscape.net --- Comment #2 from Michael Mann --- (In reply to Huang Qiangxiong from comment #0) > Created attachment 15730 [details] > grpc/protobuf sample cap file. (message compress by gzip) To setup fields information for above example use this as a UAT (custom_protobuf_fields) # This file is automatically generated, DO NOT MODIFY. "GRPC Call Path","Message Type","Field Type","Field Name","Field Number" "/helloworld.Greeter/SayHello","request","string","name","1" "/helloworld.Greeter/SayHello","request","sint32","sint32param","2" "/helloworld.Greeter/SayHello","request","uint64","Uint64param","3" "/helloworld.Greeter/SayHello","request","sfixed32","sfixed32param_largefn","536870910" "/helloworld.Greeter/SayHello","response","string","message","1" "/helloworld.Greeter/SayHello","response","sint32","sint32param","2" "/helloworld.Greeter/SayHello","response","uint64","Uint64param","3" "/helloworld.Greeter/SayHello","response","sint64","sint64param","7" "/helloworld.Greeter/SayHello","response","sfixed32","sfixed32param_largefn","536870910" -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 13932] HTTP2/GRPC/ProtoBuf: Add new GRPC and ProtoBuf dissectors, and make little change on http2 dissector for providing some information to grpc dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13932 --- Comment #1 from Huang Qiangxiong --- Created attachment 15731 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15731&action=edit a capture file of JSON over GRPC A capture file of JSON over GRPC. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
